[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057502548 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -58,154 +58,139 @@ import java.io.IOExcepti

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057502548 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -58,154 +58,139 @@ import java.io.IOExcepti

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057499949 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -532,27 +468,30 @@ public EmptyMessageParame

[jira] [Commented] (FLINK-29463) InputFormatCacheLoaderTest.checkCounter failed with AssertionError

2022-12-26 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652174#comment-17652174 ] Qingsheng Ren commented on FLINK-29463: --- https://dev.azure.com/apache-flink/apache

[jira] [Assigned] (FLINK-27284) KafkaSinkITCase$IntegrationTests.testScaleUp failed on azures due to failed to create topic

2022-12-26 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-27284: - Assignee: Qingsheng Ren > KafkaSinkITCase$IntegrationTests.testScaleUp failed on azures

[jira] [Commented] (FLINK-27284) KafkaSinkITCase$IntegrationTests.testScaleUp failed on azures due to failed to create topic

2022-12-26 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652170#comment-17652170 ] Qingsheng Ren commented on FLINK-27284: --- https://dev.azure.com/apache-flink/apache

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057486097 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -58,154 +58,139 @@ import java.io.IOExcepti

[jira] [Commented] (FLINK-27284) KafkaSinkITCase$IntegrationTests.testScaleUp failed on azures due to failed to create topic

2022-12-26 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652169#comment-17652169 ] Qingsheng Ren commented on FLINK-27284: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-30508) CliClientITCase.testSqlStatements failed with output not matched with expected

2022-12-26 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652168#comment-17652168 ] Qingsheng Ren commented on FLINK-30508: --- Other instances not linked correctly:  [

[jira] [Commented] (FLINK-27219) CliClientITCase.testSqlStatements failed on azure with jdk11

2022-12-26 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652166#comment-17652166 ] Qingsheng Ren commented on FLINK-27219: --- [~luoyuxia] Ah sorry for the mistake! It'

[jira] [Created] (FLINK-30508) CliClientITCase.testSqlStatements failed with output not matched with expected

2022-12-26 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-30508: - Summary: CliClientITCase.testSqlStatements failed with output not matched with expected Key: FLINK-30508 URL: https://issues.apache.org/jira/browse/FLINK-30508 Proj

[jira] [Commented] (FLINK-30508) CliClientITCase.testSqlStatements failed with output not matched with expected

2022-12-26 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652165#comment-17652165 ] Qingsheng Ren commented on FLINK-30508: --- [~fsk119] any idea on this one? > CliCli

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057486097 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -58,154 +58,139 @@ import java.io.IOExcepti

[GitHub] [flink] wanglijie95 commented on pull request #21559: [FLINK-29859][e2e] Running TPC-DS with adaptive batch scheduler supports custom exceptions check

2022-12-26 Thread GitBox
wanglijie95 commented on PR #21559: URL: https://github.com/apache/flink/pull/21559#issuecomment-1365671002 @zhuzhurk Thanks for review @zhuzhurk. I 've addressed the comments, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057486097 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -58,154 +58,139 @@ import java.io.IOExcepti

[jira] [Closed] (FLINK-30452) Wrong argument type of null literal is used when call Hive's function

2022-12-26 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang closed FLINK-30452. -- Assignee: luoyuxia > Wrong argument type of null literal is used when call Hive's function > -

[jira] [Updated] (FLINK-30452) Wrong argument type of null literal is used when call Hive's function

2022-12-26 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-30452: --- Summary: Wrong argument type of null literal is used when call Hive's function (was: Wrong argument

[jira] [Commented] (FLINK-30452) Wrong argument type of null literal is used when call Hive's function

2022-12-26 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652157#comment-17652157 ] Jing Zhang commented on FLINK-30452: Fix in master: 207975b416c324c634f0620e049669af

[jira] [Comment Edited] (FLINK-30452) Wrong argument type of null literal is used when call Hive's function

2022-12-26 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652157#comment-17652157 ] Jing Zhang edited comment on FLINK-30452 at 12/27/22 7:09 AM:

[jira] [Resolved] (FLINK-30452) Wrong argument type of null literal is used when call Hive's function

2022-12-26 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang resolved FLINK-30452. Resolution: Fixed > Wrong argument type of null literal is used when call Hive's function > --

[jira] [Updated] (FLINK-30452) Wrong argument type is used when call Hive's function

2022-12-26 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-30452: --- Fix Version/s: 1.17.0 > Wrong argument type is used when call Hive's function >

[jira] [Updated] (FLINK-30452) Wrong argument type is used when call Hive's function

2022-12-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30452: --- Labels: pull-request-available (was: ) > Wrong argument type is used when call Hive's funct

[GitHub] [flink] beyond1920 closed pull request #21528: [FLINK-30452][hive] fix use wrong argument type of null literal is used when call Hive's function

2022-12-26 Thread GitBox
beyond1920 closed pull request #21528: [FLINK-30452][hive] fix use wrong argument type of null literal is used when call Hive's function URL: https://github.com/apache/flink/pull/21528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Created] (FLINK-30507) EventTimeWindowCheckpointingITCase.testTumblingTimeWindowWithKVStateMinMaxParallelism could not be initialized

2022-12-26 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-30507: - Summary: EventTimeWindowCheckpointingITCase.testTumblingTimeWindowWithKVStateMinMaxParallelism could not be initialized Key: FLINK-30507 URL: https://issues.apache.org/jira/bro

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

2022-12-26 Thread GitBox
yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057476274 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/util/SqlGatewayRestClientAndEndpointUtils.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed

[GitHub] [flink] godfreyhe commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

2022-12-26 Thread GitBox
godfreyhe commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057097911 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkDynamicPartitionPruningConverterProgram.java: ## @@ -0,0 +1

[GitHub] [flink] godfreyhe commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

2022-12-26 Thread GitBox
godfreyhe commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057476012 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java: ## @@ -201,33 +224,128 @@ private static void

[GitHub] [flink] fsk119 commented on a diff in pull request #21554: [FLINK-30493][table-api] Introduce TableChange to SET/RESET options

2022-12-26 Thread GitBox
fsk119 commented on code in PR #21554: URL: https://github.com/apache/flink/pull/21554#discussion_r1057475505 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/TableChange.java: ## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] godfreyhe commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

2022-12-26 Thread GitBox
godfreyhe commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057475102 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java: ## @@ -201,33 +224,128 @@ private static void

[GitHub] [flink] godfreyhe commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

2022-12-26 Thread GitBox
godfreyhe commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057474328 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkDynamicPartitionPruningConverterProgram.java: ## @@ -0,0 +1

[jira] [Closed] (FLINK-30270) FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin

2022-12-26 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He closed FLINK-30270. -- Resolution: Fixed Fixed in master:7590cb7d84774b0e8afd7b0af31cc0af762d4c6a 1.16.1: ca42695dba5ab72c6b

[GitHub] [flink] godfreyhe commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

2022-12-26 Thread GitBox
godfreyhe commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057097911 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkDynamicPartitionPruningConverterProgram.java: ## @@ -0,0 +1

[GitHub] [flink] fsk119 commented on pull request #21554: [FLINK-30493][table-api] Introduce TableChange to SET/RESET options

2022-12-26 Thread GitBox
fsk119 commented on PR #21554: URL: https://github.com/apache/flink/pull/21554#issuecomment-1365651199 > Is it deprecated now? Yes. I think the `AlterTableOptionsOperation ` is deprecated. Considering it's totally internal, we may remove this directly? WDYT? > I sawHiveParserD

[GitHub] [flink] Myasuka commented on pull request #21406: [FLINK-30088][runtime] Fix excessive state updates for TtlMapState and TtlListState

2022-12-26 Thread GitBox
Myasuka commented on PR #21406: URL: https://github.com/apache/flink/pull/21406#issuecomment-1365640815 @rovboyko If so, I think we can add such a TTL state benchmark under https://github.com/apache/flink-benchmarks/tree/master/src/main/java/org/apache/flink/state/benchmark to prove this im

[jira] [Commented] (FLINK-30498) frocksdb throw an UnsatisfiedLinkError

2022-12-26 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652138#comment-17652138 ] Yanfei Lei commented on FLINK-30498: 👍Thanks for sharing, this can be an experience

[GitHub] [flink] godfreyhe closed pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

2022-12-26 Thread GitBox
godfreyhe closed pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error URL: https://github.com/apache/flink/pull/21487 -- This is an automated message from the Apache Git Service. To respond to the message

[jira] [Commented] (FLINK-30505) Close the connection between TM and JM when task executor failed

2022-12-26 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652132#comment-17652132 ] Xintong Song commented on FLINK-30505: -- bq. If the termination of the pod is caused

[GitHub] [flink] rovboyko commented on pull request #21406: [FLINK-30088][runtime] Fix excessive state updates for TtlMapState and TtlListState

2022-12-26 Thread GitBox
rovboyko commented on PR #21406: URL: https://github.com/apache/flink/pull/21406#issuecomment-1365623119 Hi @Myasuka ! Thanks for your reply. The main benefit of this change is avoiding of unnecessary stateIterator.update() invocation inside TtlIncrementalCleanup.runCleanup() method.

[GitHub] [flink-benchmarks] fredia commented on pull request #63: [FLINK-27571][benchmark] Recognize 'less is better' benchmarks in regression detection script

2022-12-26 Thread GitBox
fredia commented on PR #63: URL: https://github.com/apache/flink-benchmarks/pull/63#issuecomment-1365613406 Hi @pnowojski, could you please help take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Updated] (FLINK-27571) Recognize "less is better" benchmarks in regression detection script

2022-12-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27571: --- Labels: pull-request-available (was: ) > Recognize "less is better" benchmarks in regressio

[GitHub] [flink-benchmarks] fredia opened a new pull request, #63: [FLINK-27571][benchmark] Recognize 'less is better' benchmarks in regression detection script

2022-12-26 Thread GitBox
fredia opened a new pull request, #63: URL: https://github.com/apache/flink-benchmarks/pull/63 1. Add the script that updates fields for codespeed_benchmark table. After updating, the Y axis would become “ms/op (less is better)” 2. Update save_jmh_results.py , If a new benchmark is intro

[GitHub] [flink-benchmarks] fredia closed pull request #53: [FLINK-27214] make CI run 2 iterations

2022-12-26 Thread GitBox
fredia closed pull request #53: [FLINK-27214] make CI run 2 iterations URL: https://github.com/apache/flink-benchmarks/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink] beyond1920 commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

2022-12-26 Thread GitBox
beyond1920 commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1057434644 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Ap

[GitHub] [flink] beyond1920 commented on pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

2022-12-26 Thread GitBox
beyond1920 commented on PR #21401: URL: https://github.com/apache/flink/pull/21401#issuecomment-1365608382 Thanks for contribution. @lsyldliu Look good overall, I only left some minor comments. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [flink] flinkbot commented on pull request #21561: [FLINK-30505][runtime] Close the connection between TM and JM when cl…

2022-12-26 Thread GitBox
flinkbot commented on PR #21561: URL: https://github.com/apache/flink/pull/21561#issuecomment-1365603324 ## CI report: * 93fc284fe2d1e41d7d77e8f4de280e6d733f4706 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30505) Close the connection between TM and JM when task executor failed

2022-12-26 Thread Yongming Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652111#comment-17652111 ] Yongming Zhang commented on FLINK-30505: If the termination of the pod is caused

[GitHub] [flink] damumu0625 opened a new pull request, #21561: [FLINK-30505][runtime] Close the connection between TM and JM when cl…

2022-12-26 Thread GitBox
damumu0625 opened a new pull request, #21561: URL: https://github.com/apache/flink/pull/21561 …ose the connection between TM and RM ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than throug

[jira] [Updated] (FLINK-30505) Close the connection between TM and JM when task executor failed

2022-12-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30505: --- Labels: pull-request-available (was: ) > Close the connection between TM and JM when task e

[GitHub] [flink] LadyForest commented on a diff in pull request #21554: [FLINK-30493][table-api] Introduce TableChange to SET/RESET options

2022-12-26 Thread GitBox
LadyForest commented on code in PR #21554: URL: https://github.com/apache/flink/pull/21554#discussion_r1057423443 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/TableChange.java: ## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [flink] LadyForest commented on pull request #21554: [FLINK-30493][table-api] Introduce TableChange to SET/RESET options

2022-12-26 Thread GitBox
LadyForest commented on PR #21554: URL: https://github.com/apache/flink/pull/21554#issuecomment-1365585827 Hi @fsk119, thanks for the contribution; it looks good in general. I have one question about `AlterTableOptionsOption`. Is it deprecated now? I saw`HiveParserDDLSemanticAnalyzer#conver

[jira] [Assigned] (FLINK-29768) Hybrid shuffle supports consume partial finished subtask in speculative execution mode

2022-12-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-29768: -- Assignee: Weijie Guo > Hybrid shuffle supports consume partial finished subtask in speculativ

[jira] [Commented] (FLINK-30505) Close the connection between TM and JM when task executor failed

2022-12-26 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652097#comment-17652097 ] Xintong Song commented on FLINK-30505: -- On the contrary, I think this can be mislea

[jira] [Commented] (FLINK-30505) Close the connection between TM and JM when task executor failed

2022-12-26 Thread Yongming Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652093#comment-17652093 ] Yongming Zhang commented on FLINK-30505: I do this to make the exception more ob

[jira] [Updated] (FLINK-30506) Add documentation for writing Table Store with Spark3

2022-12-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30506: --- Labels: pull-request-available (was: ) > Add documentation for writing Table Store with Spa

[GitHub] [flink-table-store] tsreaper opened a new pull request, #445: [FLINK-30506] Add documentation for writing Table Store with Spark3

2022-12-26 Thread GitBox
tsreaper opened a new pull request, #445: URL: https://github.com/apache/flink-table-store/pull/445 Table Store 0.3 supports writing with Spark3. We need to add documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Commented] (FLINK-24999) flink-python doesn't work on Java 17

2022-12-26 Thread Luning Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652091#comment-17652091 ] Luning Wang commented on FLINK-24999: - maven-shade-plugin 3.2.4 don't support java17

[jira] [Created] (FLINK-30506) Add documentation for writing Table Store with Spark3

2022-12-26 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-30506: --- Summary: Add documentation for writing Table Store with Spark3 Key: FLINK-30506 URL: https://issues.apache.org/jira/browse/FLINK-30506 Project: Flink Issue Typ

[GitHub] [flink] LadyForest commented on a diff in pull request #21554: [FLINK-30493][table-api] Introduce TableChange to SET/RESET options

2022-12-26 Thread GitBox
LadyForest commented on code in PR #21554: URL: https://github.com/apache/flink/pull/21554#discussion_r105741 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/TableChange.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [flink] LadyForest commented on a diff in pull request #21554: [FLINK-30493][table-api] Introduce TableChange to SET/RESET options

2022-12-26 Thread GitBox
LadyForest commented on code in PR #21554: URL: https://github.com/apache/flink/pull/21554#discussion_r1057409885 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java: ## @@ -595,10 +596,16 @@ private Operation c

[GitHub] [flink] swuferhong commented on a diff in pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize m

2022-12-26 Thread GitBox
swuferhong commented on code in PR #21490: URL: https://github.com/apache/flink/pull/21490#discussion_r1057402776 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRelMdUtil.scala: ## @@ -247,6 +248,77 @@ object FlinkRelMdUtil {

[jira] [Closed] (FLINK-30504) Fix UnsupportedFileSystemSchemeException when writing Table Store on OSS with other engines

2022-12-26 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-30504. --- Assignee: Caizhi Weng Resolution: Fixed master: 929c1110bdbf521ad0a9eb09a65d33f76a2b5990 relea

[jira] [Commented] (FLINK-30505) Close the connection between TM and JM when task executor failed

2022-12-26 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652087#comment-17652087 ] Xintong Song commented on FLINK-30505: -- I don't see how the proposed change makes a

[GitHub] [flink-table-store] tsreaper merged pull request #444: [FLINK-30504] Fix UnsupportedFileSystemSchemeException when writing Table Store on OSS with Spark

2022-12-26 Thread GitBox
tsreaper merged PR #444: URL: https://github.com/apache/flink-table-store/pull/444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@fl

[GitHub] [flink] swuferhong commented on a diff in pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize m

2022-12-26 Thread GitBox
swuferhong commented on code in PR #21490: URL: https://github.com/apache/flink/pull/21490#discussion_r1057401207 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRelMdUtil.scala: ## @@ -247,6 +248,77 @@ object FlinkRelMdUtil {

[jira] [Commented] (FLINK-30499) Over window codegen error when member code incorrectly used in method body

2022-12-26 Thread Runkang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652086#comment-17652086 ] Runkang He commented on FLINK-30499: [~libenchao] Thanks a lot, I will create a PR A

[jira] [Commented] (FLINK-25802) OverWindow in batch mode failed

2022-12-26 Thread Runkang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652085#comment-17652085 ] Runkang He commented on FLINK-25802: [~libenchao] Thanks a lot, I will create a PR s

[jira] [Closed] (FLINK-30449) Improve Serialization and Deserialization of FetchResultsResponseBody

2022-12-26 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-30449. - Fix Version/s: 1.17.0 Resolution: Implemented Merged into master: 95cb47ef53c822161ca90cd

[jira] [Assigned] (FLINK-30449) Improve Serialization and Deserialization of FetchResultsResponseBody

2022-12-26 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-30449: - Assignee: yuzelin > Improve Serialization and Deserialization of FetchResultsResponseBo

[GitHub] [flink] fsk119 merged pull request #21523: [FLINK-30449][sql-gateway] Introduce ResultInfo to improve the serialization and deserialization of FetchResultsResponseBody

2022-12-26 Thread GitBox
fsk119 merged PR #21523: URL: https://github.com/apache/flink/pull/21523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Closed] (FLINK-30334) SourceCoordinator error splitRequest check cause HybridSource loss of data and hang

2022-12-26 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-30334. --- Resolution: Fixed master: 6e4e6c68a4a179d932dacafb2771cc84f730bbc0 1.16: 2b5e4ac8df41fe68ae8212eab4a254740e

[GitHub] [flink] zhuzhurk closed pull request #21464: [FLINK-30334][runtime] Fix noMoreSplits event handling for HybridSource

2022-12-26 Thread GitBox
zhuzhurk closed pull request #21464: [FLINK-30334][runtime] Fix noMoreSplits event handling for HybridSource URL: https://github.com/apache/flink/pull/21464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] zhuzhurk commented on pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

2022-12-26 Thread GitBox
zhuzhurk commented on PR #21464: URL: https://github.com/apache/flink/pull/21464#issuecomment-1365540296 Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #493: [FLINK-30464] Exclude metrics during stabilization and ensure a full metric window

2022-12-26 Thread GitBox
mxm commented on code in PR #493: URL: https://github.com/apache/flink-kubernetes-operator/pull/493#discussion_r1057362585 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java: ## @@ -122,7 +130,15 @@ public Coll

[GitHub] [flink] rkhachatryan commented on pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-26 Thread GitBox
rkhachatryan commented on PR #21467: URL: https://github.com/apache/flink/pull/21467#issuecomment-1365494864 Good idea, renamed in 1ff8c609144077cc57d8a8106ce4fd9085a37b4f. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [flink] wanglijie95 commented on pull request #21162: [FLINK-29665][runtime] Support flexible subpartion range division

2022-12-26 Thread GitBox
wanglijie95 commented on PR #21162: URL: https://github.com/apache/flink/pull/21162#issuecomment-1365198695 Thanks for review @zhuzhurk. I 've addressed all comments, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] wanglijie95 commented on a diff in pull request #21162: [FLINK-29665][runtime] Support flexible subpartion range division

2022-12-26 Thread GitBox
wanglijie95 commented on code in PR #21162: URL: https://github.com/apache/flink/pull/21162#discussion_r1057242727 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/VertexInputInfoStore.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Closed] (FLINK-22315) Support ADD column/constraint/watermark for ALTER TABLE statement

2022-12-26 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-22315. - Fix Version/s: 1.17.0 Resolution: Implemented Merged into master: 37995f298033f6f3a9df47

[jira] [Commented] (FLINK-30499) Over window codegen error when member code incorrectly used in method body

2022-12-26 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652006#comment-17652006 ] Benchao Li commented on FLINK-30499: [~Runking] Thanks for reporting and volunteerin

[GitHub] [flink] fsk119 closed pull request #20652: [FLINK-22315][table] Support ADD column/constraint/watermark for ALTER TABLE statement

2022-12-26 Thread GitBox
fsk119 closed pull request #20652: [FLINK-22315][table] Support ADD column/constraint/watermark for ALTER TABLE statement URL: https://github.com/apache/flink/pull/20652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (FLINK-30499) Over window codegen error when member code incorrectly used in method body

2022-12-26 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-30499: --- Priority: Major (was: Blocker) > Over window codegen error when member code incorrectly used in met

[jira] [Assigned] (FLINK-30499) Over window codegen error when member code incorrectly used in method body

2022-12-26 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-30499: -- Assignee: Runkang He > Over window codegen error when member code incorrectly used in method

[jira] [Assigned] (FLINK-25802) OverWindow in batch mode failed

2022-12-26 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-25802: -- Assignee: Runkang He > OverWindow in batch mode failed > --- > >

[jira] [Commented] (FLINK-25802) OverWindow in batch mode failed

2022-12-26 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652005#comment-17652005 ] Benchao Li commented on FLINK-25802: [~Runking] Thanks for volunteering to work on t

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

2022-12-26 Thread GitBox
swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057207173 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java: ## @@ -201,33 +224,128 @@ private static voi

[GitHub] [flink] godfreyhe commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink busy join reorder rule which based on greedy algorithm

2022-12-26 Thread GitBox
godfreyhe commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1057178039 ## docs/layouts/shortcodes/generated/optimizer_config_configuration.html: ## @@ -89,5 +89,17 @@ Boolean When it is true, the optimizer will

[GitHub] [flink] chucheng92 commented on a diff in pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situati

2022-12-26 Thread GitBox
chucheng92 commented on code in PR #21464: URL: https://github.com/apache/flink/pull/21464#discussion_r1057181722 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplitEnumeratorTest.java: ## @@ -216,6 +216,43 @@ pu

[GitHub] [flink] chucheng92 commented on pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

2022-12-26 Thread GitBox
chucheng92 commented on PR #21464: URL: https://github.com/apache/flink/pull/21464#issuecomment-1365068832 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21559: [FLINK-29859][e2e] Running TPC-DS with adaptive batch scheduler supports custom exceptions check

2022-12-26 Thread GitBox
zhuzhurk commented on code in PR #21559: URL: https://github.com/apache/flink/pull/21559#discussion_r1057175134 ## flink-end-to-end-tests/test-scripts/test-runner-common.sh: ## @@ -58,23 +59,28 @@ function run_test { exit_code="$?" # remove trap for test execution

[GitHub] [flink] yuzelin commented on pull request #21523: [FLINK-30449][sql-gateway] Introduce ResultInfo to improve the serialization and deserialization of FetchResultsResponseBody

2022-12-26 Thread GitBox
yuzelin commented on PR #21523: URL: https://github.com/apache/flink/pull/21523#issuecomment-1365065302 @fsk119 thx, LGTM. I have added a bytes case to the resultInfo.txt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Created] (FLINK-30505) Close the connection between TM and JM when task executor failed

2022-12-26 Thread Yongming Zhang (Jira)
Yongming Zhang created FLINK-30505: -- Summary: Close the connection between TM and JM when task executor failed Key: FLINK-30505 URL: https://issues.apache.org/jira/browse/FLINK-30505 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #21560: [FLINK-29768] Hybrid shuffle supports consume partial finished subtask

2022-12-26 Thread GitBox
flinkbot commented on PR #21560: URL: https://github.com/apache/flink/pull/21560#issuecomment-1365064472 ## CI report: * c98c28755e3f2febbb926a741006ae298653f41c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-29869) make ResourceActions declarative

2022-12-26 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-29869. Resolution: Done master (1.17): fc0cdeeaffb2ccdab720a8af68e337060668193a > make ResourceActions d

[GitHub] [flink] xintongsong closed pull request #21496: [FLINK-29869][ResourceManager] make ResourceAllocator declarative.

2022-12-26 Thread GitBox
xintongsong closed pull request #21496: [FLINK-29869][ResourceManager] make ResourceAllocator declarative. URL: https://github.com/apache/flink/pull/21496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Updated] (FLINK-29768) Hybrid shuffle supports consume partial finished subtask in speculative execution mode

2022-12-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29768: --- Labels: pull-request-available (was: ) > Hybrid shuffle supports consume partial finished s

[GitHub] [flink] reswqa opened a new pull request, #21560: [FLINK-29768] Hybrid shuffle supports consume partial finished subtask

2022-12-26 Thread GitBox
reswqa opened a new pull request, #21560: URL: https://github.com/apache/flink/pull/21560 ## What is the purpose of the change *At present, downstream task can be scheduled only if all upstream tasks finished in adaptive batch scheduler. We can do some improvements to support schedul

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

2022-12-26 Thread GitBox
zhuzhurk commented on code in PR #21464: URL: https://github.com/apache/flink/pull/21464#discussion_r1057158451 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplitEnumeratorTest.java: ## @@ -216,6 +216,43 @@ publ

[GitHub] [flink] fsk119 commented on pull request #21554: [FLINK-30493][table-api] Introduce TableChange to SET/RESET options

2022-12-26 Thread GitBox
fsk119 commented on PR #21554: URL: https://github.com/apache/flink/pull/21554#issuecomment-1365030894 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink] chucheng92 commented on pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

2022-12-26 Thread GitBox
chucheng92 commented on PR #21464: URL: https://github.com/apache/flink/pull/21464#issuecomment-1365028550 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Updated] (FLINK-30504) Fix UnsupportedFileSystemSchemeException when writing Table Store on OSS with other engines

2022-12-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30504: --- Labels: pull-request-available (was: ) > Fix UnsupportedFileSystemSchemeException when writ

[GitHub] [flink-table-store] tsreaper opened a new pull request, #444: [FLINK-30504] Fix UnsupportedFileSystemSchemeException when writing Table Store on OSS with Spark

2022-12-26 Thread GitBox
tsreaper opened a new pull request, #444: URL: https://github.com/apache/flink-table-store/pull/444 Currently when writing Table Store tables on OSS with other engines (for example Spark), the following exception will occur. ``` 22/12/23 17:54:12 WARN TaskSetManager: Lost task 0.0

  1   2   >