yuzelin commented on code in PR #21525:
URL: https://github.com/apache/flink/pull/21525#discussion_r1057499949
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java:
##########
@@ -532,27 +468,30 @@ public EmptyMessageParameters
getUnresolvedMessageParameters() {
}
}
- private static class TestVersionSelectionHeaders1 extends
TestVersionSelectionHeadersBase {
+ private static class TestVersionSelectionHeaders0 extends
TestVersionSelectionHeadersBase {
@Override
public Collection<SqlGatewayRestAPIVersion> getSupportedAPIVersions() {
return Collections.singleton(SqlGatewayRestAPIVersion.V0);
}
}
- private static class TestVersionSelectionHeaders2 extends
TestVersionSelectionHeadersBase {
+ private static class TestVersionSelectionHeaders12 extends
TestVersionSelectionHeadersBase {
@Override
public Collection<SqlGatewayRestAPIVersion> getSupportedAPIVersions() {
- return Collections.singleton(SqlGatewayRestAPIVersion.V1);
+ return Arrays.asList(SqlGatewayRestAPIVersion.V1,
SqlGatewayRestAPIVersion.V2);
Review Comment:
Can't remove or add value to the list returned by `Arrays.asList.` I used
`new ArrayList(Arrays.asList(xx))`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
