[jira] [Assigned] (FLINK-30386) Column constraint lacks primary key not enforced check

2022-12-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-30386: -- Assignee: Jane Chan > Column constraint lacks primary key not enforced check > --

[jira] [Closed] (FLINK-30398) Introduce S3 support for table store

2022-12-13 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-30398. --- Resolution: Fixed master: 54fd3ab2d16999d628faf4ff62c701b12ca20725 > Introduce S3 support for table

[GitHub] [flink-table-store] tsreaper merged pull request #436: [FLINK-30398] Introduce S3 support for table store

2022-12-13 Thread GitBox
tsreaper merged PR #436: URL: https://github.com/apache/flink-table-store/pull/436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@fl

[jira] [Commented] (FLINK-30387) support job singleton within TM

2022-12-13 Thread James Z.M. Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646965#comment-17646965 ] James Z.M. Gao commented on FLINK-30387: The class containing the static fields

[jira] [Updated] (FLINK-30212) Introduce a TableStoreCompactJob class for users to submit compact jobs in Table Store

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30212: --- Labels: pull-request-available (was: ) > Introduce a TableStoreCompactJob class for users t

[GitHub] [flink-table-store] tsreaper opened a new pull request, #437: [FLINK-30212] Introduce a TableStoreCompactJob class for users to submit compact jobs in Table Store

2022-12-13 Thread GitBox
tsreaper opened a new pull request, #437: URL: https://github.com/apache/flink-table-store/pull/437 Currently Flink does not support SQL statements for compacting a table. So in this ticket we create a `TableStoreCompactJob` class for users to submit compact jobs in Table Store. -- This

[jira] [Closed] (FLINK-30211) Introduce CompactStoreSink for compact jobs in Table Store

2022-12-13 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-30211. --- Resolution: Fixed master: 422c409b36efcd0e75fdde61b0601f405b18e3ef > Introduce CompactStoreSink for

[GitHub] [flink-table-store] tsreaper merged pull request #435: [FLINK-30211] Introduce CompactorSink for compact jobs in Table Store

2022-12-13 Thread GitBox
tsreaper merged PR #435: URL: https://github.com/apache/flink-table-store/pull/435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@fl

[jira] [Commented] (FLINK-30198) Support AdaptiveBatchScheduler to set per-task size for reducer task

2022-12-13 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646961#comment-17646961 ] Zhu Zhu commented on FLINK-30198: - In our experience, map tasks are also possible to be

[GitHub] [flink-ml] Fanoid commented on pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-13 Thread GitBox
Fanoid commented on PR #191: URL: https://github.com/apache/flink-ml/pull/191#issuecomment-1350491300 > Thanks for the PR! It seems that CI cannot pass due to the formatting problem. Could you please do the check following [1]? > > [1] https://github.com/apache/flink-ml/tree/master/.g

[GitHub] [flink] Sxnan commented on pull request #20862: [FLINK-29339][runtime] JobMasterPartitionTracker returns future to avoid blocking main thread

2022-12-13 Thread GitBox
Sxnan commented on PR #20862: URL: https://github.com/apache/flink/pull/20862#issuecomment-1350481417 @gaoyunhaii Thanks for your review and sorry for the late update. I updated the PR accordingly. Could you please take another look? -- This is an automated message from the Apache Git Ser

[jira] [Commented] (FLINK-30386) Column constraint lacks primary key not enforced check

2022-12-13 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646951#comment-17646951 ] Jane Chan commented on FLINK-30386: --- Thanks for the explanation, and let's fix this. P

[GitHub] [flink] flinkbot commented on pull request #21506: [FLINK-30097][docs] Update the example in the docs of DataStream cache

2022-12-13 Thread GitBox
flinkbot commented on PR #21506: URL: https://github.com/apache/flink/pull/21506#issuecomment-1350437686 ## CI report: * 336a91eb0b0efbf24a75f2161d90a441fd3e1f0d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30097) CachedDataStream java example in the document is not correct

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30097: --- Labels: pull-request-available (was: ) > CachedDataStream java example in the document is n

[GitHub] [flink] Sxnan opened a new pull request, #21506: [FLINK-30097][docs] Update the example in the docs of DataStream cache

2022-12-13 Thread GitBox
Sxnan opened a new pull request, #21506: URL: https://github.com/apache/flink/pull/21506 ## What is the purpose of the change Update the example in the docs of DataStream cache to fix the wrong type usage. ## Brief change log - Update the example in the docs of DataS

[GitHub] [flink] Samrat002 commented on pull request #21497: [FLINK-30377][table-planner] applySinkProvider use ClientWrapperClassLoader while extracting Type from KeyedStream

2022-12-13 Thread GitBox
Samrat002 commented on PR #21497: URL: https://github.com/apache/flink/pull/21497#issuecomment-1350378538 @twalthr , please help reviewing the small change in free time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-30409) Support reopening closed metric groups

2022-12-13 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646907#comment-17646907 ] Mason Chen commented on FLINK-30409: Another way to think about this is to "clear" u

[jira] [Commented] (FLINK-30409) Support reopening closed metric groups

2022-12-13 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646906#comment-17646906 ] Mason Chen commented on FLINK-30409: cc: [~chesnay] what do you think about this? 

[jira] [Created] (FLINK-30409) Support reopening closed metric groups

2022-12-13 Thread Mason Chen (Jira)
Mason Chen created FLINK-30409: -- Summary: Support reopening closed metric groups Key: FLINK-30409 URL: https://issues.apache.org/jira/browse/FLINK-30409 Project: Flink Issue Type: Improvement

[jira] [Closed] (FLINK-29679) Migrate to new schema framework & show column comment

2022-12-13 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-29679. Fix Version/s: 1.17.0 Resolution: Fixed master: b30b12d97a00ee5a338b2bd4233df1e2b38ce87f >

[GitHub] [flink] JingsongLi merged pull request #21182: [FLINK-29679][table] Migrate to new schema framework & show column comment

2022-12-13 Thread GitBox
JingsongLi merged PR #21182: URL: https://github.com/apache/flink/pull/21182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[GitHub] [flink-connector-elasticsearch] reswqa commented on pull request #50: [FLINK-30359][es] flink-sql-connector-elasticsearch6's jar should luding the dependency of com.carrotsearch:hppc

2022-12-13 Thread GitBox
reswqa commented on PR #50: URL: https://github.com/apache/flink-connector-elasticsearch/pull/50#issuecomment-1350344849 cc @zentol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-30359) Encountered NoClassDefFoundError when using flink-sql-connector-elasticsearch6

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30359: --- Labels: pull-request-available (was: ) > Encountered NoClassDefFoundError when using > fl

[GitHub] [flink-connector-elasticsearch] boring-cyborg[bot] commented on pull request #50: [FLINK-30359][es] flink-sql-connector-elasticsearch6's jar should luding the dependency of com.carrotsearch:h

2022-12-13 Thread GitBox
boring-cyborg[bot] commented on PR #50: URL: https://github.com/apache/flink-connector-elasticsearch/pull/50#issuecomment-1350344548 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- T

[jira] [Commented] (FLINK-27219) CliClientITCase.testSqlStatements failed on azure with jdk11

2022-12-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646904#comment-17646904 ] luoyuxia commented on FLINK-27219: -- [~renqs] I don't think this one [https://dev.azure

[jira] [Updated] (FLINK-30401) Add Estimator and Transformer for MinHashLSH

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30401: --- Labels: pull-request-available (was: ) > Add Estimator and Transformer for MinHashLSH > ---

[GitHub] [flink-ml] zhipeng93 commented on pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-13 Thread GitBox
zhipeng93 commented on PR #191: URL: https://github.com/apache/flink-ml/pull/191#issuecomment-1350324811 Thanks for the PR! It seems that CI cannot pass due to the formatting problem. Could you please do the check following [1]? [1] https://github.com/apache/flink-ml/tree/master/.gith

[jira] [Commented] (FLINK-27219) CliClientITCase.testSqlStatements failed on azure with jdk11

2022-12-13 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646902#comment-17646902 ] Qingsheng Ren commented on FLINK-27219: --- https://dev.azure.com/apache-flink/apache

[GitHub] [flink] zhuzhurk commented on pull request #21483: [FLINK-30358][rest] Exception location contains TM resource id and link to TM pages.

2022-12-13 Thread GitBox
zhuzhurk commented on PR #21483: URL: https://github.com/apache/flink/pull/21483#issuecomment-1350244652 Thanks for making this change. The change looks good to me. However, I would like to invite a web frontend expert to double confirm the changes to the web part. @yangjunhan would yo

[GitHub] [flink] yuzelin commented on pull request #21502: [WIP] ResultSet Modification.

2022-12-13 Thread GitBox
yuzelin commented on PR #21502: URL: https://github.com/apache/flink/pull/21502#issuecomment-1350244643 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-30035) ./bin/sql-client.sh won't import external jar into the session

2022-12-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646888#comment-17646888 ] luoyuxia commented on FLINK-30035: -- May similar issue to FLINK-30318, after FLINK-14055

[GitHub] [flink-web] mbalassi closed pull request #595: Kubernetes Operator 1.3.0 release blogpost

2022-12-13 Thread GitBox
mbalassi closed pull request #595: Kubernetes Operator 1.3.0 release blogpost URL: https://github.com/apache/flink-web/pull/595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-web] mbalassi closed pull request #593: Kubernetes Operator Release 1.3.0

2022-12-13 Thread GitBox
mbalassi closed pull request #593: Kubernetes Operator Release 1.3.0 URL: https://github.com/apache/flink-web/pull/593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-13 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1047831221 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java: ## @@ -2896,7 +2896,8 @@ private TaskExecutorTestingContext createTask

[GitHub] [flink] dmvk closed pull request #17916: [FLINK-25023] Prevent leaking classloaders from filesystems through AccessControlContext.

2022-12-13 Thread GitBox
dmvk closed pull request #17916: [FLINK-25023] Prevent leaking classloaders from filesystems through AccessControlContext. URL: https://github.com/apache/flink/pull/17916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [flink-web] morhidi commented on pull request #593: Kubernetes Operator Release 1.3.0

2022-12-13 Thread GitBox
morhidi commented on PR #593: URL: https://github.com/apache/flink-web/pull/593#issuecomment-1349911639 > Looks good. Are you planning to draft a release blogpost too, @morhidi? Yes, https://github.com/apache/flink-web/pull/595 :) -- This is an automated message from the Apache Git

[GitHub] [flink] MartijnVisser commented on pull request #21501: [FLINK-30397][Connector/Pulsar] Remove Pulsar connector

2022-12-13 Thread GitBox
MartijnVisser commented on PR #21501: URL: https://github.com/apache/flink/pull/21501#issuecomment-1349911560 > you should update the production tests archunit store to remove pulsar violations. Aren't the Pulsar violations already removed, since I've completely removed the Pulsar so

[GitHub] [flink-web] morhidi opened a new pull request, #595: Kubernetes Operator 1.3.0 release blogpost

2022-12-13 Thread GitBox
morhidi opened a new pull request, #595: URL: https://github.com/apache/flink-web/pull/595 Kubernetes Operator 1.3.0 release blogpost -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] MartijnVisser commented on pull request #21371: [FLINK-30166][Connector/FileSystem] Refactor tests that use the deprecated StreamingFileSink instead of FileSink

2022-12-13 Thread GitBox
MartijnVisser commented on PR #21371: URL: https://github.com/apache/flink/pull/21371#issuecomment-1349895213 @gaoyunhaii Any luck so far? @JingsongLi Have you thought about what's needed / can be done to completely remove the remaining StreamingFileSink implementation? -- This is

[GitHub] [flink] MartijnVisser commented on a diff in pull request #21501: [FLINK-30397][Connector/Pulsar] Remove Pulsar connector

2022-12-13 Thread GitBox
MartijnVisser commented on code in PR #21501: URL: https://github.com/apache/flink/pull/21501#discussion_r1047808521 ## flink-docs/src/main/java/org/apache/flink/docs/util/ConfigurationOptionLocator.java: ## @@ -73,15 +73,6 @@ public class ConfigurationOptionLocator {

[GitHub] [flink] MartijnVisser commented on pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

2022-12-13 Thread GitBox
MartijnVisser commented on PR #21128: URL: https://github.com/apache/flink/pull/21128#issuecomment-1349805753 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink] dmvk commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-13 Thread GitBox
dmvk commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1047786569 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java: ## @@ -2896,7 +2896,8 @@ private TaskExecutorTestingContext createTaskExecutor

[jira] [Created] (FLINK-30408) Add unit test for HA metadata check logic

2022-12-13 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-30408: -- Summary: Add unit test for HA metadata check logic Key: FLINK-30408 URL: https://issues.apache.org/jira/browse/FLINK-30408 Project: Flink Issue Type: Improvement

[jira] [Assigned] (FLINK-30407) Better encapsulate error handling logic in controllers

2022-12-13 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi reassigned FLINK-30407: - Assignee: Matyas Orhidi > Better encapsulate error handling logic in controllers >

[jira] [Created] (FLINK-30407) Better encapsulate error handling logic in controllers

2022-12-13 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-30407: -- Summary: Better encapsulate error handling logic in controllers Key: FLINK-30407 URL: https://issues.apache.org/jira/browse/FLINK-30407 Project: Flink Issue Type

[jira] [Assigned] (FLINK-30405) Add ResourceLifecycleStatus to CommonStatus and printer column

2022-12-13 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi reassigned FLINK-30405: - Assignee: Matyas Orhidi > Add ResourceLifecycleStatus to CommonStatus and printer colum

[jira] [Created] (FLINK-30406) Jobmanager Deployment error without HA metadata should not lead to unrecoverable error

2022-12-13 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-30406: -- Summary: Jobmanager Deployment error without HA metadata should not lead to unrecoverable error Key: FLINK-30406 URL: https://issues.apache.org/jira/browse/FLINK-30406 Pr

[jira] [Created] (FLINK-30405) Add ResourceLifecycleStatus to CommonStatus and printer column

2022-12-13 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-30405: -- Summary: Add ResourceLifecycleStatus to CommonStatus and printer column Key: FLINK-30405 URL: https://issues.apache.org/jira/browse/FLINK-30405 Project: Flink

[GitHub] [flink] gyfora commented on a diff in pull request #20636: [FLINK-28831][k8s]Support pluginable decorators mechanism - part 1st

2022-12-13 Thread GitBox
gyfora commented on code in PR #20636: URL: https://github.com/apache/flink/pull/20636#discussion_r1047706960 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/extended/ExtPluginDecorator.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache

[GitHub] [flink] MartijnVisser commented on pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

2022-12-13 Thread GitBox
MartijnVisser commented on PR #21128: URL: https://github.com/apache/flink/pull/21128#issuecomment-134960 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Commented] (FLINK-29863) Properly handle NaN/Infinity in OpenAPI spec

2022-12-13 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646786#comment-17646786 ] Austin Cawley-Edwards commented on FLINK-29863: --- Because we're using Jacks

[GitHub] [flink] ashmeet-kandhari commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
ashmeet-kandhari commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047583788 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaInternalProducerITCase.java: ## @@ -148,62 +153,7

[GitHub] [flink] ashmeet-kandhari commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
ashmeet-kandhari commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047582360 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaInternalProducerITCase.java: ## @@ -148,62 +153,7

[GitHub] [flink] ashmeet-kandhari commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
ashmeet-kandhari commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047582623 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaInternalProducerITCase.java: ## @@ -148,62 +153,7

[GitHub] [flink] ashmeet-kandhari commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
ashmeet-kandhari commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047581939 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaInternalProducerITCase.java: ## @@ -148,62 +153,7

[GitHub] [flink] ashmeet-kandhari commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
ashmeet-kandhari commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047581701 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaInternalProducerITCase.java: ## @@ -102,8 +106,9

[GitHub] [flink] ashmeet-kandhari commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
ashmeet-kandhari commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047578778 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java: ## @@ -428,13 +434,13 @@ private void creat

[jira] [Commented] (FLINK-29863) Properly handle NaN/Infinity in OpenAPI spec

2022-12-13 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646758#comment-17646758 ] Chesnay Schepler commented on FLINK-29863: -- It may be difficult for us to guara

[jira] [Created] (FLINK-30404) Do not redeploy taskmanagers on standalone application scaling

2022-12-13 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-30404: -- Summary: Do not redeploy taskmanagers on standalone application scaling Key: FLINK-30404 URL: https://issues.apache.org/jira/browse/FLINK-30404 Project: Flink

[GitHub] [flink-connector-hbase] ferenc-csaky commented on pull request #5: [FLINK-30349] Sync missing HBase e2e tests to external repo

2022-12-13 Thread GitBox
ferenc-csaky commented on PR #5: URL: https://github.com/apache/flink-connector-hbase/pull/5#issuecomment-1348992091 > The e2e tests will need to be re-written to not rely on the legacy E2E infrastructure but use the connector e2e framework instead. @zentol Do we have any common util

[jira] [Commented] (FLINK-29863) Properly handle NaN/Infinity in OpenAPI spec

2022-12-13 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646692#comment-17646692 ] Austin Cawley-Edwards commented on FLINK-29863: --- What might be the issue o

[GitHub] [flink] snuyanzin commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1348765223 it seems that 4-th and 5-th problems are connected regarding > 5th Comment: I might need some help on how to revert the change for that. As I cannot see anything in intellij that

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047275232 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java: ## @@ -62,131 +63,154 @@ public static void prep

[jira] [Updated] (FLINK-30402) Separate token framework generic and hadoop specific parts

2022-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30402: --- Labels: pull-request-available (was: ) > Separate token framework generic and hadoop specif

[GitHub] [flink] flinkbot commented on pull request #21505: [FLINK-30402][security][runtime] Separate token framework generic and hadoop specific parts

2022-12-13 Thread GitBox
flinkbot commented on PR #21505: URL: https://github.com/apache/flink/pull/21505#issuecomment-1348753944 ## CI report: * cc9abc95382fb3d9922ed9b5e0401acf03f9cd0a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047274864 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java: ## @@ -62,131 +63,154 @@ public static void prep

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047274424 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java: ## @@ -49,9 +50,9 @@ import java.util.UUID;

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047272871 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerITCase.java: ## @@ -68,7 +68,7 @@ public class F

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047272272 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java: ## @@ -219,7 +227,8 @@ public voi

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047271926 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaInternalProducerITCase.java: ## @@ -148,62 +153,78 @@ pu

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047271538 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaInternalProducerITCase.java: ## @@ -148,62 +153,78 @@ pu

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047270638 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaInternalProducerITCase.java: ## @@ -148,62 +153,78 @@ pu

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047270252 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaInternalProducerITCase.java: ## @@ -102,8 +106,9 @@ publ

[GitHub] [flink] gaborgsomogyi commented on pull request #21505: [FLINK-][security][runtime] Separate token framework generic and hadoop specific parts

2022-12-13 Thread GitBox
gaborgsomogyi commented on PR #21505: URL: https://github.com/apache/flink/pull/21505#issuecomment-1348745920 cc @mbalassi This PR is 99% rename/move, except the part where I've added a comment. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21505: [FLINK-][security][runtime] Separate token framework generic and hadoop specific parts

2022-12-13 Thread GitBox
gaborgsomogyi commented on code in PR #21505: URL: https://github.com/apache/flink/pull/21505#discussion_r1047268499 ## flink-runtime/src/test/java/org/apache/flink/runtime/security/token/hadoop/TestHadoopDelegationTokenProvider.java: ## @@ -16,15 +16,18 @@ * limitations under

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047268582 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaInternalProducerITCase.java: ## @@ -29,25 +29,28 @@ imp

[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #483: [FLINK-30381] Bump minikube kubernetes version for operator

2022-12-13 Thread GitBox
mbalassi merged PR #483: URL: https://github.com/apache/flink-kubernetes-operator/pull/483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Closed] (FLINK-30381) Bump minikube kubernetes version for operator

2022-12-13 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-30381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-30381. -- Fix Version/s: kubernetes-operator-1.4.0 Resolution: Fixed 4ec5220 in main > Bump mini

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047266160 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceLegacyITCase.java: ## @@ -37,7 +37,7 @@ public KafkaSourceL

[GitHub] [flink] snuyanzin commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1047264081 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java: ## @@ -428,13 +434,13 @@ private void createTestTo

[jira] [Closed] (FLINK-29852) The operator is repeatedly displayed on the Flink Web UI

2022-12-13 Thread JasonLee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JasonLee closed FLINK-29852. Resolution: Not A Problem > The operator is repeatedly displayed on the Flink Web UI > ---

[jira] [Commented] (FLINK-29852) The operator is repeatedly displayed on the Flink Web UI

2022-12-13 Thread JasonLee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646678#comment-17646678 ] JasonLee commented on FLINK-29852: -- hi all, I re-downloaded and deployed the Flink clus

[jira] [Closed] (FLINK-30370) Move existing delegation token framework authentication to providers

2022-12-13 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-30370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-30370. -- Fix Version/s: 1.17.0 Resolution: Fixed 4abdf2d in master > Move existing delegation t

[GitHub] [flink] mbalassi merged pull request #21499: [FLINK-30370][runtime][security] Move existing delegation token framework authentication to providers

2022-12-13 Thread GitBox
mbalassi merged PR #21499: URL: https://github.com/apache/flink/pull/21499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-benchmarks] 1996fanrui closed pull request #54: [FLINK-26762] Add the overdraft in checkpoint time benchmark

2022-12-13 Thread GitBox
1996fanrui closed pull request #54: [FLINK-26762] Add the overdraft in checkpoint time benchmark URL: https://github.com/apache/flink-benchmarks/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Closed] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-12-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29588. -- Resolution: Won't Fix > Add Flink Version and Application Version to Savepoint properties > --

[jira] [Closed] (FLINK-29939) Add metrics for Kubernetes Client Response 5xx count and rate

2022-12-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29939. -- Fix Version/s: kubernetes-operator-1.4.0 Resolution: Fixed merged to main f2f8bff7092b72d291d0c

[jira] [Updated] (FLINK-29939) Add metrics for Kubernetes Client Response 5xx count and rate

2022-12-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-29939: --- Affects Version/s: (was: kubernetes-operator-1.3.0) > Add metrics for Kubernetes Client Response

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1047227892 ## flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackendTest.java: ## @@ -539,11 +538,11

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1047227202 ## flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackendTest.java: ## @@ -529,7 +528,7 @@

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1047225701 ## flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackendTest.java: ## @@ -453,12 +452,12

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1047222757 ## flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogStateBackendMigrationTest.java: ## @@ -24,28 +24,26 @@ i

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1047221724 ## flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogStateBackendLoadingTest.java: ## @@ -229,14 +234,14 @@ pu

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1047220616 ## flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogStateBackendLoadingTest.java: ## @@ -58,75 +58,73 @@ imp

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1047219953 ## flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogStateBackendLoadingTest.java: ## @@ -58,75 +58,73 @@ imp

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1047219146 ## flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogPqStateTest.java: ## @@ -40,57 +40,55 @@ import static

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1047217629 ## flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogMapStateTest.java: ## @@ -36,80 +36,80 @@ import stati

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1047217368 ## flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogListStateTest.java: ## @@ -38,50 +38,48 @@ import stat

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1047216705 ## flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogDelegateStateTest.java: ## @@ -32,74 +32,77 @@ import or

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-13 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1047216223 ## flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogDelegateMemoryStateBackendTest.java: ## @@ -35,20 +35,20

  1   2   3   >