snuyanzin commented on code in PR #20991:
URL: https://github.com/apache/flink/pull/20991#discussion_r1047274424
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java:
##########
@@ -49,9 +50,9 @@
import java.util.UUID;
/** IT cases for Kafka. */
-public class KafkaITCase extends KafkaConsumerTestBase {
+class KafkaITCase extends KafkaConsumerTestBase {
- @BeforeClass
+ @BeforeAll
public static void prepare() throws Exception {
Review Comment:
could be package private or protected i guess
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java:
##########
@@ -62,131 +63,154 @@ public static void prepare() throws Exception {
// Suite of Tests
// ------------------------------------------------------------------------
- @Test(timeout = 120000)
- public void testFailOnNoBroker() throws Exception {
+ @Test
+ @Timeout(120L)
+ void testFailOnNoBroker() throws Exception {
runFailOnNoBrokerTest();
}
- @Test(timeout = 60000)
- public void testConcurrentProducerConsumerTopology() throws Exception {
+ @Test
+ @Timeout(60L)
Review Comment:
time unit should be specified
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java:
##########
@@ -62,131 +63,154 @@ public static void prepare() throws Exception {
// Suite of Tests
// ------------------------------------------------------------------------
- @Test(timeout = 120000)
- public void testFailOnNoBroker() throws Exception {
+ @Test
+ @Timeout(120L)
Review Comment:
time unit should be specified
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java:
##########
@@ -62,131 +63,154 @@ public static void prepare() throws Exception {
// Suite of Tests
// ------------------------------------------------------------------------
- @Test(timeout = 120000)
- public void testFailOnNoBroker() throws Exception {
+ @Test
+ @Timeout(120L)
+ void testFailOnNoBroker() throws Exception {
runFailOnNoBrokerTest();
}
- @Test(timeout = 60000)
- public void testConcurrentProducerConsumerTopology() throws Exception {
+ @Test
+ @Timeout(60L)
+ void testConcurrentProducerConsumerTopology() throws Exception {
runSimpleConcurrentProducerConsumerTopology();
}
- @Test(timeout = 60000)
- public void testKeyValueSupport() throws Exception {
+ @Test
+ @Timeout(60L)
+ void testKeyValueSupport() throws Exception {
runKeyValueTest();
}
// --- canceling / failures ---
- @Test(timeout = 60000)
- public void testCancelingEmptyTopic() throws Exception {
+ @Test
+ @Timeout(60L)
+ void testCancelingEmptyTopic() throws Exception {
runCancelingOnEmptyInputTest();
}
- @Test(timeout = 60000)
- public void testCancelingFullTopic() throws Exception {
+ @Test
+ @Timeout(60L)
+ void testCancelingFullTopic() throws Exception {
runCancelingOnFullInputTest();
}
// --- source to partition mappings and exactly once ---
- @Test(timeout = 60000)
- public void testOneToOneSources() throws Exception {
+ @Test
+ @Timeout(60L)
Review Comment:
time unit should be specified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
