[GitHub] [flink] lincoln-lil commented on pull request #20791: [FLINK-28569][table-planner] Fix SinkUpsertMaterializer that should be aware of the input upsertKey if it is not empty to prevent wrong r

2022-09-13 Thread GitBox
lincoln-lil commented on PR #20791: URL: https://github.com/apache/flink/pull/20791#issuecomment-1246329609 @godfreyhe thanks for reviewing this! I've updated the pr according to your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] fredia commented on a diff in pull request #20820: [FLINK-29102][test] Fix unstable ChangelogLocalRecoveryITCase

2022-09-13 Thread GitBox
fredia commented on code in PR #20820: URL: https://github.com/apache/flink/pull/20820#discussion_r970400273 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/ChangelogLocalRecoveryITCase.java: ## @@ -142,7 +142,6 @@ public void testRestartTM() throws Exception {

[GitHub] [flink] lincoln-lil commented on a diff in pull request #20791: [FLINK-28569][table-planner] Fix SinkUpsertMaterializer that should be aware of the input upsertKey if it is not empty to preve

2022-09-13 Thread GitBox
lincoln-lil commented on code in PR #20791: URL: https://github.com/apache/flink/pull/20791#discussion_r970398258 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TableSinkITCase.scala: ## @@ -157,6 +173,52 @@ class TableSinkITC

[GitHub] [flink] lincoln-lil commented on a diff in pull request #20791: [FLINK-28569][table-planner] Fix SinkUpsertMaterializer that should be aware of the input upsertKey if it is not empty to preve

2022-09-13 Thread GitBox
lincoln-lil commented on code in PR #20791: URL: https://github.com/apache/flink/pull/20791#discussion_r970397264 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/batch/AggCodeGenHelper.scala: ## @@ -93,6 +93,8 @@ object AggCodeGenHelp

[GitHub] [flink] reswqa commented on a diff in pull request #20739: [FLINK-29101] PipelinedRegionSchedulingStrategy benchmark shows performance degradation

2022-09-13 Thread GitBox
reswqa commented on code in PR #20739: URL: https://github.com/apache/flink/pull/20739#discussion_r970392133 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategy.java: ## @@ -226,44 +228,71 @@ private void maybeScheduleRegi

[GitHub] [flink] PatrickRen opened a new pull request, #20832: [FLINK-28975][connector/base] Add IdlenessManager for main and per-split output in source operator to mark idleness only if both outputs

2022-09-13 Thread GitBox
PatrickRen opened a new pull request, #20832: URL: https://github.com/apache/flink/pull/20832 Unchanged backport of #20760 on release-1.14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [flink] reswqa commented on a diff in pull request #20739: [FLINK-29101] PipelinedRegionSchedulingStrategy benchmark shows performance degradation

2022-09-13 Thread GitBox
reswqa commented on code in PR #20739: URL: https://github.com/apache/flink/pull/20739#discussion_r970392133 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategy.java: ## @@ -226,44 +228,71 @@ private void maybeScheduleRegi

[GitHub] [flink] godfreyhe commented on a diff in pull request #20791: [FLINK-28569][table-planner] Fix SinkUpsertMaterializer that should be aware of the input upsertKey if it is not empty to prevent

2022-09-13 Thread GitBox
godfreyhe commented on code in PR #20791: URL: https://github.com/apache/flink/pull/20791#discussion_r970368440 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/batch/AggCodeGenHelper.scala: ## @@ -93,6 +93,8 @@ object AggCodeGenHelper

[GitHub] [flink] flinkbot commented on pull request #20831: [FLINK-28975][connector/base] Add IdlenessManager for main and per-split output in source operator to mark idleness only if both outputs are

2022-09-13 Thread GitBox
flinkbot commented on PR #20831: URL: https://github.com/apache/flink/pull/20831#issuecomment-1246323669 ## CI report: * 3760204a3de7444be81e30ebed0c60a10a8f67ec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] PatrickRen opened a new pull request, #20831: [FLINK-28975][connector/base] Add IdlenessManager for main and per-split output in source operator to mark idleness only if both outputs

2022-09-13 Thread GitBox
PatrickRen opened a new pull request, #20831: URL: https://github.com/apache/flink/pull/20831 Unchanged backport of #20760 on release-1.15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Comment Edited] (FLINK-28975) withIdleness marks all streams from FLIP-27 sources as idle

2022-09-13 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603314#comment-17603314 ] Qingsheng Ren edited comment on FLINK-28975 at 9/14/22 6:43 AM: --

[GitHub] [flink-table-store] JingsongLi commented on pull request #290: [FLINK-29252]Support create table-store table with 'connector'='table-store'

2022-09-13 Thread GitBox
JingsongLi commented on PR #290: URL: https://github.com/apache/flink-table-store/pull/290#issuecomment-1246314622 @MOBIN-F Yes, I think so. We need to clearly define the following behaviors: - What options need to be exposed? I understand that only one path can be exposed. It is unneces

[GitHub] [flink] PatrickRen merged pull request #20819: [FLINK-28975][connector/base] Add IdlenessManager for main and per-split output in source operator to mark idleness only if both outputs are idl

2022-09-13 Thread GitBox
PatrickRen merged PR #20819: URL: https://github.com/apache/flink/pull/20819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[GitHub] [flink] masteryhx commented on a diff in pull request #20820: [FLINK-29102][test] Fix unstable ChangelogLocalRecoveryITCase

2022-09-13 Thread GitBox
masteryhx commented on code in PR #20820: URL: https://github.com/apache/flink/pull/20820#discussion_r970376387 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/ChangelogLocalRecoveryITCase.java: ## @@ -142,7 +142,6 @@ public void testRestartTM() throws Exception

[GitHub] [flink] xintongsong commented on pull request #20750: [FLINK-28928][tests] Add E2E test for hybrid shuffle mode.

2022-09-13 Thread GitBox
xintongsong commented on PR #20750: URL: https://github.com/apache/flink/pull/20750#issuecomment-1246310270 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [flink-table-store] MOBIN-F commented on pull request #290: [FLINK-29252]Support create table-store table with 'connector'='table-store'

2022-09-13 Thread GitBox
MOBIN-F commented on PR #290: URL: https://github.com/apache/flink-table-store/pull/290#issuecomment-1246307191 @JingsongLi @liyubin117 @SteNicholas I think it's more straightforward to create tables using a connector approach, like Hudi/Iceberg, and now Delta is also supported:https://gi

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-13 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r970366517 ## docs/content/docs/dev/table/hiveCompatibility/hiveDialect/overview.md: ## @@ -0,0 +1,97 @@ +--- +title: "Overview" +weight: 1 +type: docs +aliases: +- /dev/table/hiv

[jira] [Closed] (FLINK-29295) Clear RecordWriter slower to avoid causing frequent compaction conflicts

2022-09-13 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-29295. Resolution: Fixed master: 6a1b1bca4da131e47ee17cbf5d10472762a66da6 release-0.2: 75a732b40c868bab02

[GitHub] [flink-table-store] JingsongLi merged pull request #294: [FLINK-29295] Clear RecordWriter slower to avoid causing frequent compaction conflicts

2022-09-13 Thread GitBox
JingsongLi merged PR #294: URL: https://github.com/apache/flink-table-store/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #262: [FLINK-28810] Introduce write.skip-compaction to skip compaction on write

2022-09-13 Thread GitBox
JingsongLi commented on code in PR #262: URL: https://github.com/apache/flink-table-store/pull/262#discussion_r970361693 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java: ## @@ -147,6 +147,12 @@ public class CoreOptions implements Serializabl

[GitHub] [flink] curcur commented on a diff in pull request #20782: [FLINK-29195] Expose lastCheckpointId metric

2022-09-13 Thread GitBox
curcur commented on code in PR #20782: URL: https://github.com/apache/flink/pull/20782#discussion_r970359887 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java: ## @@ -327,6 +327,9 @@ public void reportIncompleteStats( static fina

[jira] [Comment Edited] (FLINK-28487) Introduce configurable RateLimitingStrategy for Async Sink

2022-09-13 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603895#comment-17603895 ] Hong Liang Teoh edited comment on FLINK-28487 at 9/14/22 6:02 AM:

[jira] [Commented] (FLINK-28487) Introduce configurable RateLimitingStrategy for Async Sink

2022-09-13 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603895#comment-17603895 ] Hong Liang Teoh commented on FLINK-28487: - Sure, where do I write the release no

[GitHub] [flink] tisonkun merged pull request #20792: [BK-1.16][FLINK-28934][Connector/pulsar] Fix split assignment for different Pulsar subscriptions

2022-09-13 Thread GitBox
tisonkun merged PR #20792: URL: https://github.com/apache/flink/pull/20792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] tisonkun commented on pull request #20792: [BK-1.16][FLINK-28934][Connector/pulsar] Fix split assignment for different Pulsar subscriptions

2022-09-13 Thread GitBox
tisonkun commented on PR #20792: URL: https://github.com/apache/flink/pull/20792#issuecomment-1246281892 @HuangXingBo OK. Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [flink] reswqa commented on a diff in pull request #20739: [FLINK-29101] PipelinedRegionSchedulingStrategy benchmark shows performance degradation

2022-09-13 Thread GitBox
reswqa commented on code in PR #20739: URL: https://github.com/apache/flink/pull/20739#discussion_r970343607 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategy.java: ## @@ -53,15 +54,16 @@ public class PipelinedRegionSche

[GitHub] [flink] zhuzhurk commented on a diff in pull request #20739: [FLINK-29101] PipelinedRegionSchedulingStrategy benchmark shows performance degradation

2022-09-13 Thread GitBox
zhuzhurk commented on code in PR #20739: URL: https://github.com/apache/flink/pull/20739#discussion_r970342505 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategy.java: ## @@ -226,44 +228,71 @@ private void maybeScheduleRe

[GitHub] [flink] zhuzhurk commented on a diff in pull request #20739: [FLINK-29101] PipelinedRegionSchedulingStrategy benchmark shows performance degradation

2022-09-13 Thread GitBox
zhuzhurk commented on code in PR #20739: URL: https://github.com/apache/flink/pull/20739#discussion_r970334069 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategy.java: ## @@ -53,15 +54,16 @@ public class PipelinedRegionSc

[jira] [Updated] (FLINK-29297) Group Table Store file writers into SingleFileWriter and RollingFileWriter

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29297: --- Labels: pull-request-available (was: ) > Group Table Store file writers into SingleFileWrit

[GitHub] [flink-table-store] tsreaper opened a new pull request, #295: [FLINK-29297] Group Table Store file writers into SingleFileWriter and RollingFileWriter

2022-09-13 Thread GitBox
tsreaper opened a new pull request, #295: URL: https://github.com/apache/flink-table-store/pull/295 Currently we have two types of files to write: * Data files (LSM tree files), where a level 0 data file is a single file and a level >= 1 data file is a set of rolling files. Statistics for

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #262: [FLINK-28810] Introduce write.skip-compaction to skip compaction on write

2022-09-13 Thread GitBox
JingsongLi commented on code in PR #262: URL: https://github.com/apache/flink-table-store/pull/262#discussion_r970289713 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/compact/NoopCompactManager.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache

[GitHub] [flink] coder-zjh commented on a diff in pull request #20724: [FLINK-27291][docs-zh] Translate the "List of Data Types" section of "Data Types" into Chinese'

2022-09-13 Thread GitBox
coder-zjh commented on code in PR #20724: URL: https://github.com/apache/flink/pull/20724#discussion_r970276568 ## docs/content.zh/docs/dev/table/types.md: ## @@ -142,56 +142,54 @@ val t: DataType = DataTypes.ARRAY(DataTypes.INT().notNull()).bridgedTo(classOf[A API is extended

[GitHub] [flink] coder-zjh commented on a diff in pull request #20724: [FLINK-27291][docs-zh] Translate the "List of Data Types" section of "Data Types" into Chinese'

2022-09-13 Thread GitBox
coder-zjh commented on code in PR #20724: URL: https://github.com/apache/flink/pull/20724#discussion_r970276366 ## docs/content.zh/docs/dev/table/types.md: ## @@ -142,56 +142,54 @@ val t: DataType = DataTypes.ARRAY(DataTypes.INT().notNull()).bridgedTo(classOf[A API is extended

[GitHub] [flink] kylemeow commented on a diff in pull request #20724: [FLINK-27291][docs-zh] Translate the "List of Data Types" section of "Data Types" into Chinese'

2022-09-13 Thread GitBox
kylemeow commented on code in PR #20724: URL: https://github.com/apache/flink/pull/20724#discussion_r970273631 ## docs/content.zh/docs/dev/table/types.md: ## @@ -142,56 +142,54 @@ val t: DataType = DataTypes.ARRAY(DataTypes.INT().notNull()).bridgedTo(classOf[A API is extended.

[jira] [Updated] (FLINK-29283) Remove hardcoded apiVersion from operator unit test

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29283: --- Labels: pull-request-available (was: ) > Remove hardcoded apiVersion from operator unit tes

[GitHub] [flink-kubernetes-operator] Huangxuny1 opened a new pull request, #367: [FLINK-29283] Remove hardcoded apiVersion from operator unit test

2022-09-13 Thread GitBox
Huangxuny1 opened a new pull request, #367: URL: https://github.com/apache/flink-kubernetes-operator/pull/367 ## What is the purpose of the change - Remove hardcoded apiVersion from operator unit test ## Brief change log Modified `ReconciliationUtilsTest#testS

[jira] [Created] (FLINK-29299) Fix the network memory size calculation issue in fine-grained resource mode

2022-09-13 Thread Yingjie Cao (Jira)
Yingjie Cao created FLINK-29299: --- Summary: Fix the network memory size calculation issue in fine-grained resource mode Key: FLINK-29299 URL: https://issues.apache.org/jira/browse/FLINK-29299 Project: Fl

[jira] [Updated] (FLINK-29298) LocalBufferPool request buffer from NetworkBufferPool hanging

2022-09-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29298: --- Fix Version/s: 1.16.0 Priority: Critical (was: Major) > LocalBufferPool request buffer fro

[jira] [Created] (FLINK-29298) LocalBufferPool request buffer from NetworkBufferPool hanging

2022-09-13 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-29298: -- Summary: LocalBufferPool request buffer from NetworkBufferPool hanging Key: FLINK-29298 URL: https://issues.apache.org/jira/browse/FLINK-29298 Project: Flink Is

[GitHub] [flink] HuangXingBo commented on pull request #20792: [BK-1.16][FLINK-28934][Connector/pulsar] Fix split assignment for different Pulsar subscriptions

2022-09-13 Thread GitBox
HuangXingBo commented on PR #20792: URL: https://github.com/apache/flink/pull/20792#issuecomment-1246171451 @tisonkun I think it's necessary for this bug fix to be merged into 1.16, and we still have a period of time to observe the impact of this fix on the stability of the ci -- Thi

[jira] [Updated] (FLINK-29277) Flink submits tasks to yarn Federation and throws an exception 'org.apache.commons.lang3.NotImplementedException: Code is not implemented'

2022-09-13 Thread Jiankun Feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiankun Feng updated FLINK-29277: - Priority: Blocker (was: Major) > Flink submits tasks to yarn Federation and throws an exception

[jira] [Commented] (FLINK-15550) testCancelTaskExceptionAfterTaskMarkedFailed failed on azure

2022-09-13 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603854#comment-17603854 ] Xingbo Huang commented on FLINK-15550: -- https://dev.azure.com/apache-flink/apache-f

[jira] [Created] (FLINK-29297) Group Table Store file writers into SingleFileWriter and RollingFileWriter

2022-09-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-29297: --- Summary: Group Table Store file writers into SingleFileWriter and RollingFileWriter Key: FLINK-29297 URL: https://issues.apache.org/jira/browse/FLINK-29297 Project: Fli

[jira] [Commented] (FLINK-29296) OperatorCoordinatorHolder.create throws NPE

2022-09-13 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603852#comment-17603852 ] Xingbo Huang commented on FLINK-29296: -- https://dev.azure.com/apache-flink/apache-f

[jira] [Created] (FLINK-29296) OperatorCoordinatorHolder.create throws NPE

2022-09-13 Thread Xingbo Huang (Jira)
Xingbo Huang created FLINK-29296: Summary: OperatorCoordinatorHolder.create throws NPE Key: FLINK-29296 URL: https://issues.apache.org/jira/browse/FLINK-29296 Project: Flink Issue Type: Bug

[GitHub] [flink] flinkbot commented on pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-09-13 Thread GitBox
flinkbot commented on PR #20830: URL: https://github.com/apache/flink/pull/20830#issuecomment-1246158997 ## CI report: * 2999364405adb168991870423494a699e4ce6074 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-13 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r970252678 ## docs/content/docs/dev/table/hiveCompatibility/hiveDialect/Queries/transform.md: ## @@ -0,0 +1,130 @@ +--- +title: "Transform Clause" +weight: 10 +type: docs +--- + +

[GitHub] [flink-table-store] liyubin117 commented on pull request #290: [FLINK-29252]Support create table-store table with 'connector'='table-store'

2022-09-13 Thread GitBox
liyubin117 commented on PR #290: URL: https://github.com/apache/flink-table-store/pull/290#issuecomment-1246157283 Support to define `connector` may confuse users to treat flink-table-store as a ordinary connector, we now treat it as a built-in table, the ddl pattern is just like mysql. in

[GitHub] [flink-table-store] tsreaper closed pull request #293: [FLINK-29291] Change DataFileWriter into a factory to create writers

2022-09-13 Thread GitBox
tsreaper closed pull request #293: [FLINK-29291] Change DataFileWriter into a factory to create writers URL: https://github.com/apache/flink-table-store/pull/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Updated] (FLINK-29271) Change to byte array from bytebuffer to improve performance when reading parquet file

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29271: --- Labels: pull-request-available (was: ) > Change to byte array from bytebuffer to improve pe

[GitHub] [flink] jiangjiguang opened a new pull request, #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-09-13 Thread GitBox
jiangjiguang opened a new pull request, #20830: URL: https://github.com/apache/flink/pull/20830 ## What is the purpose of the change The PR uses byte array api instead of ByteBuffer api to improve performance and compatible with DirectByteBuffer which does not have byte array bac

[jira] [Updated] (FLINK-29295) Clear RecordWriter slower to avoid causing frequent compaction conflicts

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29295: --- Labels: pull-request-available (was: ) > Clear RecordWriter slower to avoid causing frequen

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #294: [FLINK-29295] Clear RecordWriter slower to avoid causing frequent compaction conflicts

2022-09-13 Thread GitBox
JingsongLi opened a new pull request, #294: URL: https://github.com/apache/flink-table-store/pull/294 In AbstractTableWrite, the Writer is cleaned up as soon as no new files are generated, which may lead to the changes generated after the compaction have not been committed, but the new data

[jira] [Updated] (FLINK-29295) Clear RecordWriter slower to avoid causing frequent compaction conflicts

2022-09-13 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-29295: - Description: In AbstractTableWrite, the Writer is cleaned up as soon as no new files are genera

[GitHub] [flink] PatrickRen commented on pull request #20819: [FLINK-28975][connector/base] Add IdlenessManager for main and per-split output in source operator to mark idleness only if both outputs a

2022-09-13 Thread GitBox
PatrickRen commented on PR #20819: URL: https://github.com/apache/flink/pull/20819#issuecomment-1246147263 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Updated] (FLINK-29113) Join hint with invalid table name mixed with valid names will not raise an error

2022-09-13 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-29113: --- Component/s: Table SQL / Planner > Join hint with invalid table name mixed with valid names will not

[jira] [Created] (FLINK-29295) Clear RecordWriter slower to avoid causing frequent compaction conflicts

2022-09-13 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-29295: Summary: Clear RecordWriter slower to avoid causing frequent compaction conflicts Key: FLINK-29295 URL: https://issues.apache.org/jira/browse/FLINK-29295 Project: Fli

[jira] [Assigned] (FLINK-29113) Join hint with invalid table name mixed with valid names will not raise an error

2022-09-13 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he reassigned FLINK-29113: -- Assignee: xuyang > Join hint with invalid table name mixed with valid names will not raise an

[jira] [Updated] (FLINK-29113) Join hint with invalid table name mixed with valid names will not raise an error

2022-09-13 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-29113: --- Affects Version/s: 1.16.0 > Join hint with invalid table name mixed with valid names will not raise

[jira] [Closed] (FLINK-29113) Join hint with invalid table name mixed with valid names will not raise an error

2022-09-13 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-29113. -- Resolution: Fixed Fixed in master: d518086f475ec92a18592ec3c423bf6398e776cf in 1.16.0: 0e02c0820379797

[jira] [Updated] (FLINK-29113) Join hint with invalid table name mixed with valid names will not raise an error

2022-09-13 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-29113: --- Fix Version/s: 1.16.0 1.17.0 > Join hint with invalid table name mixed with valid

[GitHub] [flink] godfreyhe closed pull request #20705: [FLINK-29113][table-planner] throw exception when finding at least one invalid table name in join hints

2022-09-13 Thread GitBox
godfreyhe closed pull request #20705: [FLINK-29113][table-planner] throw exception when finding at least one invalid table name in join hints URL: https://github.com/apache/flink/pull/20705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-13 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r970240927 ## docs/content/docs/dev/table/hiveCompatibility/hiveDialect/overview.md: ## @@ -0,0 +1,97 @@ +--- +title: "Overview" +weight: 1 +type: docs +aliases: +- /dev/table/hiv

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-13 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r970240927 ## docs/content/docs/dev/table/hiveCompatibility/hiveDialect/overview.md: ## @@ -0,0 +1,97 @@ +--- +title: "Overview" +weight: 1 +type: docs +aliases: +- /dev/table/hiv

[jira] [Updated] (FLINK-29291) Change DataFileWriter into a factory to create writers

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29291: --- Labels: pull-request-available (was: ) > Change DataFileWriter into a factory to create wri

[GitHub] [flink-table-store] tsreaper opened a new pull request, #293: [FLINK-29291] Change DataFileWriter into a factory to create writers

2022-09-13 Thread GitBox
tsreaper opened a new pull request, #293: URL: https://github.com/apache/flink-table-store/pull/293 Currently `DataFileWriter` exposes write method for data files and extra files. However, as the number of patterns to write files is increasing (for example, we'd like to write some re

[jira] [Updated] (FLINK-29294) Introduce a CompactTask for full compaction

2022-09-13 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-29294: Affects Version/s: (was: table-store-0.3.0) > Introduce a CompactTask for full compaction > --

[jira] [Updated] (FLINK-29294) Introduce a CompactTask for full compaction

2022-09-13 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-29294: Affects Version/s: table-store-0.3.0 > Introduce a CompactTask for full compaction > -

[jira] [Created] (FLINK-29294) Introduce a CompactTask for full compaction

2022-09-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-29294: --- Summary: Introduce a CompactTask for full compaction Key: FLINK-29294 URL: https://issues.apache.org/jira/browse/FLINK-29294 Project: Flink Issue Type: Sub-tas

[jira] [Updated] (FLINK-29294) Introduce a CompactTask for full compaction

2022-09-13 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-29294: Component/s: Table Store > Introduce a CompactTask for full compaction > -

[jira] [Updated] (FLINK-29294) Introduce a CompactTask for full compaction

2022-09-13 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-29294: Fix Version/s: table-store-0.3.0 > Introduce a CompactTask for full compaction > -

[jira] [Created] (FLINK-29293) Introduce a MergeFunction for full compaction

2022-09-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-29293: --- Summary: Introduce a MergeFunction for full compaction Key: FLINK-29293 URL: https://issues.apache.org/jira/browse/FLINK-29293 Project: Flink Issue Type: Sub-t

[jira] [Created] (FLINK-29292) Change MergeFunction to produce not only KeyValues

2022-09-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-29292: --- Summary: Change MergeFunction to produce not only KeyValues Key: FLINK-29292 URL: https://issues.apache.org/jira/browse/FLINK-29292 Project: Flink Issue Type:

[GitHub] [flink] xintongsong commented on pull request #20750: [FLINK-28928][tests] Add E2E test for hybrid shuffle mode.

2022-09-13 Thread GitBox
xintongsong commented on PR #20750: URL: https://github.com/apache/flink/pull/20750#issuecomment-1246123493 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Created] (FLINK-29291) Change DataFileWriter into a factory to create writers

2022-09-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-29291: --- Summary: Change DataFileWriter into a factory to create writers Key: FLINK-29291 URL: https://issues.apache.org/jira/browse/FLINK-29291 Project: Flink Issue Ty

[jira] [Created] (FLINK-29290) Produce changelog during full compaction in Table Store

2022-09-13 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-29290: --- Summary: Produce changelog during full compaction in Table Store Key: FLINK-29290 URL: https://issues.apache.org/jira/browse/FLINK-29290 Project: Flink Issue T

[jira] [Commented] (FLINK-28902) FileSystemJobResultStoreTestInternal is a unit test that's not following the unit test naming convents

2022-09-13 Thread Tony Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603822#comment-17603822 ] Tony Zhu commented on FLINK-28902: -- Can I try this ticket? > FileSystemJobResultStoreT

[jira] [Commented] (FLINK-29288) Can't start a job with a jar in the system classpath

2022-09-13 Thread Yaroslav Tkachenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603817#comment-17603817 ] Yaroslav Tkachenko commented on FLINK-29288: Apparently removing *pipeline.j

[jira] [Created] (FLINK-29289) SequencefileInputFormat based on the new Source API

2022-09-13 Thread Jing Ge (Jira)
Jing Ge created FLINK-29289: --- Summary: SequencefileInputFormat based on the new Source API Key: FLINK-29289 URL: https://issues.apache.org/jira/browse/FLINK-29289 Project: Flink Issue Type: New Fea

[jira] [Created] (FLINK-29288) Can't start a job with a jar in the system classpath

2022-09-13 Thread Yaroslav Tkachenko (Jira)
Yaroslav Tkachenko created FLINK-29288: -- Summary: Can't start a job with a jar in the system classpath Key: FLINK-29288 URL: https://issues.apache.org/jira/browse/FLINK-29288 Project: Flink

[GitHub] [flink-connector-dynamodb] YuriGusev commented on pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-09-13 Thread GitBox
YuriGusev commented on PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#issuecomment-1245960254 Thanks for the review @dannycranmer, I'm currently away from home, bit I hope to start working on the fixes next week -- This is an automated message from the Apache Git S

[jira] [Assigned] (FLINK-29165) Operator quickstart examples using code

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-29165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi reassigned FLINK-29165: -- Assignee: Gaurav Miglani > Operator quickstart examples using code >

[jira] [Commented] (FLINK-29199) Support blue-green deployment type

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-29199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603738#comment-17603738 ] Márton Balassi commented on FLINK-29199: This would be great, [~olegv]. The chal

[jira] [Updated] (FLINK-29199) Support blue-green deployment type

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-29199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi updated FLINK-29199: --- Issue Type: New Feature (was: Improvement) > Support blue-green deployment type > -

[jira] [Assigned] (FLINK-29206) Default Flink configuration contains irrelevant settings

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-29206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi reassigned FLINK-29206: -- Assignee: Márton Balassi > Default Flink configuration contains irrelevant settings >

[jira] [Commented] (FLINK-29206) Default Flink configuration contains irrelevant settings

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-29206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603737#comment-17603737 ] Márton Balassi commented on FLINK-29206: Hi [~tashoyan], Thanks for bringing th

[jira] [Updated] (FLINK-29233) Flink Kubernetes Operator example/kustomize not running

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-29233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi updated FLINK-29233: --- Priority: Minor (was: Major) > Flink Kubernetes Operator example/kustomize not running > --

[jira] [Commented] (FLINK-29233) Flink Kubernetes Operator example/kustomize not running

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-29233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603729#comment-17603729 ] Márton Balassi commented on FLINK-29233: [~Research] could you try with adding t

[jira] [Assigned] (FLINK-29251) Send CREATED status and Cancel event via FlinkResourceListener

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-29251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi reassigned FLINK-29251: -- Assignee: Matyas Orhidi > Send CREATED status and Cancel event via FlinkResourceListe

[GitHub] [flink] flinkbot commented on pull request #20829: [FLINK-29250][rpc] Drop RcService#getTerminationFuture

2022-09-13 Thread GitBox
flinkbot commented on PR #20829: URL: https://github.com/apache/flink/pull/20829#issuecomment-1245836347 ## CI report: * 793af0701f23de70460c5978e0af627fc0db5796 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-29255) FLIP-258 - Enforce binary compatibility in patch releases

2022-09-13 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-29255. Resolution: Fixed > FLIP-258 - Enforce binary compatibility in patch releases > --

[jira] [Closed] (FLINK-29262) Update documentation

2022-09-13 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-29262. Resolution: Fixed master: 030baed8d6e406b83018671d76b817193c258ded 1.16: a325214cd0b47b286

[GitHub] [flink] zentol merged pull request #20826: [FLINK-29262][docs] Document API compatibility guarantees

2022-09-13 Thread GitBox
zentol merged PR #20826: URL: https://github.com/apache/flink/pull/20826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Updated] (FLINK-29250) Remove RpcService#getTerminationFuture

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29250: --- Labels: pull-request-available (was: ) > Remove RpcService#getTerminationFuture > -

[GitHub] [flink] zentol opened a new pull request, #20829: [FLINK-29250][rpc] Drop RcService#getTerminationFuture

2022-09-13 Thread GitBox
zentol opened a new pull request, #20829: URL: https://github.com/apache/flink/pull/20829 Unused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[jira] [Closed] (FLINK-29249) Remove RpcService#execute/scheduleRunnable

2022-09-13 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-29249. Resolution: Fixed master: 0bbee3047ed81d39d25fd736946c527e627a2bad > Remove RpcService#ex

[GitHub] [flink] zentol merged pull request #20810: [FLINK-29249][rpc] Drop RpcService#execute/scheduleRunnable

2022-09-13 Thread GitBox
zentol merged PR #20810: URL: https://github.com/apache/flink/pull/20810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] flinkbot commented on pull request #20828: [FLINK-29285][tests] Move TestUtils#getResource

2022-09-13 Thread GitBox
flinkbot commented on PR #20828: URL: https://github.com/apache/flink/pull/20828#issuecomment-1245654439 ## CI report: * 9182de73071b3259fa9f8224ca542d564a1f243c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] alpreu commented on pull request #18153: [FLINK-25568][connectors/elasticsearch] Add Elasticsearch 7 Source

2022-09-13 Thread GitBox
alpreu commented on PR #18153: URL: https://github.com/apache/flink/pull/18153#issuecomment-1245653040 >how would you estimate the progress of the change in comparison to the scope of FLIP-127? At first glance it looks pretty advanced, except the fact that (1) lookup capability and (2) push

[jira] [Updated] (FLINK-29285) Publish TestUtils#getResource

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29285: --- Labels: pull-request-available (was: ) > Publish TestUtils#getResource > --

  1   2   3   >