[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #231: [FLINK-27647] Improve Metrics documentation to include newly added metrics

2022-05-19 Thread GitBox
morhidi commented on PR #231: URL: https://github.com/apache/flink-kubernetes-operator/pull/231#issuecomment-1132539384 cc @mbalassi @wangyang0918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (FLINK-27647) Improve Metrics documentation to include newly added metrics

2022-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27647: --- Labels: pull-request-available (was: ) > Improve Metrics documentation to include newly add

[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request, #231: [FLINK-27647] Improve Metrics documentation to include newly added metrics

2022-05-19 Thread GitBox
morhidi opened a new pull request, #231: URL: https://github.com/apache/flink-kubernetes-operator/pull/231 Added Operator specific metrics description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] KarmaGYZ commented on pull request #17873: [FLINK-25009][CLI] Output slotSharingGroup as part of JsonGraph

2022-05-19 Thread GitBox
KarmaGYZ commented on PR #17873: URL: https://github.com/apache/flink/pull/17873#issuecomment-1132533635 > > @xinbinhuang Thanks for the update. Could you explain why you need to derive the total task slots required from the JSON graph? > > Our team wants to derive the total slots req

[GitHub] [flink] Vancior commented on a diff in pull request #19743: [FLINK-27657][python] Implement remote operator state backend in PyFlink

2022-05-19 Thread GitBox
Vancior commented on code in PR #19743: URL: https://github.com/apache/flink/pull/19743#discussion_r877785593 ## flink-python/pyflink/datastream/state.py: ## @@ -281,6 +283,110 @@ def __iter__(self) -> Iterator[K]: return iter(self.keys()) +class ReadOnlyBroadcastSt

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #230: [build] Add doc build for new release branch

2022-05-19 Thread GitBox
wangyang0918 commented on code in PR #230: URL: https://github.com/apache/flink-kubernetes-operator/pull/230#discussion_r877783426 ## .github/workflows/docs.yaml: ## @@ -41,9 +42,11 @@ jobs: echo "flink_branch=${currentBranch}" echo "flink_branch=${current

[GitHub] [flink] Vancior commented on a diff in pull request #19743: [FLINK-27657][python] Implement remote operator state backend in PyFlink

2022-05-19 Thread GitBox
Vancior commented on code in PR #19743: URL: https://github.com/apache/flink/pull/19743#discussion_r83328 ## flink-python/pyflink/datastream/__init__.py: ## @@ -141,6 +141,11 @@ - :class:`state.AggregatingState`: Interface for aggregating state, based on an :clas

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #229: [hotfix] Change version of documentation in update_branch_version.sh

2022-05-19 Thread GitBox
wangyang0918 commented on code in PR #229: URL: https://github.com/apache/flink-kubernetes-operator/pull/229#discussion_r89395 ## tools/releasing/update_branch_version.sh: ## @@ -64,7 +64,11 @@ perl -pi -e "s#^ENV OPERATOR_VERSION=.*#ENV OPERATOR_VERSION=${NEW_VERSION}#" D

[jira] [Closed] (FLINK-27504) State compaction not happening with sliding window and incremental RocksDB backend

2022-05-19 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-27504. Resolution: Information Provided > State compaction not happening with sliding window and incremental Rock

[jira] [Commented] (FLINK-27504) State compaction not happening with sliding window and incremental RocksDB backend

2022-05-19 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539944#comment-17539944 ] Yun Tang commented on FLINK-27504: -- [~asardaes], one specific round of compaction is ju

[jira] [Resolved] (FLINK-25950) Delete retry mechanism from ZooKeeperUtils.deleteZNode

2022-05-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-25950. --- Resolution: Fixed master: c57b84921447bb0ade5e1ff77a05ebd8bbbe71b7 > Delete retry mechanism

[GitHub] [flink] XComp merged pull request #19666: [FLINK-25950][Runtime] Delete retry mechanism from ZooKeeperUtils.deleteZNode

2022-05-19 Thread GitBox
XComp merged PR #19666: URL: https://github.com/apache/flink/pull/19666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[GitHub] [flink] Vancior commented on a diff in pull request #19743: [FLINK-27657][python] Implement remote operator state backend in PyFlink

2022-05-19 Thread GitBox
Vancior commented on code in PR #19743: URL: https://github.com/apache/flink/pull/19743#discussion_r83328 ## flink-python/pyflink/datastream/__init__.py: ## @@ -141,6 +141,11 @@ - :class:`state.AggregatingState`: Interface for aggregating state, based on an :clas

[GitHub] [flink] Vancior commented on a diff in pull request #19743: [FLINK-27657][python] Implement remote operator state backend in PyFlink

2022-05-19 Thread GitBox
Vancior commented on code in PR #19743: URL: https://github.com/apache/flink/pull/19743#discussion_r82504 ## flink-python/src/main/java/org/apache/flink/streaming/api/runners/python/beam/state/BeamStateHandler.java: ## @@ -23,6 +23,35 @@ /** Interface for doing actual opera

[GitHub] [flink] Vancior commented on a diff in pull request #19743: [FLINK-27657][python] Implement remote operator state backend in PyFlink

2022-05-19 Thread GitBox
Vancior commented on code in PR #19743: URL: https://github.com/apache/flink/pull/19743#discussion_r82151 ## flink-python/pyflink/datastream/functions.py: ## @@ -119,6 +118,22 @@ def get_aggregating_state( pass +class OperatorStateStore(ABC): Review Comment:

[GitHub] [flink] Vancior commented on a diff in pull request #19743: [FLINK-27657][python] Implement remote operator state backend in PyFlink

2022-05-19 Thread GitBox
Vancior commented on code in PR #19743: URL: https://github.com/apache/flink/pull/19743#discussion_r80129 ## flink-python/pyflink/datastream/state.py: ## @@ -281,6 +283,110 @@ def __iter__(self) -> Iterator[K]: return iter(self.keys()) +class ReadOnlyBroadcastSt

[jira] [Commented] (FLINK-27060) Extending /jars/:jarid/run API to support setting Flink configs

2022-05-19 Thread ConradJam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539937#comment-17539937 ] ConradJam commented on FLINK-27060: --- Hi [~martijnvisser] , I would like to move this w

[jira] [Closed] (FLINK-26895) Improve cancelWithSavepoint timeout error message

2022-05-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-26895. -- Resolution: Won't Fix Not relevant with 1.15 anymore > Improve cancelWithSavepoint timeout error mess

[jira] [Closed] (FLINK-27686) Only patch status when the status actually changed

2022-05-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-27686. -- Resolution: Fixed merged to main 0e537308975f29a6dc129d047f3db337122cc3ca release-1.0 8f4cc547b8988048

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #228: [FLINK-27686] Only patch status on change

2022-05-19 Thread GitBox
gyfora merged PR #228: URL: https://github.com/apache/flink-kubernetes-operator/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #230: [build] Add doc build for new release branch

2022-05-19 Thread GitBox
gyfora commented on PR #230: URL: https://github.com/apache/flink-kubernetes-operator/pull/230#issuecomment-1132511577 cc @mbalassi @wangyang0918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] deadwind4 commented on pull request #19774: [FLINK-27711][python][connector/pulsar] Align setTopicPattern for Pulsar Connector

2022-05-19 Thread GitBox
deadwind4 commented on PR #19774: URL: https://github.com/apache/flink/pull/19774#issuecomment-1132506576 I will update the doc in this ticket https://issues.apache.org/jira/browse/FLINK-27690 -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [flink] flinkbot commented on pull request #19774: [FLINK-27711][python][connector/pulsar] Align setTopicPattern for Pulsar Connector

2022-05-19 Thread GitBox
flinkbot commented on PR #19774: URL: https://github.com/apache/flink/pull/19774#issuecomment-1132505009 ## CI report: * 9071427ed48c3e005d42d64318945fa6a44f6eb0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #229: [hotfix] Change version of documentation in update_branch_version.sh

2022-05-19 Thread GitBox
gyfora merged PR #229: URL: https://github.com/apache/flink-kubernetes-operator/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Updated] (FLINK-27711) Align setTopicPattern for Pulsar Connector

2022-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27711: --- Labels: pull-request-available (was: ) > Align setTopicPattern for Pulsar Connector > -

[jira] [Updated] (FLINK-27712) Job failed to start due to "Time should be non negative"

2022-05-19 Thread Sharon Xie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharon Xie updated FLINK-27712: --- Description: Happened intermittently. A restart made the issue go away. Stack trace: {code:java} Ti

[GitHub] [flink] deadwind4 opened a new pull request, #19774: [FLINK-27711][python][connector/pulsar] Align setTopicPattern for Pulsar Connector

2022-05-19 Thread GitBox
deadwind4 opened a new pull request, #19774: URL: https://github.com/apache/flink/pull/19774 ## What is the purpose of the change set_topics_pattern is a typo, so I update set_topics_pattern to set_topic_pattern in pulsar.py ## Brief change log - *Add set_topic_pattern

[jira] [Created] (FLINK-27712) Job failed to start due to "Time should be non negative"

2022-05-19 Thread Sharon Xie (Jira)
Sharon Xie created FLINK-27712: -- Summary: Job failed to start due to "Time should be non negative" Key: FLINK-27712 URL: https://issues.apache.org/jira/browse/FLINK-27712 Project: Flink Issue Ty

[GitHub] [flink] alpreu commented on pull request #19655: [FLINK-27527] Create a file-based upsert sink for testing internal components

2022-05-19 Thread GitBox
alpreu commented on PR #19655: URL: https://github.com/apache/flink/pull/19655#issuecomment-1132500442 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Created] (FLINK-27711) Align setTopicPattern for Pulsar Connector

2022-05-19 Thread LuNng Wang (Jira)
LuNng Wang created FLINK-27711: -- Summary: Align setTopicPattern for Pulsar Connector Key: FLINK-27711 URL: https://issues.apache.org/jira/browse/FLINK-27711 Project: Flink Issue Type: Improvemen

[jira] [Commented] (FLINK-27646) Create Roadmap page for Flink Kubernetes operator

2022-05-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539930#comment-17539930 ] Gyula Fora commented on FLINK-27646: I think we have two alternatives here: 1. Incl

[GitHub] [flink] Sxnan commented on a diff in pull request #19653: [FLINK-27523] Runtime supports producing and consuming cached intermediate results

2022-05-19 Thread GitBox
Sxnan commented on code in PR #19653: URL: https://github.com/apache/flink/pull/19653#discussion_r877747182 ## flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java: ## @@ -84,6 +86,33 @@ CompletableFuture registerPartitionWithProducer( Par

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #229: [hotfix] Change version of documentation in update_branch_version.sh

2022-05-19 Thread GitBox
gyfora commented on code in PR #229: URL: https://github.com/apache/flink-kubernetes-operator/pull/229#discussion_r877749413 ## tools/releasing/update_branch_version.sh: ## @@ -64,7 +64,11 @@ perl -pi -e "s#^ENV OPERATOR_VERSION=.*#ENV OPERATOR_VERSION=${NEW_VERSION}#" Do # c

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #229: [hotfix] Change version of documentation in update_branch_version.sh

2022-05-19 Thread GitBox
gyfora commented on code in PR #229: URL: https://github.com/apache/flink-kubernetes-operator/pull/229#discussion_r877748770 ## tools/releasing/update_branch_version.sh: ## @@ -64,7 +64,11 @@ perl -pi -e "s#^ENV OPERATOR_VERSION=.*#ENV OPERATOR_VERSION=${NEW_VERSION}#" Do # c

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #228: [FLINK-27686] Only patch status on change

2022-05-19 Thread GitBox
gyfora commented on code in PR #228: URL: https://github.com/apache/flink-kubernetes-operator/pull/228#discussion_r877733469 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/StatusHelper.java: ## @@ -64,6 +67,14 @@ public > void patchAndCac

[jira] [Comment Edited] (FLINK-17295) Refactor the ExecutionAttemptID to consist of ExecutionVertexID and attemptNumber

2022-05-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539914#comment-17539914 ] Zhu Zhu edited comment on FLINK-17295 at 5/20/22 4:31 AM: -- I wa

[GitHub] [flink] flinkbot commented on pull request #19773: [FLINK-24735][sql-client] LocalExecutor should catch Throwable rathe…

2022-05-19 Thread GitBox
flinkbot commented on PR #19773: URL: https://github.com/apache/flink/pull/19773#issuecomment-1132447231 ## CI report: * 32a8b3baba8200dd3b3f5b91cf9c35288e7383fd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zhuzhurk commented on a diff in pull request #19747: [FLINK-17295][runtime] Refactor the ExecutionAttemptID to consist of ExecutionGraphID, ExecutionVertexID and attemptNumber

2022-05-19 Thread GitBox
zhuzhurk commented on code in PR #19747: URL: https://github.com/apache/flink/pull/19747#discussion_r877719574 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -364,6 +373,8 @@ public DefaultExecutionGraph( this.re

[jira] [Updated] (FLINK-24735) SQL client crashes with `Cannot add expression of different type to set`

2022-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24735: --- Labels: pull-request-available (was: ) > SQL client crashes with `Cannot add expression of

[GitHub] [flink] fsk119 opened a new pull request, #19773: [FLINK-24735][sql-client] LocalExecutor should catch Throwable rathe…

2022-05-19 Thread GitBox
fsk119 opened a new pull request, #19773: URL: https://github.com/apache/flink/pull/19773 …r than Exception ## What is the purpose of the change *Catch throwable in the SQL Client to escape the crash.* ## Verifying this change Please make sure both new and

[GitHub] [flink] zhuzhurk commented on a diff in pull request #19747: [FLINK-17295][runtime] Refactor the ExecutionAttemptID to consist of ExecutionGraphID, ExecutionVertexID and attemptNumber

2022-05-19 Thread GitBox
zhuzhurk commented on code in PR #19747: URL: https://github.com/apache/flink/pull/19747#discussion_r877718674 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -364,6 +373,8 @@ public DefaultExecutionGraph( this.re

[GitHub] [flink] zhuzhurk commented on a diff in pull request #19747: [FLINK-17295][runtime] Refactor the ExecutionAttemptID to consist of ExecutionGraphID, ExecutionVertexID and attemptNumber

2022-05-19 Thread GitBox
zhuzhurk commented on code in PR #19747: URL: https://github.com/apache/flink/pull/19747#discussion_r877718479 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionID.java: ## @@ -44,7 +47,12 @@ public final class ResultPartitionID implemen

[GitHub] [flink] zhuzhurk commented on a diff in pull request #19747: [FLINK-17295][runtime] Refactor the ExecutionAttemptID to consist of ExecutionGraphID, ExecutionVertexID and attemptNumber

2022-05-19 Thread GitBox
zhuzhurk commented on code in PR #19747: URL: https://github.com/apache/flink/pull/19747#discussion_r877716691 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java: ## @@ -68,19 +117,32 @@ public boolean equals(Object obj) {

[jira] [Assigned] (FLINK-27710) Improve logs to better display Execution

2022-05-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-27710: --- Assignee: Zhu Zhu > Improve logs to better display Execution >

[jira] [Created] (FLINK-27710) Improve logs to better display Execution

2022-05-19 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-27710: --- Summary: Improve logs to better display Execution Key: FLINK-27710 URL: https://issues.apache.org/jira/browse/FLINK-27710 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-17295) Refactor the ExecutionAttemptID to consist of ExecutionVertexID and attemptNumber

2022-05-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539914#comment-17539914 ] Zhu Zhu commented on FLINK-17295: - I was not concerning about it because PartitionReques

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-19 Thread GitBox
tsreaper commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r877715408 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreImpl.java: ## @@ -201,17 +204,28 @@ public static FileStoreImpl createWithPri

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-19 Thread GitBox
tsreaper commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r877715115 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/AggregateFunction.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #229: [hotfix] Change version of documentation in update_branch_version.sh

2022-05-19 Thread GitBox
wangyang0918 commented on PR #229: URL: https://github.com/apache/flink-kubernetes-operator/pull/229#issuecomment-1132438195 cc @gyfora -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [flink-kubernetes-operator] wangyang0918 opened a new pull request, #229: [hotfix] Change version of documentation in update_branch_version.sh

2022-05-19 Thread GitBox
wangyang0918 opened a new pull request, #229: URL: https://github.com/apache/flink-kubernetes-operator/pull/229 We also need to change version of documentation in `update_branch_version.sh`. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] luoyuxia commented on a diff in pull request #19182: [FLINK-26771][Hive] Hive dialect supports to compare boolean type with numeric/string type

2022-05-19 Thread GitBox
luoyuxia commented on code in PR #19182: URL: https://github.com/apache/flink/pull/19182#discussion_r877711250 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserSqlFunctionConverter.java: ## @@ -415,24 +425,73 @@

[jira] [Updated] (FLINK-27709) Add comment to schema

2022-05-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-27709: - Description: We can add comment to schema for table. See `CatalogBaseTable.getComment`. (was: W

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #130: [FLINK-27709] Add comment to schema

2022-05-19 Thread GitBox
JingsongLi opened a new pull request, #130: URL: https://github.com/apache/flink-table-store/pull/130 We can add comment to schema for table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Updated] (FLINK-27709) Add comment to schema

2022-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27709: --- Labels: pull-request-available (was: ) > Add comment to schema > - > >

[jira] [Created] (FLINK-27709) Add comment to schema

2022-05-19 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-27709: Summary: Add comment to schema Key: FLINK-27709 URL: https://issues.apache.org/jira/browse/FLINK-27709 Project: Flink Issue Type: Sub-task Componen

[GitHub] [flink-table-store] openinx commented on pull request #99: [FLINK-27307] Flink table store support append-only ingestion without primary keys.

2022-05-19 Thread GitBox
openinx commented on PR #99: URL: https://github.com/apache/flink-table-store/pull/99#issuecomment-1132426379 Closing this PR now because we've merge most of the changes. Thanks all for the reviewing & checking. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [flink-table-store] openinx closed pull request #99: [FLINK-27307] Flink table store support append-only ingestion without primary keys.

2022-05-19 Thread GitBox
openinx closed pull request #99: [FLINK-27307] Flink table store support append-only ingestion without primary keys. URL: https://github.com/apache/flink-table-store/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [flink] deadwind4 closed pull request #18454: [hotfix][connector/pulsar] Fix typo in JavaDocs example.

2022-05-19 Thread GitBox
deadwind4 closed pull request #18454: [hotfix][connector/pulsar] Fix typo in JavaDocs example. URL: https://github.com/apache/flink/pull/18454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [flink] luoyuxia commented on a diff in pull request #19562: [FLINK-27304][hive] Calcite's varbinary type should be converted to Hive's binary type.

2022-05-19 Thread GitBox
luoyuxia commented on code in PR #19562: URL: https://github.com/apache/flink/pull/19562#discussion_r877701927 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserTypeConverter.java: ## @@ -289,6 +289,7 @@ private

[jira] [Updated] (FLINK-27708) Add background compaction task for append-only table when ingesting.

2022-05-19 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated FLINK-27708: - Fix Version/s: table-store-0.2.0 > Add background compaction task for append-only table when ingesting.

[jira] [Created] (FLINK-27708) Add background compaction task for append-only table when ingesting.

2022-05-19 Thread Zheng Hu (Jira)
Zheng Hu created FLINK-27708: Summary: Add background compaction task for append-only table when ingesting. Key: FLINK-27708 URL: https://issues.apache.org/jira/browse/FLINK-27708 Project: Flink

[GitHub] [flink-table-store] ajian2002 commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-19 Thread GitBox
ajian2002 commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r877701752 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/AggregateFunction.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to th

[GitHub] [flink-table-store] ajian2002 commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-19 Thread GitBox
ajian2002 commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r877701051 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreImpl.java: ## @@ -201,17 +204,28 @@ public static FileStoreImpl createWithPr

[GitHub] [flink] lsyldliu commented on pull request #19410: [FLINK-15635][table] Now EnvironmentSettings accepts the user ClassLoader

2022-05-19 Thread GitBox
lsyldliu commented on PR #19410: URL: https://github.com/apache/flink/pull/19410#issuecomment-1132420587 > ping @matriv Can you help to complete this work as soon as possible? [FLIP-214](https://cwiki.apache.org/confluence/display/FLINK/FLIP-214+Support+Advanced+Function+DDL) is blo

[jira] [Closed] (FLINK-27638) failed to join with table function

2022-05-19 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-27638. - Resolution: Not A Problem > failed to join with table function > ---

[jira] [Commented] (FLINK-27638) failed to join with table function

2022-05-19 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539901#comment-17539901 ] Shengkai Fang commented on FLINK-27638: --- The source in the graph is Values source

[jira] [Updated] (FLINK-27706) Refactor all subclasses of FileStoreTableITCase to use the batchSql.

2022-05-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27706: --- Labels: pull-request-available (was: ) > Refactor all subclasses of FileStoreTableITCase to

[GitHub] [flink-table-store] openinx opened a new pull request, #129: [FLINK-27706] Refactor all subclasses of FileStoreTableITCase to use the batchSql

2022-05-19 Thread GitBox
openinx opened a new pull request, #129: URL: https://github.com/apache/flink-table-store/pull/129 A minor factor for the unit tests to reuse the `batchSql`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Updated] (FLINK-27707) Implement TableStoreFactory#onCompactTable

2022-05-19 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-27707: -- Description: Perform the latest scan and pick data files to compact. (was: Perform scan and pick data

[jira] [Created] (FLINK-27707) Implement TableStoreFactory#onCompactTable

2022-05-19 Thread Jane Chan (Jira)
Jane Chan created FLINK-27707: - Summary: Implement TableStoreFactory#onCompactTable Key: FLINK-27707 URL: https://issues.apache.org/jira/browse/FLINK-27707 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-27639) Flink JOIN uses the now() function when inserting data, resulting in data that cannot be deleted

2022-05-19 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539899#comment-17539899 ] Shengkai Fang commented on FLINK-27639: --- Hi. Could you also share the test data wi

[jira] [Comment Edited] (FLINK-27557) Let FileStoreWrite accept pre-planned manifest entries

2022-05-19 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539352#comment-17539352 ] Jane Chan edited comment on FLINK-27557 at 5/20/22 3:18 AM:

[jira] [Updated] (FLINK-27557) Let FileStoreWrite accept pre-planned manifest entries

2022-05-19 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-27557: -- Description: Currently, FileStoreWrite will scan and plan files when creating a non-empty writer. We s

[jira] [Updated] (FLINK-27706) Refactor all subclasses of FileStoreTableITCase to use the batchSql.

2022-05-19 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated FLINK-27706: - Fix Version/s: table-store-0.2.0 > Refactor all subclasses of FileStoreTableITCase to use the batchSql.

[jira] [Created] (FLINK-27706) Refactor all subclasses of FileStoreTableITCase to use the batchSql.

2022-05-19 Thread Zheng Hu (Jira)
Zheng Hu created FLINK-27706: Summary: Refactor all subclasses of FileStoreTableITCase to use the batchSql. Key: FLINK-27706 URL: https://issues.apache.org/jira/browse/FLINK-27706 Project: Flink

[jira] [Updated] (FLINK-27557) Let FileStoreWrite accept pre-planned manifest entries

2022-05-19 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-27557: -- Description: Currently, FileStoreWrite will scan and plan files when creating a non-empty writer. We s

[jira] [Updated] (FLINK-27557) Let FileStoreWrite accept pre-planned manifest entries

2022-05-19 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-27557: -- Description: Currently, FileStoreWrite will scan and plan files when creating a non-empty writer. For

[jira] [Updated] (FLINK-27557) Let FileStoreWrite accept pre-planned manifest entries

2022-05-19 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-27557: -- Description: Currently, FileStoreWrite will scan and plan files when creating a non-empty writer. For

[jira] [Updated] (FLINK-27679) Support append-only table for log store.

2022-05-19 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated FLINK-27679: - Fix Version/s: table-store-0.2.0 > Support append-only table for log store. > --

[jira] [Commented] (FLINK-27683) Insert into (column1, column2) Values(.....) can't work with sql Hints

2022-05-19 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539894#comment-17539894 ] Shengkai Fang commented on FLINK-27683: --- Yes. I think we can fix this. Are you int

[jira] [Commented] (FLINK-27654) Older jackson-databind found in /flink-kubernetes-shaded-1.0-SNAPSHOT.jar

2022-05-19 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539893#comment-17539893 ] Yang Wang commented on FLINK-27654: --- I am making this ticket as a blocker now since we

[jira] [Updated] (FLINK-27654) Older jackson-databind found in /flink-kubernetes-shaded-1.0-SNAPSHOT.jar

2022-05-19 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-27654: -- Priority: Blocker (was: Major) > Older jackson-databind found in /flink-kubernetes-shaded-1.0-SNAPSHO

[jira] [Commented] (FLINK-27654) Older jackson-databind found in /flink-kubernetes-shaded-1.0-SNAPSHOT.jar

2022-05-19 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539892#comment-17539892 ] Yang Wang commented on FLINK-27654: --- Of cause, we could also bump the kubernetes-clien

[jira] [Updated] (FLINK-27557) Let FileStoreWrite accept pre-planned manifest entries

2022-05-19 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-27557: -- Summary: Let FileStoreWrite accept pre-planned manifest entries (was: Create the empty writer for 'AL

[jira] [Commented] (FLINK-27683) Insert into (column1, column2) Values(.....) can't work with sql Hints

2022-05-19 Thread Xin Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539891#comment-17539891 ] Xin Yang commented on FLINK-27683: -- [~fsk119] It's a bug, right? > Insert into (column

[jira] [Comment Edited] (FLINK-27557) Create the empty writer for 'ALTER TABLE ... COMPACT'

2022-05-19 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539352#comment-17539352 ] Jane Chan edited comment on FLINK-27557 at 5/20/22 2:59 AM:

[jira] [Comment Edited] (FLINK-27654) Older jackson-databind found in /flink-kubernetes-shaded-1.0-SNAPSHOT.jar

2022-05-19 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539886#comment-17539886 ] Yang Wang edited comment on FLINK-27654 at 5/20/22 2:54 AM:

[GitHub] [flink] KarmaGYZ commented on a diff in pull request #17873: [FLINK-25009][CLI] Output slotSharingGroup as part of JsonGraph

2022-05-19 Thread GitBox
KarmaGYZ commented on code in PR #17873: URL: https://github.com/apache/flink/pull/17873#discussion_r877686196 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/JSONGenerator.java: ## @@ -184,6 +185,8 @@ private void decorateNode(Integer vertexID, Object

[jira] [Commented] (FLINK-27705) num-sorted-run.compaction-trigger should not interfere the num-levels

2022-05-19 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539887#comment-17539887 ] Jane Chan commented on FLINK-27705: --- The reason is that the previous write job had tri

[jira] [Commented] (FLINK-27654) Older jackson-databind found in /flink-kubernetes-shaded-1.0-SNAPSHOT.jar

2022-05-19 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539886#comment-17539886 ] Yang Wang commented on FLINK-27654: --- [~jbusche] You are right. The kubernetes-client i

[jira] [Updated] (FLINK-27654) Older jackson-databind found in /flink-kubernetes-shaded-1.0-SNAPSHOT.jar

2022-05-19 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-27654: -- Summary: Older jackson-databind found in /flink-kubernetes-shaded-1.0-SNAPSHOT.jar (was: Older jackso

[jira] [Commented] (FLINK-27705) num-sorted-run.compaction-trigger should not interfere the num-levels

2022-05-19 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539885#comment-17539885 ] Jane Chan commented on FLINK-27705: --- Stacktrace {code:java} java.util.concurrent.Execu

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-19 Thread GitBox
tsreaper commented on code in PR #121: URL: https://github.com/apache/flink-table-store/pull/121#discussion_r876537585 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreImpl.java: ## @@ -201,17 +204,28 @@ public static FileStoreImpl createWithPri

[jira] [Created] (FLINK-27705) num-sorted-run.compaction-trigger should not interfere the num-levels

2022-05-19 Thread Jane Chan (Jira)
Jane Chan created FLINK-27705: - Summary: num-sorted-run.compaction-trigger should not interfere the num-levels Key: FLINK-27705 URL: https://issues.apache.org/jira/browse/FLINK-27705 Project: Flink

[jira] [Updated] (FLINK-27654) Older jackson-databind found in flink-kubernetes-operator-1.0-SNAPSHOT-shaded.jar

2022-05-19 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-27654: -- Summary: Older jackson-databind found in flink-kubernetes-operator-1.0-SNAPSHOT-shaded.jar (was: Olde

[jira] [Closed] (FLINK-27678) Support append-only table for file store.

2022-05-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-27678. Fix Version/s: table-store-0.2.0 Assignee: Zheng Hu Resolution: Fixed master: 5928

[GitHub] [flink-table-store] JingsongLi merged pull request #126: [FLINK-27678] Support append-only table for file store.

2022-05-19 Thread GitBox
JingsongLi merged PR #126: URL: https://github.com/apache/flink-table-store/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink] HuangXingBo commented on a diff in pull request #19743: [FLINK-27657][python] Implement remote operator state backend in PyFlink

2022-05-19 Thread GitBox
HuangXingBo commented on code in PR #19743: URL: https://github.com/apache/flink/pull/19743#discussion_r876562559 ## flink-python/pyflink/datastream/functions.py: ## @@ -119,6 +118,22 @@ def get_aggregating_state( pass +class OperatorStateStore(ABC): Review Comment

[GitHub] [flink-table-store] ajian2002 commented on pull request #121: [FLINK-27626] Introduce AggregatuibMergeFunction

2022-05-19 Thread GitBox
ajian2002 commented on PR #121: URL: https://github.com/apache/flink-table-store/pull/121#issuecomment-1132373009 So the problem is solved? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (FLINK-27646) Create Roadmap page for Flink Kubernetes operator

2022-05-19 Thread ConradJam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539873#comment-17539873 ] ConradJam commented on FLINK-27646: --- OK,I would like to ask is this page built on Flin

  1   2   3   >