HuangXingBo commented on code in PR #19743:
URL: https://github.com/apache/flink/pull/19743#discussion_r876562559
##########
flink-python/pyflink/datastream/functions.py:
##########
@@ -119,6 +118,22 @@ def get_aggregating_state(
pass
+class OperatorStateStore(ABC):
Review Comment:
What about moving this class to the `state.py`?
##########
flink-python/src/main/java/org/apache/flink/streaming/api/runners/python/beam/state/BeamStateHandler.java:
##########
@@ -23,6 +23,35 @@
/** Interface for doing actual operations on Flink state based on {@link
BeamFnApi.StateRequest}. */
public interface BeamStateHandler<S> {
- BeamFnApi.StateResponse.Builder handle(BeamFnApi.StateRequest request, S
state)
+ /**
+ * Dispatches {@link BeamFnApi.StateRequest} to different handle functions
base on request case.
+ */
+ default BeamFnApi.StateResponse.Builder handle(BeamFnApi.StateRequest
request, S state)
Review Comment:
I wonder if it would be clearer if we introduce an abstract class of
`AbstractBeamStateHandler`. Personally, I don't like the form of default
interface methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
