[GitHub] [flink] alpreu commented on a diff in pull request #19655: [FLINK-27527] Create a file-based upsert sink for testing internal components

2022-05-09 Thread GitBox
alpreu commented on code in PR #19655: URL: https://github.com/apache/flink/pull/19655#discussion_r868882875 ## flink-connectors/flink-connector-upsert-test/src/test/java/org/apache/flink/connector/upserttest/sink/UpsertTestSinkWriterITCase.java: ## @@ -0,0 +1,124 @@ +/* + * Lic

[GitHub] [flink] fapaul commented on pull request #19661: [FLINK-27487][kafka] Only forward measurable Kafka metrics and ignore others

2022-05-09 Thread GitBox
fapaul commented on PR #19661: URL: https://github.com/apache/flink/pull/19661#issuecomment-1122003731 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #199: [FLINK-27551] Update status manually instead of relying on updatecontrol

2022-05-09 Thread GitBox
gyfora opened a new pull request, #199: URL: https://github.com/apache/flink-kubernetes-operator/pull/199 This PR reworks how status updates of Flink resources are updated in kubernetes. This is necessary due to https://github.com/java-operator-sdk/java-operator-sdk/issues/1198 Based

[jira] [Updated] (FLINK-27543) Hide column statistics inside the file format writer.

2022-05-09 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated FLINK-27543: - Summary: Hide column statistics inside the file format writer. (was: Introduce StatsProducer to refacto

[jira] [Updated] (FLINK-27543) Hide column statistics collector inside the file format writer.

2022-05-09 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated FLINK-27543: - Summary: Hide column statistics collector inside the file format writer. (was: Hide column statistics i

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #83: [FLINK-27170] Add Transformer and Estimator for OnlineLogisticRegression

2022-05-09 Thread GitBox
zhipeng93 commented on code in PR #83: URL: https://github.com/apache/flink-ml/pull/83#discussion_r868872809 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasL2.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #83: [FLINK-27170] Add Transformer and Estimator for OnlineLogisticRegression

2022-05-09 Thread GitBox
zhipeng93 commented on code in PR #83: URL: https://github.com/apache/flink-ml/pull/83#discussion_r868872809 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasL2.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

[GitHub] [flink] alpreu commented on a diff in pull request #19655: [FLINK-27527] Create a file-based upsert sink for testing internal components

2022-05-09 Thread GitBox
alpreu commented on code in PR #19655: URL: https://github.com/apache/flink/pull/19655#discussion_r868873968 ## flink-connectors/flink-connector-upsert-test/src/main/java/org/apache/flink/connector/upserttest/sink/BinaryFileUtil.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the

[GitHub] [flink] alpreu commented on a diff in pull request #19655: [FLINK-27527] Create a file-based upsert sink for testing internal components

2022-05-09 Thread GitBox
alpreu commented on code in PR #19655: URL: https://github.com/apache/flink/pull/19655#discussion_r868878917 ## flink-connectors/flink-connector-upsert-test/src/main/java/org/apache/flink/connector/upserttest/sink/BinaryFileUtil.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-27557) Create the empty writer for 'ALTER TABLE ... COMPACT'

2022-05-09 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534178#comment-17534178 ] Jingsong Lee commented on FLINK-27557: -- Can we just use overwrite? * overwrite spe

[GitHub] [flink] alpreu commented on a diff in pull request #19655: [FLINK-27527] Create a file-based upsert sink for testing internal components

2022-05-09 Thread GitBox
alpreu commented on code in PR #19655: URL: https://github.com/apache/flink/pull/19655#discussion_r868869814 ## flink-connectors/flink-connector-upsert-test/pom.xml: ## @@ -0,0 +1,151 @@ + + +http://maven.apache.org/POM/4.0.0"; +xmlns:xsi="http://www.w3.org/2001/

[GitHub] [flink] snuyanzin commented on a diff in pull request #19667: [FLINK-27501][tests] Migrate SerializerTestBase to JUnit5

2022-05-09 Thread GitBox
snuyanzin commented on code in PR #19667: URL: https://github.com/apache/flink/pull/19667#discussion_r868869212 ## flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerTest.java: ## @@ -48,10 +47,7 @@ import java.util.Objects; import java.util.Ran

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #116: [FLINK-27558] Introduce a new optional option for TableStoreFactory to represent planned manifest entries

2022-05-09 Thread GitBox
JingsongLi commented on code in PR #116: URL: https://github.com/apache/flink-table-store/pull/116#discussion_r868862749 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStoreFactoryOptions.java: ## @@ -39,6 +39,14 @@ public class TableSto

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #116: [FLINK-27558] Introduce a new optional option for TableStoreFactory to represent planned manifest entries

2022-05-09 Thread GitBox
JingsongLi commented on code in PR #116: URL: https://github.com/apache/flink-table-store/pull/116#discussion_r868862596 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStoreFactoryOptions.java: ## @@ -39,6 +39,14 @@ public class TableSto

[GitHub] [flink] snuyanzin commented on a diff in pull request #19667: [FLINK-27501][tests] Migrate SerializerTestBase to JUnit5

2022-05-09 Thread GitBox
snuyanzin commented on code in PR #19667: URL: https://github.com/apache/flink/pull/19667#discussion_r868862351 ## flink-core/src/test/java/org/apache/flink/api/common/typeutils/base/array/StringArraySerializerTest.java: ## @@ -91,6 +91,6 @@ protected String[][] getTestData() {

[GitHub] [flink-ml] zhipeng93 commented on pull request #96: [hotfix] Bucketizer split point search

2022-05-09 Thread GitBox
zhipeng93 commented on PR #96: URL: https://github.com/apache/flink-ml/pull/96#issuecomment-1121980771 Thanks for the fix @mumuhhh ! LGTM. Two minor comments: - Could you add a unit test that the number of inputCols is not the same as number splits? - Could you re-polish the com

[jira] [Assigned] (FLINK-27558) Introduce a new optional option for TableStoreFactory to represent planned manifest entries

2022-05-09 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-27558: Assignee: Jane Chan > Introduce a new optional option for TableStoreFactory to represent

[GitHub] [flink] wangyang0918 commented on pull request #19675: [FLINK-27550] Remove checking yarn queues before submitting job to Yarn

2022-05-09 Thread GitBox
wangyang0918 commented on PR #19675: URL: https://github.com/apache/flink/pull/19675#issuecomment-1121972802 Maybe we could check the scheduler type first. If it is capacity scheduler, `checkYarnQueues` only takes the leaf queue name. -- This is an automated message from the Apache Git Se

[jira] [Commented] (FLINK-27498) Add E2E tests to cover Flink 1.15

2022-05-09 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534160#comment-17534160 ] Yang Wang commented on FLINK-27498: --- We could close this ticket since it is already co

[jira] [Closed] (FLINK-27412) Allow flinkVersion v1_13 in flink-kubernetes-operator

2022-05-09 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang closed FLINK-27412. - Resolution: Fixed Fixed via: main: 6ce3d96937849c70e00ef5f3837bc08ed31d9952 ab1893c61adddb58011618650

[GitHub] [flink-kubernetes-operator] wangyang0918 merged pull request #197: [FLINK-27412] Allow flinkVersion v1_13 in flink-kubernetes-operator

2022-05-09 Thread GitBox
wangyang0918 merged PR #197: URL: https://github.com/apache/flink-kubernetes-operator/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Commented] (FLINK-27495) Observer should update last savepoint information directly from cluster too

2022-05-09 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534153#comment-17534153 ] Gyula Fora commented on FLINK-27495: [~thw] you are completely right. This is specif

[jira] [Commented] (FLINK-27551) Consider implementing our own status update logic

2022-05-09 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534152#comment-17534152 ] Yang Wang commented on FLINK-27551: --- I agree with you that we could have our own statu

[GitHub] [flink] zuston commented on pull request #19675: [FLINK-27550] Remove checking yarn queues before submitting job to Yarn

2022-05-09 Thread GitBox
zuston commented on PR #19675: URL: https://github.com/apache/flink/pull/19675#issuecomment-1121953341 > IIRC, the leaf queue name in capacity scheduler should be unique, which means you could use `-Dyarn.application.queue=streaming/batch`. However, for fair scheduler, you need to specify a

[jira] [Commented] (FLINK-23143) Support state migration

2022-05-09 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534149#comment-17534149 ] Hangxiang Yu commented on FLINK-23143: -- > I like the simplicity of your solution, b

[GitHub] [flink] JingGe commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

2022-05-09 Thread GitBox
JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r868138403 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,18 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC conne

[GitHub] [flink] JingGe commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

2022-05-09 Thread GitBox
JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r868138403 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,18 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC conne

[GitHub] [flink] JingGe commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

2022-05-09 Thread GitBox
JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r868138403 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,18 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC conne

[jira] [Commented] (FLINK-27495) Observer should update last savepoint information directly from cluster too

2022-05-09 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534131#comment-17534131 ] Thomas Weise commented on FLINK-27495: -- [~gyfora] is this for the case of a success

[GitHub] [flink] fredia commented on pull request #19502: [FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI

2022-05-09 Thread GitBox
fredia commented on PR #19502: URL: https://github.com/apache/flink/pull/19502#issuecomment-1121904893 Sure. I run `SocketWindowWordCount` to get WEB UI. Here are pictures: - when changelog enable, display `changelog_storage` and `changelog_periodic_materialization_interval` in check

[jira] (FLINK-27555) Performance regression in schedulingDownstreamTasks on 02.05.2022

2022-05-09 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27555 ] Guowei Ma deleted comment on FLINK-27555: --- was (Author: maguowei): Thanks [~roman] for letting this. I notice that [~zhuzh]  have make some changed recently. So would you like to have a look!

[jira] [Commented] (FLINK-27555) Performance regression in schedulingDownstreamTasks on 02.05.2022

2022-05-09 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534120#comment-17534120 ] Guowei Ma commented on FLINK-27555: --- Thanks [~roman] for letting this. I notice that [

[jira] [Commented] (FLINK-27555) Performance regression in schedulingDownstreamTasks on 02.05.2022

2022-05-09 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534119#comment-17534119 ] Zhu Zhu commented on FLINK-27555: - This benchmark result is how much time it takes to do

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #83: [FLINK-27170] Add Transformer and Estimator for OnlineLogisticRegression

2022-05-09 Thread GitBox
weibozhao commented on code in PR #83: URL: https://github.com/apache/flink-ml/pull/83#discussion_r868785218 ## flink-ml-lib/src/test/java/org/apache/flink/ml/classification/OnlineLogisticRegressionTest.java: ## @@ -0,0 +1,444 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [flink] wangyang0918 commented on pull request #19675: [FLINK-27550] Remove checking yarn queues before submitting job to Yarn

2022-05-09 Thread GitBox
wangyang0918 commented on PR #19675: URL: https://github.com/apache/flink/pull/19675#issuecomment-1121849688 IIRC, the leaf queue name in capacity scheduler should be unique, which means you could use `-Dyarn.application.queue=streaming/batch`. However, for fair scheduler, you need to speci

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #111: [FLINK-27540] Let FileStoreSource accept pre-planned manifest entries

2022-05-09 Thread GitBox
LadyForest commented on code in PR #111: URL: https://github.com/apache/flink-table-store/pull/111#discussion_r868777111 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -182,4 +219,102 @@ public FileStoreSour

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #197: [FLINK-27412] Allow flinkVersion v1_13 in flink-kubernetes-operator

2022-05-09 Thread GitBox
wangyang0918 commented on code in PR #197: URL: https://github.com/apache/flink-kubernetes-operator/pull/197#discussion_r868774483 ## e2e-tests/data/sessionjob-cr.yaml: ## @@ -22,8 +22,8 @@ metadata: namespace: default name: session-cluster-1 spec: - image: flink:1.14.3

[GitHub] [flink-ml] mumuhhh opened a new pull request, #96: [hotfix] Bucketizer split point search

2022-05-09 Thread GitBox
mumuhhh opened a new pull request, #96: URL: https://github.com/apache/flink-ml/pull/96 Using variable repair -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #197: [FLINK-27412] Allow flinkVersion v1_13 in flink-kubernetes-operator

2022-05-09 Thread GitBox
wangyang0918 commented on code in PR #197: URL: https://github.com/apache/flink-kubernetes-operator/pull/197#discussion_r868772741 ## e2e-tests/data/sessionjob-cr.yaml: ## @@ -22,8 +22,8 @@ metadata: namespace: default name: session-cluster-1 spec: - image: flink:1.14.3

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #197: [FLINK-27412] Allow flinkVersion v1_13 in flink-kubernetes-operator

2022-05-09 Thread GitBox
wangyang0918 commented on code in PR #197: URL: https://github.com/apache/flink-kubernetes-operator/pull/197#discussion_r868772648 ## e2e-tests/data/flinkdep-cr.yaml: ## @@ -22,8 +22,8 @@ metadata: namespace: default name: flink-example-statemachine spec: - image: flink

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #111: [FLINK-27540] Let FileStoreSource accept pre-planned manifest entries

2022-05-09 Thread GitBox
LadyForest commented on code in PR #111: URL: https://github.com/apache/flink-table-store/pull/111#discussion_r868771446 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -122,6 +150,17 @@ public SplitEnumerato

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #111: [FLINK-27540] Let FileStoreSource accept pre-planned manifest entries

2022-05-09 Thread GitBox
LadyForest commented on code in PR #111: URL: https://github.com/apache/flink-table-store/pull/111#discussion_r868771446 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -122,6 +150,17 @@ public SplitEnumerato

[jira] [Commented] (FLINK-27504) State compaction not happening with sliding window and incremental RocksDB backend

2022-05-09 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534105#comment-17534105 ] Yun Tang commented on FLINK-27504: -- I think you'd better to read RocksDB docs on compac

[GitHub] [flink-web] JingsongLi commented on a diff in pull request #531: Add Table Store 0.1.0 release

2022-05-09 Thread GitBox
JingsongLi commented on code in PR #531: URL: https://github.com/apache/flink-web/pull/531#discussion_r868769686 ## _posts/2022-05-01-release-table-store-0.1.0.md: ## @@ -0,0 +1,110 @@ +--- +layout: post +title: "Apache Flink Table Store 0.1.0 Release Announcement" +subtitle: "

[jira] [Closed] (FLINK-27559) Some question about flink operator state

2022-05-09 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-27559. Resolution: Information Provided > Some question about flink operator state >

[jira] [Commented] (FLINK-27559) Some question about flink operator state

2022-05-09 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534103#comment-17534103 ] Yun Tang commented on FLINK-27559: -- [~Underwood] Flink's JIRA is not a place to ask que

[jira] [Created] (FLINK-27560) Refactor SimpleStateRequestHandler for PyFlink state

2022-05-09 Thread Juntao Hu (Jira)
Juntao Hu created FLINK-27560: - Summary: Refactor SimpleStateRequestHandler for PyFlink state Key: FLINK-27560 URL: https://issues.apache.org/jira/browse/FLINK-27560 Project: Flink Issue Type: Im

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #111: [FLINK-27540] Let FileStoreSource accept pre-planned manifest entries

2022-05-09 Thread GitBox
LadyForest commented on code in PR #111: URL: https://github.com/apache/flink-table-store/pull/111#discussion_r868767988 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -182,4 +219,102 @@ public FileStoreSour

[GitHub] [flink] Myasuka commented on pull request #19502: [FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI

2022-05-09 Thread GitBox
Myasuka commented on PR #19502: URL: https://github.com/apache/flink/pull/19502#issuecomment-1121834299 @fredia would you please share the picture that how the UI looks like with this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #111: [FLINK-27540] Let FileStoreSource accept pre-planned manifest entries

2022-05-09 Thread GitBox
LadyForest commented on code in PR #111: URL: https://github.com/apache/flink-table-store/pull/111#discussion_r868767378 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -69,7 +92,10 @@ public FileStoreSource(

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #111: [FLINK-27540] Let FileStoreSource accept pre-planned manifest entries

2022-05-09 Thread GitBox
LadyForest commented on code in PR #111: URL: https://github.com/apache/flink-table-store/pull/111#discussion_r868767106 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -122,6 +150,17 @@ public SplitEnumerato

[GitHub] [flink] schumiyi commented on pull request #18914: [FLINK-26259][table-planner]Partial insert and partition insert canno…

2022-05-09 Thread GitBox
schumiyi commented on PR #18914: URL: https://github.com/apache/flink/pull/18914#issuecomment-1121831473 Appreciate if you can help take a look. @godfreyhe @wuchong @twalthr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Created] (FLINK-27559) Some question about flink operator state

2022-05-09 Thread Underwood (Jira)
Underwood created FLINK-27559: - Summary: Some question about flink operator state Key: FLINK-27559 URL: https://issues.apache.org/jira/browse/FLINK-27559 Project: Flink Issue Type: New Feature

[GitHub] [flink] luoyuxia commented on a diff in pull request #19656: [FLINK-26371][hive] Support variable substitution for sql statement while using Hive dialect

2022-05-09 Thread GitBox
luoyuxia commented on code in PR #19656: URL: https://github.com/apache/flink/pull/19656#discussion_r868761997 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java: ## @@ -807,6 +807,29 @@ public void testShowPartitions()

[GitHub] [flink-table-store] openinx commented on a diff in pull request #111: [FLINK-27540] Let FileStoreSource accept pre-planned manifest entries

2022-05-09 Thread GitBox
openinx commented on code in PR #111: URL: https://github.com/apache/flink-table-store/pull/111#discussion_r868754349 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -69,7 +92,10 @@ public FileStoreSource(

[GitHub] [flink-ml] yunfengzhou-hub commented on pull request #95: Migrated to flink 1.15.0.

2022-05-09 Thread GitBox
yunfengzhou-hub commented on PR #95: URL: https://github.com/apache/flink-ml/pull/95#issuecomment-1121813951 Hi @dotbg , thanks for contributing to Flink ML. I tried running `mvn clean install` on this PR, and it seems that there are still errors during compilation. Could you please f

[jira] [Updated] (FLINK-26588) Translate the new CAST documentation to Chinese

2022-05-09 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-26588: --- Fix Version/s: 1.15.1 > Translate the new CAST documentation to Chinese > --

[jira] [Commented] (FLINK-26588) Translate the new CAST documentation to Chinese

2022-05-09 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534087#comment-17534087 ] Leonard Xu commented on FLINK-26588: Fixed in master: a9605906aa0a4c9157717b7221ef

[GitHub] [flink] leonardBang commented on pull request #19498: [FLINK-26588][docs]Translate the new CAST documentation to Chinese

2022-05-09 Thread GitBox
leonardBang commented on PR #19498: URL: https://github.com/apache/flink/pull/19498#issuecomment-1121808405 @ChengkaiYang2022 Could you also open a backport PR for branch `release-1.15` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] leonardBang merged pull request #19498: [FLINK-26588][docs]Translate the new CAST documentation to Chinese

2022-05-09 Thread GitBox
leonardBang merged PR #19498: URL: https://github.com/apache/flink/pull/19498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[GitHub] [flink] zuston commented on pull request #19675: [FLINK-27550] Remove checking yarn queues before submitting job to Yarn

2022-05-09 Thread GitBox
zuston commented on PR #19675: URL: https://github.com/apache/flink/pull/19675#issuecomment-1121805622 @wangyang0918 Thanks for your quick reply. Yes, you are right. If using the two levels queue naming policy, the leaf queue name(`-Dyarn.application.queue=default`) or full queue(`-

[GitHub] [flink-table-store] openinx commented on a diff in pull request #99: [FLINK-27307] Flink table store support append-only ingestion without primary keys.

2022-05-09 Thread GitBox
openinx commented on code in PR #99: URL: https://github.com/apache/flink-table-store/pull/99#discussion_r868744983 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreWriteImpl.java: ## @@ -82,18 +95,41 @@ public FileStoreWriteImpl(

[GitHub] [flink-table-store] openinx commented on a diff in pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface

2022-05-09 Thread GitBox
openinx commented on code in PR #115: URL: https://github.com/apache/flink-table-store/pull/115#discussion_r868723547 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Softw

[GitHub] [flink-table-store] openinx commented on a diff in pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface

2022-05-09 Thread GitBox
openinx commented on code in PR #115: URL: https://github.com/apache/flink-table-store/pull/115#discussion_r868723542 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Softw

[jira] [Assigned] (FLINK-27297) Add the StreamExecutionEnvironment#getExecutionEnvironment(Configuration) method in PyFlink

2022-05-09 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-27297: --- Assignee: LuNng Wang > Add the StreamExecutionEnvironment#getExecutionEnvironment(Configuration) >

[jira] [Commented] (FLINK-27297) Add the StreamExecutionEnvironment#getExecutionEnvironment(Configuration) method in PyFlink

2022-05-09 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534071#comment-17534071 ] Dian Fu commented on FLINK-27297: - [~ana4] Thanks for taking this. Have assigned it to y

[jira] [Commented] (FLINK-27297) Add the StreamExecutionEnvironment#getExecutionEnvironment(Configuration) method in PyFlink

2022-05-09 Thread LuNng Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534070#comment-17534070 ] LuNng Wang commented on FLINK-27297: [~dianfu] [~hxbks2ks] I would like to try this.

[GitHub] [flink] hililiwei commented on pull request #17798: [hotfix] Fix comment typos in AsyncIOExample

2022-05-09 Thread GitBox
hililiwei commented on PR #17798: URL: https://github.com/apache/flink/pull/17798#issuecomment-1121765967 > @hililiwei You haven't updated the commit message, you have updated the PR title updated. thx. 😄 -- This is an automated message from the Apache Git Service. To respond to t

[jira] [Updated] (FLINK-27558) Introduce a new optional option for TableStoreFactory to represent planned manifest entries

2022-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27558: --- Labels: pull-request-available (was: ) > Introduce a new optional option for TableStoreFact

[GitHub] [flink-table-store] LadyForest opened a new pull request, #116: [FLINK-27558] Introduce a new optional option for TableStoreFactory to represent planned manifest entries

2022-05-09 Thread GitBox
LadyForest opened a new pull request, #116: URL: https://github.com/apache/flink-table-store/pull/116 When `TableStoreFactory.onCompactTable`gets called, the planned manifest entries need to be injected back into the enriched options, and we need a new key to represent it. -- This is an

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #86: [FLINK-27294] Add Transformer for BinaryClassificationEvaluator

2022-05-09 Thread GitBox
weibozhao commented on code in PR #86: URL: https://github.com/apache/flink-ml/pull/86#discussion_r868690036 ## flink-ml-lib/src/test/java/org/apache/flink/ml/evaluation/binaryeval/BinaryClassificationEvaluatorTest.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [flink] ChengkaiYang2022 commented on pull request #19498: [FLINK-26588][docs]Translate the new CAST documentation to Chinese

2022-05-09 Thread GitBox
ChengkaiYang2022 commented on PR #19498: URL: https://github.com/apache/flink/pull/19498#issuecomment-1121710303 CI test passed.[link](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=35507&view=results) -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] haizhou-zhao commented on a diff in pull request #19645: [FLINK-27255] [flink-avro] flink-avro does not support ser/de of large avro schema

2022-05-09 Thread GitBox
haizhou-zhao commented on code in PR #19645: URL: https://github.com/apache/flink/pull/19645#discussion_r868618419 ## flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/GenericRecordAvroTypeInfo.java: ## @@ -104,10 +105,15 @@ public boolean canEqual(O

[jira] [Commented] (FLINK-23633) HybridSource: Support dynamic stop position in FileSource

2022-05-09 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534050#comment-17534050 ] Thomas Weise commented on FLINK-23633: -- Hi [~binh] , of course. Perhaps you can sta

[jira] [Commented] (FLINK-23633) HybridSource: Support dynamic stop position in FileSource

2022-05-09 Thread Xinbin Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534048#comment-17534048 ] Xinbin Huang commented on FLINK-23633: -- Hi [~thw] , may I try to implement this? >

[jira] [Commented] (FLINK-23143) Support state migration

2022-05-09 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534026#comment-17534026 ] Roman Khachatryan commented on FLINK-23143: --- Thanks a lot for sharing the prot

[GitHub] [flink-ml] dotbg opened a new pull request, #95: Migrated to flink 1.15.0.

2022-05-09 Thread GitBox
dotbg opened a new pull request, #95: URL: https://github.com/apache/flink-ml/pull/95 * Flink 1.15.0 * Scala binary version used in test artifacts only. Hence artifact names were changed -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] snuyanzin commented on pull request #19538: [FLINK-27323][flink-table-api-java][tests] Migrate tests to JUnit5

2022-05-09 Thread GitBox
snuyanzin commented on PR #19538: URL: https://github.com/apache/flink/pull/19538#issuecomment-1121530098 merge conflicts resolved and rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot commented on pull request #19684: Add support to pass Datadog API Key as environment variable

2022-05-09 Thread GitBox
flinkbot commented on PR #19684: URL: https://github.com/apache/flink/pull/19684#issuecomment-1121463902 ## CI report: * 90ea579c38f9a5f3de805c8dd1b74ba7fc2d6a26 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] pinxiu opened a new pull request, #19684: Add support to pass Datadog API Key as environment variable

2022-05-09 Thread GitBox
pinxiu opened a new pull request, #19684: URL: https://github.com/apache/flink/pull/19684 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[GitHub] [flink] snuyanzin commented on pull request #17564: [FLINK-24640][table] CEIL, FLOOR built-in functions for Timestamp should res…

2022-05-09 Thread GitBox
snuyanzin commented on PR #17564: URL: https://github.com/apache/flink/pull/17564#issuecomment-1121413777 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-27492) Flink table scala example does not including the scala-api jars

2022-05-09 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17533908#comment-17533908 ] Yun Gao commented on FLINK-27492: - For another thing, perhaps we could also including th

[GitHub] [flink] JingGe commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

2022-05-09 Thread GitBox
JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r868138403 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,18 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC conne

[jira] [Commented] (FLINK-27506) update playgrounds for Flink 1.14

2022-05-09 Thread Shubham Bansal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17533873#comment-17533873 ] Shubham Bansal commented on FLINK-27506: Thanks, David. I will take a look at th

[GitHub] [flink] JingGe commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

2022-05-09 Thread GitBox
JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r868138403 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,18 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC conne

[GitHub] [flink] HuangZhenQiu commented on pull request #14678: [FLINK-20833][runtime] Add pluggable failure listener in job manager

2022-05-09 Thread GitBox
HuangZhenQiu commented on PR #14678: URL: https://github.com/apache/flink/pull/14678#issuecomment-1121273392 @zentol Would you please help to review this RP? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] JingGe commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

2022-05-09 Thread GitBox
JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r868138403 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,18 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC conne

[GitHub] [flink] JingGe commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

2022-05-09 Thread GitBox
JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r868138403 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,18 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC conne

[GitHub] [flink] JingGe commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

2022-05-09 Thread GitBox
JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r868138403 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,18 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC conne

[GitHub] [flink] JingGe commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

2022-05-09 Thread GitBox
JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r868138403 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,18 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC conne

[GitHub] [flink] JingGe commented on a diff in pull request #19664: [hotfix][doc] add content for using numRecordsSend and deprecating numRecordsOutErrors

2022-05-09 Thread GitBox
JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r868138403 ## docs/content/release-notes/flink-1.15.md: ## @@ -406,6 +406,18 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC conne

[jira] [Commented] (FLINK-27552) Prometheus metrics disappear after starting a job

2022-05-09 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17533852#comment-17533852 ] João Boto commented on FLINK-27552: --- I was testing with a job that was a KafkaSink (so

[GitHub] [flink] afedulov commented on a diff in pull request #19660: [FLINK-27185][connectors] Convert connector modules to assertj

2022-05-09 Thread GitBox
afedulov commented on code in PR #19660: URL: https://github.com/apache/flink/pull/19660#discussion_r868113102 ## flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java: ## @@ -723,11 +721,11 @@ publ

[jira] [Closed] (FLINK-26112) Port getRestEndpoint method to the specific service type subclass

2022-05-09 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang closed FLINK-26112. - Resolution: Fixed Fixed via: master: f24dc6da25246fdaf278f4b2ce88892ec79d1b8b ab3eb40d920fa609f49164a0bb

[jira] [Created] (FLINK-27558) Introduce a new optional option for TableStoreFactory to represent planned manifest entries

2022-05-09 Thread Jane Chan (Jira)
Jane Chan created FLINK-27558: - Summary: Introduce a new optional option for TableStoreFactory to represent planned manifest entries Key: FLINK-27558 URL: https://issues.apache.org/jira/browse/FLINK-27558

[jira] [Updated] (FLINK-26112) Port getRestEndpoint method to the specific service type subclass

2022-05-09 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-26112: -- Fix Version/s: 1.16.0 > Port getRestEndpoint method to the specific service type subclass > --

[GitHub] [flink] wangyang0918 merged pull request #18762: [FlINK-26112][k8s]Port getRestEndpoint method to the specific service type subclass

2022-05-09 Thread GitBox
wangyang0918 merged PR #18762: URL: https://github.com/apache/flink/pull/18762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[GitHub] [flink] afedulov commented on a diff in pull request #19660: [FLINK-27185][connectors] Convert connector modules to assertj

2022-05-09 Thread GitBox
afedulov commented on code in PR #19660: URL: https://github.com/apache/flink/pull/19660#discussion_r868090797 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/SourceMetricsITCase.java: ## @@ -169,45 +168,47 @@ private void ass

[GitHub] [flink] afedulov commented on a diff in pull request #19660: [FLINK-27185][connectors] Convert connector modules to assertj

2022-05-09 Thread GitBox
afedulov commented on code in PR #19660: URL: https://github.com/apache/flink/pull/19660#discussion_r868080704 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/hybrid/HybridSourceTest.java: ## @@ -29,9 +29,8 @@ import java.util.Lis

[GitHub] [flink-web] liuzhuang2017 commented on pull request #528: [hotfix][docs] Delete the redundant content of "downloads.zh.md" file.

2022-05-09 Thread GitBox
liuzhuang2017 commented on PR #528: URL: https://github.com/apache/flink-web/pull/528#issuecomment-1121172421 @MartijnVisser , Thank you very much for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

  1   2   3   >