JingGe commented on code in PR #19664: URL: https://github.com/apache/flink/pull/19664#discussion_r868138403
########## docs/content/release-notes/flink-1.15.md: ########## @@ -406,6 +406,18 @@ updating the client dependency to a version >= 7.14.0 is required due to interna The old JDBC connector (indicated by `connector.type=jdbc` in DDL) has been removed. If not done already, users need to upgrade to the newer stack (indicated by `connector=jdbc` in DDL). + +#### Extensible unified Sink uses new metric to capture outgoing records + +##### [FLINK-26126](https://issues.apache.org/jira/browse/FLINK-26126) + +New metrics `numRecordsSend` and `numRecordsSendErrors` has been introduced for users to monitor the number of +records sent to the external system. The `numRecordsOut` should be used to monitor the number of records +transferred between sink tasks. + +Connector developers should Consider using the new metric `numRecordsSendErrors` to monitor errors, +since `numRecordsOut` has a different and more general meaning, and `numRecordsOutErrors` is therefore deprecated. Review Comment: This is confused for users and connector developers, tbh. 1. `numRecordsOut` will ONLY count the records(technically Commitables) sent between sink tasks. 2. Connectors still use `numRecordsOut`. 3. the information of using `numRecordsSend` has been described in the first part and there is no use case for "changing the connector"(all connectors that used `numRecordsOut` in a wrong way have been changed). From now on, it is actually mandatory for connector developers to use them except `numRecordsOutErrors`. How about this version: Connector developers should pay attention to the usage of these metrics `numRecordsOut`, `numRecordsSend` and `numRecordsSendErrors` while building sink connectors. Please refer to the new Kafka Sink for more information. Additionally since `numRecordsOut` now only counts the records sent between sink tasks and `numRecordsOutErrors` was designed for counting the records sent to the external system, we deprecated `numRecordsOutErrors` and recommend using `numRecordsSendErrors` instead. Event with this description, it is still unclear, since `numRecordsOut` is still used, why is `numRecordsOutErrors` deprecated? It should be used to monitor errors happened while Commitables were send between sink tasks. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
