[jira] [Commented] (FLINK-18202) Introduce Protobuf format

2021-11-16 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444993#comment-17444993 ] Martijn Visser commented on FLINK-18202: [~maosuhan] I can look for a committer

[jira] [Commented] (FLINK-24894) Flink on k8s, open the HA mode based on KubernetesHaServicesFactory ,When I deleted the job, the config map created under the HA mechanism was not deleted.

2021-11-16 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444992#comment-17444992 ] liuzhuo commented on FLINK-24894: - This question also confuses me. When JobManager POD o

[jira] [Updated] (FLINK-24894) Flink on k8s, open the HA mode based on KubernetesHaServicesFactory ,When I deleted the job, the config map created under the HA mechanism was not deleted.

2021-11-16 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhuo updated FLINK-24894: Attachment: (was: image-2021-11-17-15-56-20-652.png) > Flink on k8s, open the HA mode based on Kuberne

[jira] [Created] (FLINK-24933) Support ML Python API

2021-11-16 Thread Huang Xingbo (Jira)
Huang Xingbo created FLINK-24933: Summary: Support ML Python API Key: FLINK-24933 URL: https://issues.apache.org/jira/browse/FLINK-24933 Project: Flink Issue Type: New Feature Compo

[jira] [Updated] (FLINK-24894) Flink on k8s, open the HA mode based on KubernetesHaServicesFactory ,When I deleted the job, the config map created under the HA mechanism was not deleted.

2021-11-16 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhuo updated FLINK-24894: Attachment: image-2021-11-17-15-56-20-652.png > Flink on k8s, open the HA mode based on KubernetesHaServic

[GitHub] [flink] flinkbot edited a comment on pull request #17788: [FLINK-15826][Tabel SQL/API] Add renameFunction() to Catalog

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17788: URL: https://github.com/apache/flink/pull/17788#issuecomment-968179643 ## CI report: * 4e6d4e3bab6c9fe8caf2363177e74011a175ee72 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17537: [FLINK-19722][table-planner]Pushdown Watermark to SourceProvider (new Source)

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17537: URL: https://github.com/apache/flink/pull/17537#issuecomment-948566240 ## CI report: * 0e6fea8d800cee8771cdafd718ea585be64dc7f0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17537: [FLINK-19722][table-planner]Pushdown Watermark to SourceProvider (new Source)

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17537: URL: https://github.com/apache/flink/pull/17537#issuecomment-948566240 ## CI report: * 0e6fea8d800cee8771cdafd718ea585be64dc7f0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-18202) Introduce Protobuf format

2021-11-16 Thread Suhan Mao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444985#comment-17444985 ] Suhan Mao commented on FLINK-18202: --- I think [https://github.com/apache/flink/pull/143

[GitHub] [flink] flinkbot edited a comment on pull request #17813: [FLINK-24802][Table SQL/Planner] Improve cast ROW to STRING

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17813: URL: https://github.com/apache/flink/pull/17813#issuecomment-970956527 ## CI report: * f0b062da9d26ea51f65825a15f0f882fb62b2586 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #17809: [BP-1.14][FLINK-24631][k8s] Use a stable subset of labels to select jobManager and taskManager pods

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17809: URL: https://github.com/apache/flink/pull/17809#issuecomment-970332023 ## CI report: * 8c2f74c0aa0f7c58c39b45e0310f976078ba2dc9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17815: [FLINK-22702][tests] Add test data supplier which provide null timestamp field to kafka connector tests

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17815: URL: https://github.com/apache/flink/pull/17815#issuecomment-971312244 ## CI report: * c654feccc34582ec2f2c6c22513c7a67bcd3de65 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17813: [FLINK-24802][Table SQL/Planner] Improve cast ROW to STRING

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17813: URL: https://github.com/apache/flink/pull/17813#issuecomment-970956527 ## CI report: * f0b062da9d26ea51f65825a15f0f882fb62b2586 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #17815: [FLINK-22702][tests] Add test data supplier which provide null timestamp field to kafka connector tests

2021-11-16 Thread GitBox
flinkbot commented on pull request #17815: URL: https://github.com/apache/flink/pull/17815#issuecomment-971313385 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Commented] (FLINK-15825) Add renameDatabase() to Catalog

2021-11-16 Thread Shen Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444980#comment-17444980 ] Shen Zhu commented on FLINK-15825: -- Hey Jingsong([~lzljs3620320] ), I'm interested in p

[GitHub] [flink] flinkbot commented on pull request #17815: [FLINK-22702][tests] Add test data supplier which provide null timestamp field to kafka connector tests

2021-11-16 Thread GitBox
flinkbot commented on pull request #17815: URL: https://github.com/apache/flink/pull/17815#issuecomment-971312244 ## CI report: * c654feccc34582ec2f2c6c22513c7a67bcd3de65 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #17813: [FLINK-24802][Table SQL/Planner] Improve cast ROW to STRING

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17813: URL: https://github.com/apache/flink/pull/17813#issuecomment-970956527 ## CI report: * f0b062da9d26ea51f65825a15f0f882fb62b2586 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] ruanhang1993 opened a new pull request #17815: [FLINK-22702][tests] Add test data supplier which provide null timestamp field to kafka connector tests

2021-11-16 Thread GitBox
ruanhang1993 opened a new pull request #17815: URL: https://github.com/apache/flink/pull/17815 This PR cherry-picks the PR from #16974 to the release-1.13 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [flink] maosuhan commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-11-16 Thread GitBox
maosuhan commented on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-971310164 @complone thanks for your attention and suggestion. I think we have already discussed a lot in the thread and this MR is pretty much ready for merge. Actually the reason for

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-16 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r750958184 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10 +1

[GitHub] [flink] wenlong88 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-16 Thread GitBox
wenlong88 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r750952147 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10 +1

[GitHub] [flink-ml] zhipeng93 commented on a change in pull request #30: [FLINK-24845] Add allreduce utility function in FlinkML

2021-11-16 Thread GitBox
zhipeng93 commented on a change in pull request #30: URL: https://github.com/apache/flink-ml/pull/30#discussion_r750952165 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/allreduce/AllReduceUtils.java ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Soft

[jira] [Updated] (FLINK-24845) Add allreduce utility function in FlinkML

2021-11-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24845: --- Labels: pull-request-available (was: ) > Add allreduce utility function in FlinkML > --

[jira] [Commented] (FLINK-24918) Support to specify the data dir for state benchmark

2021-11-16 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444970#comment-17444970 ] Yun Tang commented on FLINK-24918: -- [~aitozi], I think the suggestion make sense as dif

[GitHub] [flink-ml] lindong28 commented on a change in pull request #30: [FLINK-24845] Add allreduce utility function in FlinkML

2021-11-16 Thread GitBox
lindong28 commented on a change in pull request #30: URL: https://github.com/apache/flink-ml/pull/30#discussion_r750948104 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/allreduce/AllReduceUtils.java ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Soft

[jira] [Commented] (FLINK-24924) TO_TIMESTAMP and TO_DATE should fail

2021-11-16 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444963#comment-17444963 ] lincoln lee commented on FLINK-24924: - +1 to keep the current behavior and add a new

[GitHub] [flink] Myasuka commented on pull request #12345: draft: [FLINK-17971] [Runtime/StateBackends] Add RocksDB SST ingestion for batch writes

2021-11-16 Thread GitBox
Myasuka commented on pull request #12345: URL: https://github.com/apache/flink/pull/12345#issuecomment-971262295 @lgo Do you have plans to update this as we already upgraded to RocksDB-6.20.3? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (FLINK-24932) Frocksdb cannot run on Apple M1

2021-11-16 Thread Yun Tang (Jira)
Yun Tang created FLINK-24932: Summary: Frocksdb cannot run on Apple M1 Key: FLINK-24932 URL: https://issues.apache.org/jira/browse/FLINK-24932 Project: Flink Issue Type: Bug Components:

[jira] [Commented] (FLINK-13598) frocksdb doesn't have arm release

2021-11-16 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444959#comment-17444959 ] Yun Tang commented on FLINK-13598: -- [~rmetzger], RocksJava does not support Apple M1 ye

[GitHub] [flink] flinkbot edited a comment on pull request #17774: [FLINK-24611] Prevent JM from discarding state on checkpoint abortion

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17774: URL: https://github.com/apache/flink/pull/17774#issuecomment-966933536 ## CI report: * 825a694250c558dacb5751a12e53f83af018c739 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-ml] zhipeng93 closed pull request #29: [FLINK-24838] Add BaseAlgoImpl class to support link() and linkFrom()

2021-11-16 Thread GitBox
zhipeng93 closed pull request #29: URL: https://github.com/apache/flink-ml/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink-ml] zhipeng93 commented on a change in pull request #29: [FLINK-24838] Add BaseAlgoImpl class to support link() and linkFrom()

2021-11-16 Thread GitBox
zhipeng93 commented on a change in pull request #29: URL: https://github.com/apache/flink-ml/pull/29#discussion_r750922013 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/operator/batch/BatchOperator.java ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [flink] Thesharing commented on pull request #17777: [FLINK-24886][core] TimeUtils supports the form of m.

2021-11-16 Thread GitBox
Thesharing commented on pull request #1: URL: https://github.com/apache/flink/pull/1#issuecomment-971248094 I think it's great to support using "m" to denote minutes. But I think we shouldn't change the existing configurations from "min" to "m". It breaks consistency of configurati

[jira] [Commented] (FLINK-24924) TO_TIMESTAMP and TO_DATE should fail

2021-11-16 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444957#comment-17444957 ] godfrey he commented on FLINK-24924: CAST is used at high frequencies, +1 keep the b

[jira] [Commented] (FLINK-24727) Running Kerberized YARN per-job on Docker test (no fat-jar) fails on Azure

2021-11-16 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444955#comment-17444955 ] Yangze Guo commented on FLINK-24727: Looking into the PR. The root cause is it set t

[jira] [Commented] (FLINK-24851) KafkaSourceBuilder: auto.offset.reset is ignored

2021-11-16 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444954#comment-17444954 ] Qingsheng Ren commented on FLINK-24851: --- Thanks for the discussion [~tashoyan] [~l

[GitHub] [flink] flinkbot edited a comment on pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17685: URL: https://github.com/apache/flink/pull/17685#issuecomment-961148655 ## CI report: * 3f7a57dd1d7274cee626d46b4e7d050300d17031 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17685: URL: https://github.com/apache/flink/pull/17685#issuecomment-961148655 ## CI report: * 3f7a57dd1d7274cee626d46b4e7d050300d17031 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] Aitozi commented on a change in pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-16 Thread GitBox
Aitozi commented on a change in pull request #17685: URL: https://github.com/apache/flink/pull/17685#discussion_r750905415 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java ## @@ -64,10 +63,15 @@

[GitHub] [flink] Aitozi commented on a change in pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-16 Thread GitBox
Aitozi commented on a change in pull request #17685: URL: https://github.com/apache/flink/pull/17685#discussion_r750905415 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java ## @@ -64,10 +63,15 @@

[GitHub] [flink] flinkbot edited a comment on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-971129699 ## CI report: * e3269ea84366f74f9c04a6b3f7be723207958e1e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-971129699 ## CI report: * e3269ea84366f74f9c04a6b3f7be723207958e1e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] wangyang0918 commented on a change in pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-16 Thread GitBox
wangyang0918 commented on a change in pull request #17685: URL: https://github.com/apache/flink/pull/17685#discussion_r750896105 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java ## @@ -64,10 +63,

[GitHub] [flink-ml] lindong28 commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
lindong28 commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750879940 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelParams.java ## @@ -0,0 +1,45 @@ +/* + * Licensed to

[GitHub] [flink-ml] lindong28 commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
lindong28 commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750878843 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasFeatureSize.java ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] Aitozi commented on a change in pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-16 Thread GitBox
Aitozi commented on a change in pull request #17685: URL: https://github.com/apache/flink/pull/17685#discussion_r750887490 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java ## @@ -64,10 +63,15 @@

[GitHub] [flink] Aitozi commented on a change in pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-16 Thread GitBox
Aitozi commented on a change in pull request #17685: URL: https://github.com/apache/flink/pull/17685#discussion_r750886768 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java ## @@ -64,10 +63,15 @@

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750876816 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750876450 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesParams.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750875949 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink] flinkbot edited a comment on pull request #17774: [FLINK-24611] Prevent JM from discarding state on checkpoint abortion

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17774: URL: https://github.com/apache/flink/pull/17774#issuecomment-966933536 ## CI report: * 62342123020816c19f74ee57b52fa5cc1869a1df Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[jira] [Closed] (FLINK-24930) Print Sink should also print the table identifier when output data

2021-11-16 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-24930. - Resolution: Fixed > Print Sink should also print the table identifier when output data > ---

[jira] [Commented] (FLINK-24931) Remove deprecated/unused class files in flink-scala module.

2021-11-16 Thread Yuepeng Pan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444930#comment-17444930 ] Yuepeng Pan commented on FLINK-24931: - Hi,   [~igal] [~tzulitai]  , What do you thin

[jira] [Commented] (FLINK-24924) TO_TIMESTAMP and TO_DATE should fail

2021-11-16 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444929#comment-17444929 ] Jark Wu commented on FLINK-24924: - I agree throw exception would be helpful in some case

[jira] [Created] (FLINK-24931) Remove deprecated/unused class files in flink-scala module.

2021-11-16 Thread Yuepeng Pan (Jira)
Yuepeng Pan created FLINK-24931: --- Summary: Remove deprecated/unused class files in flink-scala module. Key: FLINK-24931 URL: https://issues.apache.org/jira/browse/FLINK-24931 Project: Flink Is

[jira] [Created] (FLINK-24930) Print Sink should also print the table identifier when output data

2021-11-16 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-24930: - Summary: Print Sink should also print the table identifier when output data Key: FLINK-24930 URL: https://issues.apache.org/jira/browse/FLINK-24930 Project: Flink

[GitHub] [flink] flinkbot edited a comment on pull request #17812: [hotfix][e2e] Adds missing quotes

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17812: URL: https://github.com/apache/flink/pull/17812#issuecomment-970699581 ## CI report: * ae63bca783b7c4b537cb31d8279c6b464dadc6c7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Comment Edited] (FLINK-24815) Reduce the cpu cost of calculating stateSize during state allocation

2021-11-16 Thread ming li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444925#comment-17444925 ] ming li edited comment on FLINK-24815 at 11/17/21, 3:43 AM:

[jira] [Commented] (FLINK-24815) Reduce the cpu cost of calculating stateSize during state allocation

2021-11-16 Thread ming li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444925#comment-17444925 ] ming li commented on FLINK-24815: - [~pnowojski], um. . . you are right.  Although the si

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750848588 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750848317 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750848148 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750847956 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750847799 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750847767 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750847703 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750847518 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750847113 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750846941 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750846697 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesParams.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to

[GitHub] [flink] flinkbot edited a comment on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-971129699 ## CI report: * e3269ea84366f74f9c04a6b3f7be723207958e1e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] wangyang0918 commented on a change in pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-16 Thread GitBox
wangyang0918 commented on a change in pull request #17685: URL: https://github.com/apache/flink/pull/17685#discussion_r750846414 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java ## @@ -64,10 +63,

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750846326 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java ## @@ -0,0 +1,333 @@ +/* + * Licensed to the

[GitHub] [flink-ml] gaoyunhaii commented on pull request #34: [FLINK-24279] [hotfix] fix nullpointer exception when broadcast variables are cleaned

2021-11-16 Thread GitBox
gaoyunhaii commented on pull request #34: URL: https://github.com/apache/flink-ml/pull/34#issuecomment-971130344 Very thanks @zhipeng93 for opening the PR! The fix roughly LGTM to me, perhaps we may also 1. `hotfix` usually means the PR that does not need to open issues, thus if we use

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750845569 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelData.java ## @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] [flink] flinkbot commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-11-16 Thread GitBox
flinkbot commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-971129699 ## CI report: * e3269ea84366f74f9c04a6b3f7be723207958e1e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #32: [FLINK-24817] Add Naive Bayes implementation

2021-11-16 Thread GitBox
yunfengzhou-hub commented on a change in pull request #32: URL: https://github.com/apache/flink-ml/pull/32#discussion_r750845531 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelData.java ## @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] [flink] flinkbot commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-11-16 Thread GitBox
flinkbot commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-971129434 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Updated] (FLINK-24899) Enable data compression for blocking shuffle by default

2021-11-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24899: --- Labels: pull-request-available (was: ) > Enable data compression for blocking shuffle by de

[GitHub] [flink] SteNicholas opened a new pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-11-16 Thread GitBox
SteNicholas opened a new pull request #17814: URL: https://github.com/apache/flink/pull/17814 ## What is the purpose of the change *Shuffle data compression is currently not enabled by default. Shuffle data compression is important for blocking data shuffle and enabling shuffle data

[jira] [Updated] (FLINK-24929) Kerberized YARN per-job on Docker test fails on Azure because of building image

2021-11-16 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-24929: -- Description: {code:java} 2021-11-16T15:45:14.3392286Z Nov 16 15:45:14 Building Hadoop Docker container

[jira] [Updated] (FLINK-24929) Kerberized YARN per-job on Docker test fails on Azure because of building image

2021-11-16 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-24929: -- Environment: (was: {code:java} 2021-11-16T15:45:14.3392286Z Nov 16 15:45:14 Building Hadoop Docker

[jira] [Commented] (FLINK-24929) Kerberized YARN per-job on Docker test fails on Azure because of building image

2021-11-16 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444911#comment-17444911 ] Yang Wang commented on FLINK-24929: --- Related azure instance. https://dev.azure.com/ap

[jira] [Created] (FLINK-24929) Kerberized YARN per-job on Docker test fails on Azure because of building image

2021-11-16 Thread Yang Wang (Jira)
Yang Wang created FLINK-24929: - Summary: Kerberized YARN per-job on Docker test fails on Azure because of building image Key: FLINK-24929 URL: https://issues.apache.org/jira/browse/FLINK-24929 Project: Fl

[jira] [Commented] (FLINK-24924) TO_TIMESTAMP and TO_DATE should fail

2021-11-16 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444909#comment-17444909 ] Jingsong Lee commented on FLINK-24924: -- About cast and other functions... fail thro

[jira] [Commented] (FLINK-18450) FLIP-182: Support watermark alignment

2021-11-16 Thread Alexey Trenikhin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444901#comment-17444901 ] Alexey Trenikhin commented on FLINK-18450: -- Very interested in this feature, is

[GitHub] [flink] xuyangzhong commented on a change in pull request #17734: [FLINK-23305][table]Support semi/anti interval joins

2021-11-16 Thread GitBox
xuyangzhong commented on a change in pull request #17734: URL: https://github.com/apache/flink/pull/17734#discussion_r750833819 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/interval/SemiAntiTimeIntervalJoin.java ## @

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17556: [FLINK-24627][tests] add some Junit5 extensions to replace the existed Junit4 rules

2021-11-16 Thread GitBox
ruanhang1993 commented on a change in pull request #17556: URL: https://github.com/apache/flink/pull/17556#discussion_r750831313 ## File path: flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java ###

[GitHub] [flink] beyond1920 commented on a change in pull request #17734: [FLINK-23305][table]Support semi/anti interval joins

2021-11-16 Thread GitBox
beyond1920 commented on a change in pull request #17734: URL: https://github.com/apache/flink/pull/17734#discussion_r750828675 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/interval/SemiAntiTimeIntervalJoin.java ## @@

[jira] [Commented] (FLINK-24924) TO_TIMESTAMP and TO_DATE should fail

2021-11-16 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444896#comment-17444896 ] Kurt Young commented on FLINK-24924: I would second [~TsReaper] 's concern and i rem

[jira] [Assigned] (FLINK-21415) JDBC connector should support to disable caching missing key

2021-11-16 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-21415: --- Assignee: liwei li > JDBC connector should support to disable caching missing key > ---

[jira] [Updated] (FLINK-24915) StreamElementSerializer#deserialize(StreamElement reuse, DataInputView source) forgets to handle tag == TAG_STREAM_STATUS

2021-11-16 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-24915: Component/s: API / DataStream > StreamElementSerializer#deserialize(StreamElement reuse, DataInputView >

[GitHub] [flink] flinkbot edited a comment on pull request #17809: [BP-1.14][FLINK-24631][k8s] Use a stable subset of labels to select jobManager and taskManager pods

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17809: URL: https://github.com/apache/flink/pull/17809#issuecomment-970332023 ## CI report: * 8c2f74c0aa0f7c58c39b45e0310f976078ba2dc9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17809: [BP-1.14][FLINK-24631][k8s] Use a stable subset of labels to select jobManager and taskManager pods

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17809: URL: https://github.com/apache/flink/pull/17809#issuecomment-970332023 ## CI report: * 8c2f74c0aa0f7c58c39b45e0310f976078ba2dc9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] wangyang0918 commented on pull request #17809: [BP-1.14][FLINK-24631][k8s] Use a stable subset of labels to select jobManager and taskManager pods

2021-11-16 Thread GitBox
wangyang0918 commented on pull request #17809: URL: https://github.com/apache/flink/pull/17809#issuecomment-971084435 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Assigned] (FLINK-21583) Allow comments in CSV format without having to ignore parse errors

2021-11-16 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-21583: --- Assignee: liwei li (was: li wei) > Allow comments in CSV format without having to ignore parse err

[jira] [Assigned] (FLINK-24592) FlinkSQL multiline parser improvements

2021-11-16 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-24592: --- Assignee: Sergey Nuyanzin > FlinkSQL multiline parser improvements > --

[jira] [Assigned] (FLINK-21583) Allow comments in CSV format without having to ignore parse errors

2021-11-16 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-21583: --- Assignee: li wei > Allow comments in CSV format without having to ignore parse errors > ---

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-16 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] xuyangzhong commented on a change in pull request #17734: [FLINK-23305][table]Support semi/anti interval joins

2021-11-16 Thread GitBox
xuyangzhong commented on a change in pull request #17734: URL: https://github.com/apache/flink/pull/17734#discussion_r750818825 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/interval/SemiAntiTimeIntervalJoin.java ## @

  1   2   3   4   5   6   7   >