gaoyunhaii commented on pull request #34: URL: https://github.com/apache/flink-ml/pull/34#issuecomment-971130344
Very thanks @zhipeng93 for opening the PR! The fix roughly LGTM to me, perhaps we may also 1. `hotfix` usually means the PR that does not need to open issues, thus if we use `hotfix`, we might remove `[FLINK-24279]`, Or we leave `[FLINK-24279]` and remove `[hotfix]`. And we might also change the commit message accordingly. 2. Besides, I also think we might need to add a test for this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
