[jira] [Commented] (FLINK-22084) RescalingITCase fails with adaptive scheduler

2021-04-05 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315293#comment-17315293 ] Guowei Ma commented on FLINK-22084: --- https://dev.azure.com/apache-flink/apache-flink/_

[jira] [Comment Edited] (FLINK-21954) Test failures occur due to the test not waiting for the ExecutionGraph to be created

2021-04-05 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315276#comment-17315276 ] Guowei Ma edited comment on FLINK-21954 at 4/6/21, 6:53 AM:

[GitHub] [flink] flinkbot edited a comment on pull request #15491: [FLINK-21966][python]Support Kinesis connector in Python DataStream API

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15491: URL: https://github.com/apache/flink/pull/15491#issuecomment-813862338 ## CI report: * eef9b74969b6ef78a3bb339b85b7a2a94048f8be Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15490: [FLINK-21850][docs] Improve config descriptions of sort-merge blocking shuffle and remove outdated document

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15490: URL: https://github.com/apache/flink/pull/15490#issuecomment-813862254 ## CI report: * ef852240e48c635f408892ed964e7f0d72616d98 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] sazzad16 commented on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
sazzad16 commented on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813872546 @KarmaGYZ It'll be helpful. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Comment Edited] (FLINK-21743) JdbcXaSinkFunction throws XAER_RMFAIL when calling snapshotState and beginTx

2021-04-05 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315273#comment-17315273 ] Yuan Mei edited comment on FLINK-21743 at 4/6/21, 6:51 AM: --- He

[GitHub] [flink] flinkbot edited a comment on pull request #15396: [FLINK-21008][coordination] Register a shutdown supplier in the SignalHandler for ClusterEntrypoint

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15396: URL: https://github.com/apache/flink/pull/15396#issuecomment-808861897 ## CI report: * 5e152ddd93611a57bf3659bd1c46967e46a9e4c2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Created] (FLINK-22111) ClientTest.testSimpleRequests fail

2021-04-05 Thread Guowei Ma (Jira)
Guowei Ma created FLINK-22111: - Summary: ClientTest.testSimpleRequests fail Key: FLINK-22111 URL: https://issues.apache.org/jira/browse/FLINK-22111 Project: Flink Issue Type: Bug Compon

[GitHub] [flink] KarmaGYZ commented on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
KarmaGYZ commented on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813870249 @sazzad16 Maybe you can refer to [this FLIP](https://cwiki.apache.org/confluence/display/FLINK/FLIP-72%3A+Introduce+Pulsar+Connector). All in all, I think we should reach a con

[GitHub] [flink] sazzad16 commented on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
sazzad16 commented on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813867209 @KarmaGYZ Thank you for your response. Briefly speaking, this is a simple idea. i) Save data into Redis. ii) Get data from Redis. So I'm not sure about what to do here.

[GitHub] [flink] sazzad16 removed a comment on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
sazzad16 removed a comment on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813866710 @KarmaGYZ Briefly speaking, this is a simple idea. i) Save data into Redis. ii) Get data from Redis. So I'm not sure about what to do here. Could you please refer

[GitHub] [flink] sazzad16 commented on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
sazzad16 commented on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813866710 @KarmaGYZ Briefly speaking, this is a simple idea. i) Save data into Redis. ii) Get data from Redis. So I'm not sure about what to do here. Could you please refer to an e

[jira] [Commented] (FLINK-22084) RescalingITCase fails with adaptive scheduler

2021-04-05 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315281#comment-17315281 ] Guowei Ma commented on FLINK-22084: --- https://dev.azure.com/apache-flink/apache-flink/_

[jira] [Commented] (FLINK-22027) Create separate repository for Jira Bot

2021-04-05 Thread Konstantin Knauf (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315279#comment-17315279 ] Konstantin Knauf commented on FLINK-22027: -- [~rmetzger] Simply "flink-jira-bot"

[jira] [Commented] (FLINK-21954) Test failures occur due to the test not waiting for the ExecutionGraph to be created

2021-04-05 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315276#comment-17315276 ] Guowei Ma commented on FLINK-21954: --- https://dev.azure.com/apache-flink/apache-flink/_

[jira] [Commented] (FLINK-22031) Create Jira Account for Jira Bot

2021-04-05 Thread Konstantin Knauf (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315275#comment-17315275 ] Konstantin Knauf commented on FLINK-22031: -- Thank you [~rmetzger]. > Create Ji

[GitHub] [flink] flinkbot commented on pull request #15491: [FLINK-21966][python]Support Kinesis connector in Python DataStream API

2021-04-05 Thread GitBox
flinkbot commented on pull request #15491: URL: https://github.com/apache/flink/pull/15491#issuecomment-813862338 ## CI report: * eef9b74969b6ef78a3bb339b85b7a2a94048f8be UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[jira] [Comment Edited] (FLINK-22073) ParquetFileCompactionITCase fails on Azure

2021-04-05 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315271#comment-17315271 ] Guowei Ma edited comment on FLINK-22073 at 4/6/21, 6:32 AM:

[GitHub] [flink] flinkbot commented on pull request #15490: [FLINK-21850][docs] Improve config descriptions of sort-merge blocking shuffle and remove outdated document

2021-04-05 Thread GitBox
flinkbot commented on pull request #15490: URL: https://github.com/apache/flink/pull/15490#issuecomment-813862254 ## CI report: * ef852240e48c635f408892ed964e7f0d72616d98 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #15396: [FLINK-21008][coordination] Register a shutdown supplier in the SignalHandler for ClusterEntrypoint

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15396: URL: https://github.com/apache/flink/pull/15396#issuecomment-808861897 ## CI report: * 5e152ddd93611a57bf3659bd1c46967e46a9e4c2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-21743) JdbcXaSinkFunction throws XAER_RMFAIL when calling snapshotState and beginTx

2021-04-05 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315273#comment-17315273 ] Yuan Mei commented on FLINK-21743: -- Hey [~weihao], I've tried on the latest version of

[jira] [Commented] (FLINK-22073) ParquetFileCompactionITCase fails on Azure

2021-04-05 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315271#comment-17315271 ] Guowei Ma commented on FLINK-22073: --- https://dev.azure.com/apache-flink/apache-flink/_

[jira] [Commented] (FLINK-21853) Running HA per-job cluster (rocks, non-incremental) end-to-end test could not finished in 900 seconds

2021-04-05 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315266#comment-17315266 ] Guowei Ma commented on FLINK-21853: --- https://dev.azure.com/apache-flink/apache-flink/_

[jira] [Created] (FLINK-22110) KinesisTableApiITCase.testTableApiSourceAndSink failed due to download docker image throw IOException

2021-04-05 Thread Guowei Ma (Jira)
Guowei Ma created FLINK-22110: - Summary: KinesisTableApiITCase.testTableApiSourceAndSink failed due to download docker image throw IOException Key: FLINK-22110 URL: https://issues.apache.org/jira/browse/FLINK-22110

[GitHub] [flink] flinkbot commented on pull request #15491: [FLINK-21966][python]Support Kinesis connector in Python DataStream API

2021-04-05 Thread GitBox
flinkbot commented on pull request #15491: URL: https://github.com/apache/flink/pull/15491#issuecomment-813854657 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] flinkbot commented on pull request #15490: [FLINK-21850][docs] Improve config descriptions of sort-merge blocking shuffle and remove outdated document

2021-04-05 Thread GitBox
flinkbot commented on pull request #15490: URL: https://github.com/apache/flink/pull/15490#issuecomment-813853752 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Updated] (FLINK-21966) Support Kinesis connector in Python DataStream API.

2021-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21966: --- Labels: pull-request-available (was: ) > Support Kinesis connector in Python DataStream API

[GitHub] [flink] xinbinhuang opened a new pull request #15491: [FLINK-21966][python]Support Kinesis connector in Python DataStream API

2021-04-05 Thread GitBox
xinbinhuang opened a new pull request #15491: URL: https://github.com/apache/flink/pull/15491 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring the

[GitHub] [flink] flinkbot edited a comment on pull request #15489: [FLINK-22106][table-planner-blink] Result type of GeneratedExpression in StringCallGen should be compatible with their definition in

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15489: URL: https://github.com/apache/flink/pull/15489#issuecomment-813835360 ## CI report: * 126427eaf8d47adad7b29c3d74cdf10951d2c6e2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-21850) Improve document and config description of sort-merge blocking shuffle

2021-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21850: --- Labels: pull-request-available (was: ) > Improve document and config description of sort-me

[GitHub] [flink] wsry opened a new pull request #15490: [FLINK-21850][docs] Improve config descriptions of sort-merge blocking shuffle and remove outdated document

2021-04-05 Thread GitBox
wsry opened a new pull request #15490: URL: https://github.com/apache/flink/pull/15490 ## What is the purpose of the change Improve config descriptions of sort-merge blocking shuffle and remove outdated document. ## Brief change log - Improve config descriptions o

[jira] [Closed] (FLINK-22103) testNumberOfBuiltinFunctions fail

2021-04-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-22103. --- Resolution: Fixed Fixed in master: 7a4b67e65545507d6cc2531965617a5a05694138 > testNumberOfBuiltinFunctions

[GitHub] [flink] wuchong merged pull request #15482: [FLINK-22103][hive] Fix HiveModuleTest for 1.2.1

2021-04-05 Thread GitBox
wuchong merged pull request #15482: URL: https://github.com/apache/flink/pull/15482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [flink] wangyang0918 edited a comment on pull request #15396: [FLINK-21008][coordination] Register a shutdown supplier in the SignalHandler for ClusterEntrypoint

2021-04-05 Thread GitBox
wangyang0918 edited a comment on pull request #15396: URL: https://github.com/apache/flink/pull/15396#issuecomment-813774645 The failed tests are caused by an old bug of `flink-yarn-tests`. Given that we may run multiple tests(applications) in a Yarn minicluster. If we do not check the `ap

[GitHub] [flink] flinkbot commented on pull request #15489: [FLINK-22106][table-planner-blink] Result type of GeneratedExpression in StringCallGen should be compatible with their definition in FlinkSq

2021-04-05 Thread GitBox
flinkbot commented on pull request #15489: URL: https://github.com/apache/flink/pull/15489#issuecomment-813835360 ## CI report: * 126427eaf8d47adad7b29c3d74cdf10951d2c6e2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[jira] [Created] (FLINK-22109) Misleading exception message if the number of arguments of a nested function is incorrect

2021-04-05 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-22109: --- Summary: Misleading exception message if the number of arguments of a nested function is incorrect Key: FLINK-22109 URL: https://issues.apache.org/jira/browse/FLINK-22109

[GitHub] [flink] flinkbot commented on pull request #15489: [FLINK-22106][table-planner-blink] Result type of GeneratedExpression in StringCallGen should be compatible with their definition in FlinkSq

2021-04-05 Thread GitBox
flinkbot commented on pull request #15489: URL: https://github.com/apache/flink/pull/15489#issuecomment-813828058 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Updated] (FLINK-22106) ResultType of GeneratedExpression in StringCallGen should be compatible with their definition in FlinkSqlOperatorTable

2021-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-22106: --- Labels: pull-request-available (was: ) > ResultType of GeneratedExpression in StringCallGen

[GitHub] [flink] TsReaper opened a new pull request #15489: [FLINK-22106][table-planner-blink] Result type of GeneratedExpression in StringCallGen should be compatible with their definition in FlinkSq

2021-04-05 Thread GitBox
TsReaper opened a new pull request #15489: URL: https://github.com/apache/flink/pull/15489 ## What is the purpose of the change Result type of `GeneratedExpression` of most functions in `StringCallGen` is now `VarCharType(VarCharType.MAX_LENGTH)`, which is incompatible with the func

[GitHub] [flink] becketqin commented on pull request #15425: [FLINK-21133][connector/checkpoint] Fix the stop-with-savepoint case …

2021-04-05 Thread GitBox
becketqin commented on pull request #15425: URL: https://github.com/apache/flink/pull/15425#issuecomment-813816909 PR Merged. master a9cf18b4d25f130e0bd24d51b128bbcf71892b45 release-1.13: e129817f290442c6fd7e891a6d28d848ec090050 -- This is an automated message from the Apache Git S

[GitHub] [flink] becketqin closed pull request #15425: [FLINK-21133][connector/checkpoint] Fix the stop-with-savepoint case …

2021-04-05 Thread GitBox
becketqin closed pull request #15425: URL: https://github.com/apache/flink/pull/15425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [flink] leonardBang commented on a change in pull request #15485: [FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute

2021-04-05 Thread GitBox
leonardBang commented on a change in pull request #15485: URL: https://github.com/apache/flink/pull/15485#discussion_r607493086 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java ## @@ -519,18 +520,19 @@ private static void v

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-05 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-813808256 > @fsk119 When you say solve by merging, do you mean to add the `FlinkCalcMergeRule` to the tests? Yes. In `PushFilterIntoTableSourceScanRuleTest`, we also add rule `FILTE

[GitHub] [flink] wuchong commented on a change in pull request #15485: [FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute

2021-04-05 Thread GitBox
wuchong commented on a change in pull request #15485: URL: https://github.com/apache/flink/pull/15485#discussion_r607482453 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java ## @@ -519,18 +520,19 @@ private static void valid

[jira] [Closed] (FLINK-21714) Use TIMESTAMP_LTZ as return type for function PROCTIME()

2021-04-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-21714. --- Fix Version/s: 1.13.0 Resolution: Fixed Fixed in master: 581ffc52b0f449f6ce2490ba662524da401af6ec >

[GitHub] [flink] leonardBang commented on a change in pull request #15485: [FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute

2021-04-05 Thread GitBox
leonardBang commented on a change in pull request #15485: URL: https://github.com/apache/flink/pull/15485#discussion_r607480013 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java ## @@ -519,18 +520,19 @@ private static void v

[GitHub] [flink] wuchong merged pull request #15280: [FLINK-21714][table-api] Use TIMESTAMP_LTZ as return type for function PROCTIME()

2021-04-05 Thread GitBox
wuchong merged pull request #15280: URL: https://github.com/apache/flink/pull/15280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [flink] wuchong commented on pull request #15280: [FLINK-21714][table-api] Use TIMESTAMP_LTZ as return type for function PROCTIME()

2021-04-05 Thread GitBox
wuchong commented on pull request #15280: URL: https://github.com/apache/flink/pull/15280#issuecomment-813803283 Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Assigned] (FLINK-17957) Forbidden syntax "CREATE SYSTEM FUNCTION" for sql parser

2021-04-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-17957: --- Assignee: WeiNan Zhao (was: Shengkai Fang) > Forbidden syntax "CREATE SYSTEM FUNCTION" for sql par

[GitHub] [flink] wangyang0918 edited a comment on pull request #15396: [FLINK-21008][coordination] Register a shutdown supplier in the SignalHandler for ClusterEntrypoint

2021-04-05 Thread GitBox
wangyang0918 edited a comment on pull request #15396: URL: https://github.com/apache/flink/pull/15396#issuecomment-813774645 The failed tests is caused by an old bug of `flink-yarn-tests`. Given that we may run multiple tests(applications) in a Yarn minicluster. If we do not check the `app

[GitHub] [flink] lirui-apache commented on pull request #15482: [FLINK-22103][hive] Fix HiveModuleTest for 1.2.1

2021-04-05 Thread GitBox
lirui-apache commented on pull request #15482: URL: https://github.com/apache/flink/pull/15482#issuecomment-813802031 The failure was not related and my own build passed: https://dev.azure.com/lirui-apache/flink/_build/results?buildId=483&view=results -- This is an automated message

[GitHub] [flink] RocMarshal commented on pull request #15486: [FLINK-21754][core] Fix 'Exception message does not point to the right path.'

2021-04-05 Thread GitBox
RocMarshal commented on pull request #15486: URL: https://github.com/apache/flink/pull/15486#issuecomment-813801814 @klion26 Could you help me to review this PR? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] KarmaGYZ edited a comment on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
KarmaGYZ edited a comment on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813797889 Hi, @sazzad16 . Thanks for opening the PR. However, as the Automated Checks describe, we should first reach a consensus in JIRA ticket and then push the PR. I think you

[GitHub] [flink] KarmaGYZ commented on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
KarmaGYZ commented on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813797889 Hi, @sazzad16 . Thanks for open the PR. However, as the Automated Checks describe, we should first reach a consensus in JIRA ticket and then push the PR. I think you can: 1.

[GitHub] [flink] zicat commented on a change in pull request #15247: [FLINK-21833][Table SQL / Runtime] TemporalRowTimeJoinOperator.java will lead to the state expansion by short-life-cycle & huge Row

2021-04-05 Thread GitBox
zicat commented on a change in pull request #15247: URL: https://github.com/apache/flink/pull/15247#discussion_r607444819 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java #

[GitHub] [flink] wangyang0918 commented on pull request #15396: [FLINK-21008][coordination] Register a shutdown supplier in the SignalHandler for ClusterEntrypoint

2021-04-05 Thread GitBox
wangyang0918 commented on pull request #15396: URL: https://github.com/apache/flink/pull/15396#issuecomment-813774645 I will have a look at the failed Yarn tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [flink] dianfu commented on pull request #15360: [FLINK-21938][docs] Add how to unit test python udfs

2021-04-05 Thread GitBox
dianfu commented on pull request #15360: URL: https://github.com/apache/flink/pull/15360#issuecomment-813770229 Sure. Very sorry for late response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [flink] YikSanChan commented on pull request #15360: [FLINK-21938][docs] Add how to unit test python udfs

2021-04-05 Thread GitBox
YikSanChan commented on pull request #15360: URL: https://github.com/apache/flink/pull/15360#issuecomment-813769741 @dianfu Hi Dian, can you please take a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [flink] PatrickRen commented on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits

2021-04-05 Thread GitBox
PatrickRen commented on pull request #14789: URL: https://github.com/apache/flink/pull/14789#issuecomment-813769577 Already fixed by dc3d0702087c8681435761eed7f2aa9161b09540. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [flink] PatrickRen closed pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits

2021-04-05 Thread GitBox
PatrickRen closed pull request #14789: URL: https://github.com/apache/flink/pull/14789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [flink] flinkbot edited a comment on pull request #15488: [hotfix][docs] Fix max parallelism behavior for Reactive Mode

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15488: URL: https://github.com/apache/flink/pull/15488#issuecomment-813604213 ## CI report: * 043ae9006a77e24cdf3d3fe25990bf8f720eb4dd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] XComp commented on a change in pull request #15131: [FLINK-21700][yarn]Allow to disable fetching Hadoop delegation token on Yarn

2021-04-05 Thread GitBox
XComp commented on a change in pull request #15131: URL: https://github.com/apache/flink/pull/15131#discussion_r607228165 ## File path: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java ## @@ -108,6 +108,19 @@ + "

[GitHub] [flink] flinkbot edited a comment on pull request #15488: [hotfix][docs] Fix max parallelism behavior for Reactive Mode

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15488: URL: https://github.com/apache/flink/pull/15488#issuecomment-813604213 ## CI report: * 043ae9006a77e24cdf3d3fe25990bf8f720eb4dd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813369782 ## CI report: * 1df335955008f00518bc7b82db53f3e5411004cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #15488: [hotfix][docs] Fix max parallelism behavior for Reactive Mode

2021-04-05 Thread GitBox
flinkbot commented on pull request #15488: URL: https://github.com/apache/flink/pull/15488#issuecomment-813604213 ## CI report: * 043ae9006a77e24cdf3d3fe25990bf8f720eb4dd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #15280: [FLINK-21714][table-api] Use TIMESTAMP_LTZ as return type for function PROCTIME()

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15280: URL: https://github.com/apache/flink/pull/15280#issuecomment-802654466 ## CI report: * 3b4b5fcd9d8108b51e0bf62a0bee888b4fdb5186 UNKNOWN * 834e03097f2d964094a866ef5d3cfd2a8d9f8ebe Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] austince edited a comment on pull request #15488: [hotfix][docs] Fix max parallelism behavior for Reactive Mode

2021-04-05 Thread GitBox
austince edited a comment on pull request #15488: URL: https://github.com/apache/flink/pull/15488#issuecomment-813587551 @flinkbot attention @rmetzger (?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [flink] austince commented on pull request #15488: [hotfix][docs] Fix max parallelism behavior for Reactive Mode

2021-04-05 Thread GitBox
austince commented on pull request #15488: URL: https://github.com/apache/flink/pull/15488#issuecomment-813587551 @flinkbot attention rmetzger (?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] flinkbot commented on pull request #15488: [hotfix][docs] Fix max parallelism behavior for Reactive Mode

2021-04-05 Thread GitBox
flinkbot commented on pull request #15488: URL: https://github.com/apache/flink/pull/15488#issuecomment-813585200 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] austince commented on pull request #15488: [hotfix][docs] Fix max parallelism behavior for Reactive Mode

2021-04-05 Thread GitBox
austince commented on pull request #15488: URL: https://github.com/apache/flink/pull/15488#issuecomment-813580563 @rmetzger can you have a look at this when you have a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [flink] austince opened a new pull request #15488: [hotfix][docs] Fix max parallelism behavior for Reactive Mode

2021-04-05 Thread GitBox
austince opened a new pull request #15488: URL: https://github.com/apache/flink/pull/15488 With FLINK-21844, Reactive Mode now has the same behavior when the same max parallelism as the "default" mode. This also includes minor typos/ fixes. Signed-off-by: austin ce ## W

[jira] [Commented] (FLINK-18071) CoordinatorEventsExactlyOnceITCase.checkListContainsSequence fails on CI

2021-04-05 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314987#comment-17314987 ] Kezhu Wang commented on FLINK-18071: Hi all, I pushed a  [poc branch|https://github

[GitHub] [flink] YuvalItzchakov commented on a change in pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-05 Thread GitBox
YuvalItzchakov commented on a change in pull request #15307: URL: https://github.com/apache/flink/pull/15307#discussion_r607193792 ## File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/plan/rules/logical/PushFilterInCalcIntoTableSourceRuleTes

[GitHub] [flink] YuvalItzchakov edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-05 Thread GitBox
YuvalItzchakov edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-813494028 @fsk119 When you say solve by merging, do you mean to add the `FlinkCalcMergeRule` to the tests? -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-05 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-813494028 When you say solve by merging, do you mean to add the `FlinkCalcMergeRule` to the tests? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] flinkbot edited a comment on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813369782 ## CI report: * 54885c6e3c3f413e437038e41166fbc46f8be19e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15466: [FLINK-22003][checkpointing] Prevent checkpoint from starting if any Source isn't running

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15466: URL: https://github.com/apache/flink/pull/15466#issuecomment-811978896 ## CI report: * ad1b080091b48a82188261ef9fab9c4229af4c9a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15280: [FLINK-21714][table-api] Use TIMESTAMP_LTZ as return type for function PROCTIME()

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15280: URL: https://github.com/apache/flink/pull/15280#issuecomment-802654466 ## CI report: * 3b4b5fcd9d8108b51e0bf62a0bee888b4fdb5186 UNKNOWN * 9863aad36d0fd9704c3902d166c548e9adf8b880 Azure: [CANCELED](https://dev.azure.com/apache-f

[GitHub] [flink] XComp commented on pull request #15020: [FLINK-21445][kubernetes] Application mode does not set the configuration when building PackagedProgram

2021-04-05 Thread GitBox
XComp commented on pull request #15020: URL: https://github.com/apache/flink/pull/15020#issuecomment-813454338 Any updates from your side, @SteNicholas ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Comment Edited] (FLINK-21439) Add support for exception history

2021-04-05 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314927#comment-17314927 ] Matthias edited comment on FLINK-21439 at 4/5/21, 3:27 PM: --- Hi

[jira] [Commented] (FLINK-21439) Add support for exception history

2021-04-05 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314927#comment-17314927 ] Matthias commented on FLINK-21439: -- Hi John, thank you for your proposal. You correctly

[GitHub] [flink] wuchong commented on a change in pull request #15485: [FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute

2021-04-05 Thread GitBox
wuchong commented on a change in pull request #15485: URL: https://github.com/apache/flink/pull/15485#discussion_r607112374 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/rank/window/combines/TopNRecordsCombiner.java

[GitHub] [flink] flinkbot edited a comment on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813369782 ## CI report: * 54885c6e3c3f413e437038e41166fbc46f8be19e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15485: [FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15485: URL: https://github.com/apache/flink/pull/15485#issuecomment-812897189 ## CI report: * f805a55185df95368d7a1c1ec80717c5f2202b4c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15280: [FLINK-21714][table-api] Use TIMESTAMP_LTZ as return type for function PROCTIME()

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15280: URL: https://github.com/apache/flink/pull/15280#issuecomment-802654466 ## CI report: * 3b4b5fcd9d8108b51e0bf62a0bee888b4fdb5186 UNKNOWN * 9863aad36d0fd9704c3902d166c548e9adf8b880 Azure: [CANCELED](https://dev.azure.com/apache-f

[jira] [Comment Edited] (FLINK-21464) Support ADD JAR command in sql client

2021-04-05 Thread xiangtao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314917#comment-17314917 ] xiangtao edited comment on FLINK-21464 at 4/5/21, 3:05 PM: --- [~

[jira] [Commented] (FLINK-21464) Support ADD JAR command in sql client

2021-04-05 Thread xiangtao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314917#comment-17314917 ] xiangtao commented on FLINK-21464: -- [~fsk119]  i'm sorry , my reply is a little late . 

[GitHub] [flink] sazzad16 commented on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
sazzad16 commented on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813442209 @rmetzger How to improve from review=[description]? Is there anything I can do from my side? PS: I plan to add documentation after the implementation is finalized.

[GitHub] [flink] flinkbot edited a comment on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813369782 ## CI report: * 6a48a9771278d6babe5f35c4a812e3b4139e172e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15280: [FLINK-21714][table-api] Use TIMESTAMP_LTZ as return type for function PROCTIME()

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15280: URL: https://github.com/apache/flink/pull/15280#issuecomment-802654466 ## CI report: * 3b4b5fcd9d8108b51e0bf62a0bee888b4fdb5186 UNKNOWN * 621905dc52204133a9d610a2d0c9a5f1aeaafd53 Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813369782 ## CI report: * 6a48a9771278d6babe5f35c4a812e3b4139e172e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] fsk119 commented on a change in pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-05 Thread GitBox
fsk119 commented on a change in pull request #15307: URL: https://github.com/apache/flink/pull/15307#discussion_r607091494 ## File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/plan/rules/logical/PushFilterInCalcIntoTableSourceRuleTest.java #

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-05 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-813395188 I just come back from the vacation. For the comment, I think we can solve by merging the two Calc into one Calc with the rule `FlinkCalcMergeRule`. For the second p

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-05 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-813391849 @fsk119 I'll make sure to run it. Did you see my comment regarding the need to push the rule further down after removal of redundant Calc? I also have a problem now

[GitHub] [flink] flinkbot edited a comment on pull request #14678: [FLINK-20833][runtime] Add pluggable failure listener in job manager

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #14678: URL: https://github.com/apache/flink/pull/14678#issuecomment-761905721 ## CI report: * cade20e85b29ca63c51383dca04976c1d9801042 UNKNOWN * af1d7a046e857c17831c4866b0dc83830b5e1ee0 Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-05 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-813390740 > @YuvalItzchakov Do your mind to resolve the complie error first? > > I think you can use the spotless plugin[1] to solve the style problems. > > [1] https://ci.apa

[GitHub] [flink] flinkbot edited a comment on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
flinkbot edited a comment on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813369782 ## CI report: * 6a48a9771278d6babe5f35c4a812e3b4139e172e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
flinkbot commented on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813369782 ## CI report: * 6a48a9771278d6babe5f35c4a812e3b4139e172e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot commented on pull request #15487: [FLINK-15571][connector] [POC] Redis Stream connector for Flink

2021-04-05 Thread GitBox
flinkbot commented on pull request #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-813367231 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Updated] (FLINK-15571) Create a Redis Streams Connector for Flink

2021-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-15571: --- Labels: pull-request-available (was: ) > Create a Redis Streams Connector for Flink > -

  1   2   >