[jira] [Updated] (FLINK-12715) Hive-1.2.1 build is broken

2019-06-03 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Li updated FLINK-12715: --- Description: Some Hive util methods used are not compatible between Hive-2.3.4 and Hive-1.2.1. (was: Some H

[jira] [Commented] (FLINK-10855) CheckpointCoordinator does not delete checkpoint directory of late/failed checkpoints

2019-06-03 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855394#comment-16855394 ] vinoyang commented on FLINK-10855: -- [~till.rohrmann] I have submitted a design draft, i

[GitHub] [flink] dawidwys commented on issue #8585: [FLINK-12690][table-api] Introduce a Planner interface

2019-06-03 Thread GitBox
dawidwys commented on issue #8585: [FLINK-12690][table-api] Introduce a Planner interface URL: https://github.com/apache/flink/pull/8585#issuecomment-498543605 You are right, the `Planner` will need the `CatalogManager` (not only for parse, but also for Table scans). I don't want to add

[GitHub] [flink] twalthr commented on issue #8521: [FLINK-12601][table] Make the DataStream & DataSet conversion to a Table independent from Calcite

2019-06-03 Thread GitBox
twalthr commented on issue #8521: [FLINK-12601][table] Make the DataStream & DataSet conversion to a Table independent from Calcite URL: https://github.com/apache/flink/pull/8521#issuecomment-498543106 @flinkbot approve all T

[GitHub] [flink] flinkbot commented on issue #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-06-03 Thread GitBox
flinkbot commented on issue #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#issuecomment-498542685 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your p

[jira] [Updated] (FLINK-12652) Add Glossary to Concepts Section of Documentation

2019-06-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12652: --- Labels: pull-request-available (was: ) > Add Glossary to Concepts Section of Documentation

[jira] [Created] (FLINK-12724) Add Links to new Concepts Section to Glossary

2019-06-03 Thread Konstantin Knauf (JIRA)
Konstantin Knauf created FLINK-12724: Summary: Add Links to new Concepts Section to Glossary Key: FLINK-12724 URL: https://issues.apache.org/jira/browse/FLINK-12724 Project: Flink Issue T

[GitHub] [flink] knaufk opened a new pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-06-03 Thread GitBox
knaufk opened a new pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607 ## What is the purpose of the change * Part of FLIP-42 * Add a glossary section to the documentation for further reference and to e

[jira] [Comment Edited] (FLINK-10455) Potential Kafka producer leak in case of failures

2019-06-03 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855384#comment-16855384 ] sunjincheng edited comment on FLINK-10455 at 6/4/19 6:31 AM: -

[jira] [Commented] (FLINK-10455) Potential Kafka producer leak in case of failures

2019-06-03 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855384#comment-16855384 ] sunjincheng commented on FLINK-10455: - Currently, we have added an exception capture

[jira] [Updated] (FLINK-10455) Potential Kafka producer leak in case of failures

2019-06-03 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-10455: Attachment: image-2019-06-04-14-25-16-916.png > Potential Kafka producer leak in case of failures

[jira] [Commented] (FLINK-6755) Allow triggering Checkpoints through command line client

2019-06-03 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855369#comment-16855369 ] vinoyang commented on FLINK-6755: - Hi [~till.rohrmann] [~aljoscha] [~gyfora] It seems the

[jira] [Commented] (FLINK-12713) deprecate descriptor, validator, and factory of ExternalCatalog

2019-06-03 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855362#comment-16855362 ] Timo Walther commented on FLINK-12713: -- [~phoenixjiangnan] there is no need to depr

[jira] [Created] (FLINK-12723) Adds a wiki page about setting up a Python Table API development environment

2019-06-03 Thread Dian Fu (JIRA)
Dian Fu created FLINK-12723: --- Summary: Adds a wiki page about setting up a Python Table API development environment Key: FLINK-12723 URL: https://issues.apache.org/jira/browse/FLINK-12723 Project: Flink

[jira] [Updated] (FLINK-12719) Add the Python catalog API

2019-06-03 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-12719: Summary: Add the Python catalog API (was: Add the catalog API for the Python Table API) > Add the Python

[GitHub] [flink] dawidwys commented on a change in pull request #8549: [FLINK-12604][table-api][table-planner] Register TableSource/Sink as CatalogTables

2019-06-03 Thread GitBox
dawidwys commented on a change in pull request #8549: [FLINK-12604][table-api][table-planner] Register TableSource/Sink as CatalogTables URL: https://github.com/apache/flink/pull/8549#discussion_r290133398 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/fli

[jira] [Created] (FLINK-12722) Adds Python Table API tutorial

2019-06-03 Thread Dian Fu (JIRA)
Dian Fu created FLINK-12722: --- Summary: Adds Python Table API tutorial Key: FLINK-12722 URL: https://issues.apache.org/jira/browse/FLINK-12722 Project: Flink Issue Type: Sub-task Component

[GitHub] [flink] flinkbot commented on issue #8606: [FLINK-12721] Process integer type in json format

2019-06-03 Thread GitBox
flinkbot commented on issue #8606: [FLINK-12721] Process integer type in json format URL: https://github.com/apache/flink/pull/8606#issuecomment-498529338 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request.

[GitHub] [flink] aloyszhang opened a new pull request #8606: Process integer type in json format

2019-06-03 Thread GitBox
aloyszhang opened a new pull request #8606: Process integer type in json format URL: https://github.com/apache/flink/pull/8606 ## What is the purpose of the change This PR aims at providing a more precisely way to process `integer` type in JSON format. ## Brief change log

[jira] [Updated] (FLINK-12721) make flink-json more precisely when handle integer type

2019-06-03 Thread aloyszhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] aloyszhang updated FLINK-12721: --- Description: At  present, flink-json convert integer type to `Types.BIG_DEC` which will make some m

[jira] [Created] (FLINK-12721) make flink-json more precisely when handle integer type

2019-06-03 Thread aloyszhang (JIRA)
aloyszhang created FLINK-12721: -- Summary: make flink-json more precisely when handle integer type Key: FLINK-12721 URL: https://issues.apache.org/jira/browse/FLINK-12721 Project: Flink Issue Typ

[jira] [Created] (FLINK-12720) Add the Python Table API Sphinx docs

2019-06-03 Thread Dian Fu (JIRA)
Dian Fu created FLINK-12720: --- Summary: Add the Python Table API Sphinx docs Key: FLINK-12720 URL: https://issues.apache.org/jira/browse/FLINK-12720 Project: Flink Issue Type: Sub-task Com

[GitHub] [flink] godfreyhe commented on issue #8585: [FLINK-12690][table-api] Introduce a Planner interface

2019-06-03 Thread GitBox
godfreyhe commented on issue #8585: [FLINK-12690][table-api] Introduce a Planner interface URL: https://github.com/apache/flink/pull/8585#issuecomment-498524833 hi @dawidwys, there is a minor question: `parse` method in `Planner` class returns validated `TableOperation`, so the `Planner`

[GitHub] [flink] flinkbot commented on issue #8605: [FLINK-9363] bump up flink-shaded-jackson version to 2.9.8-7.0

2019-06-03 Thread GitBox
flinkbot commented on issue #8605: [FLINK-9363] bump up flink-shaded-jackson version to 2.9.8-7.0 URL: https://github.com/apache/flink/pull/8605#issuecomment-498522976 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[jira] [Created] (FLINK-12719) Add the catalog API for the Python Table API

2019-06-03 Thread Dian Fu (JIRA)
Dian Fu created FLINK-12719: --- Summary: Add the catalog API for the Python Table API Key: FLINK-12719 URL: https://issues.apache.org/jira/browse/FLINK-12719 Project: Flink Issue Type: Sub-task

[GitHub] [flink] aloyszhang opened a new pull request #8605: [FLINK-9363] bump up flink-shaded-jackson version to 2.9.8-7.0

2019-06-03 Thread GitBox
aloyszhang opened a new pull request #8605: [FLINK-9363] bump up flink-shaded-jackson version to 2.9.8-7.0 URL: https://github.com/apache/flink/pull/8605 ## What is the purpose of the change This PR is to bump up flink-shaded-jackson version to 2.9.8-7.0, since the flink-shaded proj

[jira] [Commented] (FLINK-12426) TM occasionally hang in deploying state

2019-06-03 Thread Qi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855306#comment-16855306 ] Qi commented on FLINK-12426: [~sunhaibotb] Sure, closed. > TM occasionally hang in deployin

[jira] [Closed] (FLINK-12426) TM occasionally hang in deploying state

2019-06-03 Thread Qi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qi closed FLINK-12426. -- Resolution: Duplicate > TM occasionally hang in deploying state > --- > >

[GitHub] [flink] ifndef-SleePy commented on issue #8582: [FLINK-12681][metrics] Introduce a built-in thread-safe counter

2019-06-03 Thread GitBox
ifndef-SleePy commented on issue #8582: [FLINK-12681][metrics] Introduce a built-in thread-safe counter URL: https://github.com/apache/flink/pull/8582#issuecomment-498512073 Travis checking has been passed. @flinkbot attention @zentol Would you mind take a look?

[jira] [Created] (FLINK-12718) allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog

2019-06-03 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12718: Summary: allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog Key: FLINK-12718 URL: https://issues.apache.org/jira/browse/FLINK-12718

[jira] [Closed] (FLINK-12649) Add a shim layer to support multiple versions of HMS

2019-06-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12649. Resolution: Fixed merged in 1.9.0: 038ab385c6f9af129b5eda7fe05d8b39d6122077 > Add a shim layer to support

[jira] [Closed] (FLINK-12310) shade user facing common libraries in flink-connector-hive

2019-06-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12310. Resolution: Fixed closed since we've changed hive jars' dependencies from "compile" to "provided" > shade

[jira] [Commented] (FLINK-12686) Disentangle StreamGraph/StreamNode and StreamGraphGenerator from StreamExecutionEnvironment

2019-06-03 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855282#comment-16855282 ] Biao Liu commented on FLINK-12686: -- Hi [~aljoscha], yes, there is no setting for slot s

[jira] [Assigned] (FLINK-12686) Disentangle StreamGraph/StreamNode and StreamGraphGenerator from StreamExecutionEnvironment

2019-06-03 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Liu reassigned FLINK-12686: Assignee: Biao Liu > Disentangle StreamGraph/StreamNode and StreamGraphGenerator from > StreamEx

[jira] [Created] (FLINK-12717) Add windows support for the Python shell script

2019-06-03 Thread Dian Fu (JIRA)
Dian Fu created FLINK-12717: --- Summary: Add windows support for the Python shell script Key: FLINK-12717 URL: https://issues.apache.org/jira/browse/FLINK-12717 Project: Flink Issue Type: Sub-task

[GitHub] [flink] danny0405 edited a comment on issue #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

2019-06-03 Thread GitBox
danny0405 edited a comment on issue #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#issuecomment-498509086 @twalthr 1. I agree that remove the colon between ROW type field name and type is more in line with the sql standard

[GitHub] [flink] danny0405 commented on issue #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

2019-06-03 Thread GitBox
danny0405 commented on issue #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#issuecomment-498509086 > @danny0405 Maybe the merging happened too quickly for this PR. It is still not 100% aligned with FLIP-37. We should make sure to d

[jira] [Created] (FLINK-12716) Add an interactive shell for Python Table API

2019-06-03 Thread Dian Fu (JIRA)
Dian Fu created FLINK-12716: --- Summary: Add an interactive shell for Python Table API Key: FLINK-12716 URL: https://issues.apache.org/jira/browse/FLINK-12716 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-12715) Hive-1.2.1 build is broken

2019-06-03 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Li updated FLINK-12715: --- Component/s: Connectors / Hive > Hive-1.2.1 build is broken > -- > >

[GitHub] [flink] lirui-apache commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables

2019-06-03 Thread GitBox
lirui-apache commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r290112999 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/c

[jira] [Commented] (FLINK-12070) Make blocking result partitions consumable multiple times

2019-06-03 Thread Yingjie Cao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855260#comment-16855260 ] Yingjie Cao commented on FLINK-12070: - [~StephanEwen] There is no swap partition in

[jira] [Created] (FLINK-12715) Hive-1.2.1 build is broken

2019-06-03 Thread Rui Li (JIRA)
Rui Li created FLINK-12715: -- Summary: Hive-1.2.1 build is broken Key: FLINK-12715 URL: https://issues.apache.org/jira/browse/FLINK-12715 Project: Flink Issue Type: Sub-task Reporter: Rui

[GitHub] [flink] zjuwangg commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables

2019-06-03 Thread GitBox
zjuwangg commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r290110383 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/conne

[GitHub] [flink] zjuwangg commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables

2019-06-03 Thread GitBox
zjuwangg commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r290110408 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/conne

[GitHub] [flink] zjuwangg commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables

2019-06-03 Thread GitBox
zjuwangg commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r290110147 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/conne

[jira] [Comment Edited] (FLINK-12070) Make blocking result partitions consumable multiple times

2019-06-03 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855252#comment-16855252 ] zhijiang edited comment on FLINK-12070 at 6/4/19 2:59 AM: -- Agre

[GitHub] [flink] zjuwangg commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables

2019-06-03 Thread GitBox
zjuwangg commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r290109929 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/conne

[jira] [Comment Edited] (FLINK-12070) Make blocking result partitions consumable multiple times

2019-06-03 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855252#comment-16855252 ] zhijiang edited comment on FLINK-12070 at 6/4/19 2:58 AM: -- Agre

[jira] [Commented] (FLINK-12070) Make blocking result partitions consumable multiple times

2019-06-03 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855252#comment-16855252 ] zhijiang commented on FLINK-12070: -- Agree with Stephan and Stefan's opinions. We could

[GitHub] [flink] lirui-apache commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

2019-06-03 Thread GitBox
lirui-apache commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589#discussion_r290109158 ## File path: flink-connectors/flink-connector-hive/src/main/java/o

[GitHub] [flink] sunjincheng121 commented on issue #8550: [FLINK-12401][table] Support incremental emit under AccRetract mode for non-window streaming FlatAggregate on Table API

2019-06-03 Thread GitBox
sunjincheng121 commented on issue #8550: [FLINK-12401][table] Support incremental emit under AccRetract mode for non-window streaming FlatAggregate on Table API URL: https://github.com/apache/flink/pull/8550#issuecomment-498498965 HI @hequn8128, Thanks for the PR. Overall, I think I sho

[jira] [Commented] (FLINK-12426) TM occasionally hang in deploying state

2019-06-03 Thread Haibo Sun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855247#comment-16855247 ] Haibo Sun commented on FLINK-12426: --- [~QiLuo],  the pull request of FLINK-12547 has be

[jira] [Closed] (FLINK-12547) Deadlock when the task thread downloads jars using BlobClient

2019-06-03 Thread Haibo Sun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haibo Sun closed FLINK-12547. - > Deadlock when the task thread downloads jars using BlobClient > --

[GitHub] [flink] lirui-apache commented on issue #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

2019-06-03 Thread GitBox
lirui-apache commented on issue #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#issuecomment-498497073 > moreover, please have correct commit message in the future. E.g. the first commit's msg should be "[FLINK-12568][hi

[GitHub] [flink] flinkbot commented on issue #8604: [DOC] add ')' for the doc checkpoints.md

2019-06-03 Thread GitBox
flinkbot commented on issue #8604: [DOC] add ')' for the doc checkpoints.md URL: https://github.com/apache/flink/pull/8604#issuecomment-498496138 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We wil

[GitHub] [flink] hehuiyuan opened a new pull request #8604: [DOC] add ')' for the doc checkpoints.md

2019-06-03 Thread GitBox
hehuiyuan opened a new pull request #8604: [DOC] add ')' for the doc checkpoints.md URL: https://github.com/apache/flink/pull/8604 For `Configure for per job when constructing the state backend`, add ')' This is an automat

[jira] [Commented] (FLINK-10455) Potential Kafka producer leak in case of failures

2019-06-03 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855241#comment-16855241 ] sunjincheng commented on FLINK-10455: - [~becket_qin] is there any update from your s

[GitHub] [flink] sunjincheng121 commented on issue #8550: [FLINK-12401][table] Support incremental emit under AccRetract mode for non-window streaming FlatAggregate on Table API

2019-06-03 Thread GitBox
sunjincheng121 commented on issue #8550: [FLINK-12401][table] Support incremental emit under AccRetract mode for non-window streaming FlatAggregate on Table API URL: https://github.com/apache/flink/pull/8550#issuecomment-498492312 @flinkbot approve description

[GitHub] [flink] flinkbot commented on issue #8603: [FLINK-12608][runtime] Add getVertexOrThrow and

2019-06-03 Thread GitBox
flinkbot commented on issue #8603: [FLINK-12608][runtime] Add getVertexOrThrow and URL: https://github.com/apache/flink/pull/8603#issuecomment-498492126 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. W

[GitHub] [flink] eaglewatcherwb opened a new pull request #8603: [FLINK-12608][runtime] Add getVertexOrThrow and

2019-06-03 Thread GitBox
eaglewatcherwb opened a new pull request #8603: [FLINK-12608][runtime] Add getVertexOrThrow and URL: https://github.com/apache/flink/pull/8603 getResultPartitionOrThrow in SchedulingTopology to simplify code structure Change-Id: I33be923c3279755d360e95336199fb1bc3257f4f

[jira] [Updated] (FLINK-12608) Add getVertex/ResultPartitionOrThrow(ExecutionVertexID/IntermediateResultPartitionID) to SchedulingTopology

2019-06-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12608: --- Labels: pull-request-available (was: ) > Add > getVertex/ResultPartitionOrThrow(ExecutionV

[jira] [Commented] (FLINK-12619) Support TERMINATE/SUSPEND Job with Checkpoint

2019-06-03 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855236#comment-16855236 ] vinoyang commented on FLINK-12619: -- Hi [~klion26] and [~aljoscha] I think this issue ne

[jira] [Commented] (FLINK-1722) Streaming not respecting FinalizeOnMaster for output formats

2019-06-03 Thread Haibo Sun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855222#comment-16855222 ] Haibo Sun commented on FLINK-1722: --  OK, I will. > Streaming not respecting FinalizeOnM

[jira] [Assigned] (FLINK-1722) Streaming not respecting FinalizeOnMaster for output formats

2019-06-03 Thread Haibo Sun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haibo Sun reassigned FLINK-1722: Assignee: Haibo Sun > Streaming not respecting FinalizeOnMaster for output formats > -

[GitHub] [flink] Armstrongya commented on issue #8597: [FLINK-12438][doc-zh]Translate Task Lifecycle into Chinese

2019-06-03 Thread GitBox
Armstrongya commented on issue #8597: [FLINK-12438][doc-zh]Translate Task Lifecycle into Chinese URL: https://github.com/apache/flink/pull/8597#issuecomment-498487430 Hi @klion26 ,I'm confused with this Travis CI build check. I have already rebase and change my commit history, it looks lik

[jira] [Updated] (FLINK-12714) confusion about flink time window TimeWindow#getWindowStartWithOffset

2019-06-03 Thread Wenshuai Hou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenshuai Hou updated FLINK-12714: - Description:   hi flink team, i think the flink doc on how time windows are created and the ja

[jira] [Closed] (FLINK-12712) deprecate ExternalCatalog and its subclasses and impls

2019-06-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12712. Resolution: Fixed merged in 1.9.0: 7682248f6dca971eae1d076dbf0282358331a0e7 > deprecate ExternalCatalog a

[GitHub] [flink] asfgit closed pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog

2019-06-03 Thread GitBox
asfgit closed pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog URL: https://github.com/apache/flink/pull/8601 This is an automated message from the Apache Git Service.

[jira] [Closed] (FLINK-12713) deprecate descriptor, validator, and factory of ExternalCatalog

2019-06-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12713. Resolution: Fixed merged in 1.9.0: 61d8916a35470d6c122d9b78c1f3ae7aa9996949 > deprecate descriptor, valid

[jira] [Created] (FLINK-12714) confusion about flink time window TimeWindow#getWindowStartWithOffset

2019-06-03 Thread Wenshuai Hou (JIRA)
Wenshuai Hou created FLINK-12714: Summary: confusion about flink time window TimeWindow#getWindowStartWithOffset Key: FLINK-12714 URL: https://issues.apache.org/jira/browse/FLINK-12714 Project: Flink

[GitHub] [flink] asfgit closed pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, and related util classes

2019-06-03 Thread GitBox
asfgit closed pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, and related util classes URL: https://github.com/apache/flink/pull/8600 This is an automated message from

[GitHub] [flink] bowenli86 commented on issue #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests

2019-06-03 Thread GitBox
bowenli86 commented on issue #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests URL: https://github.com/apache/flink/pull/8600#issuecomment-498459861 @xuefuz thanks for your review. Merging

[GitHub] [flink] bowenli86 commented on issue #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog

2019-06-03 Thread GitBox
bowenli86 commented on issue #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog URL: https://github.com/apache/flink/pull/8601#issuecomment-498459824 @xuefuz thanks for your review. Addressed all comments. Merging ---

[GitHub] [flink] xuefuz commented on a change in pull request #8549: [FLINK-12604][table-api][table-planner] Register TableSource/Sink as CatalogTables

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8549: [FLINK-12604][table-api][table-planner] Register TableSource/Sink as CatalogTables URL: https://github.com/apache/flink/pull/8549#discussion_r290072835 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apach

[GitHub] [flink] xuefuz commented on a change in pull request #8549: [FLINK-12604][table-api][table-planner] Register TableSource/Sink as CatalogTables

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8549: [FLINK-12604][table-api][table-planner] Register TableSource/Sink as CatalogTables URL: https://github.com/apache/flink/pull/8549#discussion_r290072478 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apach

[GitHub] [flink] xuefuz commented on a change in pull request #8549: [FLINK-12604][table-api][table-planner] Register TableSource/Sink as CatalogTables

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8549: [FLINK-12604][table-api][table-planner] Register TableSource/Sink as CatalogTables URL: https://github.com/apache/flink/pull/8549#discussion_r290072031 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apach

[GitHub] [flink] xuefuz commented on a change in pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog URL: https://github.com/apache/flink/pull/8601#discussion_r290068591 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/

[jira] [Commented] (FLINK-12626) Client should not register table-source-sink twice in TableEnvironment

2019-06-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855095#comment-16855095 ] Bowen Li commented on FLINK-12626: -- [~twalthr] by taking a look at the {{TableEnvImpl.

[GitHub] [flink] bowenli86 commented on issue #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog

2019-06-03 Thread GitBox
bowenli86 commented on issue #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog URL: https://github.com/apache/flink/pull/8601#issuecomment-498431690 @xuefuz as we discussed offline, I removed annotations from tests and leave them for production cod

[GitHub] [flink] bowenli86 commented on issue #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests

2019-06-03 Thread GitBox
bowenli86 commented on issue #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests URL: https://github.com/apache/flink/pull/8600#issuecomment-498431177 @xuefuz as we discussed offline, I removed annotations from tests and

[GitHub] [flink] flinkbot commented on issue #8602: [FLINK-12313] Add workaround to avoid race condition in SynchronousCheckpointITCase test

2019-06-03 Thread GitBox
flinkbot commented on issue #8602: [FLINK-12313] Add workaround to avoid race condition in SynchronousCheckpointITCase test URL: https://github.com/apache/flink/pull/8602#issuecomment-498423773 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the co

[jira] [Updated] (FLINK-12313) SynchronousCheckpointITCase.taskCachedThreadPoolAllowsForSynchronousCheckpoints is unstable

2019-06-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12313: --- Labels: pull-request-available test-stability (was: test-stability) > SynchronousCheckpoint

[GitHub] [flink] 1u0 opened a new pull request #8602: [FLINK-12313] Add workaround to avoid race condition in SynchronousCheckpointITCase test

2019-06-03 Thread GitBox
1u0 opened a new pull request #8602: [FLINK-12313] Add workaround to avoid race condition in SynchronousCheckpointITCase test URL: https://github.com/apache/flink/pull/8602 ## What is the purpose of the change The `SynchronousCheckpointITCase` has a race condition and with some chanc

[jira] [Assigned] (FLINK-12313) SynchronousCheckpointITCase.taskCachedThreadPoolAllowsForSynchronousCheckpoints is unstable

2019-06-03 Thread Alex (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex reassigned FLINK-12313: Assignee: Alex > SynchronousCheckpointITCase.taskCachedThreadPoolAllowsForSynchronousCheckpoints > is un

[GitHub] [flink] asfgit closed pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

2019-06-03 Thread GitBox
asfgit closed pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [flink] bowenli86 commented on issue #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

2019-06-03 Thread GitBox
bowenli86 commented on issue #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#issuecomment-498416544 moreover, please have correct commit message in the future. E.g. the first commit's msg should be "[FLINK-12568][hive] I

[jira] [Commented] (FLINK-12070) Make blocking result partitions consumable multiple times

2019-06-03 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855013#comment-16855013 ] Stefan Richter commented on FLINK-12070: I have one more additional question: ca

[GitHub] [flink] bowenli86 commented on a change in pull request #8549: [FLINK-12604][table-api][table-planner] Register TableSource/Sink as CatalogTables

2019-06-03 Thread GitBox
bowenli86 commented on a change in pull request #8549: [FLINK-12604][table-api][table-planner] Register TableSource/Sink as CatalogTables URL: https://github.com/apache/flink/pull/8549#discussion_r289974528 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/fl

[GitHub] [flink] bowenli86 commented on a change in pull request #8549: [FLINK-12604][table-api][table-planner] Register TableSource/Sink as CatalogTables

2019-06-03 Thread GitBox
bowenli86 commented on a change in pull request #8549: [FLINK-12604][table-api][table-planner] Register TableSource/Sink as CatalogTables URL: https://github.com/apache/flink/pull/8549#discussion_r289972929 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/fl

[GitHub] [flink] xuefuz commented on a change in pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog URL: https://github.com/apache/flink/pull/8601#discussion_r289984057 ## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/

[GitHub] [flink] xuefuz commented on a change in pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog URL: https://github.com/apache/flink/pull/8601#discussion_r289984145 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flin

[GitHub] [flink] xuefuz commented on a change in pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog URL: https://github.com/apache/flink/pull/8601#discussion_r289984202 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flin

[GitHub] [flink] xuefuz commented on a change in pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog URL: https://github.com/apache/flink/pull/8601#discussion_r289983564 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/

[GitHub] [flink] xuefuz commented on a change in pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8601: [FLINK-12713][table] deprecate descriptor, validator, and factory of ExternalCatalog URL: https://github.com/apache/flink/pull/8601#discussion_r289983564 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/

[GitHub] [flink] xuefuz commented on a change in pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests URL: https://github.com/apache/flink/pull/8600#discussion_r289982158 ## File path: flink-table/flink-table-planner

[GitHub] [flink] bowenli86 commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

2019-06-03 Thread GitBox
bowenli86 commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589#discussion_r289982183 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/

[GitHub] [flink] xuefuz commented on a change in pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests URL: https://github.com/apache/flink/pull/8600#discussion_r289982243 ## File path: flink-table/flink-table-planner

[GitHub] [flink] xuefuz commented on a change in pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests URL: https://github.com/apache/flink/pull/8600#discussion_r289982051 ## File path: flink-table/flink-table-planner

[GitHub] [flink] xuefuz commented on a change in pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests URL: https://github.com/apache/flink/pull/8600#discussion_r289981952 ## File path: flink-table/flink-table-planner

[GitHub] [flink] xuefuz commented on a change in pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests

2019-06-03 Thread GitBox
xuefuz commented on a change in pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests URL: https://github.com/apache/flink/pull/8600#discussion_r289981786 ## File path: flink-table/flink-table-planner

  1   2   3   4   >