xuefuz commented on a change in pull request #8600: [FLINK-12712][table] deprecate ExternalCatalog and its subclasses, implementations, related util classes and tests URL: https://github.com/apache/flink/pull/8600#discussion_r289981786
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala ########## @@ -37,7 +37,10 @@ import scala.collection.JavaConverters._ * * @param catalogIdentifier external catalog name * @param catalog external catalog + * + * @deprecated use [[CatalogCalciteSchema]] instead. */ +@deprecated Review comment: Do we need this? I think we don't have to unless this is user facing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
