JingsongLi commented on a change in pull request #8579: [FLINK-12687][Runtime /
Operators] ByteHashSet is always in dense mode
URL: https://github.com/apache/flink/pull/8579#discussion_r289706227
##
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/tab
JingsongLi commented on a change in pull request #8579: [FLINK-12687][Runtime /
Operators] ByteHashSet is always in dense mode
URL: https://github.com/apache/flink/pull/8579#discussion_r289706312
##
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/tab
JingsongLi commented on a change in pull request #8579: [FLINK-12687][Runtime /
Operators] ByteHashSet is always in dense mode
URL: https://github.com/apache/flink/pull/8579#discussion_r289706004
##
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/tab
JingsongLi commented on a change in pull request #8579: [FLINK-12687][Runtime /
Operators] ByteHashSet is always in dense mode
URL: https://github.com/apache/flink/pull/8579#discussion_r289705832
##
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/tab
godfreyhe commented on a change in pull request #8585:
[FLINK-12690][table-api] Introduce a Planner interface
URL: https://github.com/apache/flink/pull/8585#discussion_r289703696
##
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/planner/Planner.j
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289703084
##
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/deployment/ShuffleDescriptorTest.java
###
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289702541
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputG
Rui Li created FLINK-12705:
--
Summary: Allow user to specify the Hive version in use
Key: FLINK-12705
URL: https://issues.apache.org/jira/browse/FLINK-12705
Project: Flink
Issue Type: Sub-task
sunjincheng121 commented on issue #8561: [FLINK-12588][python] Add TableSchema
for Python Table API.
URL: https://github.com/apache/flink/pull/8561#issuecomment-498129664
https://github.com/apache/flink/pull/8474 has merged, please rebase the PR!
thanks! :)
---
flinkbot commented on issue #8593: Distinguish the method of using NC on Linux
and Windows in doc comments.
URL: https://github.com/apache/flink/pull/8593#issuecomment-498129731
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to re
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289701678
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputG
LingangJiang opened a new pull request #8593: Distinguish the method of using
NC on Linux and Windows in doc comments.
URL: https://github.com/apache/flink/pull/8593
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blo
[
https://issues.apache.org/jira/browse/FLINK-12409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sunjincheng closed FLINK-12409.
---
Resolution: Fixed
Fix Version/s: 1.9.0
Fixed in master: f27c40dce0198a21cb933855ed2c7e60d2641
asfgit closed pull request #8474: [FLINK-12409][python] Adds from_elements in
TableEnvironment
URL: https://github.com/apache/flink/pull/8474
This is an automated message from the Apache Git Service.
To respond to the messag
lirui-apache commented on issue #8536: [FLINK-12568][hive] Implement
OutputFormat to write Hive tables
URL: https://github.com/apache/flink/pull/8536#issuecomment-498127122
Thanks @JingsongLi
@bowenli86 do you think we can keep that change in this PR? I'm also fine to
have a separate t
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289698969
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputG
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289697268
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java
##
JingsongLi commented on issue #8536: [FLINK-12568][hive] Implement OutputFormat
to write Hive tables
URL: https://github.com/apache/flink/pull/8536#issuecomment-498123575
> Thanks @JingsongLi , you beat me to the explanation :)
> BTW, I'd like to confirm whether type info instances are s
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289696435
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##
lirui-apache commented on issue #8536: [FLINK-12568][hive] Implement
OutputFormat to write Hive tables
URL: https://github.com/apache/flink/pull/8536#issuecomment-498122419
Thanks @JingsongLi , you beat me to the explanation :)
BTW, I'd like to confirm whether type info instances are sup
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289695493
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputG
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289692905
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputG
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289692905
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputG
lirui-apache commented on issue #8536: [FLINK-12568][hive] Implement
OutputFormat to write Hive tables
URL: https://github.com/apache/flink/pull/8536#issuecomment-498119551
> > > LGTM, but why do we need the commit "fix HiveTypeUtil
[a50ac6e](https://github.com/apache/flink/commit/a50ac6e1
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289692905
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputG
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289692748
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputG
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289692010
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/PartitionInfo.java
###
JingsongLi commented on issue #8536: [FLINK-12568][hive] Implement OutputFormat
to write Hive tables
URL: https://github.com/apache/flink/pull/8536#issuecomment-498118278
I think the problem maybe is:
Although they are static final vars, it will be a new instance after
serialize/deseria
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289691718
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/PartitionInfo.java
###
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289690010
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289690010
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289690010
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory
tzulitai commented on issue #8174: [FLINK-12190] Fix IllegalArgumentException
thrown by FlinkKinesisConsumerMigrationTest#writeSnapshot
URL: https://github.com/apache/flink/pull/8174#issuecomment-498113029
Sorry for the late review on this one. LGTM, +1.
Merging ..
-
yanghua commented on issue #8174: [FLINK-12190] Fix IllegalArgumentException
thrown by FlinkKinesisConsumerMigrationTest#writeSnapshot
URL: https://github.com/apache/flink/pull/8174#issuecomment-498111645
@tzulitai I think this PR can make sense for someone who wants to do the
migration te
shuai-xu commented on a change in pull request #7227: [FLINK-11059] [runtime]
do not add releasing failed slot to free slots
URL: https://github.com/apache/flink/pull/7227#discussion_r289684168
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/Sl
bowenli86 commented on issue #8536: [FLINK-12568][hive] Implement OutputFormat
to write Hive tables
URL: https://github.com/apache/flink/pull/8536#issuecomment-498107285
> > LGTM, but why do we need the commit "fix HiveTypeUtil
[a50ac6e](https://github.com/apache/flink/commit/a50ac6e12af3c
[
https://issues.apache.org/jira/browse/FLINK-12704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sunjincheng updated FLINK-12704:
Description:
Currently, only flink planner is completely supported. But some of the
operators ar
[
https://issues.apache.org/jira/browse/FLINK-12704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sunjincheng updated FLINK-12704:
Description:
Currently, only flink planner is completely supported. But some of the
operators ar
[
https://issues.apache.org/jira/browse/FLINK-12704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sunjincheng updated FLINK-12704:
Description: Currently, only flink planner is completely supported. But
some of the operators are
[
https://issues.apache.org/jira/browse/FLINK-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854193#comment-16854193
]
sunjincheng commented on FLINK-11107:
-
And it's better to merge this before the rele
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289681579
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory
sunjincheng created FLINK-12704:
---
Summary: Support blink planner
Key: FLINK-12704
URL: https://issues.apache.org/jira/browse/FLINK-12704
Project: Flink
Issue Type: Sub-task
Reporter
wisgood commented on a change in pull request #8571: [FLINK-12682][connectors]
StringWriter support custom row delimiter
URL: https://github.com/apache/flink/pull/8571#discussion_r289681108
##
File path:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/str
tzulitai commented on issue #8168: [Flink-11756] Update migration tests for
Flink 1.8
URL: https://github.com/apache/flink/pull/8168#issuecomment-498103830
+1, this looks good to merge!
I've verified that all tests pass, and that all related tests (except the
serializer migration ones e
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289679979
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289679485
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289679485
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory
lirui-apache commented on issue #8536: [FLINK-12568][hive] Implement
OutputFormat to write Hive tables
URL: https://github.com/apache/flink/pull/8536#issuecomment-498101915
Rebased. @bowenli86 please take another look. Thanks.
---
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289679485
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289679319
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289679295
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289678803
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory
klion26 commented on a change in pull request #8479: [FLINK-11193][State
Backends]Use user passed configuration overriding default configuration loading
from file
URL: https://github.com/apache/flink/pull/8479#discussion_r289678234
##
File path:
flink-state-backends/flink-statebac
lirui-apache commented on a change in pull request #8522:
[FLINK-12572][hive]Implement HiveInputFormat to read Hive tables
URL: https://github.com/apache/flink/pull/8522#discussion_r289676889
##
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/c
lirui-apache commented on a change in pull request #8522:
[FLINK-12572][hive]Implement HiveInputFormat to read Hive tables
URL: https://github.com/apache/flink/pull/8522#discussion_r289676257
##
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/c
lirui-apache commented on a change in pull request #8522:
[FLINK-12572][hive]Implement HiveInputFormat to read Hive tables
URL: https://github.com/apache/flink/pull/8522#discussion_r289677187
##
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/c
sunjincheng121 commented on issue #8474: [FLINK-12409][python] Adds
from_elements in TableEnvironment
URL: https://github.com/apache/flink/pull/8474#issuecomment-498098484
Thanks for the rebase, Merging...
This is an automate
Aitozi commented on a change in pull request #8479: [FLINK-11193][State
Backends]Use user passed configuration overriding default configuration loading
from file
URL: https://github.com/apache/flink/pull/8479#discussion_r289677082
##
File path:
flink-state-backends/flink-stateback
Aitozi commented on a change in pull request #8479: [FLINK-11193][State
Backends]Use user passed configuration overriding default configuration loading
from file
URL: https://github.com/apache/flink/pull/8479#discussion_r289677082
##
File path:
flink-state-backends/flink-stateback
sunjincheng121 commented on issue #7227: [FLINK-11059] [runtime] do not add
releasing failed slot to free slots
URL: https://github.com/apache/flink/pull/7227#issuecomment-498097543
@shuai-xu I appreciate if you can have look at the suggestion from
@tillrohrmann !
Since this is a blocke
[
https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854177#comment-16854177
]
vinoyang commented on FLINK-12680:
--
[~pgoyal] OK, Glad to hear this message! I have not
[
https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
vinoyang reassigned FLINK-12680:
Assignee: (was: vinoyang)
> Add timer type to metric system
> ---
[
https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854176#comment-16854176
]
Piyush Goyal edited comment on FLINK-12680 at 6/3/19 3:00 AM:
[
https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854176#comment-16854176
]
Piyush Goyal edited comment on FLINK-12680 at 6/3/19 3:00 AM:
[
https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854176#comment-16854176
]
Piyush Goyal commented on FLINK-12680:
--
thanks [~yanghua] ! If you haven't started
lirui-apache commented on issue #8536: [FLINK-12568][hive] Implement
OutputFormat to write Hive tables
URL: https://github.com/apache/flink/pull/8536#issuecomment-498093979
> LGTM, but why do we need the commit "fix HiveTypeUtil
[a50ac6e](https://github.com/apache/flink/commit/a50ac6e12af3
klion26 commented on a change in pull request #8479: [FLINK-11193][State
Backends]Use user passed configuration overriding default configuration loading
from file
URL: https://github.com/apache/flink/pull/8479#discussion_r289673669
##
File path:
flink-state-backends/flink-statebac
klion26 edited a comment on issue #8592: [FLINK-12438][doc-zh]Translate Task
Lifecycle into Chinese
URL: https://github.com/apache/flink/pull/8592#issuecomment-498093069
@Armstrongya thanks for your contribution, we should use `git rebase`
instead of `git merge` in the history, could you p
klion26 commented on issue #8592: [FLINK-12438][doc-zh]Translate Task Lifecycle
into Chinese
URL: https://github.com/apache/flink/pull/8592#issuecomment-498093069
@Armstrongya thanks for your contribution, we should use `git rebase`
instead of `git merge` in the history.
-
[
https://issues.apache.org/jira/browse/FLINK-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854170#comment-16854170
]
Congxian Qiu(klion26) commented on FLINK-11947:
---
Hi, [~cre...@gmail.com] H
[
https://issues.apache.org/jira/browse/FLINK-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854160#comment-16854160
]
vinoyang commented on FLINK-12341:
--
Hi [~gjy] I'd like to implement this subtask if you
[
https://issues.apache.org/jira/browse/FLINK-12700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854157#comment-16854157
]
vinoyang commented on FLINK-12700:
--
I think it's a valuable suggestion, the repeated do
[
https://issues.apache.org/jira/browse/FLINK-12700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
vinoyang reassigned FLINK-12700:
Assignee: vinoyang
> Nodejs installation suggestions
> ---
>
>
[
https://issues.apache.org/jira/browse/FLINK-12691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854156#comment-16854156
]
vinoyang commented on FLINK-12691:
--
Actually, I have no idea. IMO, it's hard, because i
[
https://issues.apache.org/jira/browse/FLINK-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854154#comment-16854154
]
Liya Fan commented on FLINK-12701:
--
Hi [~josh.bradt], thanks for reporting this problem
[
https://issues.apache.org/jira/browse/FLINK-11612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854150#comment-16854150
]
Jasper Yue commented on FLINK-11612:
I am interesting in this issue. [~shenlang] are
Aitozi commented on issue #8479: [FLINK-11193][State Backends]Use user passed
configuration overriding default configuration loading from file
URL: https://github.com/apache/flink/pull/8479#issuecomment-498031844
Hi @klion26 I refactor the test case to verify this fix work explicitly.
@Ste
Aitozi commented on issue #8455: [FLINK-12284][Network,Metrics]Fix the
incorrect inputBufferUsage metric in credit-based network mode
URL: https://github.com/apache/flink/pull/8455#issuecomment-498017731
Hi @zhijiangW @pnowojski I have addressed your comments. About the
`inPoolUsage` name,
flinkbot commented on issue #8592: [FLINK-12438][doc-zh]Translate Task
Lifecycle into Chinese
URL: https://github.com/apache/flink/pull/8592#issuecomment-498016450
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull
[
https://issues.apache.org/jira/browse/FLINK-12438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-12438:
---
Labels: pull-request-available (was: )
> Translate "Task Lifecycle" page into Chinese
> ---
Armstrongya opened a new pull request #8592: [FLINK-12438][doc-zh]Translate
Task Lifecycle into Chinese
URL: https://github.com/apache/flink/pull/8592
## What is the purpose of the change
This pull request completes the Chinese translation of "Task Lifecycle" from
official d
azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce
shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r289631850
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory
82 matches
Mail list logo
