lirui-apache commented on issue #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#issuecomment-498093979 > LGTM, but why do we need the commit "fix HiveTypeUtil [a50ac6e](https://github.com/apache/flink/commit/a50ac6e12af3c635160fd4ee9ea22a30f8388cef)"? Because those type info instances in `BasicTypeInfo` are not singletons. So it's not safe to check equality with `==`. This caused some problem when I developed the test case (although that test is not the final version in this PR).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
