[GitHub] [flink] JingsongLi commented on issue #8530: [FLINK-12611][table-planner-blink] Make time indicator nullable in blink

2019-05-23 Thread GitBox
JingsongLi commented on issue #8530: [FLINK-12611][table-planner-blink] Make time indicator nullable in blink URL: https://github.com/apache/flink/pull/8530#issuecomment-495495310 @flinkbot attention @KurtYoung This is an au

[GitHub] [flink] flinkbot commented on issue #8530: [FLINK-12611][table-planner-blink] Make time indicator nullable in blink

2019-05-23 Thread GitBox
flinkbot commented on issue #8530: [FLINK-12611][table-planner-blink] Make time indicator nullable in blink URL: https://github.com/apache/flink/pull/8530#issuecomment-495494684 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to re

[jira] [Updated] (FLINK-12611) Make time indicator nullable in blink

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12611: --- Labels: pull-request-available (was: ) > Make time indicator nullable in blink > --

[GitHub] [flink] JingsongLi opened a new pull request #8530: [FLINK-12611][table-planner-blink] Make time indicator nullable in blink

2019-05-23 Thread GitBox
JingsongLi opened a new pull request #8530: [FLINK-12611][table-planner-blink] Make time indicator nullable in blink URL: https://github.com/apache/flink/pull/8530 ## What is the purpose of the change Make time indicator nullable in blink to support agg on TimeIndicator ## Ver

[jira] [Updated] (FLINK-12603) Refactor InputGate interface to remove unnecessary methods

2019-05-23 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-12603: - Description: In order to make abstract InputGate simple for extending new implementations in shuffle se

[GitHub] [flink] sunjincheng121 commented on issue #8528: [hotfix][docs] fix config.zh.md file path error

2019-05-23 Thread GitBox
sunjincheng121 commented on issue #8528: [hotfix][docs] fix config.zh.md file path error URL: https://github.com/apache/flink/pull/8528#issuecomment-495493745 Keep consist with `config.md` see: https://github.com/apache/flink/blob/master/docs/ops/config.md Line 111. --

[jira] [Updated] (FLINK-12603) Refactor InputGate interface to remove unnecessary methods

2019-05-23 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-12603: - Summary: Refactor InputGate interface to remove unnecessary methods (was: Remove getOwningTaskName meth

[jira] [Created] (FLINK-12611) Make time indicator nullable in blink

2019-05-23 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12611: Summary: Make time indicator nullable in blink Key: FLINK-12611 URL: https://issues.apache.org/jira/browse/FLINK-12611 Project: Flink Issue Type: Improvement

[GitHub] [flink] flinkbot commented on issue #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-23 Thread GitBox
flinkbot commented on issue #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#issuecomment-495493460 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] flinkbot commented on issue #8528: [hotfix][docs] fix config.zh.md file path error

2019-05-23 Thread GitBox
flinkbot commented on issue #8528: [hotfix][docs] fix config.zh.md file path error URL: https://github.com/apache/flink/pull/8528#issuecomment-495493467 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. W

[GitHub] [flink] zhijiangW commented on issue #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-23 Thread GitBox
zhijiangW commented on issue #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#issuecomment-495493505 @flinkbot attention @azagrebin This

[jira] [Updated] (FLINK-12603) Remove getOwningTaskName method from InputGate

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12603: --- Labels: pull-request-available (was: ) > Remove getOwningTaskName method from InputGate > -

[GitHub] [flink] zhijiangW opened a new pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-23 Thread GitBox
zhijiangW opened a new pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529 ## What is the purpose of the change *In order to make abstract `InputGate` simple for extending new implementa

[GitHub] [flink] sunjincheng121 opened a new pull request #8528: [hotfix][docs] fix config.zh.md file path error

2019-05-23 Thread GitBox
sunjincheng121 opened a new pull request #8528: [hotfix][docs] fix config.zh.md file path error URL: https://github.com/apache/flink/pull/8528 Just hotfix `config.zh.md` file path error. This is an automated message from the

[GitHub] [flink] sunjincheng121 commented on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

2019-05-23 Thread GitBox
sunjincheng121 commented on issue #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend URL: https://github.com/apache/flink/pull/8472#issuecomment-495485579 @flinkbot approve-until architecture -

[GitHub] [flink] yanghua commented on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-05-23 Thread GitBox
yanghua commented on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#issuecomment-495483854 > @StefanRRichter After thinking seriously, my view of point has changed. > > There are

[jira] [Updated] (FLINK-12610) Introduce planner rules about aggregate

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12610: --- Labels: pull-request-available (was: ) > Introduce planner rules about aggregate >

[GitHub] [flink] godfreyhe opened a new pull request #8527: [FLINK-12610] [table-planner-blink] Introduce planner rules about aggregate

2019-05-23 Thread GitBox
godfreyhe opened a new pull request #8527: [FLINK-12610] [table-planner-blink] Introduce planner rules about aggregate URL: https://github.com/apache/flink/pull/8527 ## What is the purpose of the change *Introduce planner rules about aggregate* ## Brief change log

[GitHub] [flink] flinkbot commented on issue #8527: [FLINK-12610] [table-planner-blink] Introduce planner rules about aggregate

2019-05-23 Thread GitBox
flinkbot commented on issue #8527: [FLINK-12610] [table-planner-blink] Introduce planner rules about aggregate URL: https://github.com/apache/flink/pull/8527#issuecomment-495482203 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] yanghua commented on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-05-23 Thread GitBox
yanghua commented on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#issuecomment-495481836 > About the problem with the SQL test, having the detailed logs from JM/TMs would be helpful.

[jira] [Updated] (FLINK-12610) Introduce planner rules about aggregate

2019-05-23 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-12610: --- Description: This issue aims to introduce planner rules about aggregate, rules include: 1. {{Aggrega

[jira] [Updated] (FLINK-12610) Introduce planner rules about aggregate

2019-05-23 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-12610: --- Description: This issue aims to introduce planner rules about aggregate, rules include: 1. {{Aggrega

[jira] [Updated] (FLINK-12597) Remove the legacy flink-libraries/flink-ml

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12597: --- Labels: pull-request-available (was: ) > Remove the legacy flink-libraries/flink-ml > -

[GitHub] [flink] flinkbot commented on issue #8526: [FLINK-12597][ml] Remove the legacy flink-libraries/flink-ml

2019-05-23 Thread GitBox
flinkbot commented on issue #8526: [FLINK-12597][ml] Remove the legacy flink-libraries/flink-ml URL: https://github.com/apache/flink/pull/8526#issuecomment-495480794 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pu

[jira] [Created] (FLINK-12610) Introduce planner rules about aggregate

2019-05-23 Thread godfrey he (JIRA)
godfrey he created FLINK-12610: -- Summary: Introduce planner rules about aggregate Key: FLINK-12610 URL: https://issues.apache.org/jira/browse/FLINK-12610 Project: Flink Issue Type: New Feature

[GitHub] [flink] c4emmmm opened a new pull request #8526: [FLINK-12597][ml] Remove the legacy flink-libraries/flink-ml

2019-05-23 Thread GitBox
c4e opened a new pull request #8526: [FLINK-12597][ml] Remove the legacy flink-libraries/flink-ml URL: https://github.com/apache/flink/pull/8526 ## What is the purpose of the change This pull request removes the legacy flink-ml and flink-ml-uber in flink-libraries. They

[jira] [Commented] (FLINK-12592) StreamTableEnvironment object has no attribute connect

2019-05-23 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847256#comment-16847256 ] sunjincheng commented on FLINK-12592: - PR #8525 merged in master: 873bb4d63881942676

[GitHub] [flink] asfgit closed pull request #8525: [FLINK-12592][python] Add `--force` for python install.

2019-05-23 Thread GitBox
asfgit closed pull request #8525: [FLINK-12592][python] Add `--force` for python install. URL: https://github.com/apache/flink/pull/8525 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [flink] sunjincheng121 commented on issue #8525: [FLINK-12592][python] Add `--force` for python install.

2019-05-23 Thread GitBox
sunjincheng121 commented on issue #8525: [FLINK-12592][python] Add `--force` for python install. URL: https://github.com/apache/flink/pull/8525#issuecomment-495477921 Thanks for your review @dianfu @flinkbot approve all Merging ---

[jira] [Updated] (FLINK-12609) Align the Python data types with Java

2019-05-23 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-12609: Summary: Align the Python data types with Java (was: Align the data types of Python with Java) > Align t

[GitHub] [flink] asfgit closed pull request #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog

2019-05-23 Thread GitBox
asfgit closed pull request #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog URL: https://github.com/apache/flink/pull/8449 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Closed] (FLINK-12235) Support Hive partition in HiveCatalog

2019-05-23 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12235. Resolution: Fixed merged in 1.9.0: 95e16862822922972f70a710bc09b7ec31c9043b > Support Hive partition in H

[GitHub] [flink] bowenli86 commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog

2019-05-23 Thread GitBox
bowenli86 commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog URL: https://github.com/apache/flink/pull/8449#issuecomment-495472635 Thanks @lirui-apache very much for the PR. LGTM, merging This

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287210624 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287211563 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287213624 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287213289 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287210298 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287212076 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287214355 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287211394 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287214087 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287211242 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287213575 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287212824 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287213121 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flin

[GitHub] [flink] dianfu commented on issue #8525: [FLINK-12592][python] Add `--force` for python install.

2019-05-23 Thread GitBox
dianfu commented on issue #8525: [FLINK-12592][python] Add `--force` for python install. URL: https://github.com/apache/flink/pull/8525#issuecomment-495469674 @sunjincheng121 Thanks a lot for the PR. LGTM. +1 This is an autom

[GitHub] [flink] sunjincheng121 commented on issue #8420: [FLINK-12408][python] Allow to define the data types in Python

2019-05-23 Thread GitBox
sunjincheng121 commented on issue #8420: [FLINK-12408][python] Allow to define the data types in Python URL: https://github.com/apache/flink/pull/8420#issuecomment-495469748 LGTM. +1 to merged. @flinkbot approve all This i

[jira] [Updated] (FLINK-12592) StreamTableEnvironment object has no attribute connect

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12592: --- Labels: pull-request-available test-stability (was: test-stability) > StreamTableEnvironmen

[GitHub] [flink] flinkbot commented on issue #8525: [FLINK-12592][python] Add `--force` for python install.

2019-05-23 Thread GitBox
flinkbot commented on issue #8525: [FLINK-12592][python] Add `--force` for python install. URL: https://github.com/apache/flink/pull/8525#issuecomment-495469411 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull re

[GitHub] [flink] sunjincheng121 opened a new pull request #8525: [FLINK-12592][python] Add `--force` for python install.

2019-05-23 Thread GitBox
sunjincheng121 opened a new pull request #8525: [FLINK-12592][python] Add `--force` for python install. URL: https://github.com/apache/flink/pull/8525 ## What is the purpose of the change For ensuring overwrite the python file when install, in this PR only Add `--force` for python inst

[jira] [Updated] (FLINK-12609) Align the data types of Python with Java

2019-05-23 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-12609: Description: As discussed in  https://github.com/apache/flink/pull/8420#issuecomment-495444623, currently,

[GitHub] [flink] flinkbot commented on issue #8524: [FLINK-12591][test] Fix unstable test case StatsDReporterTest

2019-05-23 Thread GitBox
flinkbot commented on issue #8524: [FLINK-12591][test] Fix unstable test case StatsDReporterTest URL: https://github.com/apache/flink/pull/8524#issuecomment-495466023 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your p

[jira] [Updated] (FLINK-12591) StatsDReporterTest is unstable

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12591: --- Labels: pull-request-available (was: ) > StatsDReporterTest is unstable > -

[GitHub] [flink] ifndef-SleePy opened a new pull request #8524: [FLINK-12591][test] Fix unstable test case StatsDReporterTest

2019-05-23 Thread GitBox
ifndef-SleePy opened a new pull request #8524: [FLINK-12591][test] Fix unstable test case StatsDReporterTest URL: https://github.com/apache/flink/pull/8524 ## What is the purpose of the change * `StatsDReporterTest` is unstable, fix it ## Brief change log * The reason o

[GitHub] [flink] zjuwangg commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
zjuwangg commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287209116 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink

[GitHub] [flink] JingsongLi edited a comment on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-23 Thread GitBox
JingsongLi edited a comment on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#issuecomment-495451358 Hi @aljoscha >I can't really comment too much, also because I think this is probably too b

[jira] [Assigned] (FLINK-12591) StatsDReporterTest is unstable

2019-05-23 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Liu reassigned FLINK-12591: Assignee: Biao Liu > StatsDReporterTest is unstable > -- > >

[GitHub] [flink] link3280 commented on issue #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials

2019-05-23 Thread GitBox
link3280 commented on issue #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials URL: https://github.com/apache/flink/pull/7895#issuecomment-495463426 @aljoscha @tillrohrmann PTAL :hand: This

[GitHub] [flink] zjffdu commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
zjffdu commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287207827 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/b

[GitHub] [flink] zjffdu commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-23 Thread GitBox
zjffdu commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287207827 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/b

[GitHub] [flink] KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation

2019-05-23 Thread GitBox
KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation URL: https://github.com/apache/flink/pull/8499#discussion_r287198862 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation

2019-05-23 Thread GitBox
KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation URL: https://github.com/apache/flink/pull/8499#discussion_r287198770 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation

2019-05-23 Thread GitBox
KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation URL: https://github.com/apache/flink/pull/8499#discussion_r287192634 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation

2019-05-23 Thread GitBox
KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation URL: https://github.com/apache/flink/pull/8499#discussion_r287197122 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation

2019-05-23 Thread GitBox
KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation URL: https://github.com/apache/flink/pull/8499#discussion_r287205339 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation

2019-05-23 Thread GitBox
KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation URL: https://github.com/apache/flink/pull/8499#discussion_r287199074 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation

2019-05-23 Thread GitBox
KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation URL: https://github.com/apache/flink/pull/8499#discussion_r287204228 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation

2019-05-23 Thread GitBox
KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation URL: https://github.com/apache/flink/pull/8499#discussion_r287205763 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation

2019-05-23 Thread GitBox
KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation URL: https://github.com/apache/flink/pull/8499#discussion_r287205902 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation

2019-05-23 Thread GitBox
KurtYoung commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation URL: https://github.com/apache/flink/pull/8499#discussion_r287204423 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] JingsongLi commented on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-23 Thread GitBox
JingsongLi commented on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#issuecomment-495460313 > I would suggest to make this PR as clean as possible, by making the relationship with `TypeInformat

[GitHub] [flink] dianfu commented on issue #8420: [FLINK-12408][python] Allow to define the data types in Python

2019-05-23 Thread GitBox
dianfu commented on issue #8420: [FLINK-12408][python] Allow to define the data types in Python URL: https://github.com/apache/flink/pull/8420#issuecomment-495458864 @sunjincheng121 Make sense to me. Have created an JIRA https://issues.apache.org/jira/browse/FLINK-12609 to track this. --

[jira] [Created] (FLINK-12609) Align the data types of Python with Java

2019-05-23 Thread Dian Fu (JIRA)
Dian Fu created FLINK-12609: --- Summary: Align the data types of Python with Java Key: FLINK-12609 URL: https://issues.apache.org/jira/browse/FLINK-12609 Project: Flink Issue Type: Sub-task

[GitHub] [flink] KurtYoung commented on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-23 Thread GitBox
KurtYoung commented on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#issuecomment-495458585 I would suggest to make this PR as clean as possible, by making the relationship with `TypeInformation

[GitHub] [flink] xuefuz commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog

2019-05-23 Thread GitBox
xuefuz commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog URL: https://github.com/apache/flink/pull/8449#issuecomment-495454778 > Made `ensureTableAndPartitionMatch` static. Several other methods can't be static, unless we pass the needed non-static field a

[jira] [Comment Edited] (FLINK-12592) StreamTableEnvironment object has no attribute connect

2019-05-23 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847196#comment-16847196 ] sunjincheng edited comment on FLINK-12592 at 5/24/19 2:55 AM:

[jira] [Commented] (FLINK-12592) StreamTableEnvironment object has no attribute connect

2019-05-23 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847196#comment-16847196 ] sunjincheng commented on FLINK-12592: - It seems the python code not be updated, due

[jira] [Updated] (FLINK-12592) StreamTableEnvironment object has no attribute connect

2019-05-23 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12592: Attachment: (was: image-2019-05-24-10-46-40-288.png) > StreamTableEnvironment object has no at

[jira] [Updated] (FLINK-12592) StreamTableEnvironment object has no attribute connect

2019-05-23 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12592: Attachment: image-2019-05-24-10-46-40-288.png > StreamTableEnvironment object has no attribute con

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology

2019-05-23 Thread GitBox
eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology URL: https://github.com/apache/flink/pull/8446#discussion_r287198040 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapt

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology

2019-05-23 Thread GitBox
eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology URL: https://github.com/apache/flink/pull/8446#discussion_r287198052 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapt

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology

2019-05-23 Thread GitBox
eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology URL: https://github.com/apache/flink/pull/8446#discussion_r287198013 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapt

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology

2019-05-23 Thread GitBox
eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology URL: https://github.com/apache/flink/pull/8446#discussion_r287198013 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapt

[GitHub] [flink] sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

2019-05-23 Thread GitBox
sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#discussion_r287197990 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.j

[GitHub] [flink] JingsongLi commented on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-23 Thread GitBox
JingsongLi commented on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#issuecomment-495451358 Hi @aljoscha >I can't really comment too much, also because I think this is probably too big to h

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology

2019-05-23 Thread GitBox
eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology URL: https://github.com/apache/flink/pull/8446#discussion_r287197466 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapt

[GitHub] [flink] lirui-apache commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog

2019-05-23 Thread GitBox
lirui-apache commented on issue #8449: [FLINK-12235][hive] Support Hive partition in HiveCatalog URL: https://github.com/apache/flink/pull/8449#issuecomment-495451146 Made `ensureTableAndPartitionMatch` static. Several other methods can't be static, unless we pass the needed non-static fie

[GitHub] [flink] sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

2019-05-23 Thread GitBox
sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#discussion_r287197202 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.j

[GitHub] [flink] yanghua commented on issue #8438: [FLINK-12152] Make the vcore that Application Master used configurable for Flink on YARN

2019-05-23 Thread GitBox
yanghua commented on issue #8438: [FLINK-12152] Make the vcore that Application Master used configurable for Flink on YARN URL: https://github.com/apache/flink/pull/8438#issuecomment-495450204 Actually, IMO, we should not expose this config option via the `flink-conf.yaml`. Because it's no

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology

2019-05-23 Thread GitBox
eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology URL: https://github.com/apache/flink/pull/8446#discussion_r287195543 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapt

[jira] [Assigned] (FLINK-12602) Correct the flink pom `artifactId` config and scala-free check logic

2019-05-23 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng reassigned FLINK-12602: --- Assignee: sunjincheng > Correct the flink pom `artifactId` config and scala-free check logi

[GitHub] [flink] shaoxuan-wang commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-23 Thread GitBox
shaoxuan-wang commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r287195305 ## File path: flink-ml/pom.xml ## @@ -0,0 +1,39 @@ + + +http://maven.apache.org/POM

[jira] [Commented] (FLINK-12607) Introduce a REST API that returns the maxParallelism of a job

2019-05-23 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847179#comment-16847179 ] Congxian Qiu(klion26) commented on FLINK-12607: --- Thanks for filing the iss

[GitHub] [flink] sunjincheng121 commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-23 Thread GitBox
sunjincheng121 commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#issuecomment-495445962 The CI was failed, I restarted it! This is an autom

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology

2019-05-23 Thread GitBox
eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology URL: https://github.com/apache/flink/pull/8446#discussion_r287191741 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapt

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology

2019-05-23 Thread GitBox
eaglewatcherwb commented on a change in pull request #8446: [FLINK-12414] [runtime] Implement ExecutionGraph to SchedulingTopology URL: https://github.com/apache/flink/pull/8446#discussion_r287191514 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adapt

[GitHub] [flink] sunjincheng121 commented on issue #8420: [FLINK-12408][python] Allow to define the data types in Python

2019-05-23 Thread GitBox
sunjincheng121 commented on issue #8420: [FLINK-12408][python] Allow to define the data types in Python URL: https://github.com/apache/flink/pull/8420#issuecomment-495444623 Thanks for the quick update @dianfu! one more suggestion is could you open a new JIRA for you mentioned in ` shou

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-23 Thread GitBox
eaglewatcherwb commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r287190944 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strateg

[GitHub] [flink] sunjincheng121 commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-23 Thread GitBox
sunjincheng121 commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#issuecomment-495444010 @flinkbot approve-until architecture This is an auto

  1   2   3   4   >