[jira] [Created] (FLINK-12189) Fix bugs and typos in memory management related classes

2019-04-14 Thread Liya Fan (JIRA)
Liya Fan created FLINK-12189: Summary: Fix bugs and typos in memory management related classes Key: FLINK-12189 URL: https://issues.apache.org/jira/browse/FLINK-12189 Project: Flink Issue Type: B

[GitHub] [flink] hequn8128 commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-14 Thread GitBox
hequn8128 commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r275223611 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/Row

[GitHub] [flink] dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-14 Thread GitBox
dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r275222573 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvir

[jira] [Created] (FLINK-12188) Flink Deployment Docs to GCP is not updated for 2 years..

2019-04-14 Thread Chethan U (JIRA)
Chethan U created FLINK-12188: - Summary: Flink Deployment Docs to GCP is not updated for 2 years.. Key: FLINK-12188 URL: https://issues.apache.org/jira/browse/FLINK-12188 Project: Flink Issue Typ

[GitHub] [flink] dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-14 Thread GitBox
dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r275221999 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/TableEnvIm

[GitHub] [flink] KurtYoung commented on a change in pull request #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch

2019-04-14 Thread GitBox
KurtYoung commented on a change in pull request #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch URL: https://github.com/apache/flink/pull/8156#discussion_r275220462 ## File path: flink-table/flink-table-planner-blink/src/main/scal

[GitHub] [flink] hequn8128 commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-14 Thread GitBox
hequn8128 commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r275209599 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/rules/da

[GitHub] [flink] hequn8128 commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-14 Thread GitBox
hequn8128 commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r275203624 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/PlannerCo

[GitHub] [flink] zhijiangW commented on issue #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService

2019-04-14 Thread GitBox
zhijiangW commented on issue #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService URL: https://github.com/apache/flink/pull/8133#issuecomment-483101546 @azagrebin thanks for reviews and the good inline suggestions!

[GitHub] [flink] wuchong commented on issue #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-14 Thread GitBox
wuchong commented on issue #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#issuecomment-483101236 @flinkbot approve all. +1 to merge. Wait until Travis turns green. ---

[GitHub] [flink] zhijiangW commented on a change in pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService

2019-04-14 Thread GitBox
zhijiangW commented on a change in pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService URL: https://github.com/apache/flink/pull/8133#discussion_r275201901 ## File path: flink-runtime/src/main/java/o

[GitHub] [flink] zhijiangW commented on a change in pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService

2019-04-14 Thread GitBox
zhijiangW commented on a change in pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService URL: https://github.com/apache/flink/pull/8133#discussion_r275201785 ## File path: flink-runtime/src/main/java/o

[GitHub] [flink] wuchong commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-14 Thread GitBox
wuchong commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r275200993 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/TableEnvImp

[GitHub] [flink] sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-14 Thread GitBox
sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r275196822 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/run

[jira] [Updated] (FLINK-11107) [state] Avoid memory stateBackend to create arbitrary folders under HA path when no checkpoint path configured

2019-04-14 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-11107: - Priority: Blocker (was: Major) Fix Version/s: (was: 1.6.5) (was: 1.7

[jira] [Updated] (FLINK-3991) Remove deprecated configuration keys from ConfigConstants

2019-04-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-3991: -- Labels: pull-request-available (was: ) > Remove deprecated configuration keys from ConfigConst

[GitHub] [flink] flinkbot commented on issue #8172: [FLINK-3991]Remove deprecated configuration keys from ConfigConstants

2019-04-14 Thread GitBox
flinkbot commented on issue #8172: [FLINK-3991]Remove deprecated configuration keys from ConfigConstants URL: https://github.com/apache/flink/pull/8172#issuecomment-483097540 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revie

[GitHub] [flink] wuchong commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-14 Thread GitBox
wuchong commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r275199185 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/PlannerConf

[GitHub] [flink] wuchong commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-14 Thread GitBox
wuchong commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r275199185 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/PlannerConf

[GitHub] [flink] tianchen92 opened a new pull request #8172: [FLINK-3991]Remove deprecated configuration keys from ConfigConstants

2019-04-14 Thread GitBox
tianchen92 opened a new pull request #8172: [FLINK-3991]Remove deprecated configuration keys from ConfigConstants URL: https://github.com/apache/flink/pull/8172 ## What is the purpose of the change * related to [FLINK-3991](https://issues.apache.org/jira/browse/FLINK-3991). Remo

[GitHub] [flink] KurtYoung commented on a change in pull request #8165: [FLINK-12185] [table-planner-blink] Add support for generating optimized logical plan for join on stream

2019-04-14 Thread GitBox
KurtYoung commented on a change in pull request #8165: [FLINK-12185] [table-planner-blink] Add support for generating optimized logical plan for join on stream URL: https://github.com/apache/flink/pull/8165#discussion_r275198200 ## File path: flink-table/flink-table-planner-blink/

[GitHub] [flink] sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-14 Thread GitBox
sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r275198093 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/run

[GitHub] [flink] KurtYoung commented on a change in pull request #8157: [FLINK-12170] [table-planner-blink] Add support for generating optimized logical plan for Over aggregate

2019-04-14 Thread GitBox
KurtYoung commented on a change in pull request #8157: [FLINK-12170] [table-planner-blink] Add support for generating optimized logical plan for Over aggregate URL: https://github.com/apache/flink/pull/8157#discussion_r275196545 ## File path: flink-table/flink-table-planner-blink/

[GitHub] [flink] KurtYoung commented on a change in pull request #8157: [FLINK-12170] [table-planner-blink] Add support for generating optimized logical plan for Over aggregate

2019-04-14 Thread GitBox
KurtYoung commented on a change in pull request #8157: [FLINK-12170] [table-planner-blink] Add support for generating optimized logical plan for Over aggregate URL: https://github.com/apache/flink/pull/8157#discussion_r275196609 ## File path: flink-table/flink-table-planner-blink/

[GitHub] [flink] sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-14 Thread GitBox
sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r275196822 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/run

[GitHub] [flink] beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-14 Thread GitBox
beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r275196149 ## File path: flink-table/flink-table-runtime-blink/src

[GitHub] [flink] flinkbot commented on issue #8171: [FLINK-9542]ExEnv#registerCachedFile should accept Path

2019-04-14 Thread GitBox
flinkbot commented on issue #8171: [FLINK-9542]ExEnv#registerCachedFile should accept Path URL: https://github.com/apache/flink/pull/8171#issuecomment-483092523 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull re

[jira] [Updated] (FLINK-9542) ExEnv#registerCachedFile should accept Path

2019-04-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9542: -- Labels: pull-request-available (was: ) > ExEnv#registerCachedFile should accept Path > ---

[GitHub] [flink] tianchen92 opened a new pull request #8171: [FLINK-9542]ExEnv#registerCachedFile should accept Path

2019-04-14 Thread GitBox
tianchen92 opened a new pull request #8171: [FLINK-9542]ExEnv#registerCachedFile should accept Path URL: https://github.com/apache/flink/pull/8171 ## What is the purpose of the change *related to [FLINK-9542](https://issues.apache.org/jira/browse/FLINK-9542). Modify the Distr

[GitHub] [flink] zjffdu commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode

2019-04-14 Thread GitBox
zjffdu commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode URL: https://github.com/apache/flink/pull/8144#issuecomment-483088606 @tillrohrmann I checked the `flink-yarn-tests` module, we have yarn test in non-secure mode. But the tricky th

[GitHub] [flink] JingsongLi commented on a change in pull request #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch

2019-04-14 Thread GitBox
JingsongLi commented on a change in pull request #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch URL: https://github.com/apache/flink/pull/8156#discussion_r275187480 ## File path: flink-table/flink-table-planner-blink/src/main/sca

[jira] [Comment Edited] (FLINK-10333) Rethink ZooKeeper based stores (SubmittedJobGraph, MesosWorker, CompletedCheckpoints)

2019-04-14 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817441#comment-16817441 ] TisonKun edited comment on FLINK-10333 at 4/14/19 8:30 PM: --- [~

[jira] [Commented] (FLINK-10333) Rethink ZooKeeper based stores (SubmittedJobGraph, MesosWorker, CompletedCheckpoints)

2019-04-14 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817441#comment-16817441 ] TisonKun commented on FLINK-10333: -- [~till.rohrmann] I draft a document about using tra

[GitHub] [flink] zzchun opened a new pull request #8170: [hotfix] [typo] fix typo in debugging_event_time

2019-04-14 Thread GitBox
zzchun opened a new pull request #8170: [hotfix] [typo] fix typo in debugging_event_time URL: https://github.com/apache/flink/pull/8170 ## What is the purpose of the change Fix typos in debugging_event_time.md ## Verifying this change This change is a trivial rework / c

[GitHub] [flink] flinkbot commented on issue #8170: [hotfix] [typo] fix typo in debugging_event_time

2019-04-14 Thread GitBox
flinkbot commented on issue #8170: [hotfix] [typo] fix typo in debugging_event_time URL: https://github.com/apache/flink/pull/8170#issuecomment-482985111 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request.

[GitHub] [flink] haf commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-14 Thread GitBox
haf commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-482967569 @Xeli No worries as all, I'm getting it for free, right? :) Happy to reference this fr

[GitHub] [flink] Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-14 Thread GitBox
Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-482959975 Hi @haf Apologies for the late response but thank you for trying/testing the connec

[GitHub] [flink] KurtYoung commented on a change in pull request #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch

2019-04-14 Thread GitBox
KurtYoung commented on a change in pull request #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch URL: https://github.com/apache/flink/pull/8156#discussion_r275146308 ## File path: flink-table/flink-table-planner-blink/src/main/scal

[GitHub] [flink] KurtYoung commented on a change in pull request #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch

2019-04-14 Thread GitBox
KurtYoung commented on a change in pull request #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch URL: https://github.com/apache/flink/pull/8156#discussion_r275146373 ## File path: flink-table/flink-table-runtime-blink/src/main/java

[GitHub] [flink] KurtYoung commented on a change in pull request #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch

2019-04-14 Thread GitBox
KurtYoung commented on a change in pull request #8156: [FLINK-12168][table-planner-blink] Support e2e limit, sortLimit, rank, union in blink batch URL: https://github.com/apache/flink/pull/8156#discussion_r275146297 ## File path: flink-table/flink-table-planner-blink/src/main/scal

[GitHub] [flink] yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-14 Thread GitBox
yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275145014 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoi

[GitHub] [flink] yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-14 Thread GitBox
yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275144408 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoord

[GitHub] [flink] yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-14 Thread GitBox
yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275144132 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java

[GitHub] [flink] flinkbot commented on issue #8169: [hotfix][utils] Remove overwork LeaderRetrievalUtils.getRecoverMode

2019-04-14 Thread GitBox
flinkbot commented on issue #8169: [hotfix][utils] Remove overwork LeaderRetrievalUtils.getRecoverMode URL: https://github.com/apache/flink/pull/8169#issuecomment-482926659 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] TisonKun opened a new pull request #8169: [hotfix][utils] Remove overwork LeaderRetrievalUtils.getRecoverMode

2019-04-14 Thread GitBox
TisonKun opened a new pull request #8169: [hotfix][utils] Remove overwork LeaderRetrievalUtils.getRecoverMode URL: https://github.com/apache/flink/pull/8169 ## What is the purpose of the change `LeaderRetrievalUtils.getRecoverMode` is an alias of `HighAvailabilityMode.fromConfig`. H

[GitHub] [flink] yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-14 Thread GitBox
yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275143507 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java

[jira] [Commented] (FLINK-10785) Update FlinkKinesisConsumerMigrationTest for 1.7

2019-04-14 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817209#comment-16817209 ] vinoyang commented on FLINK-10785: -- When I update this migration test for Flink 1.8. I