[GitHub] [flink] hequn8128 commented on issue #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-09 Thread GitBox
hequn8128 commented on issue #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#issuecomment-481558633 @dawidwys Cool. Great job for the `ExpressionResolver` and `ResolverRules`. I will rebase this PR soon. Thank you for letting

[jira] [Assigned] (FLINK-12149) Support Proto for Streaming File Sink

2019-04-09 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-12149: Assignee: vinoyang > Support Proto for Streaming File Sink > ---

[GitHub] [flink] dawidwys commented on issue #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-09 Thread GitBox
dawidwys commented on issue #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#issuecomment-481556068 Hi @hequn8128, The commit(413e3feb786df9b0df951eae7e942ac45ba3d22a) that introduces `ExpressionResolver` and `ResolverRules` w

[GitHub] [flink] yanghua closed pull request #7990: [FLINK-5018] Make source idle timeout user configurable

2019-04-09 Thread GitBox
yanghua closed pull request #7990: [FLINK-5018] Make source idle timeout user configurable URL: https://github.com/apache/flink/pull/7990 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [flink] yanghua commented on issue #7990: [FLINK-5018] Make source idle timeout user configurable

2019-04-09 Thread GitBox
yanghua commented on issue #7990: [FLINK-5018] Make source idle timeout user configurable URL: https://github.com/apache/flink/pull/7990#issuecomment-481554455 @tzulitai OK, agree, have closed. This is an automated message fr

[jira] [Updated] (FLINK-12131) Resetting ExecutionVertex in region failover may cause inconsistency of IntermediateResult status

2019-04-09 Thread Zhu Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-12131: Description: Currently the *IntermediateResult* status is only reset when its producer *ExecutionJobVerte

[GitHub] [flink] tzulitai commented on issue #7990: [FLINK-5018] Make source idle timeout user configurable

2019-04-09 Thread GitBox
tzulitai commented on issue #7990: [FLINK-5018] Make source idle timeout user configurable URL: https://github.com/apache/flink/pull/7990#issuecomment-481552760 I've discussed this a bit with @aljoscha offline, and we still don't feel comfortable with enabling this yet. It's still somet

[jira] [Commented] (FLINK-12118) Documentation in left navigation is not in step with its content

2019-04-09 Thread Ji Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814102#comment-16814102 ] Ji Liu commented on FLINK-12118: This is because the release branch for 1.8 was already

[jira] [Commented] (FLINK-10130) How to define two hdfs name-node IPs in flink-conf.yaml file

2019-04-09 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814097#comment-16814097 ] Liya Fan commented on FLINK-10130: -- [~Paul Lin] is right. HDFS name service solves the

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273804286 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flin

[GitHub] [flink] tzulitai commented on a change in pull request #8106: [FLINK-12092] [docs]Clarity when `onTimer(...)` is called

2019-04-09 Thread GitBox
tzulitai commented on a change in pull request #8106: [FLINK-12092] [docs]Clarity when `onTimer(...)` is called URL: https://github.com/apache/flink/pull/8106#discussion_r273802245 ## File path: docs/dev/stream/operators/process_function.md ## @@ -44,8 +44,8 @@ For fault-t

[jira] [Commented] (FLINK-11776) Refactor to simplify the process of scheduleOrUpdateConsumers

2019-04-09 Thread Zhu Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814081#comment-16814081 ] Zhu Zhu commented on FLINK-11776: - Nice catch. With this change duplicated partitions up

[GitHub] [flink] tzulitai commented on issue #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend

2019-04-09 Thread GitBox
tzulitai commented on issue #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend URL: https://github.com/apache/flink/pull/8122#issuecomment-481546917 LGTM, merging .. --

[jira] [Updated] (FLINK-10391) MillisOfDay is used in place of instant for LocalTime ctor in AvroKryoSerializerUtils

2019-04-09 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated FLINK-10391: - Attachment: image-2019-04-10-13-54-13-788.png > MillisOfDay is used in place of instant for LocalTime ct

[jira] [Commented] (FLINK-10391) MillisOfDay is used in place of instant for LocalTime ctor in AvroKryoSerializerUtils

2019-04-09 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814075#comment-16814075 ] Liya Fan commented on FLINK-10391: -- The current implementation already uses  org.joda.t

[jira] [Updated] (FLINK-10929) Add support for Apache Arrow

2019-04-09 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated FLINK-10929: - Attachment: image-2019-04-10-13-43-08-107.png > Add support for Apache Arrow > -

[GitHub] [flink] flinkbot edited a comment on issue #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend

2019-04-09 Thread GitBox
flinkbot edited a comment on issue #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend URL: https://github.com/apache/flink/pull/8122#issuecomment-480782903 Thanks a lot for your contribution to the Apache Flink project. I

[GitHub] [flink] tzulitai commented on issue #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend

2019-04-09 Thread GitBox
tzulitai commented on issue #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend URL: https://github.com/apache/flink/pull/8122#issuecomment-481540886 @flinkbot approve architecture @flinkbot approve quality ---

[GitHub] [flink] tzulitai commented on a change in pull request #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend

2019-04-09 Thread GitBox
tzulitai commented on a change in pull request #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend URL: https://github.com/apache/flink/pull/8122#discussion_r273795477 ## File path: flink-runtime/src/main/java/or

[GitHub] [flink] tzulitai commented on a change in pull request #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend

2019-04-09 Thread GitBox
tzulitai commented on a change in pull request #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend URL: https://github.com/apache/flink/pull/8122#discussion_r273795301 ## File path: flink-runtime/src/main/java/or

[GitHub] [flink] tzulitai commented on a change in pull request #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend

2019-04-09 Thread GitBox
tzulitai commented on a change in pull request #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend URL: https://github.com/apache/flink/pull/8122#discussion_r273794431 ## File path: flink-runtime/src/main/java/or

[GitHub] [flink] tzulitai removed a comment on issue #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend

2019-04-09 Thread GitBox
tzulitai removed a comment on issue #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend URL: https://github.com/apache/flink/pull/8122#issuecomment-481538012 @carp84 changes look good to me now, +1. Will merge this

[GitHub] [flink] tzulitai commented on issue #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend

2019-04-09 Thread GitBox
tzulitai commented on issue #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend URL: https://github.com/apache/flink/pull/8122#issuecomment-481538012 @carp84 changes look good to me now, +1. Will merge this ..

[jira] [Commented] (FLINK-11813) Standby per job mode Dispatchers don't know job's JobSchedulingStatus

2019-04-09 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814052#comment-16814052 ] TisonKun commented on FLINK-11813: -- [~zhuzh] It looks like an ingenious perspective. Wi

[GitHub] [flink] Ryantaocer commented on issue #8125: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSourceTask

2019-04-09 Thread GitBox
Ryantaocer commented on issue #8125: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSourceTask URL: https://github.com/apache/flink/pull/8125#issuecomment-481534396 Hi @StefanRRichter, we finally get a green travis. Could you help to merge it? Thanks! -

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273789325 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273788265 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273789023 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273788360 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[jira] [Commented] (FLINK-5428) Decrease restart delay in RecoveryITCase

2019-04-09 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814037#comment-16814037 ] Liya Fan commented on FLINK-5428: - Now this UT can be finished in 3s, so this issue can b

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273787827 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273787458 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273786622 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flin

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273762720 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flin

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273785242 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flin

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273781418 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flin

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273786560 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flin

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273784986 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flin

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273781229 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flin

[jira] [Commented] (FLINK-11813) Standby per job mode Dispatchers don't know job's JobSchedulingStatus

2019-04-09 Thread Zhu Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814030#comment-16814030 ] Zhu Zhu commented on FLINK-11813: - I think PENDING and RUNNING together with null(or NON

[GitHub] [flink] flinkbot commented on issue #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService

2019-04-09 Thread GitBox
flinkbot commented on issue #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService URL: https://github.com/apache/flink/pull/8133#issuecomment-481528194 Thanks a lot for your contribution to the Apache Flink project. I'm the

[jira] [Updated] (FLINK-12146) Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService

2019-04-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12146: --- Labels: pull-request-available (was: ) > Remove unregister task from NetworkEnvironment to

[GitHub] [flink] zhijiangW opened a new pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService

2019-04-09 Thread GitBox
zhijiangW opened a new pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService URL: https://github.com/apache/flink/pull/8133 ## What is the purpose of the change *`NetworkEnvironment#unregisterTask` is us

[GitHub] [flink] beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-09 Thread GitBox
beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r273783736 ## File path: flink-table/flink-table-runtime-blink/src

[GitHub] [flink] beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-09 Thread GitBox
beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r273782377 ## File path: flink-table/flink-table-runtime-blink/src

[GitHub] [flink] tianchen92 edited a comment on issue #8121: [FLINK-10437]Some of keys under withDeprecatedKeys aren't marked as @…

2019-04-09 Thread GitBox
tianchen92 edited a comment on issue #8121: [FLINK-10437]Some of keys under withDeprecatedKeys aren't marked as @… URL: https://github.com/apache/flink/pull/8121#issuecomment-481077070 hi, @fhueske could you please help review this PR? thx!

[jira] [Commented] (FLINK-7916) Remove NetworkStackThroughputITCase

2019-04-09 Thread Ji Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814021#comment-16814021 ] Ji Liu commented on FLINK-7916: --- [~till.rohrmann] Absolutely, in the long run it's a better

[GitHub] [flink] flinkbot commented on issue #8132: [FLINK-7916]Remove NetworkStackThroughputITCase

2019-04-09 Thread GitBox
flinkbot commented on issue #8132: [FLINK-7916]Remove NetworkStackThroughputITCase URL: https://github.com/apache/flink/pull/8132#issuecomment-481522402 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. W

[jira] [Updated] (FLINK-7916) Remove NetworkStackThroughputITCase

2019-04-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-7916: -- Labels: pull-request-available (was: ) > Remove NetworkStackThroughputITCase > ---

[GitHub] [flink] tianchen92 opened a new pull request #8132: [FLINK-7916]Remove NetworkStackThroughputITCase

2019-04-09 Thread GitBox
tianchen92 opened a new pull request #8132: [FLINK-7916]Remove NetworkStackThroughputITCase URL: https://github.com/apache/flink/pull/8132 ## What is the purpose of the change *related to [FLINK-7916](https://issues.apache.org/jira/browse/FLINK-7916) establish a "benchmark" mo

[GitHub] [flink] beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-09 Thread GitBox
beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r273780363 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-09 Thread GitBox
beyond1920 commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r273780309 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-09 Thread GitBox
JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r273778387 ## File path: flink-table/flink-table-runtime-blink/src

[GitHub] [flink] JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-09 Thread GitBox
JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r273778026 ## File path: flink-table/flink-table-runtime-blink/src

[GitHub] [flink] JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-09 Thread GitBox
JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r27302 ## File path: flink-table/flink-table-runtime-blink/src

[GitHub] [flink] JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-09 Thread GitBox
JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r273777448 ## File path: flink-table/flink-table-runtime-blink/src

[GitHub] [flink] JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-09 Thread GitBox
JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r273776462 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-09 Thread GitBox
JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r273777288 ## File path: flink-table/flink-table-runtime-blink/src

[GitHub] [flink] JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-09 Thread GitBox
JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r273775150 ## File path: flink-table/flink-table-planner-blink/src

[GitHub] [flink] JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-09 Thread GitBox
JingsongLi commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r273777158 ## File path: flink-table/flink-table-runtime-blink/src

[jira] [Commented] (FLINK-11831) Separate CodeGeneratorContext for different generation targets

2019-04-09 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813998#comment-16813998 ] Liya Fan commented on FLINK-11831: -- Hi [~ykt836], thank you for opening this issue. I t

[GitHub] [flink] an0 commented on a change in pull request #8106: [FLINK-12092] [docs]Clarity when `onTimer(...)` is called

2019-04-09 Thread GitBox
an0 commented on a change in pull request #8106: [FLINK-12092] [docs]Clarity when `onTimer(...)` is called URL: https://github.com/apache/flink/pull/8106#discussion_r273766880 ## File path: docs/dev/stream/operators/process_function.md ## @@ -44,8 +44,8 @@ For fault-tolera

[jira] [Commented] (FLINK-12145) Host config in flink-web is incorrect

2019-04-09 Thread Ji Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813986#comment-16813986 ] Ji Liu commented on FLINK-12145: [~fhueske] alright, I raised this issue just because 0.

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
sunjincheng121 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273762199 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flin

[jira] [Updated] (FLINK-12150) Flink on mesos failed to created TaskManager while cache directory is gone

2019-04-09 Thread JackHe (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JackHe updated FLINK-12150: --- Description: Fetcher tries to fetch files from local cache directory in order to bring up a new TaskManager

[jira] [Updated] (FLINK-12150) Flink on mesos failed to created TaskManager while cache directory is gone

2019-04-09 Thread JackHe (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JackHe updated FLINK-12150: --- Attachment: stderr (10) > Flink on mesos failed to created TaskManager while cache directory is gone > -

[jira] [Created] (FLINK-12150) Flink on mesos failed to created TaskManager while cache directory is gone

2019-04-09 Thread JackHe (JIRA)
JackHe created FLINK-12150: -- Summary: Flink on mesos failed to created TaskManager while cache directory is gone Key: FLINK-12150 URL: https://issues.apache.org/jira/browse/FLINK-12150 Project: Flink

[GitHub] [flink] alpinegizmo commented on a change in pull request #8106: [FLINK-12092] [docs]Clarity when `onTimer(...)` is called

2019-04-09 Thread GitBox
alpinegizmo commented on a change in pull request #8106: [FLINK-12092] [docs]Clarity when `onTimer(...)` is called URL: https://github.com/apache/flink/pull/8106#discussion_r273737265 ## File path: docs/dev/stream/operators/process_function.md ## @@ -44,8 +44,8 @@ For faul

[GitHub] [flink] chunhui-shi commented on issue #7844: [FLINK-10932][ResourceManager] Initial flink-kubernetes module with e…

2019-04-09 Thread GitBox
chunhui-shi commented on issue #7844: [FLINK-10932][ResourceManager] Initial flink-kubernetes module with e… URL: https://github.com/apache/flink/pull/7844#issuecomment-481453539 Thanks for the interests in this PR. I have talked with Till offline and Till gave some feed back to the comple

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273667180 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273667746 ## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273667037 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] GJL commented on issue #8131: [FLINK-12123][tests] Upgrade Jepsen to 0.1.13

2019-04-09 Thread GitBox
GJL commented on issue #8131: [FLINK-12123][tests] Upgrade Jepsen to 0.1.13 URL: https://github.com/apache/flink/pull/8131#issuecomment-481378679 Merging as soon as build is green. This is an automated message from the Apache

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273642509 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-09 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r273642509 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-09 Thread GitBox
haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-481330654 When I run this code with Flink 1.7, I get this critical error when things crash:

[GitHub] [flink] haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-09 Thread GitBox
haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-481330654 When I run this code with Flink 1.7, I get this critical error when things crash:

[GitHub] [flink] haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-09 Thread GitBox
haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-481330654 When I run this code with Flink 1.7, I get this critical error when things crash:

[jira] [Created] (FLINK-12149) Support Proto for Streaming File Sink

2019-04-09 Thread Kailash Hassan Dayanand (JIRA)
Kailash Hassan Dayanand created FLINK-12149: --- Summary: Support Proto for Streaming File Sink Key: FLINK-12149 URL: https://issues.apache.org/jira/browse/FLINK-12149 Project: Flink

[GitHub] [flink] haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-09 Thread GitBox
haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-481330654 When I run this code with Flink 1.7, I get this critical error when things crash:

[GitHub] [flink] haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-09 Thread GitBox
haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-481330654 When I run this code with Flink 1.7, I get this critical error when things crash:

[GitHub] [flink] haf commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-09 Thread GitBox
haf commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-481330654 When I run this code with Flink 1.7, I get this critical error when things crash: ```

[jira] [Commented] (FLINK-12084) Flink API extensions do not seems to include split method

2019-04-09 Thread Jacopo Gobbi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813597#comment-16813597 ] Jacopo Gobbi commented on FLINK-12084: -- Sorry, I was not aware of the deprecation,

[jira] [Resolved] (FLINK-12084) Flink API extensions do not seems to include split method

2019-04-09 Thread Jacopo Gobbi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Gobbi resolved FLINK-12084. -- Resolution: Won't Fix > Flink API extensions do not seems to include split method > --

[jira] [Commented] (FLINK-11843) Dispatcher fails to recover jobs if leader change happens during JobManagerRunner termination

2019-04-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813582#comment-16813582 ] Till Rohrmann commented on FLINK-11843: --- The problem actually not only occurs if t

[GitHub] [flink] azagrebin closed pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-04-09 Thread GitBox
azagrebin closed pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889 This is an automated message from the Apache Git Service. To respond to

[jira] [Comment Edited] (FLINK-11843) Dispatcher fails to recover jobs if leader change happens during JobManagerRunner termination

2019-04-09 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813562#comment-16813562 ] Andrey Zagrebin edited comment on FLINK-11843 at 4/9/19 3:50 PM: -

[jira] [Commented] (FLINK-11843) Dispatcher fails to recover jobs if leader change happens during JobManagerRunner termination

2019-04-09 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813562#comment-16813562 ] Andrey Zagrebin commented on FLINK-11843: - As discussed in [PR|https://github.co

[jira] [Commented] (FLINK-11665) Flink fails to remove JobGraph from ZK even though it reports it did

2019-04-09 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813552#comment-16813552 ] Andrey Zagrebin commented on FLINK-11665: - As discussed in [PR|https://github.co

[GitHub] [flink] azagrebin commented on issue #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-04-09 Thread GitBox
azagrebin commented on issue #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#issuecomment-481307684 Thanks for the reviews @tillrohrmann @TisonKun I agree to address this issue with the more proper design in the

[GitHub] [flink] TisonKun commented on issue #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-04-09 Thread GitBox
TisonKun commented on issue #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#issuecomment-481278785 @tillrohrmann > I would like to make the Dispatcher not being used across leader sessions and instead creati

[GitHub] [flink] flinkbot edited a comment on issue #8131: [FLINK-12123][tests] Upgrade Jepsen to 0.1.13

2019-04-09 Thread GitBox
flinkbot edited a comment on issue #8131: [FLINK-12123][tests] Upgrade Jepsen to 0.1.13 URL: https://github.com/apache/flink/pull/8131#issuecomment-481252344 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull reque

[GitHub] [flink] tillrohrmann commented on issue #8131: [FLINK-12123][tests] Upgrade Jepsen to 0.1.13

2019-04-09 Thread GitBox
tillrohrmann commented on issue #8131: [FLINK-12123][tests] Upgrade Jepsen to 0.1.13 URL: https://github.com/apache/flink/pull/8131#issuecomment-481275520 @flinkbot approve all This is an automated message from the Apache Git

[GitHub] [flink] tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-04-09 Thread GitBox
tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#discussion_r262437718 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatch

[GitHub] [flink] tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-04-09 Thread GitBox
tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#discussion_r262440270 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatch

[GitHub] [flink] tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-04-09 Thread GitBox
tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#discussion_r262440942 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatch

[GitHub] [flink] tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-04-09 Thread GitBox
tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#discussion_r262442875 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/ZooKeepe

[GitHub] [flink] tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-04-09 Thread GitBox
tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#discussion_r262441482 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/ZooKeepe

[GitHub] [flink] tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-04-09 Thread GitBox
tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#discussion_r262443043 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/ZooKeepe

[GitHub] [flink] tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-04-09 Thread GitBox
tillrohrmann commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#discussion_r262443984 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/ZooKeepe

  1   2   3   >