tzulitai commented on a change in pull request #8122: [FLINK-12121] [State
Backends] Use composition instead of inheritance for the InternalKeyContext
logic in backend
URL: https://github.com/apache/flink/pull/8122#discussion_r273795477
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/StateTable.java
##########
@@ -199,6 +208,6 @@ public void
setMetaInfo(RegisteredKeyValueStateBackendMetaInfo<N, S> metaInfo) {
@Nonnull
@Override
public StateSnapshotKeyGroupReader keyGroupReader(int readVersion) {
- return StateTableByKeyGroupReaders.readerForVersion(this,
readVersion);
+ return StateTableByKeyGroupReaders.readerForVersion(this,
readVersion, keySerializer);
Review comment:
Same here, seems redundant to pass in the key serializer since we're passing
in the state table already. Maybe we should have `getKeySerializer` on
`StateTable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
