[jira] [Commented] (FLINK-7916) Remove NetworkStackThroughputITCase

2019-04-07 Thread LiuJi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812155#comment-16812155 ] LiuJi commented on FLINK-7916: -- Agree, I think move these tests to _org.apache.flink.test.ma

[GitHub] [flink] KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480705151 I don't think it's an optimization. I would say it's intuition every reader will have in the first pla

[GitHub] [flink] dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-07 Thread GitBox
dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272903193 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/t

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272878771 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Table.java

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272875577 ## File path: docs/dev/table/tableApi.md ## @@ -1847,6 +1847,22 @@ Table table = input

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272877997 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Table.java

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272899748 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/OperationT

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272878971 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.s

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272877780 ## File path: docs/dev/table/tableApi.md ## @@ -1847,6 +1847,22 @@ Table table = input

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272878215 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Table.java

[GitHub] [flink] dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-07 Thread GitBox
dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272902524 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/t

[GitHub] [flink] dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-07 Thread GitBox
dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272901252 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/t

[GitHub] [flink] JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480702530 >> As I said before, you can immediately determine the left and right boundary with currentIndex - pr

[GitHub] [flink] JingsongLi edited a comment on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
JingsongLi edited a comment on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480702530 >> As I said before, you can immediately determine the left and right boundary with currentInd

[jira] [Commented] (FLINK-9787) Change ExecutionConfig#getGlobalJobParameters to return an instance of GlobalJobParameters instead of null if no custom globalJobParameters are set yet

2019-04-07 Thread LiuJi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812145#comment-16812145 ] LiuJi commented on FLINK-9787: -- Agree, it's a good idea to avoid NPE when invoke getGlobalJ

[jira] [Updated] (FLINK-12120) Support queries like "select sum(b), count(c) from T group by a" run in batch mode

2019-04-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12120: --- Labels: pull-request-available (was: ) > Support queries like "select sum(b), count(c) from

[GitHub] [flink] KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480699105 I think the problem is the methods you proposed: `isLeftBoundRowInWindow` and `isRightBoundRowInWindow

[GitHub] [flink] flinkbot commented on issue #8120: [FLINK-12120][table-planner-blink] Support queries like "select sum(b), count(c) from T group by a" run in batch mode

2019-04-07 Thread GitBox
flinkbot commented on issue #8120: [FLINK-12120][table-planner-blink] Support queries like "select sum(b), count(c) from T group by a" run in batch mode URL: https://github.com/apache/flink/pull/8120#issuecomment-480699193 Thanks a lot for your contribution to the Apache Flink project. I'm

[jira] [Commented] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted

2019-04-07 Thread LiuJi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812138#comment-16812138 ] LiuJi commented on FLINK-10437: --- You mean we should check all classes which use _withDepre

[GitHub] [flink] JingsongLi opened a new pull request #8120: [FLINK-12120][table-planner-blink] Introduce "select sum(b), count(c) from T group by a" in Blink batch

2019-04-07 Thread GitBox
JingsongLi opened a new pull request #8120: [FLINK-12120][table-planner-blink] Introduce "select sum(b), count(c) from T group by a" in Blink batch URL: https://github.com/apache/flink/pull/8120 ## What is the purpose of the change Introduce "select sum(b), count(c) from T group by a

[jira] [Updated] (FLINK-12120) Support queries like "select sum(b), count(c) from T group by a" run in batch mode

2019-04-07 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-12120: --- Summary: Support queries like "select sum(b), count(c) from T group by a" run in batch mode (was: I

[jira] [Created] (FLINK-12120) Introduce "select sum(b), count(c) from T group by a" in Blink batch

2019-04-07 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12120: Summary: Introduce "select sum(b), count(c) from T group by a" in Blink batch Key: FLINK-12120 URL: https://issues.apache.org/jira/browse/FLINK-12120 Project: Flink

[GitHub] [flink] zhijiangW commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-07 Thread GitBox
zhijiangW commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272894672 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NetworkEn

[GitHub] [flink] JingsongLi edited a comment on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
JingsongLi edited a comment on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480694448 Consider a new `BaseSlidingOverFrame`: It has two abstract method: 1.`public abstract boo

[GitHub] [flink] JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480694448 Consider a new `BaseSlidingOverFrame`: It has two abstract method: 1.`public abstract boolean is

[GitHub] [flink] KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480690209 Isn't `(currentIndex - precedingCount, currentIndex + followingCount) enough for RowSlidingOverFrame?

[GitHub] [flink] KurtYoung edited a comment on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
KurtYoung edited a comment on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480690209 Isn't `(currentIndex - precedingCount, currentIndex + followingCount)` enough for RowSlidingOve

[jira] [Commented] (FLINK-8801) S3's eventual consistent read-after-write may fail yarn deployment of resources to S3

2019-04-07 Thread Tao Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812100#comment-16812100 ] Tao Yang commented on FLINK-8801: - Hi, [~till.rohrmann]. Could you please take a look at

[jira] [Commented] (FLINK-4785) Flink string parser doesn't handle string fields containing two consecutive double quotes

2019-04-07 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812098#comment-16812098 ] Liya Fan commented on FLINK-4785: - Hi [~f.pompermaier], it seems the url is no longer val

[jira] [Commented] (FLINK-11964) Avoid hash collision of partition and bucket in HybridHashTable in Blink SQL

2019-04-07 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812085#comment-16812085 ] Liya Fan commented on FLINK-11964: -- Hi [~lzljs3620320], this is a good point, because t

[GitHub] [flink] JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480671968 > Why `RowSlidingOverFrame` needs a comparator class? Don't need a comparator class, but need a

[GitHub] [flink] JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480671767 > Why `RowSlidingOverFrame` needs a comparator class? consider sql: `order by c range Unboun

[GitHub] [flink] JingsongLi removed a comment on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
JingsongLi removed a comment on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480671767 > Why `RowSlidingOverFrame` needs a comparator class? consider sql: `order by c rang

[GitHub] [flink] KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480670657 Why `RowSlidingOverFrame` needs a comparator class? --

[jira] [Closed] (FLINK-12081) Introduce aggregation operator code generator to blink batch

2019-04-07 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12081. -- Resolution: Implemented Fix Version/s: 1.9.0 fixed in 518cf6a10ba105d655de738ce5fccc5fffc8e8a6

[GitHub] [flink] KurtYoung closed pull request #8099: [FLINK-12081][table-planner-blink] Introduce aggregation operator code generator to blink batch

2019-04-07 Thread GitBox
KurtYoung closed pull request #8099: [FLINK-12081][table-planner-blink] Introduce aggregation operator code generator to blink batch URL: https://github.com/apache/flink/pull/8099 This is an automated message from the Apache

[GitHub] [flink] KurtYoung commented on a change in pull request #8110: [FLINK-12098] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on stream

2019-04-07 Thread GitBox
KurtYoung commented on a change in pull request #8110: [FLINK-12098] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on stream URL: https://github.com/apache/flink/pull/8110#discussion_r272871831 ## File path: flink-table/flink-ta

[GitHub] [flink] KurtYoung commented on a change in pull request #8110: [FLINK-12098] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on stream

2019-04-07 Thread GitBox
KurtYoung commented on a change in pull request #8110: [FLINK-12098] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on stream URL: https://github.com/apache/flink/pull/8110#discussion_r272872792 ## File path: flink-table/flink-ta

[GitHub] [flink] KurtYoung commented on a change in pull request #8110: [FLINK-12098] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on stream

2019-04-07 Thread GitBox
KurtYoung commented on a change in pull request #8110: [FLINK-12098] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on stream URL: https://github.com/apache/flink/pull/8110#discussion_r272871786 ## File path: flink-table/flink-ta

[GitHub] [flink] zhijiangW commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-07 Thread GitBox
zhijiangW commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272871749 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NetworkEn

[GitHub] [flink] zhijiangW commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-07 Thread GitBox
zhijiangW commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272871749 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NetworkEn

[jira] [Comment Edited] (FLINK-12113) User code passing to fromCollection(Iterator, Class) not cleaned

2019-04-07 Thread yankai zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812049#comment-16812049 ] yankai zhang edited comment on FLINK-12113 at 4/8/19 2:43 AM:

[jira] [Comment Edited] (FLINK-12113) User code passing to fromCollection(Iterator, Class) not cleaned

2019-04-07 Thread yankai zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812049#comment-16812049 ] yankai zhang edited comment on FLINK-12113 at 4/8/19 2:40 AM:

[jira] [Commented] (FLINK-12113) User code passing to fromCollection(Iterator, Class) not cleaned

2019-04-07 Thread yankai zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812049#comment-16812049 ] yankai zhang commented on FLINK-12113: -- Interesting. I guess maybe java has some op

[GitHub] [flink] hequn8128 commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272864780 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/

[GitHub] [flink] hequn8128 commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272864780 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/

[GitHub] [flink] hequn8128 commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272868599 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/

[GitHub] [flink] hequn8128 commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272863163 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/

[GitHub] [flink] hequn8128 commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272863996 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/

[GitHub] [flink] hequn8128 commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-07 Thread GitBox
hequn8128 commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272863189 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/

[jira] [Commented] (FLINK-10684) Improve the CSV reading process

2019-04-07 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812036#comment-16812036 ] Liya Fan commented on FLINK-10684: -- In my opinion, it may be reasonable not to print in

[jira] [Commented] (FLINK-4859) Clearly Separate Responsibilities of StreamOperator and StreamTask

2019-04-07 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812032#comment-16812032 ] Liya Fan commented on FLINK-4859: - Hi [~aljoscha], would you please give more description

[GitHub] [flink] JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-07 Thread GitBox
JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480660556 @KurtYoung I think that even with `RowSlidingOverFrame` and `RangeSlidingOverFrame`, still need a

[jira] [Closed] (FLINK-12094) Introduce sort merge join operator to blink batch

2019-04-07 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12094. -- Resolution: Implemented Fix Version/s: 1.9.0 fixed in 63876fbedfa52e7e6d6439384bfaca5aa5137d8b

[GitHub] [flink] KurtYoung closed pull request #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch

2019-04-07 Thread GitBox
KurtYoung closed pull request #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch URL: https://github.com/apache/flink/pull/8107 This is an automated message from the Apache Git Servic

[GitHub] [flink] JingsongLi commented on issue #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch

2019-04-07 Thread GitBox
JingsongLi commented on issue #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch URL: https://github.com/apache/flink/pull/8107#issuecomment-480657547 (To checks failed) I've passed the test in offline. --

[GitHub] [flink] Myasuka commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-04-07 Thread GitBox
Myasuka commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#discussion_r272844294 ## File path: flink-filesystems/flink-azure-fs-hadoop/src/main/java/org/apache/flink/fs/azurefs/AbstractAzu

[GitHub] [flink] Myasuka commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-04-07 Thread GitBox
Myasuka commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#discussion_r272843960 ## File path: flink-filesystems/flink-azure-fs-hadoop/src/test/java/org/apache/flink/fs/azurefs/AzureFileSy

[GitHub] [flink] Myasuka commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-04-07 Thread GitBox
Myasuka commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#discussion_r272843786 ## File path: flink-filesystems/flink-azure-fs-hadoop/src/main/java/org/apache/flink/fs/azurefs/AbstractAzu

[jira] [Commented] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted

2019-04-07 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811909#comment-16811909 ] TisonKun commented on FLINK-10437: -- [~tianchen92] it's still our case at least as descr

[jira] [Commented] (FLINK-10049) Unify the processing logic for NULL arguments in SQL built-in functions

2019-04-07 Thread LiuJi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811903#comment-16811903 ] LiuJi commented on FLINK-10049: --- It seems string functions in different SQL engines may ha

[jira] [Comment Edited] (FLINK-10049) Unify the processing logic for NULL arguments in SQL built-in functions

2019-04-07 Thread LiuJi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811903#comment-16811903 ] LiuJi edited comment on FLINK-10049 at 4/7/19 2:53 PM: --- It seems s

[jira] [Commented] (FLINK-10684) Improve the CSV reading process

2019-04-07 Thread LiuJi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811901#comment-16811901 ] LiuJi commented on FLINK-10684: --- Hi,[~xccui] Is there any update on this issue? As you sai

[jira] [Commented] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted

2019-04-07 Thread LiuJi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811899#comment-16811899 ] LiuJi commented on FLINK-10437: --- Hi [~Tison] Does the problem still exist? if so, I would

[jira] [Commented] (FLINK-12113) User code passing to fromCollection(Iterator, Class) not cleaned

2019-04-07 Thread Guowei Ma (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811892#comment-16811892 ] Guowei Ma commented on FLINK-12113: --- I can't reproduce your problem.    !image-2019-

[jira] [Updated] (FLINK-12113) User code passing to fromCollection(Iterator, Class) not cleaned

2019-04-07 Thread Guowei Ma (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guowei Ma updated FLINK-12113: -- Attachment: image-2019-04-07-21-52-37-264.png > User code passing to fromCollection(Iterator, Class) n

[GitHub] [flink] GJL closed pull request #8119: Release 1.7

2019-04-07 Thread GitBox
GJL closed pull request #8119: Release 1.7 URL: https://github.com/apache/flink/pull/8119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (FLINK-6263) Leader error in Kafka producer on leader change (broker restart/failrue)

2019-04-07 Thread Tim (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811692#comment-16811692 ] Tim commented on FLINK-6263: Any updates on this problem? > Leader error in Kafka producer o