dawidwys commented on a change in pull request #8062: [FLINK-11884][table]
Implement expression resolution on top of new Expressions
URL: https://github.com/apache/flink/pull/8062#discussion_r272901252
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/ApiExpressionUtils.java
##########
@@ -78,12 +83,12 @@ public static SymbolExpression symbol(TableSymbol symbol) {
return new SymbolExpression(symbol);
}
- public static UnresolvedFieldReferenceExpression
unresolvedFieldRef(String name) {
- return new UnresolvedFieldReferenceExpression(name);
+ public static UnresolvedReferenceExpression unresolvedFieldRef(String
name) {
+ return new UnresolvedReferenceExpression(name);
}
public static TableReferenceExpression tableRef(String name, Table
table) {
Review comment:
I agree it is worth unifying java and scala, but in this case I think it is
better to aim for the scala behavior. Mostly because the table might not
necessarily be registered in the catalog (might be just an "in place" query),
in this case we cannot resolve the table by name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
