[GitHub] [flink] JingsongLi commented on a change in pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch

2019-03-27 Thread GitBox
JingsongLi commented on a change in pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch URL: https://github.com/apache/flink/pull/8066#discussion_r269875537 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/a

[GitHub] [flink] JingsongLi commented on a change in pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch

2019-03-27 Thread GitBox
JingsongLi commented on a change in pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch URL: https://github.com/apache/flink/pull/8066#discussion_r269875309 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/a

[GitHub] [flink] JingsongLi commented on issue #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink

2019-03-27 Thread GitBox
JingsongLi commented on issue #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink URL: https://github.com/apache/flink/pull/8056#issuecomment-477471711 @KurtYoung Thanks your comments, I have fixed them.

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
sunjincheng121 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269874310 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/tabl

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
sunjincheng121 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269873295 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/tabl

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
sunjincheng121 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269872958 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/tabl

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269872671 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Ta

[jira] [Commented] (FLINK-12025) Support FOR SYSTEM_TIME AS OF in temporal table

2019-03-27 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803626#comment-16803626 ] vinoyang commented on FLINK-12025: -- [~twalthr] What's your idea about this issue? Do yo

[jira] [Commented] (FLINK-9607) Support ParquetTableSink

2019-03-27 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803621#comment-16803621 ] vinoyang commented on FLINK-9607: - Look forward to your contribution. Have assigned to yo

[jira] [Assigned] (FLINK-9607) Support ParquetTableSink

2019-03-27 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-9607: --- Assignee: Zhenqiu Huang (was: Guibo Pan) > Support ParquetTableSink > > >

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
sunjincheng121 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269869862 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/tabl

[jira] [Updated] (FLINK-12042) RocksDBStateBackend mistakenly uses default filesystem

2019-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12042: --- Labels: pull-request-available (was: ) > RocksDBStateBackend mistakenly uses default filesy

[GitHub] [flink] link3280 opened a new pull request #8068: [FLINK-12042] Fix RocksDBStateBackend's mistaken usage of default filesystem

2019-03-27 Thread GitBox
link3280 opened a new pull request #8068: [FLINK-12042] Fix RocksDBStateBackend's mistaken usage of default filesystem URL: https://github.com/apache/flink/pull/8068 ## What is the purpose of the change The scheme of SnapshotDirectory is not specified when RocksDBStateBackend is

[GitHub] [flink] KurtYoung commented on a change in pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch URL: https://github.com/apache/flink/pull/8066#discussion_r269868173 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/ap

[GitHub] [flink] flinkbot commented on issue #8068: [FLINK-12042] Fix RocksDBStateBackend's mistaken usage of default filesystem

2019-03-27 Thread GitBox
flinkbot commented on issue #8068: [FLINK-12042] Fix RocksDBStateBackend's mistaken usage of default filesystem URL: https://github.com/apache/flink/pull/8068#issuecomment-477463547 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community t

[GitHub] [flink] KurtYoung commented on a change in pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch URL: https://github.com/apache/flink/pull/8066#discussion_r269868098 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/ap

[GitHub] [flink] KurtYoung commented on a change in pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch URL: https://github.com/apache/flink/pull/8066#discussion_r269867445 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/ap

[GitHub] [flink] KurtYoung commented on a change in pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch URL: https://github.com/apache/flink/pull/8066#discussion_r269865873 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/ap

[jira] [Updated] (FLINK-12042) RocksDBStateBackend mistakenly uses default filesystem

2019-03-27 Thread Paul Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Lin updated FLINK-12042: - Affects Version/s: 1.8.0 1.7.2 > RocksDBStateBackend mistakenly uses default file

[jira] [Commented] (FLINK-11746) Add thrift format support in Flink

2019-03-27 Thread Yu Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803603#comment-16803603 ] Yu Yang commented on FLINK-11746: - [~tiwalter]  Could you help to review this PR?  > Ad

[GitHub] [flink] hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269861796 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269861784 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269861792 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269861806 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269861826 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api

[GitHub] [flink] hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269861779 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269861768 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269861771 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269861814 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api

[GitHub] [flink] hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269861790 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269861761 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[GitHub] [flink] hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
hequn8128 commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269861776 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api

[jira] [Created] (FLINK-12042) RocksDBStateBackend mistakenly uses default filesystem

2019-03-27 Thread Paul Lin (JIRA)
Paul Lin created FLINK-12042: Summary: RocksDBStateBackend mistakenly uses default filesystem Key: FLINK-12042 URL: https://issues.apache.org/jira/browse/FLINK-12042 Project: Flink Issue Type: Bu

[GitHub] [flink] flinkbot commented on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink

2019-03-27 Thread GitBox
flinkbot commented on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink URL: https://github.com/apache/flink/pull/8067#issuecomment-477454313 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[GitHub] [flink] yuyang08 opened a new pull request #8067: [FLINK-11746][formats] Add thrift format support to Flink

2019-03-27 Thread GitBox
yuyang08 opened a new pull request #8067: [FLINK-11746][formats] Add thrift format support to Flink URL: https://github.com/apache/flink/pull/8067 ## What is the purpose of the change `org.apache.flink.api.java.typeutils.TypeExtractor` is not able to construct TypeInformation correc

[jira] [Updated] (FLINK-11746) Add thrift format support in Flink

2019-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11746: --- Labels: pull-request-available (was: ) > Add thrift format support in Flink > -

[GitHub] [flink] KurtYoung commented on a change in pull request #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink URL: https://github.com/apache/flink/pull/8056#discussion_r269846302 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/tab

[GitHub] [flink] KurtYoung commented on a change in pull request #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink URL: https://github.com/apache/flink/pull/8056#discussion_r269845575 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/tab

[GitHub] [flink] KurtYoung commented on a change in pull request #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink URL: https://github.com/apache/flink/pull/8056#discussion_r269857820 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/tab

[GitHub] [flink] KurtYoung commented on a change in pull request #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink URL: https://github.com/apache/flink/pull/8056#discussion_r269845314 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/tab

[GitHub] [flink] KurtYoung commented on a change in pull request #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink URL: https://github.com/apache/flink/pull/8056#discussion_r269857783 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/tab

[GitHub] [flink] KurtYoung commented on a change in pull request #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8056: [FLINK-12013][table-planner-blink] Support calc and correlate in blink URL: https://github.com/apache/flink/pull/8056#discussion_r269845486 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/tab

[jira] [Commented] (FLINK-9607) Support ParquetTableSink

2019-03-27 Thread Zhenqiu Huang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803590#comment-16803590 ] Zhenqiu Huang commented on FLINK-9607: -- [~yanghua] [~guibopan] OK, I am recently wor

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269853661 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/ta

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269855371 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/ta

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269851370 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Ta

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269855484 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/ta

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269851306 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Ta

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269850570 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Ta

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269853922 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/ta

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269850734 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Ta

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269851741 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/ta

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269850879 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Ta

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269853076 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/ta

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269854382 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/st

[GitHub] [flink] dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …

2019-03-27 Thread GitBox
dianfu commented on a change in pull request #8057: [FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` … URL: https://github.com/apache/flink/pull/8057#discussion_r269853051 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/ta

[GitHub] [flink] flinkbot commented on issue #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch

2019-03-27 Thread GitBox
flinkbot commented on issue #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch URL: https://github.com/apache/flink/pull/8066#issuecomment-477439975 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the commun

[jira] [Updated] (FLINK-12041) Introduce ResettableExternalBuffer to blink batch

2019-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12041: --- Labels: pull-request-available (was: ) > Introduce ResettableExternalBuffer to blink batch

[GitHub] [flink] JingsongLi opened a new pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch

2019-03-27 Thread GitBox
JingsongLi opened a new pull request #8066: [FLINK-12041][table-runtime-blink] Introduce ResettableExternalBuffer to blink batch URL: https://github.com/apache/flink/pull/8066 ## What is the purpose of the change Introduce ResettableExternalBuffer: A resettable external buffer for

[jira] [Created] (FLINK-12041) Introduce ResettableExternalBuffer to blink batch

2019-03-27 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12041: Summary: Introduce ResettableExternalBuffer to blink batch Key: FLINK-12041 URL: https://issues.apache.org/jira/browse/FLINK-12041 Project: Flink Issue Type:

[GitHub] [flink] zhijiangW commented on issue #8063: [hotfix] Remove unused construction and IOMode from NetworkEnvironmentConfiguration

2019-03-27 Thread GitBox
zhijiangW commented on issue #8063: [hotfix] Remove unused construction and IOMode from NetworkEnvironmentConfiguration URL: https://github.com/apache/flink/pull/8063#issuecomment-477436381 Thanks for review @azagrebin , I have submitted the commit for addressing your comments. :) ---

[GitHub] [flink] Clarkkkkk commented on a change in pull request #7780: [FLINK-11593][tests] Check & port TaskManagerTest to new code base

2019-03-27 Thread GitBox
Clark commented on a change in pull request #7780: [FLINK-11593][tests] Check & port TaskManagerTest to new code base URL: https://github.com/apache/flink/pull/7780#discussion_r269847537 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecuto

[GitHub] [flink] TisonKun edited a comment on issue #8046: [FLINK-12006][tests] Wait for Curator background operation finished

2019-03-27 Thread GitBox
TisonKun edited a comment on issue #8046: [FLINK-12006][tests] Wait for Curator background operation finished URL: https://github.com/apache/flink/pull/8046#issuecomment-477431589 @tillrohrmann done as we decided on JIRA. You might trigger extra travis builds to ensure it is the case. The

[GitHub] [flink] TisonKun commented on issue #8046: [FLINK-12006][tests] Wait for Curator background operation finished

2019-03-27 Thread GitBox
TisonKun commented on issue #8046: [FLINK-12006][tests] Wait for Curator background operation finished URL: https://github.com/apache/flink/pull/8046#issuecomment-477431589 @tillrohrmann done as we decided on JIRA. You might trigger extra travis build to ensure it is the case. Theoretical

[GitHub] [flink] KurtYoung commented on a change in pull request #8051: [FLINK-12018] [table-planner-blink] Add support for generating optimized logical plan for Sort and Rank

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8051: [FLINK-12018] [table-planner-blink] Add support for generating optimized logical plan for Sort and Rank URL: https://github.com/apache/flink/pull/8051#discussion_r269838324 ## File path: flink-table/flink-table-planner-blink/

[GitHub] [flink] KurtYoung commented on a change in pull request #8051: [FLINK-12018] [table-planner-blink] Add support for generating optimized logical plan for Sort and Rank

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8051: [FLINK-12018] [table-planner-blink] Add support for generating optimized logical plan for Sort and Rank URL: https://github.com/apache/flink/pull/8051#discussion_r269842435 ## File path: flink-table/flink-table-planner-blink/

[GitHub] [flink] KurtYoung commented on a change in pull request #8051: [FLINK-12018] [table-planner-blink] Add support for generating optimized logical plan for Sort and Rank

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8051: [FLINK-12018] [table-planner-blink] Add support for generating optimized logical plan for Sort and Rank URL: https://github.com/apache/flink/pull/8051#discussion_r269842220 ## File path: flink-table/flink-table-planner-blink/

[GitHub] [flink] KurtYoung commented on a change in pull request #8051: [FLINK-12018] [table-planner-blink] Add support for generating optimized logical plan for Sort and Rank

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8051: [FLINK-12018] [table-planner-blink] Add support for generating optimized logical plan for Sort and Rank URL: https://github.com/apache/flink/pull/8051#discussion_r269843890 ## File path: flink-table/flink-table-planner-blink/

[GitHub] [flink] KurtYoung commented on a change in pull request #8051: [FLINK-12018] [table-planner-blink] Add support for generating optimized logical plan for Sort and Rank

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8051: [FLINK-12018] [table-planner-blink] Add support for generating optimized logical plan for Sort and Rank URL: https://github.com/apache/flink/pull/8051#discussion_r269843899 ## File path: flink-table/flink-table-planner-blink/

[GitHub] [flink] KurtYoung commented on a change in pull request #8051: [FLINK-12018] [table-planner-blink] Add support for generating optimized logical plan for Sort and Rank

2019-03-27 Thread GitBox
KurtYoung commented on a change in pull request #8051: [FLINK-12018] [table-planner-blink] Add support for generating optimized logical plan for Sort and Rank URL: https://github.com/apache/flink/pull/8051#discussion_r269842446 ## File path: flink-table/flink-table-planner-blink/

[GitHub] [flink] Clarkkkkk commented on a change in pull request #7780: [FLINK-11593][tests] Check & port TaskManagerTest to new code base

2019-03-27 Thread GitBox
Clark commented on a change in pull request #7780: [FLINK-11593][tests] Check & port TaskManagerTest to new code base URL: https://github.com/apache/flink/pull/7780#discussion_r269840529 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecuto

[jira] [Assigned] (FLINK-12039) Remove ASSIGNED_SLOT_UPDATER in Execution.tryAssignResource

2019-03-27 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-12039: Assignee: vinoyang > Remove ASSIGNED_SLOT_UPDATER in Execution.tryAssignResource > --

[jira] [Commented] (FLINK-12023) Override TaskManager memory when submitting a Flink job

2019-03-27 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803536#comment-16803536 ] vinoyang commented on FLINK-12023: -- [~RustedBones] I do not think it is valuable. Your

[jira] [Commented] (FLINK-11921) Upgrade Calcite dependency to 1.19

2019-03-27 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803520#comment-16803520 ] vinoyang commented on FLINK-11921: -- [~walterddr] Thanks for clarifying this. It does no

[jira] [Assigned] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-03-27 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-11935: Assignee: vinoyang > Remove DateTimeUtils pull-in and fix datetime casting problem >

[jira] [Commented] (FLINK-9607) Support ParquetTableSink

2019-03-27 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803518#comment-16803518 ] vinoyang commented on FLINK-9607: - Hi [~ZhenqiuHuang] I have not started. I think [~guibo

[GitHub] [flink] TisonKun commented on issue #8046: [FLINK-12006][tests] Wait for Curator background operation finished

2019-03-27 Thread GitBox
TisonKun commented on issue #8046: [FLINK-12006][tests] Wait for Curator background operation finished URL: https://github.com/apache/flink/pull/8046#issuecomment-477401296 Reproduce the issue. Add a fix to see if it goes absent. ---

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-27 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r269801235 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-27 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r269800930 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[jira] [Commented] (FLINK-9607) Support ParquetTableSink

2019-03-27 Thread Zhenqiu Huang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803361#comment-16803361 ] Zhenqiu Huang commented on FLINK-9607: -- [~yanghua][~guibopan] Are you working on thi

[jira] [Commented] (FLINK-11914) Expose a REST endpoint in JobManager to kill specific TaskManager

2019-03-27 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803209#comment-16803209 ] Shuyi Chen commented on FLINK-11914: Hi [~Zentol], thanks a lot for the comments. cc

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-27 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r26950 ## File path: flink-end-to-end-tests/flink-connector-gcp-pub

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-27 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r269677433 ## File path: flink-streaming-java/src/main/java/org/apache/

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-27 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r269678671 ## File path: flink-end-to-end-tests/test-scripts/test_stream

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-27 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r269626263 ## File path: flink-connectors/flink-connector-gcp-pubsub/sr

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-27 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r269665970 ## File path: flink-end-to-end-tests/flink-connector-gcp-pub

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-27 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r269641718 ## File path: flink-connectors/flink-connector-gcp-pubsub/sr

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-27 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r269633381 ## File path: flink-end-to-end-tests/flink-connector-gcp-pub

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-27 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r269633168 ## File path: flink-end-to-end-tests/flink-connector-gcp-pub

[jira] [Commented] (FLINK-12040) Remove unused akka dependencies in pom.xml

2019-03-27 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803059#comment-16803059 ] TisonKun commented on FLINK-12040: -- The code diff is not complex https://github.com/Tis

[jira] [Commented] (FLINK-12006) ZooKeeperHaServicesTest.testSimpleCloseAndCleanupAllData is unstable

2019-03-27 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803051#comment-16803051 ] TisonKun commented on FLINK-12006: -- It looks like such a repeat test a common request,

[GitHub] [flink] eliaslevy commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0

2019-03-27 Thread GitBox
eliaslevy commented on issue #8055: [FLINK-12024] Bump universal Kafka connector to Kafka dependency to 2.2.0 URL: https://github.com/apache/flink/pull/8055#issuecomment-477250103 While the universal tries to track the latest Kafka client version, at times it may fall behind. E.g. before

[GitHub] [flink] TisonKun commented on issue #8046: [FLINK-12006][tests] Wait for Curator background operation finished

2019-03-27 Thread GitBox
TisonKun commented on issue #8046: [FLINK-12006][tests] Wait for Curator background operation finished URL: https://github.com/apache/flink/pull/8046#issuecomment-477249169 Further discussion happens on JIRA. As discussion there, I firstly repeat the test to try to reliably reproduce the

[GitHub] [flink] flinkbot commented on issue #8065: [BP-1.7][FLINK-12021] Deploy execution in topological sorted order

2019-03-27 Thread GitBox
flinkbot commented on issue #8065: [BP-1.7][FLINK-12021] Deploy execution in topological sorted order URL: https://github.com/apache/flink/pull/8065#issuecomment-477245523 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review y

[GitHub] [flink] tillrohrmann opened a new pull request #8065: [BP-1.7][FLINK-12021] Deploy execution in topological sorted order

2019-03-27 Thread GitBox
tillrohrmann opened a new pull request #8065: [BP-1.7][FLINK-12021] Deploy execution in topological sorted order URL: https://github.com/apache/flink/pull/8065 Backport or #8060 to `release-1.7`. This is an automated message

[jira] [Commented] (FLINK-12006) ZooKeeperHaServicesTest.testSimpleCloseAndCleanupAllData is unstable

2019-03-27 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803025#comment-16803025 ] TisonKun commented on FLINK-12006: -- Let's continue discussion on JIRA. I think your id

[GitHub] [flink] tillrohrmann commented on a change in pull request #8060: [FLINK-12021] Deploy execution in topological sorted order

2019-03-27 Thread GitBox
tillrohrmann commented on a change in pull request #8060: [FLINK-12021] Deploy execution in topological sorted order URL: https://github.com/apache/flink/pull/8060#discussion_r269651710 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraph

[GitHub] [flink] tillrohrmann commented on a change in pull request #8060: [FLINK-12021] Deploy execution in topological sorted order

2019-03-27 Thread GitBox
tillrohrmann commented on a change in pull request #8060: [FLINK-12021] Deploy execution in topological sorted order URL: https://github.com/apache/flink/pull/8060#discussion_r269651472 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java

[jira] [Commented] (FLINK-12006) ZooKeeperHaServicesTest.testSimpleCloseAndCleanupAllData is unstable

2019-03-27 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803002#comment-16803002 ] Till Rohrmann commented on FLINK-12006: --- Yes, atm I don't see a proper fix apart f

[GitHub] [flink] TisonKun edited a comment on issue #8046: [FLINK-12006][coordination] Ensure owned znode deleted on ZooKeeperHaServices#deleteOwnedZNode

2019-03-27 Thread GitBox
TisonKun edited a comment on issue #8046: [FLINK-12006][coordination] Ensure owned znode deleted on ZooKeeperHaServices#deleteOwnedZNode URL: https://github.com/apache/flink/pull/8046#issuecomment-477234305 @tillrohrmann Thanks for your analysis. It looks reasonable. For this test we can e

  1   2   3   >