[ 
https://issues.apache.org/jira/browse/FLINK-12006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803025#comment-16803025
 ] 

TisonKun commented on FLINK-12006:
----------------------------------

Let's continue discussion on JIRA.

I think your idea make sense to harden the test. Even though running the test 
in a loop is just increase probability we reproduce the problem(not 100% 
anyway).

The fix is based on that in the test, at most one {{WatchEvent}} (i.e., write 
leader information) was triggered. ATM I think we preserve this condition.

I'd at first try to reliably reproduce the problem on Travis and if succeed, 
add the fix as described above.

> ZooKeeperHaServicesTest.testSimpleCloseAndCleanupAllData is unstable
> --------------------------------------------------------------------
>
>                 Key: FLINK-12006
>                 URL: https://issues.apache.org/jira/browse/FLINK-12006
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>            Reporter: Aljoscha Krettek
>            Assignee: TisonKun
>            Priority: Critical
>              Labels: pull-request-available, test-stability
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is the log from a failed Travis run: 
> https://travis-ci.org/apache/flink/jobs/510263371
> The relevant section is:
> {code}
> 11:15:11.201 [INFO] Running 
> org.apache.flink.runtime.highavailability.zookeeper.ZooKeeperHaServicesTest
> 11:15:12.908 [INFO] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time 
> elapsed: 9.255 s - in org.apache.flink.runtime.jobmaster.JobMasterTest
> 11:15:13.646 [INFO] Running 
> org.apache.flink.runtime.highavailability.zookeeper.ZooKeeperRegistryTest
> 11:15:14.874 [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time 
> elapsed: 3.67 s <<< FAILURE! - in 
> org.apache.flink.runtime.highavailability.zookeeper.ZooKeeperHaServicesTest
> 11:15:14.874 [ERROR] 
> testSimpleCloseAndCleanupAllData(org.apache.flink.runtime.highavailability.zookeeper.ZooKeeperHaServicesTest)
>   Time elapsed: 0.132 s  <<< FAILURE!
> java.lang.AssertionError: 
> Expected: is <[zookeeper]>
>      but: was <[zookeeper, foo]>
>       at 
> org.apache.flink.runtime.highavailability.zookeeper.ZooKeeperHaServicesTest.testSimpleCloseAndCleanupAllData(ZooKeeperHaServicesTest.java:136)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to