[GitHub] [flink] sunhaibotb edited a comment on issue #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces

2019-03-18 Thread GitBox
sunhaibotb edited a comment on issue #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces URL: https://github.com/apache/flink/pull/7959#issuecomment-474219792 See the following links for the code of runtime implemention and benchmark.

[GitHub] [flink] sunhaibotb commented on issue #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces

2019-03-18 Thread GitBox
sunhaibotb commented on issue #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces URL: https://github.com/apache/flink/pull/7959#issuecomment-474219792 See the following links for the code of runtime implemention and benchmark. - [Al

[GitHub] [flink] yanghua commented on issue #8005: [FLINK-11818] Provide pipe transformation function for DataSet API

2019-03-18 Thread GitBox
yanghua commented on issue #8005: [FLINK-11818] Provide pipe transformation function for DataSet API URL: https://github.com/apache/flink/pull/8005#issuecomment-474218394 Hi @fhueske can you review this PR? Thanks. This is an

[jira] [Commented] (FLINK-11953) Introduce Plugin/Loading system and integrate it with FileSystem

2019-03-18 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795743#comment-16795743 ] Ufuk Celebi commented on FLINK-11953: - [~srichter] [Presto's plugin system|https://

[GitHub] [flink] sunhaibotb commented on issue #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces

2019-03-18 Thread GitBox
sunhaibotb commented on issue #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces URL: https://github.com/apache/flink/pull/7959#issuecomment-474215888 The code has been updated, and please you review it again. @pnowojski @StefanRRichter

[GitHub] [flink] sunhaibotb commented on a change in pull request #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces

2019-03-18 Thread GitBox
sunhaibotb commented on a change in pull request #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces URL: https://github.com/apache/flink/pull/7959#discussion_r266742726 ## File path: flink-streaming-java/src/main/java/org/apache/fl

[GitHub] [flink] sunhaibotb commented on a change in pull request #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces

2019-03-18 Thread GitBox
sunhaibotb commented on a change in pull request #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces URL: https://github.com/apache/flink/pull/7959#discussion_r266742726 ## File path: flink-streaming-java/src/main/java/org/apache/fl

[GitHub] [flink] sunhaibotb commented on a change in pull request #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces

2019-03-18 Thread GitBox
sunhaibotb commented on a change in pull request #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces URL: https://github.com/apache/flink/pull/7959#discussion_r266742570 ## File path: flink-streaming-java/src/main/java/org/apache/fl

[GitHub] [flink] KurtYoung commented on a change in pull request #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types

2019-03-18 Thread GitBox
KurtYoung commented on a change in pull request #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types URL: https://github.com/apache/flink/pull/8003#discussion_r266741891 ## File path: flink-table/flink-table-common/src/main/java

[jira] [Assigned] (FLINK-11961) Clear up and refactor the code generation of scalar functions and operators

2019-03-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-11961: --- Assignee: Jark Wu > Clear up and refactor the code generation of scalar functions and operators > -

[jira] [Created] (FLINK-11961) Clear up and refactor the code generation of scalar functions and operators

2019-03-18 Thread Jark Wu (JIRA)
Jark Wu created FLINK-11961: --- Summary: Clear up and refactor the code generation of scalar functions and operators Key: FLINK-11961 URL: https://issues.apache.org/jira/browse/FLINK-11961 Project: Flink

[GitHub] [flink] bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-18 Thread GitBox
bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r266730735 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/tab

[GitHub] [flink] bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-18 Thread GitBox
bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r266730440 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/tab

[GitHub] [flink] bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-18 Thread GitBox
bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r266730360 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/tab

[GitHub] [flink] bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-18 Thread GitBox
bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r266730070 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/tab

[GitHub] [flink] bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-18 Thread GitBox
bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r266730597 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/tab

[GitHub] [flink] bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-18 Thread GitBox
bowenli86 commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r266729223 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/tab

[jira] [Created] (FLINK-11959) Introduce window operator for blink streaming runtime

2019-03-18 Thread Kurt Young (JIRA)
Kurt Young created FLINK-11959: -- Summary: Introduce window operator for blink streaming runtime Key: FLINK-11959 URL: https://issues.apache.org/jira/browse/FLINK-11959 Project: Flink Issue Type:

[jira] [Created] (FLINK-11960) Check all the builtin functions and operators are reasonable

2019-03-18 Thread Jark Wu (JIRA)
Jark Wu created FLINK-11960: --- Summary: Check all the builtin functions and operators are reasonable Key: FLINK-11960 URL: https://issues.apache.org/jira/browse/FLINK-11960 Project: Flink Issue Typ

[GitHub] [flink] JingsongLi commented on a change in pull request #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types

2019-03-18 Thread GitBox
JingsongLi commented on a change in pull request #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types URL: https://github.com/apache/flink/pull/8003#discussion_r266723093 ## File path: flink-table/flink-table-common/src/main/jav

[GitHub] [flink] KurtYoung commented on a change in pull request #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types

2019-03-18 Thread GitBox
KurtYoung commented on a change in pull request #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types URL: https://github.com/apache/flink/pull/8003#discussion_r266720317 ## File path: flink-table/flink-table-common/src/main/java

[GitHub] [flink] flinkbot commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-18 Thread GitBox
flinkbot commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#issuecomment-474185108 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] xuefuz opened a new pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-18 Thread GitBox
xuefuz opened a new pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007 …related interfaces ## What is the purpose of the change *Add new catalog APIs pertaining to FLIP-30*

[GitHub] [flink] xuefuz closed pull request #7643: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-18 Thread GitBox
xuefuz closed pull request #7643: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/7643 This is an automated message from the Apache Git Service. To res

[GitHub] [flink] JingsongLi commented on issue #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types

2019-03-18 Thread GitBox
JingsongLi commented on issue #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types URL: https://github.com/apache/flink/pull/8003#issuecomment-474179324 > @JingsongLi why not putting `CustomTypeDefinedFunction` into `flink-table-planner-

[jira] [Closed] (FLINK-11528) Translate the "Use Cases" page into Chinese

2019-03-18 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui closed FLINK-11528. --- > Translate the "Use Cases" page into Chinese > --- > >

[jira] [Resolved] (FLINK-11528) Translate the "Use Cases" page into Chinese

2019-03-18 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui resolved FLINK-11528. - Resolution: Done Implemented with 6af7f48bd754fb9a5635c25ec7656677fcf10b9b > Translate the "Use

[jira] [Created] (FLINK-11958) flink on windows yarn deploy failed

2019-03-18 Thread Matrix42 (JIRA)
Matrix42 created FLINK-11958: Summary: flink on windows yarn deploy failed Key: FLINK-11958 URL: https://issues.apache.org/jira/browse/FLINK-11958 Project: Flink Issue Type: Bug Compone

[jira] [Assigned] (FLINK-11955) Modify build to move filesystems from lib to plugins folder

2019-03-18 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-11955: Assignee: vinoyang > Modify build to move filesystems from lib to plugins folder > --

[jira] [Assigned] (FLINK-11956) Remove shading from filesystems build

2019-03-18 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-11956: Assignee: vinoyang > Remove shading from filesystems build >

[jira] [Commented] (FLINK-11926) The Description of Assigners allowing a fixed amount of lateness is not correct

2019-03-18 Thread chaiyongqiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795518#comment-16795518 ] chaiyongqiang commented on FLINK-11926: --- I'm confused. Let's consider the simpler

[jira] [Updated] (FLINK-11926) The Description of Assigners allowing a fixed amount of lateness is not correct

2019-03-18 Thread chaiyongqiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaiyongqiang updated FLINK-11926: -- Attachment: screenshot-1.png > The Description of Assigners allowing a fixed amount of latenes

[GitHub] [flink] bowenli86 edited a comment on issue #7643: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-18 Thread GitBox
bowenli86 edited a comment on issue #7643: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/7643#issuecomment-462653964 Just took another look and found this PR needs to adapt to the new flink-table structure given tha

[GitHub] [flink] flinkbot edited a comment on issue #7643: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-03-18 Thread GitBox
flinkbot edited a comment on issue #7643: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/7643#issuecomment-459849424 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the commu

[GitHub] [flink] gustavo-momente commented on issue #7980: [FLINK-11913] Shadding cassandra driver dependencies in cassandra conector

2019-03-18 Thread GitBox
gustavo-momente commented on issue #7980: [FLINK-11913] Shadding cassandra driver dependencies in cassandra conector URL: https://github.com/apache/flink/pull/7980#issuecomment-474117211 Any update or something that I should be doing? ---

[jira] [Updated] (FLINK-11957) Expose failure cause in the API response when dispatcher fails to submit a job

2019-03-18 Thread Mark Cho (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Cho updated FLINK-11957: - Description: We use POST /jars/:jarid/run API endpoint to submit a Flink job [https://ci.apache.org/pro

[jira] [Created] (FLINK-11957) Expose failure cause in the API response when dispatcher fails to submit a job

2019-03-18 Thread Mark Cho (JIRA)
Mark Cho created FLINK-11957: Summary: Expose failure cause in the API response when dispatcher fails to submit a job Key: FLINK-11957 URL: https://issues.apache.org/jira/browse/FLINK-11957 Project: Flink

[jira] [Commented] (FLINK-11912) Expose per partition Kafka lag metric in Flink Kafka connector

2019-03-18 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795108#comment-16795108 ] Rong Rong commented on FLINK-11912: --- +1. I think this metrics will be extremely helpfu

[jira] [Commented] (FLINK-11654) Multiple transactional KafkaProducers writing to same cluster have clashing transaction IDs

2019-03-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795094#comment-16795094 ] Aljoscha Krettek commented on FLINK-11654: -- I don't know, unfortunately. [~pnow

[jira] [Updated] (FLINK-11892) Port conflict when running nightly end-to-end tests

2019-03-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-11892: - Issue Type: Bug (was: Sub-task) Parent: (was: FLINK-11891) > Port conflict

[jira] [Closed] (FLINK-11891) Fix some script or test case bug in 1.8 RC

2019-03-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-11891. Resolution: Not A Problem Closing this, because the sub-issues have been resolved. I think

[jira] [Updated] (FLINK-11950) Add missing dependencies in NOTICE file of flink-dist.

2019-03-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-11950: - Issue Type: Bug (was: Sub-task) Parent: (was: FLINK-11891) > Add missing de

[jira] [Commented] (FLINK-11947) Support MapState key / value schema evolution for RocksDB

2019-03-18 Thread Cliff Resnick (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795072#comment-16795072 ] Cliff Resnick commented on FLINK-11947: --- Thanks for the explanation, that makes se

[GitHub] [flink] flinkbot edited a comment on issue #8006: [FLINK-11068][table] Convert the API classes of *Table to interfaces

2019-03-18 Thread GitBox
flinkbot edited a comment on issue #8006: [FLINK-11068][table] Convert the API classes of *Table to interfaces URL: https://github.com/apache/flink/pull/8006#issuecomment-473933358 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] twalthr commented on issue #8006: [FLINK-11068][table] Convert the API classes of *Table to interfaces

2019-03-18 Thread GitBox
twalthr commented on issue #8006: [FLINK-11068][table] Convert the API classes of *Table to interfaces URL: https://github.com/apache/flink/pull/8006#issuecomment-473933673 @flinkbot approve-until consensus This is an automat

[GitHub] [flink] flinkbot edited a comment on issue #7976: [FLINK-11908][table] Port window classes into flink-api-java

2019-03-18 Thread GitBox
flinkbot edited a comment on issue #7976: [FLINK-11908][table] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#issuecomment-472496692 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] flinkbot commented on issue #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers

2019-03-18 Thread GitBox
flinkbot commented on issue #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers URL: https://github.com/apache/flink/pull/8002#issuecomment-473933410 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the commu

[GitHub] [flink] flinkbot commented on issue #7999: [hotfix][runtime] Remove unused local variable in ExecutionGraphBuilder

2019-03-18 Thread GitBox
flinkbot commented on issue #7999: [hotfix][runtime] Remove unused local variable in ExecutionGraphBuilder URL: https://github.com/apache/flink/pull/7999#issuecomment-473933436 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to rev

[GitHub] [flink] flinkbot commented on issue #8006: [FLINK-11068][table] Convert the API classes of *Table to interfaces

2019-03-18 Thread GitBox
flinkbot commented on issue #8006: [FLINK-11068][table] Convert the API classes of *Table to interfaces URL: https://github.com/apache/flink/pull/8006#issuecomment-473933358 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] flinkbot commented on issue #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types

2019-03-18 Thread GitBox
flinkbot commented on issue #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types URL: https://github.com/apache/flink/pull/8003#issuecomment-473933392 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I h

[GitHub] [flink] flinkbot commented on issue #8005: [FLINK-11818] Provide pipe transformation function for DataSet API

2019-03-18 Thread GitBox
flinkbot commented on issue #8005: [FLINK-11818] Provide pipe transformation function for DataSet API URL: https://github.com/apache/flink/pull/8005#issuecomment-473933375 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review y

[GitHub] [flink] flinkbot commented on issue #8001: [FLINK-11949][table-planner-blink] Introduce DeclarativeAggregateFunction and AggsHandlerCodeGenerator to blink planner

2019-03-18 Thread GitBox
flinkbot commented on issue #8001: [FLINK-11949][table-planner-blink] Introduce DeclarativeAggregateFunction and AggsHandlerCodeGenerator to blink planner URL: https://github.com/apache/flink/pull/8001#issuecomment-473933421 Thanks a lot for your contribution to the Apache Flink project. I'

[GitHub] [flink] hequn8128 opened a new pull request #8006: [FLINK-11068][table] Convert the API classes of *Table to interfaces

2019-03-18 Thread GitBox
hequn8128 opened a new pull request #8006: [FLINK-11068][table] Convert the API classes of *Table to interfaces URL: https://github.com/apache/flink/pull/8006 ## What is the purpose of the change This pull request convert table related classes into interface. ## Brief chan

[jira] [Updated] (FLINK-11068) Convert the API classes *Table, *Window to interfaces

2019-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11068: --- Labels: pull-request-available (was: ) > Convert the API classes *Table, *Window to interfa

[GitHub] [flink] dianfu commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common

2019-03-18 Thread GitBox
dianfu commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common URL: https://github.com/apache/flink/pull/7848#issuecomment-473925322 @twalthr Makes much sense to me. I have updated the PR and limit the changes to a minimal.

[GitHub] [flink] dianfu commented on a change in pull request #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common

2019-03-18 Thread GitBox
dianfu commented on a change in pull request #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common URL: https://github.com/apache/flink/pull/7848#discussion_r266455143 ## File path: flink-connectors/flink-connector-elasticsearch6/pom.

[GitHub] [flink] twalthr commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common

2019-03-18 Thread GitBox
twalthr commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common URL: https://github.com/apache/flink/pull/7848#issuecomment-473922638 @dianfu thanks for your feedback. Yes, I think we should always aim for small and less inv

[jira] [Updated] (FLINK-11685) Add plan test infrastructure

2019-03-18 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-11685: --- Fix Version/s: 1.9.0 > Add plan test infrastructure > > >

[GitHub] [flink] GJL commented on a change in pull request #7986: [FLINK-10517][rest] Add stability test

2019-03-18 Thread GitBox
GJL commented on a change in pull request #7986: [FLINK-10517][rest] Add stability test URL: https://github.com/apache/flink/pull/7986#discussion_r266450453 ## File path: flink-docs/pom.xml ## @@ -53,6 +53,12 @@ under the License. flink-runtime_${s

[jira] [Closed] (FLINK-11680) Make query plan easier to read

2019-03-18 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-11680. -- Resolution: Duplicate Fix Version/s: 1.9.0 > Make query plan easier to read > -

[jira] [Closed] (FLINK-11685) Add plan test infrastructure

2019-03-18 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-11685. -- Resolution: Duplicate > Add plan test infrastructure > > >

[GitHub] [flink] twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization

2019-03-18 Thread GitBox
twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization URL: https://github.com/apache/flink/pull/7932#discussion_r266424918 ## File path: flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonRow

[GitHub] [flink] twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization

2019-03-18 Thread GitBox
twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization URL: https://github.com/apache/flink/pull/7932#discussion_r266421509 ## File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRow

[GitHub] [flink] twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization

2019-03-18 Thread GitBox
twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization URL: https://github.com/apache/flink/pull/7932#discussion_r266421832 ## File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRow

[GitHub] [flink] twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization

2019-03-18 Thread GitBox
twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization URL: https://github.com/apache/flink/pull/7932#discussion_r266412972 ## File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/Default

[GitHub] [flink] twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization

2019-03-18 Thread GitBox
twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization URL: https://github.com/apache/flink/pull/7932#discussion_r266415279 ## File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/Default

[GitHub] [flink] twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization

2019-03-18 Thread GitBox
twalthr commented on a change in pull request #7932: [FLINK-11727][formats] Fixed JSON format issues after serialization URL: https://github.com/apache/flink/pull/7932#discussion_r266416872 ## File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/Default

[GitHub] [flink] twalthr commented on issue #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types

2019-03-18 Thread GitBox
twalthr commented on issue #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types URL: https://github.com/apache/flink/pull/8003#issuecomment-473894308 @JingsongLi why not putting `CustomTypeDefinedFunction` into `flink-table-planner-blink

[jira] [Updated] (FLINK-11818) Provide pipe transformation function for DataSet API

2019-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11818: --- Labels: pull-request-available (was: ) > Provide pipe transformation function for DataSet A

[GitHub] [flink] yanghua opened a new pull request #8005: [FLINK-11818] Provide pipe transformation function for DataSet API

2019-03-18 Thread GitBox
yanghua opened a new pull request #8005: [FLINK-11818] Provide pipe transformation function for DataSet API URL: https://github.com/apache/flink/pull/8005 ## What is the purpose of the change *This pull request Provide pipe transformation function for DataSetUtils* ## Brief ch

[GitHub] [flink] dianfu edited a comment on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common

2019-03-18 Thread GitBox
dianfu edited a comment on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common URL: https://github.com/apache/flink/pull/7848#issuecomment-473886791 @twalthr Thanks a lot for the review. Considering that this change will break the AP

[GitHub] [flink] hequn8128 commented on issue #7976: [FLINK-11908][table] Port window classes into flink-api-java

2019-03-18 Thread GitBox
hequn8128 commented on issue #7976: [FLINK-11908][table] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#issuecomment-473887453 @twalthr Thanks for your valuable suggestions. I will move on the next PR(convert Table to the interface). --

[GitHub] [flink] dianfu commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common

2019-03-18 Thread GitBox
dianfu commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common URL: https://github.com/apache/flink/pull/7848#issuecomment-473886791 @twalthr Thanks a lot for the review. Considering that this change will break the API of Fi

[GitHub] [flink] tweise merged pull request #8000: [hotfix] [FLINK-9007] [kinesis] [e2e] Build Kinesis test under include-kinesis profile

2019-03-18 Thread GitBox
tweise merged pull request #8000: [hotfix] [FLINK-9007] [kinesis] [e2e] Build Kinesis test under include-kinesis profile URL: https://github.com/apache/flink/pull/8000 This is an automated message from the Apache Git Service

[GitHub] [flink] asfgit closed pull request #7976: [FLINK-11908][table] Port window classes into flink-api-java

2019-03-18 Thread GitBox
asfgit closed pull request #7976: [FLINK-11908][table] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976 This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Updated] (FLINK-11908) Port window classes into flink-table-api-java

2019-03-18 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-11908: - Summary: Port window classes into flink-table-api-java (was: Port window classes into flink-api

[jira] [Closed] (FLINK-11908) Port window classes into flink-table-api-java

2019-03-18 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-11908. Resolution: Fixed Fix Version/s: 1.9.0 Fixed in 1.9.0: 7a273577021bf84927242c9372757215e1ff

[jira] [Closed] (FLINK-11950) Add missing dependencies in NOTICE file of flink-dist.

2019-03-18 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-11950. --- Resolution: Fixed Fix Version/s: 1.9.0 Release Note: Add `frocksdbjni` dependency in NOTI

[GitHub] [flink] asfgit closed pull request #8004: [FLINK-11950][dist]Add missing dependencies in NOTICE file of flink-d…

2019-03-18 Thread GitBox
asfgit closed pull request #8004: [FLINK-11950][dist]Add missing dependencies in NOTICE file of flink-d… URL: https://github.com/apache/flink/pull/8004 This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] twalthr commented on issue #7976: [FLINK-11908][table] Port window classes into flink-api-java

2019-03-18 Thread GitBox
twalthr commented on issue #7976: [FLINK-11908][table] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#issuecomment-473873877 @flinkbot approve all This is an automated message from the

[GitHub] [flink] twalthr commented on a change in pull request #7976: [FLINK-11908][table] Port window classes into flink-api-java

2019-03-18 Thread GitBox
twalthr commented on a change in pull request #7976: [FLINK-11908][table] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#discussion_r266388865 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/OverWindowP

[GitHub] [flink] twalthr commented on a change in pull request #7976: [FLINK-11908][table] Port window classes into flink-api-java

2019-03-18 Thread GitBox
twalthr commented on a change in pull request #7976: [FLINK-11908][table] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#discussion_r266385177 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/Pla

[GitHub] [flink] twalthr commented on a change in pull request #7976: [FLINK-11908][table] Port window classes into flink-api-java

2019-03-18 Thread GitBox
twalthr commented on a change in pull request #7976: [FLINK-11908][table] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#discussion_r266389146 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/OverWindowP

[jira] [Assigned] (FLINK-11954) Provide unit test(s) for new plugin infrastructure

2019-03-18 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter reassigned FLINK-11954: -- Assignee: Stefan Richter > Provide unit test(s) for new plugin infrastructure > -

[jira] [Assigned] (FLINK-11953) Introduce Plugin/Loading system and integrate it with FileSystem

2019-03-18 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter reassigned FLINK-11953: -- Assignee: Stefan Richter > Introduce Plugin/Loading system and integrate it with File

[GitHub] [flink] sunjincheng121 commented on issue #8004: [FLINK-11950][dist]Add missing dependencies in NOTICE file of flink-d…

2019-03-18 Thread GitBox
sunjincheng121 commented on issue #8004: [FLINK-11950][dist]Add missing dependencies in NOTICE file of flink-d… URL: https://github.com/apache/flink/pull/8004#issuecomment-473868203 Thanks for review @zentol @aljoscha! I'll merge the PR. ---

[jira] [Created] (FLINK-11956) Remove shading from filesystems build

2019-03-18 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-11956: -- Summary: Remove shading from filesystems build Key: FLINK-11956 URL: https://issues.apache.org/jira/browse/FLINK-11956 Project: Flink Issue Type: Sub-tas

[jira] [Created] (FLINK-11955) Modify build to move filesystems from lib to plugins folder

2019-03-18 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-11955: -- Summary: Modify build to move filesystems from lib to plugins folder Key: FLINK-11955 URL: https://issues.apache.org/jira/browse/FLINK-11955 Project: Flink

[jira] [Created] (FLINK-11954) Provide unit test(s) for new plugin infrastructure

2019-03-18 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-11954: -- Summary: Provide unit test(s) for new plugin infrastructure Key: FLINK-11954 URL: https://issues.apache.org/jira/browse/FLINK-11954 Project: Flink Issue

[jira] [Created] (FLINK-11953) Introduce Plugin/Loading system and integrate it with FileSystem

2019-03-18 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-11953: -- Summary: Introduce Plugin/Loading system and integrate it with FileSystem Key: FLINK-11953 URL: https://issues.apache.org/jira/browse/FLINK-11953 Project: Flink

[jira] [Created] (FLINK-11952) Introduce Plugin Architecture for loading FileSystems

2019-03-18 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-11952: -- Summary: Introduce Plugin Architecture for loading FileSystems Key: FLINK-11952 URL: https://issues.apache.org/jira/browse/FLINK-11952 Project: Flink Iss

[jira] [Updated] (FLINK-11059) JobMaster may continue using an invalid slot if releasing idle slot meet a timeout

2019-03-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-11059: -- Fix Version/s: 1.8.1 1.9.0 1.7.3 > JobMaster may continu

[jira] [Updated] (FLINK-11950) Add missing dependencies in NOTICE file of flink-dist.

2019-03-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-11950: - Priority: Blocker (was: Major) > Add missing dependencies in NOTICE file of flink-dist.

[GitHub] [flink] JingsongLi edited a comment on issue #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types

2019-03-18 Thread GitBox
JingsongLi edited a comment on issue #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types URL: https://github.com/apache/flink/pull/8003#issuecomment-473861118 @twalthr Thanks for your review, but now UDF is in table-common, how to move

[GitHub] [flink] JingsongLi commented on issue #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types

2019-03-18 Thread GitBox
JingsongLi commented on issue #8003: [FLINK-11951][table-common] Enhance UserDefinedFunction interface to allow more user defined types URL: https://github.com/apache/flink/pull/8003#issuecomment-473861118 But now UDF is in table-common, how to move those changes to `flink-table-planner-bl

[jira] [Updated] (FLINK-11059) JobMaster may continue using an invalid slot if releasing idle slot meet a timeout

2019-03-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-11059: -- Priority: Critical (was: Major) > JobMaster may continue using an invalid slot if releasing i

[jira] [Updated] (FLINK-11950) Add missing dependencies in NOTICE file of flink-dist.

2019-03-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-11950: - Fix Version/s: 1.8.0 > Add missing dependencies in NOTICE file of flink-dist. >

[GitHub] [flink] twalthr commented on a change in pull request #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common

2019-03-18 Thread GitBox
twalthr commented on a change in pull request #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common URL: https://github.com/apache/flink/pull/7848#discussion_r266378657 ## File path: flink-table/flink-table-common/src/main/java/org/a

[GitHub] [flink] twalthr commented on a change in pull request #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common

2019-03-18 Thread GitBox
twalthr commented on a change in pull request #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common URL: https://github.com/apache/flink/pull/7848#discussion_r266376188 ## File path: flink-table/flink-table-planner/src/main/scala/org

[GitHub] [flink] twalthr commented on a change in pull request #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common

2019-03-18 Thread GitBox
twalthr commented on a change in pull request #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common URL: https://github.com/apache/flink/pull/7848#discussion_r266378472 ## File path: flink-table/flink-table-common/src/main/java/org/a

  1   2   >