twalthr commented on a change in pull request #7932: [FLINK-11727][formats]
Fixed JSON format issues after serialization
URL: https://github.com/apache/flink/pull/7932#discussion_r266421509
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -128,107 +191,11 @@ public boolean equals(Object o) {
return false;
}
final JsonRowDeserializationSchema that =
(JsonRowDeserializationSchema) o;
- return failOnMissingField == that.failOnMissingField &&
Objects.equals(typeInfo, that.typeInfo);
+ return Objects.equals(typeInfo, that.typeInfo);
Review comment:
This does not test for full equality anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
