[jira] [Assigned] (FLINK-11533) Retrieve job class name from JAR manifest in ClassPathJobGraphRetriever

2019-02-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reassigned FLINK-11533: --- Assignee: Ufuk Celebi (was: vinoyang) > Retrieve job class name from JAR manifest in Class

[jira] [Commented] (FLINK-11533) Retrieve job class name from JAR manifest in ClassPathJobGraphRetriever

2019-02-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763366#comment-16763366 ] Ufuk Celebi commented on FLINK-11533: - [~yanghua] I assigned myself. Sorry for the c

[jira] [Commented] (FLINK-11534) Don't exit JVM after job termination with standalone job

2019-02-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763365#comment-16763365 ] Ufuk Celebi commented on FLINK-11534: - [~yanghua] I assigned myself. Sorry for the c

[jira] [Assigned] (FLINK-11534) Don't exit JVM after job termination with standalone job

2019-02-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reassigned FLINK-11534: --- Assignee: Ufuk Celebi (was: vinoyang) > Don't exit JVM after job termination with standalo

[jira] [Commented] (FLINK-11526) Support Chinese Website for Apache Flink

2019-02-07 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763286#comment-16763286 ] Jark Wu commented on FLINK-11526: - Hi [~fhueske], thank you for your kind help. What do

[GitHub] TisonKun commented on issue #6883: [FLINK-10610] [tests] Port slot sharing cases to new codebase

2019-02-07 Thread GitBox
TisonKun commented on issue #6883: [FLINK-10610] [tests] Port slot sharing cases to new codebase URL: https://github.com/apache/flink/pull/6883#issuecomment-461654971 Address comments. For `TaskManagerFailsWithSlotSharingITCase`, it can also be covered in this scope. Ported as `testSlotSh

[GitHub] walterddr commented on a change in pull request #7607: [FLINK-10076][table] Upgrade Calcite dependency to 1.18

2019-02-07 Thread GitBox
walterddr commented on a change in pull request #7607: [FLINK-10076][table] Upgrade Calcite dependency to 1.18 URL: https://github.com/apache/flink/pull/7607#discussion_r254910013 ## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/sql/GroupWin

[GitHub] sunjincheng121 edited a comment on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-02-07 Thread GitBox
sunjincheng121 edited a comment on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-461442650 Hi, @twalthr I will be very grateful if you have time to have look at the PR. Great thanks for the offli

[GitHub] bowenli86 commented on issue #7643: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-02-07 Thread GitBox
bowenli86 commented on issue #7643: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/7643#issuecomment-461575592 LGTM This is an automated message from t

[GitHub] bowenli86 edited a comment on issue #7643: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-02-07 Thread GitBox
bowenli86 edited a comment on issue #7643: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/7643#issuecomment-461575592 LGTM +1 This is an automated me

[GitHub] GJL commented on issue #7659: [FLINK-11514][client] Port ClusterClientTest

2019-02-07 Thread GitBox
GJL commented on issue #7659: [FLINK-11514][client] Port ClusterClientTest URL: https://github.com/apache/flink/pull/7659#issuecomment-461555449 Thanks, I will have a look tomorrow. This is an automated message from the Apache

[GitHub] flinkbot commented on issue #7666: [FLINK-11548][tests] Delete test ClusterShutdownITCase

2019-02-07 Thread GitBox
flinkbot commented on issue #7666: [FLINK-11548][tests] Delete test ClusterShutdownITCase URL: https://github.com/apache/flink/pull/7666#issuecomment-461553356 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull req

[GitHub] GJL opened a new pull request #7666: [FLINK-11548][tests] Delete test ClusterShutdownITCase

2019-02-07 Thread GitBox
GJL opened a new pull request #7666: [FLINK-11548][tests] Delete test ClusterShutdownITCase URL: https://github.com/apache/flink/pull/7666 ## What is the purpose of the change *This deletes the test `ClusterShutdownITCase`. The test was asserting that the `StopCluster` message is se

[jira] [Commented] (FLINK-11501) Add a ratelimiting feature to the FlinkKafkaConsumer

2019-02-07 Thread Lakshmi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762965#comment-16762965 ] Lakshmi Rao commented on FLINK-11501: - Adding some screenshots of results from testi

[jira] [Updated] (FLINK-11501) Add a ratelimiting feature to the FlinkKafkaConsumer

2019-02-07 Thread Lakshmi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lakshmi Rao updated FLINK-11501: Attachment: Ratelimiting-2.png > Add a ratelimiting feature to the FlinkKafkaConsumer > --

[jira] [Updated] (FLINK-11501) Add a ratelimiting feature to the FlinkKafkaConsumer

2019-02-07 Thread Lakshmi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lakshmi Rao updated FLINK-11501: Attachment: RateLimiting-1.png > Add a ratelimiting feature to the FlinkKafkaConsumer > --

[jira] [Created] (FLINK-11552) Akka association issues in 1.7.x

2019-02-07 Thread William Cummings (JIRA)
William Cummings created FLINK-11552: Summary: Akka association issues in 1.7.x Key: FLINK-11552 URL: https://issues.apache.org/jira/browse/FLINK-11552 Project: Flink Issue Type: Bug

[GitHub] zentol commented on issue #7263: [FLINK-11081] Support binding port range for REST server

2019-02-07 Thread GitBox
zentol commented on issue #7263: [FLINK-11081] Support binding port range for REST server URL: https://github.com/apache/flink/pull/7263#issuecomment-461525668 I'll take another look tomorrow. This is an automated message fro

[GitHub] zentol commented on issue #6598: [FLINK-10179] [Startup Shell Scripts] .bat script to start Flink history server

2019-02-07 Thread GitBox
zentol commented on issue #6598: [FLINK-10179] [Startup Shell Scripts] .bat script to start Flink history server URL: https://github.com/apache/flink/pull/6598#issuecomment-461525379 yes, I'm still using windows. I believe we should have a larger discussions as to how powerful the wi

[GitHub] zentol commented on issue #6962: change accumulator value to be formatted with digit group separator

2019-02-07 Thread GitBox
zentol commented on issue #6962: change accumulator value to be formatted with digit group separator URL: https://github.com/apache/flink/pull/6962#issuecomment-461523734 I would like to understand what case we're trying to solve here. What locality-dependent component does a stringified n

[jira] [Commented] (FLINK-11413) Reporter filtering using "metrics.reporters" broken on Java 9+

2019-02-07 Thread Matthieu Bonneviot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762893#comment-16762893 ] Matthieu Bonneviot commented on FLINK-11413: [~Zentol] I was wondering if I

[GitHub] zentol commented on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer

2019-02-07 Thread GitBox
zentol commented on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer URL: https://github.com/apache/flink/pull/7655#issuecomment-461520680 did...you just approve your own description? @aljoscha 😕 --

[GitHub] zentol commented on issue #7407: [FLINK-11260] Bump the Janino compiler to 3.0.11

2019-02-07 Thread GitBox
zentol commented on issue #7407: [FLINK-11260] Bump the Janino compiler to 3.0.11 URL: https://github.com/apache/flink/pull/7407#issuecomment-461520415 AFAIK we keep our janino dependency in sync with calcite, as seen in #7607. --

[GitHub] flinkbot edited a comment on issue #7662: [FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler (rebased)

2019-02-07 Thread GitBox
flinkbot edited a comment on issue #7662: [FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler (rebased) URL: https://github.com/apache/flink/pull/7662#issuecomment-461371865 Thanks a lot for your contribution to the Apache Flink project. I'm the @fl

[GitHub] tillrohrmann commented on issue #7662: [FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler (rebased)

2019-02-07 Thread GitBox
tillrohrmann commented on issue #7662: [FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler (rebased) URL: https://github.com/apache/flink/pull/7662#issuecomment-461508136 @flinkbot attention @tillrohrmann ---

[GitHub] tillrohrmann commented on issue #7662: [FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler (rebased)

2019-02-07 Thread GitBox
tillrohrmann commented on issue #7662: [FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler (rebased) URL: https://github.com/apache/flink/pull/7662#issuecomment-461508063 @flinkbot approve consensus --

[GitHub] tillrohrmann commented on issue #7662: [FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler (rebased)

2019-02-07 Thread GitBox
tillrohrmann commented on issue #7662: [FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler (rebased) URL: https://github.com/apache/flink/pull/7662#issuecomment-461507944 @flinkbot approve description

[GitHub] greghogan commented on a change in pull request #7575: [FLINK-11418][docs] Fix version of bundler to 1.16.1

2019-02-07 Thread GitBox
greghogan commented on a change in pull request #7575: [FLINK-11418][docs] Fix version of bundler to 1.16.1 URL: https://github.com/apache/flink/pull/7575#discussion_r254750131 ## File path: docs/README.md ## @@ -12,11 +12,11 @@ dependencies are installed locally when you

[GitHub] StefanRRichter merged pull request #7612: [FLINK-11483][tests] Improve StreamOperatorSnapshotRestoreTest with JUnit's Parameterized

2019-02-07 Thread GitBox
StefanRRichter merged pull request #7612: [FLINK-11483][tests] Improve StreamOperatorSnapshotRestoreTest with JUnit's Parameterized URL: https://github.com/apache/flink/pull/7612 This is an automated message from the Apache

[jira] [Closed] (FLINK-11315) Make magic number in KvStateSerializer as a constant value to make more readable

2019-02-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-11315. -- Resolution: Fixed Fix Version/s: 1.8.0 Merged in: master: e6a318c420 > Make magic numb

[GitHub] StefanRRichter merged pull request #7482: [Flink-11315] Make magic number in KvStateSerializer as a constant va…

2019-02-07 Thread GitBox
StefanRRichter merged pull request #7482: [Flink-11315] Make magic number in KvStateSerializer as a constant va… URL: https://github.com/apache/flink/pull/7482 This is an automated message from the Apache Git Service. To res

[GitHub] StefanRRichter commented on issue #7482: [Flink-11315] Make magic number in KvStateSerializer as a constant va…

2019-02-07 Thread GitBox
StefanRRichter commented on issue #7482: [Flink-11315] Make magic number in KvStateSerializer as a constant va… URL: https://github.com/apache/flink/pull/7482#issuecomment-461481839 LGTM 👍 This is an automated message from t

[GitHub] yanghua commented on issue #7263: [FLINK-11081] Support binding port range for REST server

2019-02-07 Thread GitBox
yanghua commented on issue #7263: [FLINK-11081] Support binding port range for REST server URL: https://github.com/apache/flink/pull/7263#issuecomment-461472153 @zentol Does this PR need any more changes? This is an automated

[GitHub] StefanRRichter closed pull request #7481: [Flink-11314] Reuse RocksDBWriteBatchWrapper in the flush function of…

2019-02-07 Thread GitBox
StefanRRichter closed pull request #7481: [Flink-11314] Reuse RocksDBWriteBatchWrapper in the flush function of… URL: https://github.com/apache/flink/pull/7481 This is an automated message from the Apache Git Service. To res

[GitHub] StefanRRichter commented on issue #7481: [Flink-11314] Reuse RocksDBWriteBatchWrapper in the flush function of…

2019-02-07 Thread GitBox
StefanRRichter commented on issue #7481: [Flink-11314] Reuse RocksDBWriteBatchWrapper in the flush function of… URL: https://github.com/apache/flink/pull/7481#issuecomment-461471778 Manually merged in 1b71e447e0. This is an a

[GitHub] StefanRRichter commented on issue #7448: [hotfix][runtime] fix synchronous snapshots completed log

2019-02-07 Thread GitBox
StefanRRichter commented on issue #7448: [hotfix][runtime] fix synchronous snapshots completed log URL: https://github.com/apache/flink/pull/7448#issuecomment-461470326 @zsq12138 Till is right, even if it is called asynchronous snapshot, there is usually a very short synchronous part, for

[GitHub] StefanRRichter closed pull request #7448: [hotfix][runtime] fix synchronous snapshots completed log

2019-02-07 Thread GitBox
StefanRRichter closed pull request #7448: [hotfix][runtime] fix synchronous snapshots completed log URL: https://github.com/apache/flink/pull/7448 This is an automated message from the Apache Git Service. To respond to the m

[jira] [Closed] (FLINK-11314) Reuse RocksDBWriteBatchWrapper in the flush method of RocksDBMapState

2019-02-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-11314. -- Resolution: Fixed Fix Version/s: 1.8.0 Merged in: master: 1b71e447e0 > Reuse RocksDBWr

[GitHub] StefanRRichter commented on issue #7481: [Flink-11314] Reuse RocksDBWriteBatchWrapper in the flush function of…

2019-02-07 Thread GitBox
StefanRRichter commented on issue #7481: [Flink-11314] Reuse RocksDBWriteBatchWrapper in the flush function of… URL: https://github.com/apache/flink/pull/7481#issuecomment-461466886 Thanks for the contribution, LGTM 👍 Merging. --

[jira] [Assigned] (FLINK-11546) Add option to manually set job ID in CLI

2019-02-07 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-11546: Assignee: vinoyang > Add option to manually set job ID in CLI > -

[jira] [Assigned] (FLINK-11534) Don't exit JVM after job termination with standalone job

2019-02-07 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-11534: Assignee: vinoyang > Don't exit JVM after job termination with standalone job > -

[GitHub] igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254725322 ## File path: flink-tests/src/test/scala/org/apache/flink/api/scala/migration/Scala

[GitHub] asfgit closed pull request #7492: [FLINK-11311] [datastream] fix StreamSource implements StreamOperator interface multiple times

2019-02-07 Thread GitBox
asfgit closed pull request #7492: [FLINK-11311] [datastream] fix StreamSource implements StreamOperator interface multiple times URL: https://github.com/apache/flink/pull/7492 This is an automated message from the Apache Git

[jira] [Closed] (FLINK-11311) StreamSource implements StreamOperator interface multiple times.

2019-02-07 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-11311. -- Resolution: Fixed Merged in: master: e354d0bf70 > StreamSource implements StreamOperator inte

[GitHub] StefanRRichter commented on issue #7492: [FLINK-11311] [datastream] fix StreamSource implements StreamOperator interface multiple times

2019-02-07 Thread GitBox
StefanRRichter commented on issue #7492: [FLINK-11311] [datastream] fix StreamSource implements StreamOperator interface multiple times URL: https://github.com/apache/flink/pull/7492#issuecomment-461461337 LGTM 👍 This is an

[jira] [Commented] (FLINK-11533) Retrieve job class name from JAR manifest in ClassPathJobGraphRetriever

2019-02-07 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762750#comment-16762750 ] vinoyang commented on FLINK-11533: -- I'd like to claim this ticket. > Retrieve job clas

[GitHub] igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254721699 ## File path: flink-scala/src/main/scala/org/apache/flink/api/scala/package.scala #

[jira] [Assigned] (FLINK-11533) Retrieve job class name from JAR manifest in ClassPathJobGraphRetriever

2019-02-07 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-11533: Assignee: vinoyang > Retrieve job class name from JAR manifest in ClassPathJobGraphRetriever > --

[jira] [Assigned] (FLINK-11532) Remove the deprecation of ExternalCatalogTable.builder()

2019-02-07 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-11532: Assignee: vinoyang > Remove the deprecation of ExternalCatalogTable.builder() > -

[jira] [Updated] (FLINK-11551) Allow RpcEndpoints to execute asynchronous stop operations

2019-02-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11551: --- Labels: pull-request-available (was: ) > Allow RpcEndpoints to execute asynchronous stop op

[GitHub] flinkbot commented on issue #7665: [FLINK-11551][rpc] Allow RpcEndpoint to execute asynchronous stop operations

2019-02-07 Thread GitBox
flinkbot commented on issue #7665: [FLINK-11551][rpc] Allow RpcEndpoint to execute asynchronous stop operations URL: https://github.com/apache/flink/pull/7665#issuecomment-461453001 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community t

[GitHub] tillrohrmann opened a new pull request #7665: [FLINK-11551][rpc] Allow RpcEndpoint to execute asynchronous stop operations

2019-02-07 Thread GitBox
tillrohrmann opened a new pull request #7665: [FLINK-11551][rpc] Allow RpcEndpoint to execute asynchronous stop operations URL: https://github.com/apache/flink/pull/7665 ## What is the purpose of the change Replace RpcEndpoin#postStop with RpcEndpoint#onStop method which can execute

[GitHub] igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254711991 ## File path: flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/Specif

[GitHub] igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254712136 ## File path: flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/Tuple2

[GitHub] igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254711911 ## File path: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/

[jira] [Created] (FLINK-11551) Allow RpcEndpoints to execute asynchronous stop operations

2019-02-07 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-11551: - Summary: Allow RpcEndpoints to execute asynchronous stop operations Key: FLINK-11551 URL: https://issues.apache.org/jira/browse/FLINK-11551 Project: Flink

[GitHub] igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254709919 ## File path: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/

[GitHub] igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
igalshilman commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254708093 ## File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/Compos

[jira] [Comment Edited] (FLINK-11498) Getting java.lang.InstantiationError when trying to install flink 1.7.1 version

2019-02-07 Thread sambi reddy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762711#comment-16762711 ] sambi reddy edited comment on FLINK-11498 at 2/7/19 2:30 PM: -

[jira] [Commented] (FLINK-11498) Getting java.lang.InstantiationError when trying to install flink 1.7.1 version

2019-02-07 Thread sambi reddy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762711#comment-16762711 ] sambi reddy commented on FLINK-11498: - [~till.rohrmann] yes {norformat} java -vers

[GitHub] sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-02-07 Thread GitBox
sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-461442650 Hi, @twalthr I will be very grateful if you have time to have look at the PR. Great thanks for the offline disc

[GitHub] StefanRRichter commented on issue #7612: [FLINK-11483][tests] Improve StreamOperatorSnapshotRestoreTest with JUnit's Parameterized

2019-02-07 Thread GitBox
StefanRRichter commented on issue #7612: [FLINK-11483][tests] Improve StreamOperatorSnapshotRestoreTest with JUnit's Parameterized URL: https://github.com/apache/flink/pull/7612#issuecomment-461437597 @tzulitai changing the ping seemingly did not work, but now I saw it anyways :-) I have n

[GitHub] greghogan commented on issue #6598: [FLINK-10179] [Startup Shell Scripts] .bat script to start Flink history server

2019-02-07 Thread GitBox
greghogan commented on issue #6598: [FLINK-10179] [Startup Shell Scripts] .bat script to start Flink history server URL: https://github.com/apache/flink/pull/6598#issuecomment-461441591 @zentol are you still on Windows? This

[jira] [Updated] (FLINK-11449) Uncouple the Expression class from RexNodes

2019-02-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11449: --- Labels: pull-request-available (was: ) > Uncouple the Expression class from RexNodes >

[GitHub] flinkbot commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-02-07 Thread GitBox
flinkbot commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-461438683 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review yo

[GitHub] sunjincheng121 opened a new pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-02-07 Thread GitBox
sunjincheng121 opened a new pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664 ## What is the purpose of the change *(This pull request uncouple the Expression class from RexNodes.)* ## Brief cha

[GitHub] greghogan commented on issue #6962: change accumulator value to be formatted with digit group separator

2019-02-07 Thread GitBox
greghogan commented on issue #6962: change accumulator value to be formatted with digit group separator URL: https://github.com/apache/flink/pull/6962#issuecomment-461438304 Is this valid if we have a non-numeric accumulator? Not sure if that is an issue. -

[GitHub] greghogan commented on issue #7015: Add the -p option to nc

2019-02-07 Thread GitBox
greghogan commented on issue #7015: Add the -p option to nc URL: https://github.com/apache/flink/pull/7015#issuecomment-461437299 `nc` on MacOS does not allow use of both `-l` and `-p`. Ubuntu seems fine either with or without `-p`. What variant of `nc` is Flink's Docker image using? Is th

[GitHub] zentol commented on issue #7659: [FLINK-11514][client] Port ClusterClientTest

2019-02-07 Thread GitBox
zentol commented on issue #7659: [FLINK-11514][client] Port ClusterClientTest URL: https://github.com/apache/flink/pull/7659#issuecomment-461433082 @GJL I've addressed your comments, and then decided to rework the savepoint-trigger tests. Additionally I fixed a bug in the RestClusterClie

[GitHub] aljoscha commented on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer

2019-02-07 Thread GitBox
aljoscha commented on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer URL: https://github.com/apache/flink/pull/7655#issuecomment-461431281 @flinkbot attention @tzulitai @igalshilman This is an

[GitHub] greghogan commented on issue #7407: [FLINK-11260] Bump the Janino compiler to 3.0.11

2019-02-07 Thread GitBox
greghogan commented on issue #7407: [FLINK-11260] Bump the Janino compiler to 3.0.11 URL: https://github.com/apache/flink/pull/7407#issuecomment-461432304 I think we're better off with a process and schedule for updating dependencies during the release cycle. -

[GitHub] flinkbot edited a comment on issue #7644: [FLINK-11375][schedule] releaseSlot in SlotSharingManager using

2019-02-07 Thread GitBox
flinkbot edited a comment on issue #7644: [FLINK-11375][schedule] releaseSlot in SlotSharingManager using URL: https://github.com/apache/flink/pull/7644#issuecomment-459927197 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[GitHub] zentol commented on a change in pull request #7659: [FLINK-11514][client] Port ClusterClientTest

2019-02-07 Thread GitBox
zentol commented on a change in pull request #7659: [FLINK-11514][client] Port ClusterClientTest URL: https://github.com/apache/flink/pull/7659#discussion_r254694930 ## File path: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java #

[GitHub] flinkbot edited a comment on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer

2019-02-07 Thread GitBox
flinkbot edited a comment on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer URL: https://github.com/apache/flink/pull/7655#issuecomment-461015963 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to r

[GitHub] StefanRRichter commented on issue #7644: [FLINK-11375][schedule] releaseSlot in SlotSharingManager using

2019-02-07 Thread GitBox
StefanRRichter commented on issue #7644: [FLINK-11375][schedule] releaseSlot in SlotSharingManager using URL: https://github.com/apache/flink/pull/7644#issuecomment-461431966 @eaglewatcherwb thanks for the contribution! The description sounds like this problem could already be solved by th

[GitHub] aljoscha edited a comment on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer

2019-02-07 Thread GitBox
aljoscha edited a comment on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer URL: https://github.com/apache/flink/pull/7655#issuecomment-461430276 I added the test (that is essentially written by @igalshilman)

[GitHub] flinkbot edited a comment on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer

2019-02-07 Thread GitBox
flinkbot edited a comment on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer URL: https://github.com/apache/flink/pull/7655#issuecomment-461015963 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to r

[GitHub] aljoscha commented on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer

2019-02-07 Thread GitBox
aljoscha commented on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer URL: https://github.com/apache/flink/pull/7655#issuecomment-461431524 @flinkbot approve description This is an automated me

[GitHub] aljoscha commented on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer

2019-02-07 Thread GitBox
aljoscha commented on issue #7655: [FLINK-11539] Add TypeSerializerSnapshot for TraversableSerializer URL: https://github.com/apache/flink/pull/7655#issuecomment-461430276 I added the test (that is essentially written by @igalshilman. ---

[GitHub] greghogan commented on issue #7555: [FLINK-11373] CliFrontend cuts off reason for error messages

2019-02-07 Thread GitBox
greghogan commented on issue #7555: [FLINK-11373] CliFrontend cuts off reason for error messages URL: https://github.com/apache/flink/pull/7555#issuecomment-461428878 @leesf we may want to retain a short message while increasing the detail or specificity. We can log stacktraces but for CLI

[GitHub] StefanRRichter edited a comment on issue #7586: [FLINK-10912][rocksdb] Configurable RocksDBStateBackend options

2019-02-07 Thread GitBox
StefanRRichter edited a comment on issue #7586: [FLINK-10912][rocksdb] Configurable RocksDBStateBackend options URL: https://github.com/apache/flink/pull/7586#issuecomment-461428217 @Myasuka Thanks a lot for this contribution. Before starting the review, I first have a few high level quest

[GitHub] StefanRRichter commented on issue #7586: [FLINK-10912][rocksdb] Configurable RocksDBStateBackend options

2019-02-07 Thread GitBox
StefanRRichter commented on issue #7586: [FLINK-10912][rocksdb] Configurable RocksDBStateBackend options URL: https://github.com/apache/flink/pull/7586#issuecomment-461428217 @Myasuka Thanks a lot for this contribution. Before starting the review, I first have a few high level questions. W

[GitHub] greghogan commented on issue #7560: [FLINK-11344][webfrontend] display all execution attempts on web

2019-02-07 Thread GitBox
greghogan commented on issue #7560: [FLINK-11344][webfrontend] display all execution attempts on web URL: https://github.com/apache/flink/pull/7560#issuecomment-461423743 @eaglewatcherwb could you include before and after screenshots? Do we have a simple, reproducible way to create failed

[GitHub] greghogan commented on issue #7599: [FLINK-11442] upgrade oss sdk version

2019-02-07 Thread GitBox
greghogan commented on issue #7599: [FLINK-11442] upgrade oss sdk version URL: https://github.com/apache/flink/pull/7599#issuecomment-461421985 LGTM. Upstream fix looks to be [here](https://github.com/aliyun/aliyun-oss-java-sdk/commit/956b0e656ec452a38b0851a29eb67ced409ebb70). Updated depe

[jira] [Closed] (FLINK-11524) LeaderChangeClusterComponentsTest.testReelectionOfJobMaster failed on Travis

2019-02-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-11524. - Resolution: Fixed Fix Version/s: 1.8.0 Fixed via 0baad99de3387fd01ca16a43857b5f0b4ae52101

[GitHub] tillrohrmann closed pull request #7654: [FLINK-11524] Solve race condition in EmbeddedLeaderService

2019-02-07 Thread GitBox
tillrohrmann closed pull request #7654: [FLINK-11524] Solve race condition in EmbeddedLeaderService URL: https://github.com/apache/flink/pull/7654 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254637872 ## File path: flink-scala/src/main/scala/org/apache/flink/api/scala/package.scala

[GitHub] aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254636962 ## File path: flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/Tuple2Cas

[GitHub] aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254631118 ## File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/Composite

[GitHub] aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254636297 ## File path: flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/SpecificC

[GitHub] aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254635530 ## File path: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/Tup

[GitHub] aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254635974 ## File path: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/Tup

[GitHub] aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254639261 ## File path: flink-scala/src/test/scala/org/apache/flink/api/scala/typeutils/ScalaCas

[GitHub] aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

2019-02-07 Thread GitBox
aljoscha commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family URL: https://github.com/apache/flink/pull/7658#discussion_r254674935 ## File path: flink-tests/src/test/scala/org/apache/flink/api/scala/migration/ScalaSer

[GitHub] GJL commented on a change in pull request #7661: [FLINK-11515][client] Port ClientTest

2019-02-07 Thread GitBox
GJL commented on a change in pull request #7661: [FLINK-11515][client] Port ClientTest URL: https://github.com/apache/flink/pull/7661#discussion_r254673467 ## File path: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ## @@ -216,41 +177,13 @@ p

[GitHub] GJL commented on a change in pull request #7661: [FLINK-11515][client] Port ClientTest

2019-02-07 Thread GitBox
GJL commented on a change in pull request #7661: [FLINK-11515][client] Port ClientTest URL: https://github.com/apache/flink/pull/7661#discussion_r254674001 ## File path: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java ## @@ -752

[GitHub] GJL commented on a change in pull request #7661: [FLINK-11515][client] Port ClientTest

2019-02-07 Thread GitBox
GJL commented on a change in pull request #7661: [FLINK-11515][client] Port ClientTest URL: https://github.com/apache/flink/pull/7661#discussion_r254672065 ## File path: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ## @@ -102,39 +92,14 @@ pu

[GitHub] GJL commented on a change in pull request #7661: [FLINK-11515][client] Port ClientTest

2019-02-07 Thread GitBox
GJL commented on a change in pull request #7661: [FLINK-11515][client] Port ClientTest URL: https://github.com/apache/flink/pull/7661#discussion_r254673664 ## File path: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ## @@ -280,10 +213,6 @@ pu

[jira] [Commented] (FLINK-11449) Uncouple the Expression class from RexNodes

2019-02-07 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762641#comment-16762641 ] sunjincheng commented on FLINK-11449: - Thanks [~twalthr] , I'll open the PR. today l

[GitHub] GJL commented on a change in pull request #7659: [FLINK-11514][client] Port ClusterClientTest

2019-02-07 Thread GitBox
GJL commented on a change in pull request #7659: [FLINK-11514][client] Port ClusterClientTest URL: https://github.com/apache/flink/pull/7659#discussion_r254670295 ## File path: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java ##

  1   2   >