[jira] [Commented] (FLINK-9061) add entropy to s3 path for better scalability

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544858#comment-16544858 ] ASF GitHub Bot commented on FLINK-9061: --- Github user indrc commented on the issue:

[GitHub] flink issue #6302: [FLINK-9061][checkpointing] add entropy to s3 path for be...

2018-07-15 Thread indrc
Github user indrc commented on the issue: https://github.com/apache/flink/pull/6302 @StephanEwen Thanks for your comments and feedback, my replies below 1. after talking to @StefanRRichter we decided to bring in this dependency to use a standard library instead; initially the pr ha

[jira] [Commented] (FLINK-9853) add hex support in table api and sql

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544848#comment-16544848 ] ASF GitHub Bot commented on FLINK-9853: --- Github user xueyumusic commented on a diff

[GitHub] flink pull request #6337: [FLINK-9853][Tabel API & SQL] add HEX support

2018-07-15 Thread xueyumusic
Github user xueyumusic commented on a diff in the pull request: https://github.com/apache/flink/pull/6337#discussion_r202581145 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala --- @@ -182,4 +184,6 @@ object Scalar

[jira] [Updated] (FLINK-9839) End-to-end test: Streaming job with SSL

2018-07-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-9839: - Affects Version/s: 1.6.0 > End-to-end test: Streaming job with SSL >

[jira] [Updated] (FLINK-9839) End-to-end test: Streaming job with SSL

2018-07-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-9839: - Fix Version/s: 1.6.0 > End-to-end test: Streaming job with SSL >

[jira] [Updated] (FLINK-9839) End-to-end test: Streaming job with SSL

2018-07-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-9839: - Priority: Blocker (was: Major) > End-to-end test: Streaming job with SSL > -

[jira] [Commented] (FLINK-9630) Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544812#comment-16544812 ] ASF GitHub Bot commented on FLINK-9630: --- Github user yanghua commented on the issue

[GitHub] flink issue #6336: [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause...

2018-07-15 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6336 @ubyyj you can use this command to trigger Travis rebuild : ``` git commit --allow-empty -m "" ``` ---

[GitHub] flink pull request #6281: [FLINK-9750] Add new StreamingFileSink with Resuma...

2018-07-15 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/6281#discussion_r202574665 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java --- @@ -0,0 +1,397 @@ +/*

[jira] [Commented] (FLINK-9750) Create new StreamingFileSink that works on Flink's FileSystem abstraction

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544811#comment-16544811 ] ASF GitHub Bot commented on FLINK-9750: --- Github user kl0u commented on a diff in th

[jira] [Commented] (FLINK-9853) add hex support in table api and sql

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544807#comment-16544807 ] ASF GitHub Bot commented on FLINK-9853: --- Github user yanghua commented on a diff in

[jira] [Commented] (FLINK-9853) add hex support in table api and sql

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544808#comment-16544808 ] ASF GitHub Bot commented on FLINK-9853: --- Github user yanghua commented on a diff in

[GitHub] flink pull request #6337: [FLINK-9853][Tabel API & SQL] add HEX support

2018-07-15 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6337#discussion_r202573057 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala --- @@ -182,4 +184,6 @@ object ScalarFun

[GitHub] flink pull request #6337: [FLINK-9853][Tabel API & SQL] add HEX support

2018-07-15 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6337#discussion_r202572746 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -400,6 +400,12 @@ trait ImplicitExpressionO

[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...

2018-07-15 Thread lamber-ken
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6321 @StephanEwen, if the original authors of the code had an intention of writing the code as it is now, I'll follow your advice and leave it as it is. ---

[jira] [Commented] (FLINK-9829) The wrapper classes be compared by symbol of '==' directly in BigDecSerializer.java

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544753#comment-16544753 ] ASF GitHub Bot commented on FLINK-9829: --- Github user lamber-ken commented on the is

[jira] [Commented] (FLINK-9829) The wrapper classes be compared by symbol of '==' directly in BigDecSerializer.java

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544748#comment-16544748 ] ASF GitHub Bot commented on FLINK-9829: --- Github user lamber-ken commented on the is

[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...

2018-07-15 Thread lamber-ken
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6321 @zentol, @StephanEwen, thank you for explaining the question about hotfixes. I was not very clear about whether to create a jira or hotfix before. ---

[jira] [Commented] (FLINK-9829) The wrapper classes be compared by symbol of '==' directly in BigDecSerializer.java

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544745#comment-16544745 ] ASF GitHub Bot commented on FLINK-9829: --- Github user lamber-ken commented on a diff

[GitHub] flink pull request #6321: [FLINK-9829] fix the wrapper classes be compared b...

2018-07-15 Thread lamber-ken
Github user lamber-ken commented on a diff in the pull request: https://github.com/apache/flink/pull/6321#discussion_r202566500 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BigDecSerializer.java --- @@ -69,17 +69,17 @@ public void serialize(BigDeci

[jira] [Commented] (FLINK-9630) Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544722#comment-16544722 ] ASF GitHub Bot commented on FLINK-9630: --- GitHub user ubyyj reopened a pull request:

[jira] [Commented] (FLINK-9630) Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544723#comment-16544723 ] ASF GitHub Bot commented on FLINK-9630: --- Github user ubyyj commented on the issue:

[jira] [Commented] (FLINK-9630) Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544721#comment-16544721 ] ASF GitHub Bot commented on FLINK-9630: --- Github user ubyyj commented on the issue:

[GitHub] flink issue #6336: [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause...

2018-07-15 Thread ubyyj
Github user ubyyj commented on the issue: https://github.com/apache/flink/pull/6336 trigger travis build ---

[jira] [Commented] (FLINK-9630) Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544720#comment-16544720 ] ASF GitHub Bot commented on FLINK-9630: --- Github user ubyyj closed the pull request

[GitHub] flink issue #6336: [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause...

2018-07-15 Thread ubyyj
Github user ubyyj commented on the issue: https://github.com/apache/flink/pull/6336 unrelavent build failure, close and will reopen again, to trigger travis build again ---

[GitHub] flink pull request #6336: [FLINK-9630] [connector] Kafka09PartitionDiscovere...

2018-07-15 Thread ubyyj
Github user ubyyj closed the pull request at: https://github.com/apache/flink/pull/6336 ---

[GitHub] flink pull request #6336: [FLINK-9630] [connector] Kafka09PartitionDiscovere...

2018-07-15 Thread ubyyj
GitHub user ubyyj reopened a pull request: https://github.com/apache/flink/pull/6336 [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause connection … …leak on TopicAuthorizationException **(The sections below can be removed for hotfixes of typos)** ##

[jira] [Closed] (FLINK-9751) Add a RecoverableWriter to the FileSystem abstraction

2018-07-15 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-9751. --- > Add a RecoverableWriter to the FileSystem abstraction > ---

[jira] [Resolved] (FLINK-9751) Add a RecoverableWriter to the FileSystem abstraction

2018-07-15 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-9751. - Resolution: Fixed Implemented in e2960949bf84534978cb0be9f1a53cd783b43001 9d238e1a170a96c311b0daf

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544694#comment-16544694 ] ASF GitHub Bot commented on FLINK-9489: --- Github user StefanRRichter commented on a

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202556109 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java --- @@ -80,13 +82,57 @@ public E peek(

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544693#comment-16544693 ] ASF GitHub Bot commented on FLINK-9489: --- Github user StefanRRichter commented on a

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202556091 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -446,8 +485,10 @@ public String toString(

[jira] [Commented] (FLINK-9750) Create new StreamingFileSink that works on Flink's FileSystem abstraction

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544692#comment-16544692 ] ASF GitHub Bot commented on FLINK-9750: --- Github user StephanEwen commented on a dif

[GitHub] flink pull request #6281: [FLINK-9750] Add new StreamingFileSink with Resuma...

2018-07-15 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/6281#discussion_r202556032 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java --- @@ -0,0 +1,397 @@ +

[GitHub] flink issue #6326: Mutual authentication for internal communication

2018-07-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6326 Thanks for the review and for merging. @NicoK has an end-to-end test for SSL PR already (#6327) which would be great to rebase on top of this change. ---

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202552616 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/PriorityComparable.java --- @@ -0,0 +1,35 @@ +/* + * Licensed to the Apach

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202552483 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyExtractorFunction.java --- @@ -28,9 +28,22 @@ @FunctionalInterface pu

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544676#comment-16544676 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544670#comment-16544670 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544674#comment-16544674 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202553765 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -342,16 +379,20 @@ private void restorePar

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544668#comment-16544668 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544669#comment-16544669 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202553524 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java --- @@ -80,13 +82,57 @@ public E peek()

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544667#comment-16544667 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544671#comment-16544671 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202553358 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TieBreakingPriorityComparator.java --- @@ -85,10 +85,10 @@ public int compare(T o1

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544673#comment-16544673 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544675#comment-16544675 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202552563 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupPartitioner.java --- @@ -264,6 +265,42 @@ public void writeMappingsInKeyGr

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202553887 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -446,8 +485,10 @@ public String toString()

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202552705 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastStateBackendMetaInfo.java --- @@ -24,37 +24,46 @@ import o

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544672#comment-16544672 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202553958 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueueStateSnapshot.java --- @@ -60,36 +61,35 @@ /**

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202552876 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastStateBackendMetaInfo.java --- @@ -63,54 +72,46 @@ public Regis

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544663#comment-16544663 ] ASF GitHub Bot commented on FLINK-7251: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r202553410 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -584,21 +581,6 @@ private static void registerFactory(Type

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544657#comment-16544657 ] ASF GitHub Bot commented on FLINK-7251: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r202552984 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -584,21 +581,6 @@ private static void registerFactory(Type

[jira] [Created] (FLINK-9854) Allow passing multi-line input to SQL Client CLI

2018-07-15 Thread Timo Walther (JIRA)
Timo Walther created FLINK-9854: --- Summary: Allow passing multi-line input to SQL Client CLI Key: FLINK-9854 URL: https://issues.apache.org/jira/browse/FLINK-9854 Project: Flink Issue Type: Sub-

[jira] [Commented] (FLINK-8858) Add support for INSERT INTO in SQL Client

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544654#comment-16544654 ] ASF GitHub Bot commented on FLINK-8858: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-8858) Add support for INSERT INTO in SQL Client

2018-07-15 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8858. - Resolution: Fixed Fix Version/s: 1.6.0 Fixed in 1.6.0: 695bc56a9e20b9d86eea14a02899b400d32

[GitHub] flink pull request #6332: [FLINK-8858] [sql-client] Add support for INSERT I...

2018-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6332 ---

[jira] [Resolved] (FLINK-9483) "Building Flink" doc doesn't highlight quick build command

2018-07-15 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-9483. - Resolution: Fixed > "Building Flink" doc doesn't highlight quick build command >

[jira] [Resolved] (FLINK-8544) JSONKeyValueDeserializationSchema throws NPE when message key is null

2018-07-15 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-8544. - Resolution: Fixed Fix Version/s: 1.6.0 > JSONKeyValueDeserializationSchema throws

[jira] [Resolved] (FLINK-9758) ContinuousFileProcessingTest failed due to not setting runtimeContext

2018-07-15 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-9758. - Resolution: Fixed Fix Version/s: (was: 1.5.2) 1.6.0 > Conti

[jira] [Commented] (FLINK-8731) TwoInputStreamTaskTest flaky on travis

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544632#comment-16544632 ] ASF GitHub Bot commented on FLINK-8731: --- GitHub user dawidwys opened a pull request

[jira] [Updated] (FLINK-8731) TwoInputStreamTaskTest flaky on travis

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-8731: -- Labels: pull-request-available test-stability (was: test-stability) > TwoInputStreamTaskTest f

[GitHub] flink pull request #6338: [FLINK-8731] Replaced mockito with custom mock in ...

2018-07-15 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/6338 [FLINK-8731] Replaced mockito with custom mock in TestInputChannel Replaced questionable usage if Mockito with custom written mock. You can merge this pull request into a Git repository by running

[jira] [Commented] (FLINK-9758) ContinuousFileProcessingTest failed due to not setting runtimeContext

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544631#comment-16544631 ] ASF GitHub Bot commented on FLINK-9758: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8544) JSONKeyValueDeserializationSchema throws NPE when message key is null

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544629#comment-16544629 ] ASF GitHub Bot commented on FLINK-8544: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-9483) "Building Flink" doc doesn't highlight quick build command

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544630#comment-16544630 ] ASF GitHub Bot commented on FLINK-9483: --- Github user asfgit closed the pull request

[GitHub] flink pull request #6109: [FLINK-9483] 'Building Flink' doc doesn't highligh...

2018-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6109 ---

[GitHub] flink pull request #6260: [FLINK-9758] Fix ContinuousFileProcessingTest fail...

2018-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6260 ---

[GitHub] flink pull request #5516: [FLINK-8544] [Kafka Connector] Handle null message...

2018-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5516 ---

[jira] [Commented] (FLINK-9675) Avoid FileInputStream/FileOutputStream

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544617#comment-16544617 ] ASF GitHub Bot commented on FLINK-9675: --- Github user tedyu commented on the issue:

[GitHub] flink issue #6335: [FLINK-9675] [fs] Avoid FileInputStream/FileOutputStream

2018-07-15 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/6335 From https://travis-ci.org/apache/flink/jobs/404127448 : ``` Failed tests: BlobServerPutTest.testPutBufferFailsIncomingForJob Expected: (an instance of java.io.IOException and excepti

[GitHub] flink issue #6326: Mutual authentication for internal communication

2018-07-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6326 Pushed another commit that rebuilds the generated config docs ---

[GitHub] flink pull request #6050: [FLINK-9404][flink-connector-filesystem] Adapter v...

2018-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6050 ---

[jira] [Commented] (FLINK-9404) Adapter viewfs in BucketingSink when verify that truncate actually works

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544611#comment-16544611 ] ASF GitHub Bot commented on FLINK-9404: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-9061) add entropy to s3 path for better scalability

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544603#comment-16544603 ] ASF GitHub Bot commented on FLINK-9061: --- Github user StephanEwen commented on the i

[GitHub] flink issue #6302: [FLINK-9061][checkpointing] add entropy to s3 path for be...

2018-07-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6302 Thanks for this contribution, that's a valuable fix. I have a few thoughts and suggestions on how we might improve the feature a bit still: - Can we get id of the `commons-text` depende

[jira] [Commented] (FLINK-9121) Remove Flip-6 prefixes from code base

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544602#comment-16544602 ] ASF GitHub Bot commented on FLINK-9121: --- Github user Matrix42 commented on a diff i

[GitHub] flink pull request #5801: [FLINK-9121] [flip6] Remove Flip6 prefixes and oth...

2018-07-15 Thread Matrix42
Github user Matrix42 commented on a diff in the pull request: https://github.com/apache/flink/pull/5801#discussion_r202548776 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java --- @@ -49,30 +54,45 @@ public YarnClusterDescriptor( @Ove

[jira] [Commented] (FLINK-9829) The wrapper classes be compared by symbol of '==' directly in BigDecSerializer.java

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544599#comment-16544599 ] ASF GitHub Bot commented on FLINK-9829: --- Github user StephanEwen commented on the i

[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...

2018-07-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6321 Is the issue addressed here a bug? If not, and if it seems that the original authors of the code had an intention of writing the code as it is now, I would suggest to leave it as it is. ---

[jira] [Commented] (FLINK-9829) The wrapper classes be compared by symbol of '==' directly in BigDecSerializer.java

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544598#comment-16544598 ] ASF GitHub Bot commented on FLINK-9829: --- Github user StephanEwen commented on the i

[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...

2018-07-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6321 This would be clearly not a hotfix. As per the pull request template, contributors should use hotfixes mainly for typos and JavaDoc updates. ---

[jira] [Commented] (FLINK-9794) JDBCOutputFormat does not consider idle connection and multithreads synchronization

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544554#comment-16544554 ] ASF GitHub Bot commented on FLINK-9794: --- Github user jrthe42 commented on the issue

[GitHub] flink issue #6301: [FLINK-9794] [jdbc] JDBCOutputFormat does not consider id...

2018-07-15 Thread jrthe42
Github user jrthe42 commented on the issue: https://github.com/apache/flink/pull/6301 Hi @hequn8128, I agree with you that a connection pool is more effective using connection resource. I didn't choose connection pool because that will introduce new dependencies, and I'm not sure if t

[jira] [Commented] (FLINK-9841) Web UI only show partial taskmanager log

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544549#comment-16544549 ] ASF GitHub Bot commented on FLINK-9841: --- Github user yanghua commented on the issue

[GitHub] flink issue #6329: [FLINK-9841] Web UI only show partial taskmanager log

2018-07-15 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6329 @dawidwys can you review this PR? ---

[jira] [Commented] (FLINK-9675) Avoid FileInputStream/FileOutputStream

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544544#comment-16544544 ] ASF GitHub Bot commented on FLINK-9675: --- Github user zhangminglei commented on the

[GitHub] flink issue #6335: [FLINK-9675] [fs] Avoid FileInputStream/FileOutputStream

2018-07-15 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6335 @tedyu Could you please take a look on this ? Thank you very much. ---

[jira] [Updated] (FLINK-9853) add hex support in table api and sql

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9853: -- Labels: pull-request-available (was: ) > add hex support in table api and sql > --

[jira] [Commented] (FLINK-9853) add hex support in table api and sql

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544542#comment-16544542 ] ASF GitHub Bot commented on FLINK-9853: --- GitHub user xueyumusic opened a pull reque

[GitHub] flink pull request #6337: [FLINK-9853][Tabel API & SQL] add HEX support

2018-07-15 Thread xueyumusic
GitHub user xueyumusic opened a pull request: https://github.com/apache/flink/pull/6337 [FLINK-9853][Tabel API & SQL] add HEX support ## What is the purpose of the change This PR propose to add HEX in table api and sql, the syntax like mysql, which could take int or string argu

  1   2   >