[jira] [Commented] (FLINK-9758) ContinuousFileProcessingTest failed due to not setting runtimeContext

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544400#comment-16544400 ] ASF GitHub Bot commented on FLINK-9758: --- Github user Myasuka commented on the issue

[GitHub] flink issue #6260: [FLINK-9758] Fix ContinuousFileProcessingTest failure due...

2018-07-14 Thread Myasuka
Github user Myasuka commented on the issue: https://github.com/apache/flink/pull/6260 @dawidwys thanks for your suggestion, I have already refactor code with a helper method to create the continuous-monitoring function. ---

[jira] [Updated] (FLINK-9675) Avoid FileInputStream/FileOutputStream

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9675: -- Labels: filesystem pull-request-available (was: filesystem) > Avoid FileInputStream/FileOutput

[jira] [Commented] (FLINK-9675) Avoid FileInputStream/FileOutputStream

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544391#comment-16544391 ] ASF GitHub Bot commented on FLINK-9675: --- GitHub user zhangminglei opened a pull req

[GitHub] flink pull request #6335: [FLINK-9675] [fs] Avoid FileInputStream/FileOutput...

2018-07-14 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/6335 [FLINK-9675] [fs] Avoid FileInputStream/FileOutputStream ## What is the purpose of the change Avoid using FileInputStream/FileOutputStream because they rely on finalizers (before Java

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544291#comment-16544291 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544289#comment-16544289 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544290#comment-16544290 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544288#comment-16544288 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[GitHub] flink pull request #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified...

2018-07-14 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6323#discussion_r202520986 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/SourceSink.java --- @@ -51,16 +51,10 @@ public void addPrope

[GitHub] flink pull request #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified...

2018-07-14 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6323#discussion_r202521065 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFormatFactory.scala --- @@ -16,42 +16,17 @@ * limitations

[GitHub] flink pull request #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified...

2018-07-14 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6323#discussion_r202521122 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala --- @@ -18,143 +18,358 @@ packa

[GitHub] flink pull request #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified...

2018-07-14 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6323#discussion_r202521212 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala --- @@ -18,143 +18,358 @@ packa

[GitHub] flink pull request #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified...

2018-07-14 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6323#discussion_r202520938 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactory.scala --- @@ -16,14 +16,14 @@ * limitations under

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544279#comment-16544279 ] ASF GitHub Bot commented on FLINK-8558: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8858) Add support for INSERT INTO in SQL Client

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544277#comment-16544277 ] ASF GitHub Bot commented on FLINK-8858: --- Github user pnowojski commented on a diff

[GitHub] flink pull request #6332: [FLINK-8858] [sql-client] Add support for INSERT I...

2018-07-14 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6332#discussion_r202520618 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java --- @@ -329,14 +341,46 @@ public v

[GitHub] flink pull request #6332: [FLINK-8858] [sql-client] Add support for INSERT I...

2018-07-14 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6332#discussion_r202520454 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java --- @@ -354,6 +398,23 @@ private void callSelect

[jira] [Commented] (FLINK-8858) Add support for INSERT INTO in SQL Client

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544273#comment-16544273 ] ASF GitHub Bot commented on FLINK-8858: --- Github user pnowojski commented on a diff

[jira] [Commented] (FLINK-8858) Add support for INSERT INTO in SQL Client

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544272#comment-16544272 ] ASF GitHub Bot commented on FLINK-8858: --- Github user pnowojski commented on a diff

[GitHub] flink pull request #6332: [FLINK-8858] [sql-client] Add support for INSERT I...

2018-07-14 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6332#discussion_r202520415 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java --- @@ -173,55 +180,92 @@ public void open() {

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544260#comment-16544260 ] ASF GitHub Bot commented on FLINK-9489: --- Github user sihuazhou commented on a diff

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544262#comment-16544262 ] ASF GitHub Bot commented on FLINK-9489: --- Github user sihuazhou commented on a diff

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544261#comment-16544261 ] ASF GitHub Bot commented on FLINK-9489: --- Github user sihuazhou commented on a diff

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544256#comment-16544256 ] ASF GitHub Bot commented on FLINK-9489: --- Github user sihuazhou commented on a diff

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544258#comment-16544258 ] ASF GitHub Bot commented on FLINK-9489: --- Github user sihuazhou commented on a diff

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544259#comment-16544259 ] ASF GitHub Bot commented on FLINK-9489: --- Github user sihuazhou commented on a diff

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544257#comment-16544257 ] ASF GitHub Bot commented on FLINK-9489: --- Github user sihuazhou commented on a diff

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-14 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202517181 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TieBreakingPriorityComparator.java --- @@ -85,10 +85,10 @@ public int compare(T o1, T

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-14 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202519256 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -446,8 +485,10 @@ public String toString() {

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-14 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202517247 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java --- @@ -305,6 +351,6 @@ private void checkR

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-14 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202516863 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupPartitioner.java --- @@ -264,6 +265,42 @@ public void writeMappingsInKeyGroup

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-14 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202519024 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueueSnapshotRestoreWrapper.java --- @@ -0,0 +1,102 @@ +/* +

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-14 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202518473 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastStateBackendMetaInfo.java --- @@ -63,54 +72,46 @@ public Register

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-14 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202519294 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/PriorityComparable.java --- @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache S

[jira] [Commented] (FLINK-9764) Failure in LocalRecoveryRocksDBFullITCase

2018-07-14 Thread Congxian Qiu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544221#comment-16544221 ] Congxian Qiu commented on FLINK-9764: - I ran the test in my laptop more than 1,000 ti

[jira] [Commented] (FLINK-5232) Add a Thread default uncaught exception handler on the JobManager

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544192#comment-16544192 ] ASF GitHub Bot commented on FLINK-5232: --- Github user yanghua commented on the issue

[GitHub] flink issue #6334: [FLINK-5232] Add a Thread default uncaught exception hand...

2018-07-14 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6334 hi @tillrohrmann I tried to fix this issue based on your suggestion in the jira. But there seems a little question, I want to consult you. The question is about the ActorSystem, you suggested

[jira] [Commented] (FLINK-5232) Add a Thread default uncaught exception handler on the JobManager

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544183#comment-16544183 ] ASF GitHub Bot commented on FLINK-5232: --- GitHub user yanghua opened a pull request:

[jira] [Updated] (FLINK-5232) Add a Thread default uncaught exception handler on the JobManager

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-5232: -- Labels: pull-request-available (was: ) > Add a Thread default uncaught exception handler on th

[GitHub] flink pull request #6334: [FLINK-5232] Add a Thread default uncaught excepti...

2018-07-14 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6334 [FLINK-5232] Add a Thread default uncaught exception handler on the JobManager ## What is the purpose of the change *This pull request Add a Thread default uncaught exception handler on the

[jira] [Assigned] (FLINK-8995) Add a test operator with keyed state that uses custom, stateful serializer

2018-07-14 Thread Congxian Qiu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Congxian Qiu reassigned FLINK-8995: --- Assignee: (was: Congxian Qiu) > Add a test operator with keyed state that uses custom, s

[jira] [Assigned] (FLINK-8995) Add a test operator with keyed state that uses custom, stateful serializer

2018-07-14 Thread Congxian Qiu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Congxian Qiu reassigned FLINK-8995: --- Assignee: Congxian Qiu > Add a test operator with keyed state that uses custom, stateful ser

[jira] [Commented] (FLINK-8858) Add support for INSERT INTO in SQL Client

2018-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544099#comment-16544099 ] ASF GitHub Bot commented on FLINK-8858: --- Github user twalthr commented on the issue

[GitHub] flink issue #6332: [FLINK-8858] [sql-client] Add support for INSERT INTO in ...

2018-07-14 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/6332 Thanks for the review @pnowojski. I agree that we should support `flink-cli < query01.sql` or `echo "INSERT INTO bar SELECT * FROM foo" | flink-cli`. However, I would move this to a separate issue be