[
https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544261#comment-16544261
]
ASF GitHub Bot commented on FLINK-9489:
---------------------------------------
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202517181
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/TieBreakingPriorityComparator.java
---
@@ -85,10 +85,10 @@ public int compare(T o1, T o2) {
return ((Comparable<T>) o1).compareTo(o2);
}
- // we catch this case before moving to more expensive tie
breaks.
- if (o1.equals(o2)) {
- return 0;
- }
+// // we catch this case before moving to more expensive tie
breaks.
--- End diff --
For what reason we need to comment this.
> Checkpoint timers as part of managed keyed state instead of raw keyed state
> ---------------------------------------------------------------------------
>
> Key: FLINK-9489
> URL: https://issues.apache.org/jira/browse/FLINK-9489
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> Timer state should now become part of the keyed state backend snapshot, i.e.,
> stored inside the managed keyed state. This means that we have to connect our
> preparation for asynchronous checkpoints with the backend, so that the timers
> are written as part of the state for each key-group. This means that we will
> also free up the raw keyed state an might expose it to user functions in the
> future.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
