[jira] [Commented] (FLINK-8756) Support ClusterClient.getAccumulators() in RestClusterClient

[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375378#comment-16375378 ] ASF GitHub Bot commented on FLINK-8756: --- GitHub user yanghua opened a pull request:

[GitHub] flink pull request #5573: [FLINK-8756][Client] Support ClusterClient.getAccu...

GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/5573 [FLINK-8756][Client] Support ClusterClient.getAccumulators() in RestClusterClient ## What is the purpose of the change This PR Support ClusterClient.getAccumulators() in RestClusterClient.

[jira] [Commented] (FLINK-7641) Loss of JobManager in HA mode should not cause jobs to fail

[ https://issues.apache.org/jira/browse/FLINK-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375201#comment-16375201 ] vinoyang commented on FLINK-7641: - yes [~elevy] you are right, our implementation go furth

[jira] [Commented] (FLINK-7641) Loss of JobManager in HA mode should not cause jobs to fail

[ https://issues.apache.org/jira/browse/FLINK-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375179#comment-16375179 ] Elias Levy commented on FLINK-7641: --- I mean that if you have a standalone cluster in HA

[jira] [Commented] (FLINK-8761) Various improvements to the Quickstarts

[ https://issues.apache.org/jira/browse/FLINK-8761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374912#comment-16374912 ] ASF GitHub Bot commented on FLINK-8761: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5569: [FLINK-8761] [quickstarts] Big improvements to the quicks...

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5569 Thanks for checking this out! Concerning the removed `flink-clients` dependency - that was done on purpose. Here is my motivation for that: - For the 'provided' API dependency, it s

[jira] [Commented] (FLINK-8761) Various improvements to the Quickstarts

[ https://issues.apache.org/jira/browse/FLINK-8761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374907#comment-16374907 ] ASF GitHub Bot commented on FLINK-8761: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #5569: [FLINK-8761] [quickstarts] Big improvements to the...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5569#discussion_r170351589 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -50,181 +51,113 @@ under the License.

[GitHub] flink pull request #5569: [FLINK-8761] [quickstarts] Big improvements to the...

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5569#discussion_r170351448 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -50,181 +51,113 @@ under the License.

[jira] [Commented] (FLINK-8761) Various improvements to the Quickstarts

[ https://issues.apache.org/jira/browse/FLINK-8761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374906#comment-16374906 ] ASF GitHub Bot commented on FLINK-8761: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374695#comment-16374695 ] ASF GitHub Bot commented on FLINK-8746: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374696#comment-16374696 ] ASF GitHub Bot commented on FLINK-8746: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170314390 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -534,42 +536,94 @@ public void postStop() throws Excepti

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170314325 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointTriggerException.java --- @@ -0,0 +1,42 @@ +/* + * Licensed

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374693#comment-16374693 ] ASF GitHub Bot commented on FLINK-8746: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170314219 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -289,7 +290,7 @@ public void invoke() throws E

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374692#comment-16374692 ] ASF GitHub Bot commented on FLINK-8746: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170313695 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -1156,6 +1213,26 @@ private void disposeSavepoint(String

[jira] [Created] (FLINK-8771) Upgrade scalastyle to 1.0.0

Ted Yu created FLINK-8771: - Summary: Upgrade scalastyle to 1.0.0 Key: FLINK-8771 URL: https://issues.apache.org/jira/browse/FLINK-8771 Project: Flink Issue Type: Improvement Components: Bui

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374620#comment-16374620 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170304145 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala --- @@ -18,37 +18,85 @@ package

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374600#comment-16374600 ] ASF GitHub Bot commented on FLINK-8746: --- Github user GJL commented on a diff in the

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374603#comment-16374603 ] ASF GitHub Bot commented on FLINK-8746: --- Github user GJL commented on a diff in the

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374602#comment-16374602 ] ASF GitHub Bot commented on FLINK-8746: --- Github user GJL commented on a diff in the

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374601#comment-16374601 ] ASF GitHub Bot commented on FLINK-8746: --- Github user GJL commented on a diff in the

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374604#comment-16374604 ] ASF GitHub Bot commented on FLINK-8746: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170279814 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -1156,6 +1213,26 @@ private void disposeSavepoint(String savepoin

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170296322 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointTriggerException.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to the A

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170296168 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointTriggerException.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to the A

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170300254 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -534,42 +536,94 @@ public void postStop() throws Exception {

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170281192 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -289,7 +290,7 @@ public void invoke() throws Exception

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374593#comment-16374593 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374581#comment-16374581 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374575#comment-16374575 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170257084 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class RowtimeValidat

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170273135 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactory.scala --- @@ -41,10 +41,10 @@ trait TableSourceFactor

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170290993 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/RowtimeTest.scala --- @@ -18,48 +18,67 @@ package org.apa

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374579#comment-16374579 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374589#comment-16374589 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170224845 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSource.java --- @@ -83,10 +84,

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170257053 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class RowtimeValidat

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374586#comment-16374586 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170230041 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -178,46 +244,128 @@ class Descript

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170291034 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/RowtimeTest.scala --- @@ -18,48 +18,67 @@ package org.apa

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374594#comment-16374594 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170230962 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -178,46 +244,128 @@ class Descript

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170271213 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/Schema.scala --- @@ -32,11 +32,36 @@ import scala.collection.mutable

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374577#comment-16374577 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374587#comment-16374587 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374578#comment-16374578 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170256851 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class RowtimeValidat

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170229569 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -128,6 +165,13 @@ class Descriptor

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170230912 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -178,46 +244,128 @@ class Descript

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170296912 --- Diff: flink-formats/flink-json/src/main/java/org/apache/flink/table/descriptors/JsonValidator.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374574#comment-16374574 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374584#comment-16374584 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374580#comment-16374580 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374595#comment-16374595 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374592#comment-16374592 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374591#comment-16374591 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374576#comment-16374576 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374582#comment-16374582 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374585#comment-16374585 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374590#comment-16374590 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374583#comment-16374583 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374588#comment-16374588 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374572#comment-16374572 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374573#comment-16374573 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374571#comment-16374571 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170256878 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class RowtimeValidat

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170230028 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -155,6 +199,28 @@ class Descriptor

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170273904 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/CsvTest.scala --- @@ -47,53 +79,18 @@ class CsvTest extends Descript

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170274382 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala --- @@ -18,37 +18,85 @@ package

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170298004 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala --- @@ -18,37 +18,85 @@ package

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170232160 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -246,13 +394,93 @@ class Descripto

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170256073 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class RowtimeValidat

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170272030 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala --- @@ -67,14 +92,188 @@ class SchemaValidator

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170297941 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala --- @@ -18,37 +18,85 @@ package

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170229924 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -89,37 +105,58 @@ class Descriptor

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170256006 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class RowtimeValidat

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170256141 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class RowtimeValidat

[jira] [Updated] (FLINK-8737) Creating a union of UnionGate instances will fail with UnsupportedOperationException when retrieving buffers

[ https://issues.apache.org/jira/browse/FLINK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-8737: --- Priority: Blocker (was: Major) > Creating a union of UnionGate instances will fail with > Unsupporte

[jira] [Updated] (FLINK-8736) Memory segment offsets for slices of slices are wrong

[ https://issues.apache.org/jira/browse/FLINK-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-8736: --- Priority: Critical (was: Major) > Memory segment offsets for slices of slices are wrong > ---

[jira] [Updated] (FLINK-8755) SpilledSubpartitionView wrongly relys on the backlog for determining whether more data is available

[ https://issues.apache.org/jira/browse/FLINK-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-8755: --- Priority: Blocker (was: Major) > SpilledSubpartitionView wrongly relys on the backlog for determining

[jira] [Commented] (FLINK-8751) Canceling a job results in a InterruptedException in the TM

[ https://issues.apache.org/jira/browse/FLINK-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374551#comment-16374551 ] Stephan Ewen commented on FLINK-8751: - Yes, that makes sense. The reason here is that

[jira] [Commented] (FLINK-8751) Canceling a job results in a InterruptedException in the TM

[ https://issues.apache.org/jira/browse/FLINK-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374525#comment-16374525 ] Elias Levy commented on FLINK-8751: --- Apologies.  I meant TM.  It was a long day.  I've a

[jira] [Updated] (FLINK-8751) Canceling a job results in a InterruptedException in the TM

[ https://issues.apache.org/jira/browse/FLINK-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elias Levy updated FLINK-8751: -- Description: Canceling a job results in the following exception reported by the TM:  {code:java} ERROR o

[jira] [Updated] (FLINK-8760) Correctly set `moreAvailable` flag in SingleInputGate and UnionInputGate

[ https://issues.apache.org/jira/browse/FLINK-8760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-8760: -- Priority: Blocker (was: Major) > Correctly set `moreAvailable` flag in SingleInputGate and Unio

[jira] [Updated] (FLINK-8694) Make notifyDataAvailable call reliable

[ https://issues.apache.org/jira/browse/FLINK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-8694: -- Priority: Blocker (was: Major) > Make notifyDataAvailable call reliable > -

[jira] [Commented] (FLINK-8694) Make notifyDataAvailable call reliable

[ https://issues.apache.org/jira/browse/FLINK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374496#comment-16374496 ] ASF GitHub Bot commented on FLINK-8694: --- GitHub user pnowojski opened a pull request

[GitHub] flink pull request #5572: [FLINK-8694][runtime] Fix notifyDataAvailable race...

GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/5572 [FLINK-8694][runtime] Fix notifyDataAvailable race condition This fixes two bugs in network stack: https://issues.apache.org/jira/browse/FLINK-8760 https://issues.apache.org/jira/browse/FLI

[jira] [Updated] (FLINK-8759) Bump Netty to 4.0.56

[ https://issues.apache.org/jira/browse/FLINK-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-8759: - Affects Version/s: 1.5.0 > Bump Netty to 4.0.56 > > > Key: FL

[jira] [Updated] (FLINK-8759) Bump Netty to 4.0.56

[ https://issues.apache.org/jira/browse/FLINK-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-8759: - Priority: Blocker (was: Major) > Bump Netty to 4.0.56 > > >

[jira] [Commented] (FLINK-8759) Bump Netty to 4.0.56

[ https://issues.apache.org/jira/browse/FLINK-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374480#comment-16374480 ] ASF GitHub Bot commented on FLINK-8759: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #5571: [FLINK-8759][network] preparations for the update ...

GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5571 [FLINK-8759][network] preparations for the update of netty to version 4.0.56 ## What is the purpose of the change Based on the changes from #5570, this PR prepares a netty version bump by cir

[jira] [Commented] (FLINK-8725) Separate NFA-state from NFA in CEP library

[ https://issues.apache.org/jira/browse/FLINK-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374474#comment-16374474 ] ASF GitHub Bot commented on FLINK-8725: --- Github user kl0u commented on the issue:

[GitHub] flink issue #5559: [FLINK-8725] Separate state from NFA in CEP library

Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5559 @aljoscha I will have a look today. ---

[jira] [Commented] (FLINK-8725) Separate NFA-state from NFA in CEP library

[ https://issues.apache.org/jira/browse/FLINK-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374471#comment-16374471 ] ASF GitHub Bot commented on FLINK-8725: --- Github user aljoscha commented on the issue

[GitHub] flink issue #5559: [FLINK-8725] Separate state from NFA in CEP library

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5559 R: @kl0u ---

[jira] [Commented] (FLINK-8768) Change NettyMessageDecoder to inherit from LengthFieldBasedFrameDecoder

[ https://issues.apache.org/jira/browse/FLINK-8768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374464#comment-16374464 ] ASF GitHub Bot commented on FLINK-8768: --- GitHub user NicoK opened a pull request:

  1   2   3   4   >