Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5564#discussion_r170229569
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
 ---
    @@ -128,6 +165,13 @@ class DescriptorProperties(normalizeKeys: Boolean = 
true) {
         )
       }
     
    +  /**
    +    * Adds a table schema under the given key. This method is intended for 
Java code.
    +    */
    +  def putTableSchema(key: String, nameAndType: JList[JTuple2[String, 
String]]): Unit = {
    --- End diff --
    
    I think we should drop the Scala equivalent method. This is not a public 
API class that needs a shiny Scala interface but should be usable from Java and 
Scala.


---

Reply via email to