[
https://issues.apache.org/jira/browse/FLINK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279261#comment-16279261
]
ASF GitHub Bot commented on FLINK-5506:
---
GitHub user greghogan opened a pull request
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5126
[FLINK-5506] [gelly] Fix CommunityDetection NullPointerException
## What is the purpose of the change
This fixes a regression which can result in `NullPointerException` when
running the `
[
https://issues.apache.org/jira/browse/FLINK-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279100#comment-16279100
]
ASF GitHub Bot commented on FLINK-8174:
---
Github user EronWright commented on the iss
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/5114
@tillrohrmann I believe your feedback has been addressed, please take a
look thanks.
---
[
https://issues.apache.org/jira/browse/FLINK-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278956#comment-16278956
]
ASF GitHub Bot commented on FLINK-8174:
---
Github user EronWright commented on a diff
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/5114#discussion_r155026726
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/LaunchCoordinator.scala
---
@@ -185,7 +189,7 @@ class LaunchCoordinator(
[
https://issues.apache.org/jira/browse/FLINK-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278898#comment-16278898
]
ASF GitHub Bot commented on FLINK-8085:
---
Github user GJL commented on a diff in the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155018207
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java
---
@@ -267,10 +270,77 @@ public void testAnyPreferredLocationC
[
https://issues.apache.org/jira/browse/FLINK-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278891#comment-16278891
]
ASF GitHub Bot commented on FLINK-8085:
---
Github user GJL commented on a diff in the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155016510
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java
---
@@ -267,10 +270,77 @@ public void testAnyPreferredLocationC
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155015331
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerIsolatedTasksTest.java
---
@@ -294,11 +297,11 @@ public void testSc
[
https://issues.apache.org/jira/browse/FLINK-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278883#comment-16278883
]
ASF GitHub Bot commented on FLINK-8085:
---
Github user GJL commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278868#comment-16278868
]
ASF GitHub Bot commented on FLINK-8085:
---
Github user GJL commented on a diff in the
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155012983
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -331,8 +334,19 @@ public void setInitialState(TaskStateSnaps
[
https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278865#comment-16278865
]
ASF GitHub Bot commented on FLINK-4812:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5125
There are a few reason for that:
1) It keeps the `Outputs` immutable. We need all metrics to be available up
front before creating the output, but since the OperatorIOMetricGroup is
created i
[
https://issues.apache.org/jira/browse/FLINK-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278843#comment-16278843
]
ASF GitHub Bot commented on FLINK-8193:
---
Github user StephanEwen commented on the is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5118
+1 for the latest suggestion
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5125
What's a bit strange is that other input/output related metrics are created
in `OperatorIOMetricGroup` and then handed to the `Outputs` while the watermark
gauges are created in the `Outputs` and th
[
https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278839#comment-16278839
]
ASF GitHub Bot commented on FLINK-4812:
---
Github user aljoscha commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278832#comment-16278832
]
ASF GitHub Bot commented on FLINK-7468:
---
Github user zhijiangW commented on the issu
[
https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278831#comment-16278831
]
ASF GitHub Bot commented on FLINK-4812:
---
Github user zentol commented on a diff in t
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r155004802
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init() throw
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4559
@NicoK , sorry I missed that synchronization comment, I may submit the
updates tomorrow for the latest comments.
---
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278826#comment-16278826
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user zhijiangW commented on the issu
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4533
@NicoK , thanks for the patch you provided offline, and I submit the new
commit for your changes. :)
---
[
https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278822#comment-16278822
]
ASF GitHub Bot commented on FLINK-4812:
---
Github user aljoscha commented on a diff in
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r155002960
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init() thr
[
https://issues.apache.org/jira/browse/FLINK-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278817#comment-16278817
]
ASF GitHub Bot commented on FLINK-8174:
---
Github user EronWright commented on a diff
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/5114#discussion_r155000484
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -217,15 +222,13 @@ public String to
[
https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278813#comment-16278813
]
ASF GitHub Bot commented on FLINK-4812:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278814#comment-16278814
]
ASF GitHub Bot commented on FLINK-8174:
---
Github user EronWright commented on a diff
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/5114#discussion_r154999162
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/LaunchCoordinator.scala
---
@@ -148,14 +149,17 @@ class LaunchCoordinator(
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r154999100
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init() throw
[
https://issues.apache.org/jira/browse/FLINK-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278806#comment-16278806
]
ASF GitHub Bot commented on FLINK-8174:
---
Github user EronWright commented on a diff
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r154998623
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init() throw
[
https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278808#comment-16278808
]
ASF GitHub Bot commented on FLINK-4812:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278807#comment-16278807
]
ASF GitHub Bot commented on FLINK-4812:
---
Github user zentol commented on a diff in t
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r154998584
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init() throw
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/5114#discussion_r154998531
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/LaunchCoordinator.scala
---
@@ -148,14 +149,17 @@ class LaunchCoordinator(
[
https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278793#comment-16278793
]
ASF GitHub Bot commented on FLINK-4812:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278795#comment-16278795
]
ASF GitHub Bot commented on FLINK-4812:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278794#comment-16278794
]
ASF GitHub Bot commented on FLINK-4812:
---
Github user aljoscha commented on a diff in
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r154951890
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/collector/selector/CopyingDirectedOutput.java
---
@@ -36,7 +36,7 @@
@Su
[
https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278791#comment-16278791
]
ASF GitHub Bot commented on FLINK-7880:
---
Github user zentol commented on a diff in t
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r154986979
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamOperator.java
---
@@ -135,4 +135,14 @@ OperatorSnapshotResult s
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5125#discussion_r154986786
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -80,7 +91,10 @@ public void init() thr
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154955042
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
---
@
[
https://issues.apache.org/jira/browse/FLINK-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278779#comment-16278779
]
ASF GitHub Bot commented on FLINK-8201:
---
Github user aljoscha commented on the issue
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5123
Ok, sounds good to me. @tillrohrmann could you please have a look at this?
It's a very small change but I know too little about these parts to be sure
that it doesn't cause other problems.
---
[
https://issues.apache.org/jira/browse/FLINK-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek closed FLINK-8186.
---
Resolution: Fixed
Fixed on release-1.4 in
612f07bbd2dc9aa1abf01ebf817c8341c1ad7a10
Fixed on m
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278745#comment-16278745
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on the issue:
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4533
oh, you were faster...
---
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278730#comment-16278730
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user NicoK commented on the issue:
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4533
ok, I fiddled with my remarks a bit and you are right for the problems of
reducing the visibility, which is partly caused by the
`CreditBasedClientHandler` not replacing `PartitionRequestClientHandler`
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278721#comment-16278721
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user zhijiangW commented on the issu
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4533
@NicoK @pnowojski , I have updated the codes for above comments.
---
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278717#comment-16278717
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user zhijiangW commented on a diff i
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154977986
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -244,54 +237,89 @@ public vo
[
https://issues.apache.org/jira/browse/FLINK-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278715#comment-16278715
]
ASF GitHub Bot commented on FLINK-8200:
---
Github user wenlong88 commented on the issu
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/5122
@StephanEwen Thanks for reviewing, I have update the pr according to your
comment.
---
[
https://issues.apache.org/jira/browse/FLINK-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278711#comment-16278711
]
ASF GitHub Bot commented on FLINK-8201:
---
Github user wenlong88 commented on the issu
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/5123
@aljoscha yes, the task manager config file is created in $PWD dir, and
files created in temporary folder will be cleared automatically by junit.
---
[
https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278686#comment-16278686
]
ASF GitHub Bot commented on FLINK-8139:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278688#comment-16278688
]
ASF GitHub Bot commented on FLINK-8139:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278687#comment-16278687
]
ASF GitHub Bot commented on FLINK-8139:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278684#comment-16278684
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user zhijiangW commented on a diff i
[
https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278689#comment-16278689
]
ASF GitHub Bot commented on FLINK-8139:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278685#comment-16278685
]
ASF GitHub Bot commented on FLINK-8139:
---
Github user twalthr commented on a diff in
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5065#discussion_r154965051
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -721,6 +722,42 @@ abstract class TableEnvironm
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5065#discussion_r154964510
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -721,6 +722,42 @@ abstract class TableEnvironm
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5065#discussion_r154961218
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
@@ -98,7 +98,9 @@ abstract class BatchTableE
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5065#discussion_r154967459
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -411,6 +411,7 @@ abstract class TableEnvironme
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5065#discussion_r154968022
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -721,6 +722,42 @@ abstract class TableEnvironm
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154972475
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -244,54 +237,89 @@ public vo
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278681#comment-16278681
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user zhijiangW commented on a diff i
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154972024
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -280,94 +280,120 @@ public Str
[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278677#comment-16278677
]
ASF GitHub Bot commented on FLINK-7416:
---
Github user zhijiangW commented on a diff i
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r154971179
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -223,11 +229,13 @@ void notify
[
https://issues.apache.org/jira/browse/FLINK-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278664#comment-16278664
]
ASF GitHub Bot commented on FLINK-7692:
---
Github user tony810430 commented on a diff
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154968275
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -441,14 +441,14 @@ private MetricGroup addG
[
https://issues.apache.org/jira/browse/FLINK-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278663#comment-16278663
]
Ted Yu commented on FLINK-8198:
---
Thanks for the fix, Stephan.
> Useless check against -1 in
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4911#discussion_r154965613
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
---
@@ -183,17 +240,124 @@ public int hashCode() {
[
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278654#comment-16278654
]
ASF GitHub Bot commented on FLINK-7878:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4911#discussion_r154965306
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
---
@@ -183,17 +240,124 @@ public int hashCode() {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4911#discussion_r154499927
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
---
@@ -183,17 +240,124 @@ public int hashCode() {
[
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278653#comment-16278653
]
ASF GitHub Bot commented on FLINK-7878:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4911#discussion_r154965118
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
---
@@ -37,11 +44,24 @@
* Direct Memory Size
[
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278651#comment-16278651
]
ASF GitHub Bot commented on FLINK-7878:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278657#comment-16278657
]
ASF GitHub Bot commented on FLINK-7878:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4911#discussion_r154500054
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
---
@@ -83,18 +102,23 @@ public ResourceSpec(double cpuCores
[
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278649#comment-16278649
]
ASF GitHub Bot commented on FLINK-7878:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278650#comment-16278650
]
ASF GitHub Bot commented on FLINK-7878:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278656#comment-16278656
]
ASF GitHub Bot commented on FLINK-7878:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4911#discussion_r154500041
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/operators/ResourceSpecTest.java
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Ap
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4911#discussion_r154499917
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
---
@@ -183,17 +240,124 @@ public int hashCode() {
[
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278652#comment-16278652
]
ASF GitHub Bot commented on FLINK-7878:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278648#comment-16278648
]
ASF GitHub Bot commented on FLINK-7878:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4911#discussion_r154964117
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
---
@@ -61,18 +81,17 @@
/** How many state size in m
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4911#discussion_r154499904
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
---
@@ -183,17 +240,124 @@ public int hashCode() {
1 - 100 of 244 matches
Mail list logo
