[ 
https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278654#comment-16278654
 ] 

ASF GitHub Bot commented on FLINK-7878:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4911#discussion_r154965118
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
 ---
    @@ -37,11 +44,24 @@
      *     <li>Direct Memory Size</li>
      *     <li>Native Memory Size</li>
      *     <li>State Size</li>
    + *     <li>Extended resources</li>
      * </ol>
      */
     @Internal
     public class ResourceSpec implements Serializable {
     
    +   public enum ResourceAggregateType {
    +           /**
    +            * Denotes keeping the sum of the values with same name when 
merging two resource specs for operator chaining
    +            */
    +           AGGREGATE_TYPE_SUM,
    +
    +           /**
    +            * Denotes keeping the max of the values with same name when 
merging two resource specs for operator chaining
    +            */
    +           AGGREGATE_TYPE_MAX
    +   }
    --- End diff --
    
    Let's move this enum to `Resource`


> Extend the resource type user can define in ResourceSpec
> --------------------------------------------------------
>
>                 Key: FLINK-7878
>                 URL: https://issues.apache.org/jira/browse/FLINK-7878
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataSet API, DataStream API
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>              Labels: flip-6
>
> Now, flink only support user define how much CPU and MEM used in an operator, 
> but now the resource in a cluster is various. For example, an application for 
> image processing may need GPU, some others may need FPGA. 
> Only CPU and MEM is not enough, and the resource type is becoming more and 
> more, so we need to make the ResourSpec extendible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to