[jira] [Commented] (FLINK-7449) Improve and enhance documentation for incremental checkpoints

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265563#comment-16265563 ] ASF GitHub Bot commented on FLINK-7449: --- Github user ChrisChinchilla commented on a

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-11-24 Thread ChrisChinchilla
Github user ChrisChinchilla commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r153034462 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs] ```

[jira] [Commented] (FLINK-7449) Improve and enhance documentation for incremental checkpoints

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1626#comment-1626 ] ASF GitHub Bot commented on FLINK-7449: --- Github user ChrisChinchilla commented on a

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-11-24 Thread ChrisChinchilla
Github user ChrisChinchilla commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r153033430 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs] ```

[GitHub] flink issue #5045: [hotfix][docs] Review of concepts docs for grammar and cl...

2017-11-24 Thread ChrisChinchilla
Github user ChrisChinchilla commented on the issue: https://github.com/apache/flink/pull/5045 @greghogan That said, the whole 'we' vs 'you' discussion is purely a stylistic preference (if that's what you meant) as long as it's consistent and clear who you mean, but the comment about r

[GitHub] flink issue #5045: [hotfix][docs] Review of concepts docs for grammar and cl...

2017-11-24 Thread ChrisChinchilla
Github user ChrisChinchilla commented on the issue: https://github.com/apache/flink/pull/5045 @greghogan @zentol I will get these updates to you asap. But I will have to strongly disagree on the 'you' and passive voice points. I've been working as a technical writer for some t

[jira] [Created] (FLINK-8150) WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs

2017-11-24 Thread Gary Yao (JIRA)
Gary Yao created FLINK-8150: --- Summary: WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs Key: FLINK-8150 URL: https://issues.apache.org/jira/browse/FLINK-8150 Project: Flink

[jira] [Created] (FLINK-8149) Replace usages of deprecated SerializationSchema

2017-11-24 Thread Hai Zhou UTC+8 (JIRA)
Hai Zhou UTC+8 created FLINK-8149: - Summary: Replace usages of deprecated SerializationSchema Key: FLINK-8149 URL: https://issues.apache.org/jira/browse/FLINK-8149 Project: Flink Issue Type:

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265444#comment-16265444 ] ASF GitHub Bot commented on FLINK-7499: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #4581: [FLINK-7499][io] fix double buffer release in SpillableSu...

2017-11-24 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4581 Rat check did not pass. Could you please fix this @NicoK. ---

[jira] [Commented] (FLINK-8142) Cleanup reference to deprecated constants in ConfigConstants

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265443#comment-16265443 ] ASF GitHub Bot commented on FLINK-8142: --- GitHub user yew1eb opened a pull request:

[GitHub] flink pull request #5067: [FLINK-8142][config] Cleanup reference to deprecat...

2017-11-24 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/5067 [FLINK-8142][config] Cleanup reference to deprecated constants in ConfigConstants ## What is the purpose of the change ConfigConstants contains several deprecated String constants that are u

[jira] [Updated] (FLINK-7694) Port JobMetricsHandler to new REST handler

2017-11-24 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-7694: Description: Port {{org.apache.flink.runtime.rest.handler.legacy.metrics.JobMetricsHandler}} to new handler

[GitHub] flink issue #5032: [FLINK-8090] [DataStream] Improve the error message for d...

2017-11-24 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/5032 Hi @aljoscha, I wonder if you could help review this PR when you are convenient. Thanks, Xingcan ---

[jira] [Commented] (FLINK-8090) Improve error message when registering different states under the same name.

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265363#comment-16265363 ] ASF GitHub Bot commented on FLINK-8090: --- Github user xccui commented on the issue:

[jira] [Commented] (FLINK-7883) Stop fetching source before a cancel with savepoint

2017-11-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265345#comment-16265345 ] Aljoscha Krettek commented on FLINK-7883: - The problem is that this is harder than

[GitHub] flink issue #5066: [FLINK-8148][yarn/s3] fix test instability in YarnFileSta...

2017-11-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5066 Makes sense, +1 ---

[jira] [Commented] (FLINK-8148) Test instability in YarnFileStageTest

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265344#comment-16265344 ] ASF GitHub Bot commented on FLINK-8148: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-8100) Consider introducing log4j-extras

2017-11-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265322#comment-16265322 ] Aljoscha Krettek commented on FLINK-8100: - We don't use log4j directly but slf4j.

[jira] [Commented] (FLINK-8103) Flink 1.4 not writing to standard out log file

2017-11-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265321#comment-16265321 ] Aljoscha Krettek commented on FLINK-8103: - I just ran an example like this on the

[jira] [Commented] (FLINK-8124) EventTimeTrigger (and other triggers) could have less specific generic types

2017-11-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265309#comment-16265309 ] Aljoscha Krettek commented on FLINK-8124: - I think that should be feasible, yes.

[jira] [Closed] (FLINK-6294) BucketingSink throws NPE while cancelling job

2017-11-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-6294. --- Resolution: Fixed Fixed on release-1.3 in 5aea4917662d80899d3adff0378b97ae58aa2afc Fixed on r

[jira] [Updated] (FLINK-6294) BucketingSink throws NPE while cancelling job

2017-11-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-6294: Fix Version/s: 1.4.1 1.3.3 > BucketingSink throws NPE while cancelling jo

[jira] [Updated] (FLINK-7694) Port JobMetricsHandler to new REST handler

2017-11-24 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-7694: Component/s: Distributed Coordination > Port JobMetricsHandler to new REST handler > ---

[jira] [Updated] (FLINK-7694) Port JobMetricsHandler to new REST handler

2017-11-24 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-7694: Labels: flip6 (was: ) > Port JobMetricsHandler to new REST handler > --

[jira] [Updated] (FLINK-7694) Port JobMetricsHandler to new REST handler

2017-11-24 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-7694: Description: Port {{org.apache.flink.runtime.rest.handler.legacy.metrics.JobMetricsHandler}} > Port JobMetr

[jira] [Assigned] (FLINK-7694) Port JobMetricsHandler to new REST handler

2017-11-24 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-7694: --- Assignee: Gary Yao (was: Bowen Li) > Port JobMetricsHandler to new REST handler > --

[GitHub] flink pull request #5066: [FLINK-8148][yarn/s3] fix test instability in Yarn...

2017-11-24 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5066 [FLINK-8148][yarn/s3] fix test instability in YarnFileStageTestS3ITCase ## What is the purpose of the change `YarnFileStageTestS3ITCase.testRecursiveUploadForYarn` verifies that the test dire

[jira] [Commented] (FLINK-8148) Test instability in YarnFileStageTest

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265301#comment-16265301 ] ASF GitHub Bot commented on FLINK-8148: --- GitHub user NicoK opened a pull request:

[jira] [Updated] (FLINK-8148) Test instability in YarnFileStageTest

2017-11-24 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-8148: --- Labels: test-stability (was: ) > Test instability in YarnFileStageTest >

[jira] [Created] (FLINK-8148) Test instability in YarnFileStageTest

2017-11-24 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-8148: -- Summary: Test instability in YarnFileStageTest Key: FLINK-8148 URL: https://issues.apache.org/jira/browse/FLINK-8148 Project: Flink Issue Type: Bug Com

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152972315 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -729,6 +804,12 @@ public Void

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265295#comment-16265295 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265293#comment-16265293 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152972034 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -306,51 +306,88 @@ public void

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265296#comment-16265296 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265297#comment-16265297 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152962580 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -330,64 +332,120 @@ public voi

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152969860 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -330,64 +332,120 @@ public voi

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152963546 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -330,64 +332,120 @@ public voi

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265294#comment-16265294 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265298#comment-16265298 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-8093) flink job fail because of kafka producer create fail of "javax.management.InstanceAlreadyExistsException"

2017-11-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265290#comment-16265290 ] Aljoscha Krettek commented on FLINK-8093: - Do you mean thread safe or *not* thread

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152972414 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -715,4 +686,58 @@ private Remo

[jira] [Updated] (FLINK-8147) Support and to CEP's pattern API

2017-11-24 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-8147: -- Issue Type: New Feature (was: Bug) > Support and to CEP's pattern API > ---

[jira] [Updated] (FLINK-8147) Support and to CEP's pattern API

2017-11-24 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-8147: -- Priority: Minor (was: Major) > Support and to CEP's pattern API > -

[jira] [Commented] (FLINK-6909) Flink should support Lombok POJO

2017-11-24 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265280#comment-16265280 ] Timo Walther commented on FLINK-6909: - I tested a simple Lombok POJO and it worked as

[jira] [Comment Edited] (FLINK-6909) Flink should support Lombok POJO

2017-11-24 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265280#comment-16265280 ] Timo Walther edited comment on FLINK-6909 at 11/24/17 1:37 PM: -

[jira] [Resolved] (FLINK-8117) Eliminate modulo operation from RoundRobinChannelSelector and RebalancePartitioner

2017-11-24 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay resolved FLINK-8117. Resolution: Implemented > Eliminate modulo operation from RoundRobinChannelSelector and > Rebalance

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265251#comment-16265251 ] ASF GitHub Bot commented on FLINK-8144: --- Github user fhueske commented on the issue:

[GitHub] flink issue #5063: [FLINK-8144] [table] Optimize the timer logic in RowTimeU...

2017-11-24 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5063 I see. The bad performance is related to way that you generate the watermarks. Generating so many watermarks is very inefficient because you processing many more watermarks than actual records (water

[jira] [Commented] (FLINK-8139) Check for proper equals() and hashCode() when registering a table

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265244#comment-16265244 ] ASF GitHub Bot commented on FLINK-8139: --- Github user fhueske commented on the issue:

[GitHub] flink issue #5065: [FLINK-8139][table] Check for proper equals() and hashCod...

2017-11-24 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5065 Hi @Aegeaner, thanks for the pull request. I had a brief look at it and noticed a few things: 1. Please fill out the PR template (see #5063 as an example) 2. Please add unit tests tha

[jira] [Commented] (FLINK-8147) Support and to CEP's pattern API

2017-11-24 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265243#comment-16265243 ] Dian Fu commented on FLINK-8147: Any comments is welcome. Do you think it's useful? What d

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265239#comment-16265239 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152961281 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -572,20 +560,53 @@ void addExclusi

[jira] [Created] (FLINK-8147) Support and to CEP's pattern API

2017-11-24 Thread Dian Fu (JIRA)
Dian Fu created FLINK-8147: -- Summary: Support and to CEP's pattern API Key: FLINK-8147 URL: https://issues.apache.org/jira/browse/FLINK-8147 Project: Flink Issue Type: Bug Components: CEP

[jira] [Commented] (FLINK-8125) Support limiting the number of open FileSystem connections

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265231#comment-16265231 ] ASF GitHub Bot commented on FLINK-8125: --- Github user StephanEwen closed the pull req

[GitHub] flink pull request #5059: [FLINK-8125] [core] Introduce limiting of file sys...

2017-11-24 Thread StephanEwen
Github user StephanEwen closed the pull request at: https://github.com/apache/flink/pull/5059 ---

[jira] [Resolved] (FLINK-8125) Support limiting the number of open FileSystem connections

2017-11-24 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-8125. - Resolution: Fixed Fixed in - 1.5.0 via d7c2c417213502130b1aeab1868313df178555cc - 1.4.1 via a1

[jira] [Closed] (FLINK-8125) Support limiting the number of open FileSystem connections

2017-11-24 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-8125. --- > Support limiting the number of open FileSystem connections > ---

[jira] [Created] (FLINK-8146) Potential resource leak in PythonPlanBinder#unzipPythonLibrary

2017-11-24 Thread Ted Yu (JIRA)
Ted Yu created FLINK-8146: - Summary: Potential resource leak in PythonPlanBinder#unzipPythonLibrary Key: FLINK-8146 URL: https://issues.apache.org/jira/browse/FLINK-8146 Project: Flink Issue Type: B

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265213#comment-16265213 ] ASF GitHub Bot commented on FLINK-8144: --- Github user dianfu commented on a diff in t

[GitHub] flink pull request #5063: [FLINK-8144] [table] Optimize the timer logic in R...

2017-11-24 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/5063#discussion_r152955709 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RowTimeUnboundedOver.scala --- @@ -116,7 +116,7 @@ abstract cla

[GitHub] flink pull request #5055: [FLINK-7718] [flip6] Add JobVertexMetricsHandler t...

2017-11-24 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5055#discussion_r152951899 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/AbstractMetricsHandler.java --- @@ -0,0 +1,141 @@ +/* + * Licens

[jira] [Commented] (FLINK-7718) Port JobVertixMetricsHandler to new REST endpoint

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265202#comment-16265202 ] ASF GitHub Bot commented on FLINK-7718: --- Github user GJL commented on a diff in the

[jira] [Commented] (FLINK-8139) Check for proper equals() and hashCode() when registering a table

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265184#comment-16265184 ] ASF GitHub Bot commented on FLINK-8139: --- GitHub user Aegeaner opened a pull request:

[GitHub] flink pull request #5065: [FLINK-8139][table] Check for proper equals() and ...

2017-11-24 Thread Aegeaner
GitHub user Aegeaner opened a pull request: https://github.com/apache/flink/pull/5065 [FLINK-8139][table] Check for proper equals() and hashCode() when reg… https://issues.apache.org/jira/browse/FLINK-8139 Check for proper equals() and hashCode() when registering a table.

[jira] [Commented] (FLINK-8145) IOManagerAsync not properly shut down in various tests

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265165#comment-16265165 ] ASF GitHub Bot commented on FLINK-8145: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #5064: [FLINK-8145][tests] fix various IOManagerAsync ins...

2017-11-24 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5064 [FLINK-8145][tests] fix various IOManagerAsync instances not being shut down ## What is the purpose of the change Fix several unit tests using `IOManagerAsync` but not shutting it down afterw

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265155#comment-16265155 ] ASF GitHub Bot commented on FLINK-7499: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152944166 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -320,4 +559,40 @@ void awaitNotifica

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265143#comment-16265143 ] ASF GitHub Bot commented on FLINK-5465: --- Github user StefanRRichter commented on the

[GitHub] flink issue #5058: [FLINK-5465] [streaming] Wait for pending timer threads t...

2017-11-24 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5058 I was thinking about where to put those options and after all it was a choice between fragmentation and inconsistency. I considered `TaskManagerOptions` but it sounds like a wrong place, if yo

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265138#comment-16265138 ] ASF GitHub Bot commented on FLINK-5465: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5058: [FLINK-5465] [streaming] Wait for pending timer threads t...

2017-11-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5058 I would like to make a few comments for followup: - I think `TimerServiceOptions` should not be an own class, we are getting a crazy fragmentation of options into classes (that have som

[GitHub] flink issue #5063: [FLINK-8144] [table] Optimize the timer logic in RowTimeU...

2017-11-24 Thread dianfu
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/5063 {{AbstractKeyedCEPPatternOperator}} has similar logic as {{RowTimeUnboundedOver}}. As described in FLINK-8106, we find that the performance is very bad under the current logic for {{AbstractKeyedCEPP

[jira] [Issue Comment Deleted] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-8144: --- Comment: was deleted (was: {{AbstractKeyedCEPPatternOperator}} has similar logic as {{RowTimeUnboundedOver}}.

[jira] [Comment Edited] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265130#comment-16265130 ] Dian Fu edited comment on FLINK-8144 at 11/24/17 10:19 AM: --- {{Ab

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265133#comment-16265133 ] ASF GitHub Bot commented on FLINK-8144: --- Github user dianfu commented on the issue:

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265130#comment-16265130 ] Dian Fu commented on FLINK-8144: {{AbstractKeyedCEPPatternOperator}} has similar logic as

[jira] [Created] (FLINK-8145) IOManagerAsync not properly shut down in various tests

2017-11-24 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-8145: -- Summary: IOManagerAsync not properly shut down in various tests Key: FLINK-8145 URL: https://issues.apache.org/jira/browse/FLINK-8145 Project: Flink Issue Type:

[jira] [Assigned] (FLINK-6909) Flink should support Lombok POJO

2017-11-24 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-6909: --- Assignee: Timo Walther > Flink should support Lombok POJO >

[jira] [Commented] (FLINK-6909) Flink should support Lombok POJO

2017-11-24 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265118#comment-16265118 ] Timo Walther commented on FLINK-6909: - This looks like a bug to me. I will assign the

[jira] [Closed] (FLINK-7316) always use off-heap network buffers

2017-11-24 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-7316. - Resolution: Fixed Fix Version/s: 1.5.0 Merged in 1854a3de19. > always use off-heap network

[jira] [Commented] (FLINK-7316) always use off-heap network buffers

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265104#comment-16265104 ] ASF GitHub Bot commented on FLINK-7316: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4481: [FLINK-7316][network] always use off-heap network ...

2017-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4481 ---

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265097#comment-16265097 ] ASF GitHub Bot commented on FLINK-8144: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5063: [FLINK-8144] [table] Optimize the timer logic in R...

2017-11-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5063#discussion_r152929249 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RowTimeUnboundedOver.scala --- @@ -116,7 +116,7 @@ abstract cl

[GitHub] flink issue #4481: [FLINK-7316][network] always use off-heap network buffers

2017-11-24 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4481 Will merge this now. ---

[jira] [Commented] (FLINK-7316) always use off-heap network buffers

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265093#comment-16265093 ] ASF GitHub Bot commented on FLINK-7316: --- Github user StefanRRichter commented on the

[jira] [Commented] (FLINK-7316) always use off-heap network buffers

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265094#comment-16265094 ] ASF GitHub Bot commented on FLINK-7316: --- Github user StefanRRichter commented on the

[GitHub] flink issue #4481: [FLINK-7316][network] always use off-heap network buffers

2017-11-24 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4481 LGTM 👍 ---

[jira] [Commented] (FLINK-8144) Optimize the timer logic in RowTimeUnboundedOver

2017-11-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265088#comment-16265088 ] Fabian Hueske commented on FLINK-8144: -- Did you observe this behavior in practice, i.

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265082#comment-16265082 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265080#comment-16265080 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265079#comment-16265079 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265083#comment-16265083 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265081#comment-16265081 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7959) Split CodeGenerator into CodeGeneratorContext and ExprCodeGenerator

2017-11-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265077#comment-16265077 ] ASF GitHub Bot commented on FLINK-7959: --- Github user twalthr commented on a diff in

  1   2   >