[
https://issues.apache.org/jira/browse/FLINK-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265443#comment-16265443
]
ASF GitHub Bot commented on FLINK-8142:
---------------------------------------
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5067
[FLINK-8142][config] Cleanup reference to deprecated constants in
ConfigConstants
## What is the purpose of the change
ConfigConstants contains several deprecated String constants that are used
by other Flink modules. Those should be cleaned up.
## Brief change log
- *Replace usages of deprecated `TASK_MANAGER_MEMORY_SIZE_KEY` ,
`EXECUTION_RETRIES_KEY`, `EXECUTION_RETRY_DELAY_KEY`,
`TASK_MANAGER_MEMORY_PRE_ALLOCATE_KEY`, `JOB_MANAGER_IPC_ADDRESS_KEY`*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink FLINK-8142
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5067.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5067
----
commit 0cf6eb6a0bbee829adedc9ddce230c4aa70abe94
Author: yew1eb <yew...@gmail.com>
Date: 2017-11-23T15:52:38Z
[FLINK-8142][minor] Cleanup reference to deprecated constants in
ConfigConstants
----
> Cleanup reference to deprecated constants in ConfigConstants
> ------------------------------------------------------------
>
> Key: FLINK-8142
> URL: https://issues.apache.org/jira/browse/FLINK-8142
> Project: Flink
> Issue Type: Improvement
> Components: Local Runtime
> Affects Versions: 1.4.0
> Reporter: Hai Zhou UTC+8
> Assignee: Hai Zhou UTC+8
> Priority: Minor
> Fix For: 1.5.0
>
>
> ConfigConstants contains several deprecated String constants that are used by
> other Flink modules. Those should be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
