[jira] [Commented] (FLINK-8090) Improve error message when registering different states under the same name.

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262007#comment-16262007 ] ASF GitHub Bot commented on FLINK-8090: --- Github user bowenli86 commented on a diff i

[GitHub] flink pull request #5032: [FLINK-8090] [DataStream] Improve the error messag...

2017-11-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5032#discussion_r152475532 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContextTest.java --- @@ -270,6 +271,20 @@ public voi

[jira] [Commented] (FLINK-8118) Allow to specify the offsets of KafkaTableSources

2017-11-21 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261951#comment-16261951 ] Xingcan Cui commented on FLINK-8118: Hi [~twalthr], thanks for raising this. I got two

[jira] [Commented] (FLINK-6101) GroupBy fields with arithmetic expression (include UDF) can not be selected

2017-11-21 Thread lincoln.lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261907#comment-16261907 ] lincoln.lee commented on FLINK-6101: [~twalthr] This implementation support select ori

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261904#comment-16261904 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-21 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152459473 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -134,9 +138,9 @@ void assignEx

[jira] [Commented] (FLINK-7716) Port JobManagerMetricsHandler to new REST endpoint

2017-11-21 Thread Hai Zhou UTC+8 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261898#comment-16261898 ] Hai Zhou UTC+8 commented on FLINK-7716: --- [~gjy] Sorry, I have not had any free time

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261892#comment-16261892 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-21 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152457595 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -240,15 +245,13 @@ void releas

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261886#comment-16261886 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-21 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152456861 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -394,7 +419,63 @@ public Buffe

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261871#comment-16261871 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-21 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152454790 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -394,7 +419,63 @@ public Buffe

[GitHub] flink pull request #5047: Code refine of WordWithCount

2017-11-21 Thread harborl
GitHub user harborl opened a pull request: https://github.com/apache/flink/pull/5047 Code refine of WordWithCount Only because of the thread-safe and coding convention consideration, please check if it's OK with adding `final` decoration? *Thank you very much for contr

[jira] [Commented] (FLINK-6101) GroupBy fields with arithmetic expression (include UDF) can not be selected

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261869#comment-16261869 ] ASF GitHub Bot commented on FLINK-6101: --- GitHub user lincoln-lil opened a pull reque

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-21 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152454439 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -82,17 +84,19 @@ /** T

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261870#comment-16261870 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #5046: [FLINK-6101] [table] Support select GroupBy fields...

2017-11-21 Thread lincoln-lil
GitHub user lincoln-lil opened a pull request: https://github.com/apache/flink/pull/5046 [FLINK-6101] [table] Support select GroupBy fields with arithmetic ex… ## What is the purpose of the change Support select GroupBy fields with arithmetic expressions(include UDF)

[jira] [Commented] (FLINK-8090) Improve error message when registering different states under the same name.

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261868#comment-16261868 ] ASF GitHub Bot commented on FLINK-8090: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #5032: [FLINK-8090] [DataStream] Improve the error messag...

2017-11-21 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5032#discussion_r152454242 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContextTest.java --- @@ -270,6 +271,20 @@ public void te

[jira] [Commented] (FLINK-4520) Integrate Siddhi as a lightweight CEP Library

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261822#comment-16261822 ] ASF GitHub Bot commented on FLINK-4520: --- Github user haoch commented on the issue:

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2017-11-21 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 Keep this PR open until https://github.com/apache/bahir-flink/pull/22 merged. ---

[GitHub] flink pull request #5045: [hotfix][docs] Review of concepts docs for grammar...

2017-11-21 Thread ChrisChinchilla
GitHub user ChrisChinchilla opened a pull request: https://github.com/apache/flink/pull/5045 [hotfix][docs] Review of concepts docs for grammar and clarity Spending some time doing a brief review of a few docs sections, just a start and I think more could be done. I didn't

[jira] [Created] (FLINK-8127) Add New Relic Metric Reporter

2017-11-21 Thread Ron Crocker (JIRA)
Ron Crocker created FLINK-8127: -- Summary: Add New Relic Metric Reporter Key: FLINK-8127 URL: https://issues.apache.org/jira/browse/FLINK-8127 Project: Flink Issue Type: Improvement Com

[GitHub] flink issue #5023: [hotfix][docs] Review of concepts docs for grammar, forma...

2017-11-21 Thread ChrisChinchilla
Github user ChrisChinchilla commented on the issue: https://github.com/apache/flink/pull/5023 @greghogan Will start this PR afresh. ---

[GitHub] flink pull request #5023: [hotfix][docs] Review of concepts docs for grammar...

2017-11-21 Thread ChrisChinchilla
Github user ChrisChinchilla closed the pull request at: https://github.com/apache/flink/pull/5023 ---

[GitHub] flink pull request #5024: [hotfix][docs] Readme review to clarify heading fo...

2017-11-21 Thread ChrisChinchilla
Github user ChrisChinchilla commented on a diff in the pull request: https://github.com/apache/flink/pull/5024#discussion_r152427259 --- Diff: docs/index.md --- @@ -23,19 +24,17 @@ specific language governing permissions and limitations under the License. --> -

[GitHub] flink pull request #5024: [hotfix][docs] Readme review to clarify heading fo...

2017-11-21 Thread ChrisChinchilla
Github user ChrisChinchilla commented on a diff in the pull request: https://github.com/apache/flink/pull/5024#discussion_r152426833 --- Diff: docs/index.md --- @@ -23,19 +24,17 @@ specific language governing permissions and limitations under the License. --> -

[GitHub] flink pull request #5024: [hotfix][docs] Readme review to clarify heading fo...

2017-11-21 Thread ChrisChinchilla
Github user ChrisChinchilla commented on a diff in the pull request: https://github.com/apache/flink/pull/5024#discussion_r152426709 --- Diff: docs/README.md --- @@ -90,7 +90,7 @@ This will be replaced with the value of the variable called `NAME` when generati Headi

[jira] [Commented] (FLINK-4877) Refactorings around FLINK-3674 (User Function Timers)

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261566#comment-16261566 ] ASF GitHub Bot commented on FLINK-4877: --- Github user greghogan commented on the issu

[jira] [Commented] (FLINK-8126) Update and fix checkstyle

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261567#comment-16261567 ] ASF GitHub Bot commented on FLINK-8126: --- Github user zentol commented on the issue:

[GitHub] flink issue #4877: [FLINK-4877] About SourceFunction extends Serializable

2017-11-21 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4877 @vim-wj if you are okay with Stephan's suggestion could you close this pull request? Also, a small note: `FLINK-4877` references a [Jira ticket](https://issues.apache.org/jira/browse/FLINK

[GitHub] flink issue #5044: [FLINK-8126] [build] Fix and update checkstyle

2017-11-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5044 +1 ---

[jira] [Commented] (FLINK-7316) always use off-heap network buffers

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261560#comment-16261560 ] ASF GitHub Bot commented on FLINK-7316: --- Github user NicoK commented on the issue:

[GitHub] flink issue #4481: [FLINK-7316][network] always use off-heap network buffers

2017-11-21 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4481 rebased again - this should be good to go. @StefanRRichter can you continue with this? ---

[jira] [Commented] (FLINK-8126) Update and fix checkstyle

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261538#comment-16261538 ] ASF GitHub Bot commented on FLINK-8126: --- GitHub user greghogan opened a pull request

[GitHub] flink pull request #5044: [FLINK-8126] [build] Fix and update checkstyle

2017-11-21 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/5044 [FLINK-8126] [build] Fix and update checkstyle ## What is the purpose of the change Update to the latest checkstyle version and fix the errors not previously detected. ## Brief c

[GitHub] flink pull request #5006: [hotfix][docs][QS] MInor cleanup of QS documentati...

2017-11-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5006#discussion_r152406271 --- Diff: docs/dev/stream/state/queryable_state.md --- @@ -162,14 +161,19 @@ So far, you have set up your cluster to run with queryable state and you have de

[GitHub] flink pull request #4946: [FLINK-7967] [config] Deprecate Hadoop specific Fl...

2017-11-21 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4946#discussion_r152405696 --- Diff: flink-dist/src/main/resources/flink-conf.yaml --- @@ -151,6 +151,9 @@ jobmanager.web.port: 8081 # Path to the Hadoop configuration dire

[jira] [Commented] (FLINK-7967) Deprecate Hadoop specific Flink configuration options

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261507#comment-16261507 ] ASF GitHub Bot commented on FLINK-7967: --- Github user greghogan commented on a diff i

[jira] [Commented] (FLINK-8070) YarnTestBase should print prohibited string

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261503#comment-16261503 ] ASF GitHub Bot commented on FLINK-8070: --- Github user zentol commented on the issue:

[GitHub] flink issue #5012: [FLINK-8070][yarn][tests] Print errors found in log files

2017-11-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5012 Also, this particular exception stops at after `Caused by: java.lang.VerifyError: Inconsistent stackmap frames at branch target 152` because the next lines don't look like a stack trace. Here

[GitHub] flink issue #5012: [FLINK-8070][yarn][tests] Print errors found in log files

2017-11-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5012 In this particular stack trace, you have the stack trace of the assertion error ``` java.lang.AssertionError(... exception message ...) at org.junit.runners.model.MultipleFail

[jira] [Commented] (FLINK-8070) YarnTestBase should print prohibited string

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261494#comment-16261494 ] ASF GitHub Bot commented on FLINK-8070: --- Github user zentol commented on the issue:

[GitHub] flink pull request #5006: [hotfix][docs][QS] MInor cleanup of QS documentati...

2017-11-21 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5006#discussion_r152402516 --- Diff: docs/dev/stream/state/queryable_state.md --- @@ -162,14 +161,19 @@ So far, you have set up your cluster to run with queryable state and you have

[GitHub] flink pull request #5006: [hotfix][docs][QS] MInor cleanup of QS documentati...

2017-11-21 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5006#discussion_r152402801 --- Diff: docs/dev/stream/state/queryable_state.md --- @@ -162,14 +161,19 @@ So far, you have set up your cluster to run with queryable state and you have

[GitHub] flink pull request #5006: [hotfix][docs][QS] MInor cleanup of QS documentati...

2017-11-21 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5006#discussion_r152402097 --- Diff: docs/dev/stream/state/queryable_state.md --- @@ -60,7 +60,7 @@ The Queryable State feature consists of three main entities: returning it to

[jira] [Closed] (FLINK-8123) Bundle python library in jar

2017-11-21 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8123. --- Resolution: Fixed 1.5: c4107d4c336ed8dbadc03a7018eb255f4df3d1cc > Bundle python library in ja

[jira] [Commented] (FLINK-2170) Add OrcTableSource

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261489#comment-16261489 ] ASF GitHub Bot commented on FLINK-2170: --- GitHub user fhueske opened a pull request:

[GitHub] flink pull request #5043: [FLINK-2170] [connectors] Add OrcRowInputFormat an...

2017-11-21 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/5043 [FLINK-2170] [connectors] Add OrcRowInputFormat and OrcTableSource. ## What is the purpose of the change * Adds `OrcRowInputFormat` to read [ORC files](https://orc.apache.org) as `DataSet`.

[GitHub] flink issue #5012: [FLINK-8070][yarn][tests] Print errors found in log files

2017-11-21 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5012 LGTM. I'm puzzled why the `])` is printed out-of-order in the middle of the stack trace. ---

[jira] [Commented] (FLINK-8070) YarnTestBase should print prohibited string

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261448#comment-16261448 ] ASF GitHub Bot commented on FLINK-8070: --- Github user greghogan commented on the issu

[jira] [Commented] (FLINK-8084) Remove japicmp deactivations in several modules

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261430#comment-16261430 ] ASF GitHub Bot commented on FLINK-8084: --- Github user greghogan commented on the issu

[GitHub] flink issue #5020: [FLINK-8084][build] Remove unnecessary japicmp pom entrie...

2017-11-21 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5020 +1 ---

[GitHub] flink pull request #5024: [hotfix][docs] Readme review to clarify heading fo...

2017-11-21 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5024#discussion_r152384448 --- Diff: docs/index.md --- @@ -23,19 +24,17 @@ specific language governing permissions and limitations under the License. --> - -

[GitHub] flink pull request #5024: [hotfix][docs] Readme review to clarify heading fo...

2017-11-21 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5024#discussion_r152386126 --- Diff: docs/index.md --- @@ -23,19 +24,17 @@ specific language governing permissions and limitations under the License. --> - -

[GitHub] flink pull request #5024: [hotfix][docs] Readme review to clarify heading fo...

2017-11-21 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5024#discussion_r152384103 --- Diff: docs/README.md --- @@ -90,7 +90,7 @@ This will be replaced with the value of the variable called `NAME` when generati Headings

[jira] [Commented] (FLINK-8036) Consider using gradle to build Flink

2017-11-21 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261371#comment-16261371 ] Greg Hogan commented on FLINK-8036: --- Are many developers running tests from the command

[jira] [Commented] (FLINK-8113) Bump maven-shade-plugin to 3.0.0

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261335#comment-16261335 ] ASF GitHub Bot commented on FLINK-8113: --- Github user zentol commented on the issue:

[GitHub] flink issue #5042: [FLINK-8113][build] Bump maven-shade-plugin to 3.0.0

2017-11-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5042 I looked through the open issues for 3.0.0, and the ones that were fixed for 3.1.0 and i couldn't find anything critical. ---

[jira] [Updated] (FLINK-8126) Update and fix checkstyle

2017-11-21 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-8126: -- Component/s: Build System > Update and fix checkstyle > - > > Ke

[jira] [Created] (FLINK-8126) Update and fix checkstyle

2017-11-21 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-8126: - Summary: Update and fix checkstyle Key: FLINK-8126 URL: https://issues.apache.org/jira/browse/FLINK-8126 Project: Flink Issue Type: Bug Affects Versions: 1.5.0

[jira] [Commented] (FLINK-6294) BucketingSink throws NPE while cancelling job

2017-11-21 Thread Cristian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261228#comment-16261228 ] Cristian commented on FLINK-6294: - This is happening to me on Flink 1.3.2. The line is dif

[jira] [Commented] (FLINK-8117) Eliminate modulo operation from RoundRobinChannelSelector and RebalancePartitioner

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261209#comment-16261209 ] ASF GitHub Bot commented on FLINK-8117: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5041: [FLINK-8117] [runtime] [streaming] Eliminate modulo opera...

2017-11-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5041 Merging this... ---

[jira] [Created] (FLINK-8125) Support limiting the number of open FileSystem connections

2017-11-21 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-8125: --- Summary: Support limiting the number of open FileSystem connections Key: FLINK-8125 URL: https://issues.apache.org/jira/browse/FLINK-8125 Project: Flink Issue

[jira] [Commented] (FLINK-8036) Consider using gradle to build Flink

2017-11-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261193#comment-16261193 ] Ted Yu commented on FLINK-8036: --- Last note: when I see gradlew run selected test(s) so fast,

[jira] [Commented] (FLINK-8117) Eliminate modulo operation from RoundRobinChannelSelector and RebalancePartitioner

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261140#comment-16261140 ] ASF GitHub Bot commented on FLINK-8117: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5041: [FLINK-8117] [runtime] [streaming] Eliminate modulo opera...

2017-11-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5041 Very good change, and nice implementation! +1 to merge this. ---

[jira] [Commented] (FLINK-8113) Bump maven-shade-plugin to 3.0.0

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261134#comment-16261134 ] ASF GitHub Bot commented on FLINK-8113: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5042: [FLINK-8113][build] Bump maven-shade-plugin to 3.0.0

2017-11-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5042 Looks good to me. Do we know if there are any new known issues in shade "3.0.0"? The first release of a new major version sometimes has a few regressions. Have you checked the Maven JIRA

[jira] [Commented] (FLINK-8090) Improve error message when registering different states under the same name.

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261122#comment-16261122 ] ASF GitHub Bot commented on FLINK-8090: --- Github user bowenli86 commented on a diff i

[GitHub] flink pull request #5032: [FLINK-8090] [DataStream] Improve the error messag...

2017-11-21 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5032#discussion_r152348905 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContextTest.java --- @@ -270,6 +271,20 @@ public voi

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261077#comment-16261077 ] ASF GitHub Bot commented on FLINK-7499: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #4581: [FLINK-7499][io] also let AsynchronousBufferFileWr...

2017-11-21 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152342531 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java --- @@ -108,11 +108,7 @@ int releaseMemory(

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261075#comment-16261075 ] ASF GitHub Bot commented on FLINK-7499: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #4581: [FLINK-7499][io] also let AsynchronousBufferFileWr...

2017-11-21 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152342364 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/AsynchronousBufferFileWriter.java --- @@ -31,9 +31,26 @@ protected Asynchrono

[jira] [Comment Edited] (FLINK-7716) Port JobManagerMetricsHandler to new REST endpoint

2017-11-21 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261014#comment-16261014 ] Gary Yao edited comment on FLINK-7716 at 11/21/17 4:39 PM: --- [~ye

[jira] [Commented] (FLINK-7716) Port JobManagerMetricsHandler to new REST endpoint

2017-11-21 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261014#comment-16261014 ] Gary Yao commented on FLINK-7716: - [~yew1eb] This ticket is similar to FLINK-7718 which I

[jira] [Resolved] (FLINK-4600) Support min/max aggregations for Date/Time/Timestamp/Intervals

2017-11-21 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-4600. - Resolution: Fixed Fix Version/s: 1.5.0 I will close this issue for now. I don't know if we

[jira] [Commented] (FLINK-8097) Add built-in support for min/max aggregation for Date/Time

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261011#comment-16261011 ] ASF GitHub Bot commented on FLINK-8097: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5027: [FLINK-8097] [table] Add built-in support for min/...

2017-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5027 ---

[jira] [Resolved] (FLINK-8097) Add built-in support for min/max aggregation for Date/Time

2017-11-21 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8097. - Resolution: Fixed Fixed in 1.5: 44c603d2b62fff20a7213ad55512dc38f43a50bc > Add built-in support f

[jira] [Commented] (FLINK-8097) Add built-in support for min/max aggregation for Date/Time

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260993#comment-16260993 ] ASF GitHub Bot commented on FLINK-8097: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5027: [FLINK-8097] [table] Add built-in support for min/max agg...

2017-11-21 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5027 Thanks @dianfu. Looks good to merge. Merging... ---

[jira] [Commented] (FLINK-8038) Support MAP value constructor

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260970#comment-16260970 ] ASF GitHub Bot commented on FLINK-8038: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-8038) Support MAP value constructor

2017-11-21 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8038. - Resolution: Fixed Fix Version/s: 1.5.0 Fixed in 1.5: c5f5615cf84026039614701b5e6b3b0e003ead

[GitHub] flink pull request #5015: [FLINK-8038][Table API] Support MAP value construc...

2017-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5015 ---

[jira] [Commented] (FLINK-8038) Support MAP value constructor

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260883#comment-16260883 ] ASF GitHub Bot commented on FLINK-8038: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5015: [FLINK-8038][Table API] Support MAP value constructor

2017-11-21 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5015 Thanks for the update @walterddr. I found a little bug for cardinalities. I will fix it and merge this PR. ---

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260867#comment-16260867 ] ASF GitHub Bot commented on FLINK-7880: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260868#comment-16260868 ] ASF GitHub Bot commented on FLINK-7880: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260869#comment-16260869 ] ASF GitHub Bot commented on FLINK-7880: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260871#comment-16260871 ] ASF GitHub Bot commented on FLINK-7880: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260866#comment-16260866 ] ASF GitHub Bot commented on FLINK-7880: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7880) flink-queryable-state-java fails with core-dump

2017-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260870#comment-16260870 ] ASF GitHub Bot commented on FLINK-7880: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #5038: [FLINK-7880][FLINK-7975][FLINK-7974][QS] QS test i...

2017-11-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5038#discussion_r152298612 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java --- @@ -386,6 +430,9 @@ p

[GitHub] flink pull request #5038: [FLINK-7880][FLINK-7975][FLINK-7974][QS] QS test i...

2017-11-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5038#discussion_r152298240 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java --- @@ -312,32 +345,43 @@

[GitHub] flink pull request #5038: [FLINK-7880][FLINK-7975][FLINK-7974][QS] QS test i...

2017-11-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5038#discussion_r152299398 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java --- @@ -95,15 +97,20 @@

[GitHub] flink pull request #5038: [FLINK-7880][FLINK-7975][FLINK-7974][QS] QS test i...

2017-11-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5038#discussion_r152300724 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java --- @@ -166,28 +167,57 @@

  1   2   >