[GitHub] flink issue #4309: [FLINK-7166][avro] cleanup generated test classes in the ...

2017-07-18 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4309 That would make sense and I was going that way at first. It is spread over some of the project files though and there was something about eclipse having problems with it (although the last time, we tri

[jira] [Commented] (FLINK-7198) Datadog Metric Reporter reports incorrect host for JobManager

2017-07-18 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092679#comment-16092679 ] Bowen Li commented on FLINK-7198: - Datadog Metric Reporter gets host name from MetricGroup

[GitHub] flink issue #4240: [FLINK-7058] Fix scala-2.10 dependencies

2017-07-18 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4240 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[jira] [Commented] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092678#comment-16092678 ] ASF GitHub Bot commented on FLINK-7058: --- Github user pnowojski commented on the issu

[GitHub] flink pull request #4359: [FLINK-7140][blob] add an additional random compon...

2017-07-18 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4359#discussion_r128165494 --- Diff: flink-core/src/main/java/org/apache/flink/util/AbstractID.java --- @@ -46,7 +46,7 @@ /** The lower part of the actual ID */ protected

[jira] [Commented] (FLINK-7140) include a UUID/random name into the BlobKey

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092676#comment-16092676 ] ASF GitHub Bot commented on FLINK-7140: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-6125) Commons httpclient is not shaded anymore in Flink 1.2

2017-07-18 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092668#comment-16092668 ] Tzu-Li (Gordon) Tai commented on FLINK-6125: [~phoenixjiangnan] did you confir

[jira] [Commented] (FLINK-6125) Commons httpclient is not shaded anymore in Flink 1.2

2017-07-18 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092660#comment-16092660 ] Bowen Li commented on FLINK-6125: - This is similar to https://issues.apache.org/jira/brows

[jira] [Commented] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

2017-07-18 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092661#comment-16092661 ] Bowen Li commented on FLINK-6951: - This is similar to https://issues.apache.org/jira/brows

[jira] [Commented] (FLINK-7224) Incorrect Javadoc description in all Kafka consumer versions

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092654#comment-16092654 ] ASF GitHub Bot commented on FLINK-7224: --- GitHub user tzulitai opened a pull request:

[GitHub] flink pull request #4363: [FLINK-7224] [kafka, docs] Fix incorrect Javadoc /...

2017-07-18 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/4363 [FLINK-7224] [kafka, docs] Fix incorrect Javadoc / docs regarding Kafka partition metadata querying Since Flink 1.3, partition metadata is no longer queried on the client side. This commit corr

[jira] [Updated] (FLINK-7224) Incorrect Javadoc description in all Kafka consumer versions

2017-07-18 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-7224: --- Description: Currently, all Kafka consumer version still have this in the Javadoc: {c

[jira] [Updated] (FLINK-7224) Incorrect Javadoc description in all Kafka consumer versions

2017-07-18 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-7224: --- Description: Currently, all Kafka consumer version still have this in the Javadoc: {c

[jira] [Created] (FLINK-7224) Incorrect Javadoc description in all Kafka consumer versions

2017-07-18 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-7224: -- Summary: Incorrect Javadoc description in all Kafka consumer versions Key: FLINK-7224 URL: https://issues.apache.org/jira/browse/FLINK-7224 Project: Flink

[GitHub] flink issue #4310: [misc] Commit read offsets in Kafka integration tests

2017-07-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4310 I would like to revisit tests that use this method by first discussing: wouldn't it be more appropriate to have a validating mapper function that throws a `SuccessException` once it sees all reco

[jira] [Commented] (FLINK-7174) Bump dependency of Kafka 0.10.x to the latest one

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092619#comment-16092619 ] ASF GitHub Bot commented on FLINK-7174: --- Github user tzulitai commented on the issue

[GitHub] flink issue #4321: [FLINK-7174] Bump Kafka 0.10 dependency to 0.10.2.1

2017-07-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4321 One other question: I need a bit more context on why the version bump requires that change in the `KafkaConsumerThread`. From what I perceive, that should be an separate issue to fix hot looping, no

[GitHub] flink issue #4321: [FLINK-7174] Bump Kafka 0.10 dependency to 0.10.2.1

2017-07-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4321 @pnowojski we can't just drop that test, IMO. It's crucial that those tests exist to guard against incorrect reassignment logic in the `KafkaConsumerThread`. Breaking that would mess up the shutdown

[jira] [Commented] (FLINK-7174) Bump dependency of Kafka 0.10.x to the latest one

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092616#comment-16092616 ] ASF GitHub Bot commented on FLINK-7174: --- Github user tzulitai commented on the issue

[jira] [Commented] (FLINK-7222) Kafka010ITCase fails on windows

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092608#comment-16092608 ] ASF GitHub Bot commented on FLINK-7222: --- Github user tzulitai commented on the issue

[GitHub] flink issue #4361: [FLINK-7222] fix Kafka010ITCase fails on windows

2017-07-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4361 Thanks for the pull request @zjureel. While you're on this, could you also fix this for Kafka 08 and 09? --- If your project is set up for it, you can reply to this email and have your reply app

[jira] [Created] (FLINK-7223) Increase DEFAULT_SHARD_DISCOVERY_INTERVAL_MILLIS for Flink-kinesis-connector

2017-07-18 Thread Bowen Li (JIRA)
Bowen Li created FLINK-7223: --- Summary: Increase DEFAULT_SHARD_DISCOVERY_INTERVAL_MILLIS for Flink-kinesis-connector Key: FLINK-7223 URL: https://issues.apache.org/jira/browse/FLINK-7223 Project: Flink

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092533#comment-16092533 ] ASF GitHub Bot commented on FLINK-7143: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection ...

2017-07-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4357#discussion_r128147490 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -517,16

[GitHub] flink pull request #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection ...

2017-07-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4357#discussion_r128147542 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -517,16

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092535#comment-16092535 ] ASF GitHub Bot commented on FLINK-7143: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092528#comment-16092528 ] ASF GitHub Bot commented on FLINK-7143: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection ...

2017-07-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4357#discussion_r128147294 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -517,16

[jira] [Commented] (FLINK-5541) Missing null check for localJar in FlinkSubmitter#submitTopology()

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092494#comment-16092494 ] ASF GitHub Bot commented on FLINK-5541: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...

2017-07-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4315 PR had been updated. Please helps to check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[jira] [Commented] (FLINK-5541) Missing null check for localJar in FlinkSubmitter#submitTopology()

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092492#comment-16092492 ] ASF GitHub Bot commented on FLINK-5541: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...

2017-07-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4315 Oh my gosh, The newest checkstyle is very awesome, it can detect this kinda message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[jira] [Commented] (FLINK-7134) Remove hadoop1.x code in mapreduce.utils.HadoopUtils

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092482#comment-16092482 ] ASF GitHub Bot commented on FLINK-7134: --- GitHub user zhangminglei opened a pull requ

[GitHub] flink pull request #4362: [FLINK-7134] Remove hadoop1.x code in mapreduce.ut...

2017-07-18 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4362 [FLINK-7134] Remove hadoop1.x code in mapreduce.utils.HadoopUtils You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei/flink flink-

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092481#comment-16092481 ] ASF GitHub Bot commented on FLINK-6075: --- Github user wuchong commented on the issue:

[GitHub] flink issue #4263: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-07-18 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4263 Hi @fhueske , I left this comment under the JIRA. To make sure you know our situation, I post it here: >I think the most useful feature is PR3 "ORDER BY OFFSET FETCH" (i.e. TopN). It is an

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092476#comment-16092476 ] Jark Wu commented on FLINK-7194: [~fhueske], even if we change {{ScalarFunction.getResultT

[jira] [Commented] (FLINK-7222) Kafka010ITCase fails on windows

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092466#comment-16092466 ] ASF GitHub Bot commented on FLINK-7222: --- GitHub user zjureel opened a pull request:

[GitHub] flink pull request #4361: [FLINK-7222] fix Kafka010ITCase fails on windows

2017-07-18 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4361 [FLINK-7222] fix Kafka010ITCase fails on windows Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your chan

[jira] [Commented] (FLINK-7134) Remove hadoop1.x code in mapreduce.utils.HadoopUtils

2017-07-18 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092465#comment-16092465 ] mingleizhang commented on FLINK-7134: - I will work on this soon enough. > Remove hado

[jira] [Assigned] (FLINK-7222) Kafka010ITCase fails on windows

2017-07-18 Thread Fang Yong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong reassigned FLINK-7222: Assignee: Fang Yong > Kafka010ITCase fails on windows > --- > >

[jira] [Updated] (FLINK-7222) Kafka010ITCase fails on windows

2017-07-18 Thread Fang Yong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong updated FLINK-7222: - Description: Kafka010ITCase fails on windows for the following resions {code} java.lang.AssertionError: ca

[jira] [Created] (FLINK-7222) Kafka010ITCase fails on windows

2017-07-18 Thread Fang Yong (JIRA)
Fang Yong created FLINK-7222: Summary: Kafka010ITCase fails on windows Key: FLINK-7222 URL: https://issues.apache.org/jira/browse/FLINK-7222 Project: Flink Issue Type: Bug Components: K

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-07-18 Thread hongyuhong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092438#comment-16092438 ] hongyuhong commented on FLINK-6233: --- Hi [~fhueske], [~xccui] is now working on this issu

[jira] [Assigned] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-07-18 Thread hongyuhong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hongyuhong reassigned FLINK-6233: - Assignee: Xingcan Cui (was: hongyuhong) > Support rowtime inner equi-join between two streams in

[jira] [Commented] (FLINK-7197) Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092415#comment-16092415 ] ASF GitHub Bot commented on FLINK-7197: --- Github user tedyu commented on the issue:

[GitHub] flink issue #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorithmWrappi...

2017-07-18 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/4345 Fine by me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[jira] [Commented] (FLINK-7108) Implement Session cluster entry point

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092413#comment-16092413 ] ASF GitHub Bot commented on FLINK-7108: --- Github user EronWright commented on a diff

[GitHub] flink pull request #4281: [FLINK-7108] [yarn] Add YARN entry points based on...

2017-07-18 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4281#discussion_r128130195 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnJobClusterEntrypoint.java --- @@ -0,0 +1,138 @@ +/* + * Licensed to the A

[GitHub] flink issue #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorithmWrappi...

2017-07-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4345 @tedyu does this look right to you now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[jira] [Commented] (FLINK-7197) Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092408#comment-16092408 ] ASF GitHub Bot commented on FLINK-7197: --- Github user greghogan commented on the issu

[jira] [Commented] (FLINK-7140) include a UUID/random name into the BlobKey

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092407#comment-16092407 ] ASF GitHub Bot commented on FLINK-7140: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #4359: [FLINK-7140][blob] add an additional random compon...

2017-07-18 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4359#discussion_r128129730 --- Diff: flink-core/src/main/java/org/apache/flink/util/AbstractID.java --- @@ -46,7 +46,7 @@ /** The lower part of the actual ID */ protec

[jira] [Commented] (FLINK-7108) Implement Session cluster entry point

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092404#comment-16092404 ] ASF GitHub Bot commented on FLINK-7108: --- Github user EronWright commented on a diff

[GitHub] flink pull request #4281: [FLINK-7108] [yarn] Add YARN entry points based on...

2017-07-18 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4281#discussion_r128129505 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtils.java --- @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-7108) Implement Session cluster entry point

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092400#comment-16092400 ] ASF GitHub Bot commented on FLINK-7108: --- Github user EronWright commented on a diff

[GitHub] flink pull request #4281: [FLINK-7108] [yarn] Add YARN entry points based on...

2017-07-18 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4281#discussion_r128129161 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtils.java --- @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-7220) Update RocksDB dependency to 5.5.1

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092397#comment-16092397 ] ASF GitHub Bot commented on FLINK-7220: --- Github user greghogan commented on the issu

[GitHub] flink issue #4360: [FLINK-7220] [checkpoints] Update RocksDB dependency to 5...

2017-07-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4360 RocksDB 5.5.5 looks to include the desired licensing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[jira] [Commented] (FLINK-7204) CombineHint.NONE

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092384#comment-16092384 ] ASF GitHub Bot commented on FLINK-7204: --- Github user greghogan commented on the issu

[GitHub] flink issue #4350: [FLINK-7204] [core] CombineHint.NONE

2017-07-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4350 @fhueske updated and manually verified. I had misinterpreted `DriverStrategy` to imply that `SORTED_REDUCE` would not use a combiner. --- If your project is set up for it, you can reply to this em

[jira] [Commented] (FLINK-7082) Flip-6: Generic entry point for Flink sessions

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092347#comment-16092347 ] ASF GitHub Bot commented on FLINK-7082: --- Github user EronWright commented on the iss

[GitHub] flink issue #4261: [FLINK-7082] Add generic entry point for session and per-...

2017-07-18 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/4261 Looking at the various diagrams of FLIP-6, there's quite a few possible arrangements of the 'building blocks'. I wonder if composition over inheritance would be preferable as we develop the othe

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092282#comment-16092282 ] ASF GitHub Bot commented on FLINK-7143: --- Github user stevenzwu commented on a diff i

[GitHub] flink pull request #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection ...

2017-07-18 Thread stevenzwu
Github user stevenzwu commented on a diff in the pull request: https://github.com/apache/flink/pull/4357#discussion_r128113797 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -517,16

[jira] [Commented] (FLINK-7082) Flip-6: Generic entry point for Flink sessions

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092263#comment-16092263 ] ASF GitHub Bot commented on FLINK-7082: --- Github user EronWright commented on a diff

[GitHub] flink pull request #4261: [FLINK-7082] Add generic entry point for session a...

2017-07-18 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4261#discussion_r128109508 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java --- @@ -0,0 +1,247 @@ +/* + * Licensed to the Ap

[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092084#comment-16092084 ] ASF GitHub Bot commented on FLINK-6998: --- Github user zhenzhongxu commented on a diff

[GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...

2017-07-18 Thread zhenzhongxu
Github user zhenzhongxu commented on a diff in the pull request: https://github.com/apache/flink/pull/4187#discussion_r128078950 --- Diff: docs/monitoring/metrics.md --- @@ -896,6 +896,28 @@ Thus, in order to infer the metric identifier: + Connector:

[jira] [Commented] (FLINK-7220) Update RocksDB dependency to 5.5.1

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092016#comment-16092016 ] ASF GitHub Bot commented on FLINK-7220: --- Github user zentol commented on the issue:

[GitHub] flink issue #4360: [FLINK-7220] [checkpoints] Update RocksDB dependency to 5...

2017-07-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4360 We should still be able to switch back to the original RocksDB dependency. The licensing issue should also apply to frocksdb. --- If your project is set up for it, you can reply to this email and hav

[jira] [Commented] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092012#comment-16092012 ] Chesnay Schepler commented on FLINK-7058: - 1.4: 8b59b4fcafba331dc03ef661919b497d84

[jira] [Closed] (FLINK-7162) Tests should not write outside 'target' directory.

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7162. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: 8a43b9c0b7b0272cd5076f206d3b42d14396d9d6 >

[jira] [Closed] (FLINK-7184) Activate checkstyle flink-java/hadoop

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7184. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: 0fd492caf9da900eb5edbc3c040b3337a19a75f3 >

[jira] [Closed] (FLINK-7183) Activate checkstyle flink-java/aggregation

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7183. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: afb85f5f15bf734163b88c3558851f24f50da2f6 >

[jira] [Closed] (FLINK-7189) Activate checkstyle flink-java/utils

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7189. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: 137463cd6651dd63fbc3d45796208cb359680d73 >

[jira] [Closed] (FLINK-6550) Calling ctx.collect with a null OutputTag should log a warning or throw an exception

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6550. --- Resolution: Fixed Assignee: Chesnay Schepler Fix Version/s: 1.4.0 1.4: daed1ee

[jira] [Closed] (FLINK-7182) Activate checkstyle flink-java/functions

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7182. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: ec1044d985f24b9c1e45d1d25ef060a504e1695d >

[jira] [Commented] (FLINK-7189) Activate checkstyle flink-java/utils

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091998#comment-16091998 ] ASF GitHub Bot commented on FLINK-7189: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-7186) Activate checkstyle flink-java/sampling

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7186. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: 72678f1407fd24088edae3c96d33b90b43e21a0f >

[jira] [Commented] (FLINK-7182) Activate checkstyle flink-java/functions

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091999#comment-16091999 ] ASF GitHub Bot commented on FLINK-7182: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-7183) Activate checkstyle flink-java/aggregation

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091996#comment-16091996 ] ASF GitHub Bot commented on FLINK-7183: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092001#comment-16092001 ] ASF GitHub Bot commented on FLINK-7058: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-6550) Calling ctx.collect with a null OutputTag should log a warning or throw an exception

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091997#comment-16091997 ] ASF GitHub Bot commented on FLINK-6550: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-7184) Activate checkstyle flink-java/hadoop

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092000#comment-16092000 ] ASF GitHub Bot commented on FLINK-7184: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-7162) Tests should not write outside 'target' directory.

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092002#comment-16092002 ] ASF GitHub Bot commented on FLINK-7162: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4240: [FLINK-7058] Fix scala-2.10 dependencies

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #4311: [FLINK-7162] [test] Tests should not write outside...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4311 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #4341: [FLINK-7184] Activate checkstyle flink-java/hadoop

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #4339: [FLINK-7186] Activate checkstyle flink-java/sampli...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #4336: [FLINK-7189] Activate checkstyle flink-java/utils

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4336 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #4312: [FLINK-6550] Reject null OutputTags in Context#col...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-7186) Activate checkstyle flink-java/sampling

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091995#comment-16091995 ] ASF GitHub Bot commented on FLINK-7186: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4333: [FLINK-7182] Activate checkstyle flink-java/functi...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4333 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #4332: [FLINK-7183] Activate checkstyle flink-java/aggreg...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4332 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-7103) Implement skeletal structure of dispatcher component

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091916#comment-16091916 ] ASF GitHub Bot commented on FLINK-7103: --- Github user EronWright commented on the iss

[GitHub] flink issue #4260: [FLINK-7103] [dispatcher] Add skeletal structure of Dispa...

2017-07-18 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/4260 My take on this skeleton is that the `Dispatcher` should not use the `JobManagerRunner` directly. My rationale is: 1. The dispatcher should never execute user code, otherwise it cannot trul

[jira] [Updated] (FLINK-7209) Support DataView in Java and Scala Tuples and case classes or as the accumulator of AggregateFunction itself

2017-07-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-7209: -- Component/s: (was: State Backends, Checkpointing) Table API & SQL > Support

[jira] [Updated] (FLINK-7208) Refactor build-in agg(MaxWithRetractAccumulator and MinWithRetractAccumulator) using the DataView

2017-07-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-7208: -- Component/s: Table API & SQL > Refactor build-in agg(MaxWithRetractAccumulator and > MinWithRet

[jira] [Updated] (FLINK-7210) Add TwoPhaseCommitSinkFunction (implementing exactly-once semantic in generic way)

2017-07-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-7210: -- Component/s: Streaming Connectors > Add TwoPhaseCommitSinkFunction (implementing exactly-once se

  1   2   3   >