[jira] [Comment Edited] (FLINK-6211) Validation error in Kinesis Consumer when using AT_TIMESTAMP as start position

2017-03-28 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946619#comment-15946619 ] Tzu-Li (Gordon) Tai edited comment on FLINK-6211 at 3/29/17 6:48 AM: ---

[jira] [Commented] (FLINK-4523) Allow Kinesis Consumer to start from specific timestamp / Date

2017-03-28 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946622#comment-15946622 ] Wei-Che Wei commented on FLINK-4523: [~tsriharsha] I have opened a task (FLINK-6211)

[jira] [Commented] (FLINK-6211) Validation error in Kinesis Consumer when using AT_TIMESTAMP as start position

2017-03-28 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946619#comment-15946619 ] Tzu-Li (Gordon) Tai commented on FLINK-6211: Thanks for looking into this. I w

[jira] [Updated] (FLINK-6211) Validation error in Kinesis Consumer when using AT_TIMESTAMP as start position

2017-03-28 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-6211: --- Fix Version/s: 1.2.1 > Validation error in Kinesis Consumer when using AT_TIMESTAMP as

[jira] [Updated] (FLINK-6211) Validation error in Kinesis Consumer when using AT_TIMESTAMP as start position

2017-03-28 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-6211: --- Priority: Blocker (was: Major) > Validation error in Kinesis Consumer when using AT_T

[jira] [Updated] (FLINK-6211) Validation error in Kinesis Consumer when using AT_TIMESTAMP as start position

2017-03-28 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Che Wei updated FLINK-6211: --- Fix Version/s: 1.3.0 > Validation error in Kinesis Consumer when using AT_TIMESTAMP as start position

[jira] [Updated] (FLINK-6211) Validation error in Kinesis Consumer when using AT_TIMESTAMP as start position

2017-03-28 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Che Wei updated FLINK-6211: --- Component/s: Kinesis Connector > Validation error in Kinesis Consumer when using AT_TIMESTAMP as start

[jira] [Created] (FLINK-6211) Validation error in Kinesis Consumer when using AT_TIMESTAMP as start position

2017-03-28 Thread Wei-Che Wei (JIRA)
Wei-Che Wei created FLINK-6211: -- Summary: Validation error in Kinesis Consumer when using AT_TIMESTAMP as start position Key: FLINK-6211 URL: https://issues.apache.org/jira/browse/FLINK-6211 Project: Fli

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108597029 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala --- @@ -0

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946603#comment-15946603 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108596940 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -729,6 +747,39 @@ object Agg

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108599930 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala --- @@ -0

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108596217 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -195,6 +194,45

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946606#comment-15946606 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108596688 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -729,6 +747,39 @@ object Agg

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946609#comment-15946609 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946597#comment-15946597 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946602#comment-15946602 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946612#comment-15946612 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946608#comment-15946608 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946599#comment-15946599 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108598502 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala --- @@ -0

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946600#comment-15946600 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946605#comment-15946605 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946601#comment-15946601 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946598#comment-15946598 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946604#comment-15946604 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946613#comment-15946613 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946611#comment-15946611 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108595908 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -696,6 +696,181 @@ class SqlI

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108596582 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -729,6 +747,39 @@ object Agg

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946607#comment-15946607 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946610#comment-15946610 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a d

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108599456 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -129,7 +129,7 @@ class SqlITC

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108597142 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala --- @@ -0

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108600245 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala --- @@ -350,4 +350,59 @@ c

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108598345 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala --- @@ -0

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108598458 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala --- @@ -0

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108596468 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -89,6 +95,18 @@ object Aggre

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108597606 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala --- @@ -0

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108598268 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -729,6 +747,39 @@ object Agg

[GitHub] flink pull request #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3574#discussion_r108599214 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala --- @@ -0

[jira] [Commented] (FLINK-4523) Allow Kinesis Consumer to start from specific timestamp / Date

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946592#comment-15946592 ] ASF GitHub Bot commented on FLINK-4523: --- Github user tony810430 commented on a diff

[GitHub] flink pull request #2916: [FLINK-4523] [kinesis] Allow Kinesis Consumer to s...

2017-03-28 Thread tony810430
Github user tony810430 commented on a diff in the pull request: https://github.com/apache/flink/pull/2916#discussion_r108599820 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java --- @@ -215,4

[jira] [Commented] (FLINK-4523) Allow Kinesis Consumer to start from specific timestamp / Date

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946588#comment-15946588 ] ASF GitHub Bot commented on FLINK-4523: --- Github user tsriharsha commented on a diff

[GitHub] flink pull request #2916: [FLINK-4523] [kinesis] Allow Kinesis Consumer to s...

2017-03-28 Thread tsriharsha
Github user tsriharsha commented on a diff in the pull request: https://github.com/apache/flink/pull/2916#discussion_r108598516 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java --- @@ -215,4

[jira] [Commented] (FLINK-4523) Allow Kinesis Consumer to start from specific timestamp / Date

2017-03-28 Thread Sriharsha Tikkireddy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946584#comment-15946584 ] Sriharsha Tikkireddy commented on FLINK-4523: - [~tonywei] Hey I tried to run u

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946503#comment-15946503 ] ASF GitHub Bot commented on FLINK-5982: --- Github user tony810430 commented on the iss

[GitHub] flink issue #3633: [FLINK-5982] [runtime] Refactor AbstractInvokable and Sta...

2017-03-28 Thread tony810430
Github user tony810430 commented on the issue: https://github.com/apache/flink/pull/3633 @StephanEwen Thanks for the suggestion. I have updated the patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946496#comment-15946496 ] ASF GitHub Bot commented on FLINK-5654: --- Github user sunjincheng121 commented on the

[GitHub] flink issue #3607: [FLINK-5654] - Add processing time OVER RANGE BETWEEN x P...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3607 Hi, @rtudoran When open a PR. we should keep our commits based on the latest master branch, so that the PR. only contains the change for this issue and will be clearly for other's review.I ha

[jira] [Commented] (FLINK-6204) Improve Event-Time OVER ROWS BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-28 Thread shijinkui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946477#comment-15946477 ] shijinkui commented on FLINK-6204: -- -1. hi, guys. I want to know the differance between

[jira] [Commented] (FLINK-5655) Add event time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946474#comment-15946474 ] ASF GitHub Bot commented on FLINK-5655: --- Github user sunjincheng121 commented on the

[GitHub] flink issue #3629: [FLINK-5655][table]Add event time OVER RANGE BETWEEN x PR...

2017-03-28 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3629 Hi @fhueske thanks a lot for your review. I have updated the PR according to your comments. There is one thing need your explanation.i.e. : `Also, I realized that this implementation (

[jira] [Updated] (FLINK-6210) RocksDB instance should be closed in ListViaMergeSpeedMiniBenchmark

2017-03-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-6210: -- Description: rocksDB instance should be closed upon returning from main(). ListViaRangeSpeedMiniBenchmark has

[jira] [Comment Edited] (FLINK-6085) flink as micro service

2017-03-28 Thread Chen Qin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945991#comment-15945991 ] Chen Qin edited comment on FLINK-6085 at 3/29/17 3:04 AM: -- To unl

[jira] [Commented] (FLINK-6082) Support window definition for SQL Queries based on WHERE clause with time condition

2017-03-28 Thread hongyuhong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946417#comment-15946417 ] hongyuhong commented on FLINK-6082: --- Hi [~fhueske], i think what radu means about using

[jira] [Comment Edited] (FLINK-6204) Improve Event-Time OVER ROWS BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-28 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945183#comment-15945183 ] sunjincheng edited comment on FLINK-6204 at 3/29/17 2:02 AM: -

[jira] [Commented] (FLINK-6117) 'zookeeper.sasl.disable' not takes effet when starting CuratorFramework

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946400#comment-15946400 ] ASF GitHub Bot commented on FLINK-6117: --- Github user zhengcanbin commented on the is

[GitHub] flink issue #3600: [FLINK-6117]Make setting of 'zookeeper.sasl.disable' work...

2017-03-28 Thread zhengcanbin
Github user zhengcanbin commented on the issue: https://github.com/apache/flink/pull/3600 @StephanEwen @vijikarthi @EronWright @Rucongzhang Thanks all! I have changed this default behaviour, now `zookeeper.sasl.disable` is `false` by default. --- If your project is set up for it

[jira] [Commented] (FLINK-6034) Add KeyedStateHandle for the snapshots in keyed streams

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946381#comment-15946381 ] ASF GitHub Bot commented on FLINK-6034: --- Github user shixiaogang closed the pull req

[jira] [Commented] (FLINK-6034) Add KeyedStateHandle for the snapshots in keyed streams

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946380#comment-15946380 ] ASF GitHub Bot commented on FLINK-6034: --- Github user shixiaogang commented on the is

[GitHub] flink pull request #3531: [FLINK-6034][checkpoint] Add KeyedStateHandle for ...

2017-03-28 Thread shixiaogang
Github user shixiaogang closed the pull request at: https://github.com/apache/flink/pull/3531 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #3531: [FLINK-6034][checkpoint] Add KeyedStateHandle for the sna...

2017-03-28 Thread shixiaogang
Github user shixiaogang commented on the issue: https://github.com/apache/flink/pull/3531 @StefanRRichter Thanks for your work. I will close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-6117) 'zookeeper.sasl.disable' not takes effet when starting CuratorFramework

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946336#comment-15946336 ] ASF GitHub Bot commented on FLINK-6117: --- Github user Rucongzhang commented on the is

[GitHub] flink issue #3600: [FLINK-6117]Make setting of 'zookeeper.sasl.disable' work...

2017-03-28 Thread Rucongzhang
Github user Rucongzhang commented on the issue: https://github.com/apache/flink/pull/3600 @StephanEwen , yes, now if you want to use kerberos , you need additionally to set zookeeper.sasl.disable to false. And I agree with you, the default value of zookeeper.sasl.disable can set to f

[GitHub] flink pull request #3636: Change to validateOptionalDatePropery method

2017-03-28 Thread tsriharsha
GitHub user tsriharsha opened a pull request: https://github.com/apache/flink/pull/3636 Change to validateOptionalDatePropery method Current version of validateoptionaldateproperty will fail because it will check for date first and if it passes it will fail to get parsed as a double

[jira] [Created] (FLINK-6210) RocksDB instance should be closed in ListViaMergeSpeedMiniBenchmark

2017-03-28 Thread Ted Yu (JIRA)
Ted Yu created FLINK-6210: - Summary: RocksDB instance should be closed in ListViaMergeSpeedMiniBenchmark Key: FLINK-6210 URL: https://issues.apache.org/jira/browse/FLINK-6210 Project: Flink Issue Ty

[jira] [Commented] (FLINK-6209) StreamPlanEnvironment always has a parallelism of 1

2017-03-28 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946043#comment-15946043 ] Haohui Mai commented on FLINK-6209: --- We found that FLINK-5808 removes this snippet of co

[jira] [Created] (FLINK-6209) StreamPlanEnvironment always has a parallelism of 1

2017-03-28 Thread Haohui Mai (JIRA)
Haohui Mai created FLINK-6209: - Summary: StreamPlanEnvironment always has a parallelism of 1 Key: FLINK-6209 URL: https://issues.apache.org/jira/browse/FLINK-6209 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-6085) flink as micro service

2017-03-28 Thread Chen Qin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945991#comment-15945991 ] Chen Qin commented on FLINK-6085: - To unlock scenarios like blocking rpc call or async cal

[GitHub] flink issue #3600: [FLINK-6117]Make setting of 'zookeeper.sasl.disable' work...

2017-03-28 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/3600 The thread is becoming confused as to what the default behavior should be. In brief I think the code should say: ``` public static final ConfigOption ZOOKEEPER_SASL_DISABLE =

[jira] [Commented] (FLINK-6117) 'zookeeper.sasl.disable' not takes effet when starting CuratorFramework

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945893#comment-15945893 ] ASF GitHub Bot commented on FLINK-6117: --- Github user EronWright commented on the iss

[jira] [Commented] (FLINK-6183) TaskMetricGroup may not be cleanup when Task.run() is never called or exits early

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945700#comment-15945700 ] ASF GitHub Bot commented on FLINK-6183: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #3610: [FLINK-6183]/[FLINK-6184] Prevent some NPE and unc...

2017-03-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3610#discussion_r108503328 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java --- @@ -80,8 +80,17 @@ public TaskMetricGroup ad

[jira] [Closed] (FLINK-6034) Add KeyedStateHandle for the snapshots in keyed streams

2017-03-28 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-6034. - Resolution: Fixed Fix Version/s: 1.3.0 Implemented in cd5527417a1cae57073a8855c6c3b88c88c78

[jira] [Commented] (FLINK-6034) Add KeyedStateHandle for the snapshots in keyed streams

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945649#comment-15945649 ] ASF GitHub Bot commented on FLINK-6034: --- Github user StefanRRichter commented on the

[GitHub] flink issue #3531: [FLINK-6034][checkpoint] Add KeyedStateHandle for the sna...

2017-03-28 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3531 Merged in cd5527417a1cae57073a8855c6c3b88c88c780aa. @shixiaogang can you please close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on G

[jira] [Commented] (FLINK-6117) 'zookeeper.sasl.disable' not takes effet when starting CuratorFramework

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945618#comment-15945618 ] ASF GitHub Bot commented on FLINK-6117: --- Github user vijikarthi commented on the iss

[GitHub] flink issue #3600: [FLINK-6117]Make setting of 'zookeeper.sasl.disable' work...

2017-03-28 Thread vijikarthi
Github user vijikarthi commented on the issue: https://github.com/apache/flink/pull/3600 The default ZK SASL client behavior is to enable SASL client and to be in consistent it makes sense for us to leave the default option enabled. --- If your project is set up for it, you can reply

[jira] [Commented] (FLINK-6117) 'zookeeper.sasl.disable' not takes effet when starting CuratorFramework

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945613#comment-15945613 ] ASF GitHub Bot commented on FLINK-6117: --- Github user vijikarthi commented on a diff

[GitHub] flink pull request #3600: [FLINK-6117]Make setting of 'zookeeper.sasl.disabl...

2017-03-28 Thread vijikarthi
Github user vijikarthi commented on a diff in the pull request: https://github.com/apache/flink/pull/3600#discussion_r108284815 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java --- @@ -55,6 +55,10 @@ // ZooKeeper Security Options

[jira] [Commented] (FLINK-6207) Duplicate type serializers for async snapshots of CopyOnWriteStateTable

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945612#comment-15945612 ] ASF GitHub Bot commented on FLINK-6207: --- Github user StefanRRichter closed the pull

[GitHub] flink pull request #3634: [FLINK-6207] Duplicate TypeSerializers for async s...

2017-03-28 Thread StefanRRichter
Github user StefanRRichter closed the pull request at: https://github.com/apache/flink/pull/3634 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Closed] (FLINK-6207) Duplicate type serializers for async snapshots of CopyOnWriteStateTable

2017-03-28 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-6207. - Resolution: Fixed Fix Version/s: 1.2.1 fixed in 89866a5 backported to 1.2 in bb3e26f > Du

[GitHub] flink pull request #3635: [FLINK-5913] [gelly] Example drivers

2017-03-28 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3635 [FLINK-5913] [gelly] Example drivers Replace existing and create new algorithm Driver implementations for each of the library methods. You can merge this pull request into a Git repository by run

[jira] [Commented] (FLINK-5913) Example drivers

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945600#comment-15945600 ] ASF GitHub Bot commented on FLINK-5913: --- GitHub user greghogan opened a pull request

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945578#comment-15945578 ] ASF GitHub Bot commented on FLINK-5982: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3633: [FLINK-5982] [runtime] Refactor AbstractInvokable and Sta...

2017-03-28 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3633 Thanks for this refactoring. I had only a quick look so far, but one thought was that this patch could probably be simplified by making `triggerCheckpoint()` (and restore / notifyComplete) not ab

[jira] [Commented] (FLINK-6183) TaskMetricGroup may not be cleanup when Task.run() is never called or exits early

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945559#comment-15945559 ] ASF GitHub Bot commented on FLINK-6183: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #3610: [FLINK-6183]/[FLINK-6184] Prevent some NPE and unc...

2017-03-28 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3610#discussion_r108478998 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java --- @@ -80,8 +80,17 @@ public TaskMetricGro

[GitHub] flink issue #3627: Release 0.4 alpha.0

2017-03-28 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3627 Can you close this PR? Looks like this is some confusion... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[jira] [Created] (FLINK-6208) Implement skip till next match strategy

2017-03-28 Thread Dawid Wysakowicz (JIRA)
Dawid Wysakowicz created FLINK-6208: --- Summary: Implement skip till next match strategy Key: FLINK-6208 URL: https://issues.apache.org/jira/browse/FLINK-6208 Project: Flink Issue Type: New F

[jira] [Commented] (FLINK-6207) Duplicate type serializers for async snapshots of CopyOnWriteStateTable

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945535#comment-15945535 ] ASF GitHub Bot commented on FLINK-6207: --- Github user StefanRRichter commented on the

[GitHub] flink issue #3634: [FLINK-6207] Duplicate TypeSerializers for async snapshot...

2017-03-28 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3634 Thanks for the fast review @tillrohrmann ! I will let the test extend the `TestLogger` as suggested and then merge this. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-6207) Duplicate type serializers for async snapshots of CopyOnWriteStateTable

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945525#comment-15945525 ] ASF GitHub Bot commented on FLINK-6207: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #3634: [FLINK-6207] Duplicate TypeSerializers for async s...

2017-03-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3634#discussion_r108473910 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateTableTest.java --- @@ -380,6 +385,77 @@ public void testCopyO

[GitHub] flink pull request #3629: [FLINK-5655][table]Add event time OVER RANGE BETWE...

2017-03-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3629#discussion_r108463560 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RangeClauseBoundedOverProcessFunction.scala --- @@ -0,0 +1,213

[GitHub] flink pull request #3629: [FLINK-5655][table]Add event time OVER RANGE BETWE...

2017-03-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3629#discussion_r108467653 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RangeClauseBoundedOverProcessFunction.scala --- @@ -0,0 +1,213

[jira] [Commented] (FLINK-5655) Add event time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945515#comment-15945515 ] ASF GitHub Bot commented on FLINK-5655: --- Github user fhueske commented on a diff in

  1   2   3   >