Github user tsriharsha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2916#discussion_r108598516
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
@@ -215,4 +229,18 @@ private static void
validateOptionalPositiveDoubleProperty(Properties config, St
}
}
}
+
+ private static void validateOptionalDateProperty(Properties config,
String key, String message) {
+ if (config.containsKey(key)) {
+ try {
+
initTimestampDateFormat.parse(config.getProperty(key));
--- End diff --
Hey this throws an error if a double is passed but the next line throws an
exception when a timestamp string is passed. @tzulitai @tony810430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
