[
https://issues.apache.org/jira/browse/FLINK-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhuhaifeng updated FLINK-4840:
--
Description:
We should expose the following Metrics on the TaskIOMetricGroup:
1. recordProcessLatency(ms
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635399#comment-15635399
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86493542
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncCollector.java
---
@@ -0,0 +1,86 @@
+/*
+ * Lic
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635394#comment-15635394
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86493343
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncCollector.java
---
@@ -0,0 +1,86 @@
+/*
+ * Lic
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635391#comment-15635391
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86493182
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AsyncDataStream.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licens
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635389#comment-15635389
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86493149
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AsyncDataStream.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licens
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635368#comment-15635368
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86492545
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AsyncDataStream.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licens
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635365#comment-15635365
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86492478
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AsyncDataStream.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licens
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635355#comment-15635355
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86492216
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -0,0 +1,194 @@
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86486644
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -0,0 +1,194 @@
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635158#comment-15635158
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635152#comment-15635152
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86486482
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -0,0 +1,194 @@
[
https://issues.apache.org/jira/browse/FLINK-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635107#comment-15635107
]
Tzu-Li (Gordon) Tai edited comment on FLINK-4576 at 11/4/16 4:01 AM:
---
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635142#comment-15635142
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635140#comment-15635140
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86486085
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -0,0 +1,194 @@
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86486055
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -0,0 +1,194 @@
[
https://issues.apache.org/jira/browse/FLINK-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635107#comment-15635107
]
Tzu-Li (Gordon) Tai edited comment on FLINK-4576 at 11/4/16 3:57 AM:
---
[
https://issues.apache.org/jira/browse/FLINK-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635107#comment-15635107
]
Tzu-Li (Gordon) Tai edited comment on FLINK-4576 at 11/4/16 3:52 AM:
---
[
https://issues.apache.org/jira/browse/FLINK-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635107#comment-15635107
]
Tzu-Li (Gordon) Tai commented on FLINK-4576:
I think the general problem with
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86484584
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -0,0 +1,194 @@
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635099#comment-15635099
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
Github user bjlovegithub commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r86482845
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -0,0 +1,194 @@
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635053#comment-15635053
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on a dif
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
Hi @tillrohrmann , Thanks for your review ;D I will check through each of
your comments and update the PR later.
Coming to the first part of review, the first one is about `UNORDERED` mode
a
[
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635019#comment-15635019
]
ASF GitHub Bot commented on FLINK-4391:
---
Github user bjlovegithub commented on the i
Github user kalmanchapman commented on the issue:
https://github.com/apache/flink/pull/2735
Hey Theodore,
Thanks for taking a look at my PR!
- I'll add docs shortly, per the examples you posted.
- I've tested against datasets in the hundreds-of-megabytes size (using the
[
https://issues.apache.org/jira/browse/FLINK-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634747#comment-15634747
]
ASF GitHub Bot commented on FLINK-2094:
---
Github user kalmanchapman commented on the
Github user soniclavier commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86462637
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
@@ -273,32 +284,93 @@
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634612#comment-15634612
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user soniclavier commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634603#comment-15634603
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user soniclavier commented on the is
Github user soniclavier commented on the issue:
https://github.com/apache/flink/pull/2736
Thanks for the review @aljoscha :thumbsup:, I will make the changes soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634525#comment-15634525
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user vijikarthi commented on the iss
Github user vijikarthi commented on the issue:
https://github.com/apache/flink/pull/2425
@mxm - Sorry that I have missed to address some of your comments. Attached
patch that includes Netty code null precondition validation and fixes the Blob
service cookie length issue. Please take a
[
https://issues.apache.org/jira/browse/FLINK-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634445#comment-15634445
]
Shannon Carey commented on FLINK-4091:
--
Flink's inclusion of altered Cassandra classe
[
https://issues.apache.org/jira/browse/FLINK-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634275#comment-15634275
]
ASF GitHub Bot commented on FLINK-4876:
---
Github user attachmentgenie commented on th
Github user attachmentgenie commented on the issue:
https://github.com/apache/flink/pull/2680
@uce i personally always prefer a explicit default as that keeps me in
control instead of the upstream implementation, but i can live with setting it
to `null`.
---
If your project is set u
Github user tfournier314 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2740#discussion_r86402178
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StringIndexer.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed t
Github user tfournier314 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2740#discussion_r86402282
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StringIndexer.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed t
[
https://issues.apache.org/jira/browse/FLINK-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633603#comment-15633603
]
ASF GitHub Bot commented on FLINK-4964:
---
Github user tfournier314 commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633599#comment-15633599
]
ASF GitHub Bot commented on FLINK-4964:
---
Github user tfournier314 commented on a dif
Github user tfournier314 commented on the issue:
https://github.com/apache/flink/pull/2684
@thvasilo @tillrohrmann Ok I will investigate this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633596#comment-15633596
]
ASF GitHub Bot commented on FLINK-4865:
---
Github user tfournier314 commented on the i
Github user thvasilo commented on the issue:
https://github.com/apache/flink/pull/2684
Hello @tillrohrmann I think you make some valid points. My original idea
was to move completely to using `LabeledVector` to the de facto format for
supervised learning problems and do away with `(Ve
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2680#discussion_r86392650
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -1193,7 +1195,12 @@
// ---
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2680#discussion_r86392695
--- Diff: flink-dist/src/main/resources/flink-conf.yaml ---
@@ -60,6 +60,10 @@ parallelism.default: 1
#==
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2680#discussion_r86388867
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -1193,7 +1195,12 @@
// ---
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2680#discussion_r86395548
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -1193,7 +1195,12 @@
// ---
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2680#discussion_r86394590
--- Diff: docs/setup/config.md ---
@@ -131,6 +131,8 @@ For Kafka and ZK, process-wide JAAS config will be
created using the provided se
- `taskmanager.
[
https://issues.apache.org/jira/browse/FLINK-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633504#comment-15633504
]
ASF GitHub Bot commented on FLINK-4876:
---
Github user uce commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633505#comment-15633505
]
ASF GitHub Bot commented on FLINK-4876:
---
Github user uce commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633502#comment-15633502
]
ASF GitHub Bot commented on FLINK-4876:
---
Github user uce commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633503#comment-15633503
]
ASF GitHub Bot commented on FLINK-4876:
---
Github user uce commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633506#comment-15633506
]
ASF GitHub Bot commented on FLINK-4876:
---
Github user uce commented on a diff in the
Github user thvasilo commented on the issue:
https://github.com/apache/flink/pull/2735
Thank you for your contribution Kalman!
I just took a brief look, this is a big PR so will probably take some time
to review.
For now a few things that jump to mind:
* We'
[
https://issues.apache.org/jira/browse/FLINK-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633492#comment-15633492
]
ASF GitHub Bot commented on FLINK-2094:
---
Github user thvasilo commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Bress updated FLINK-5011:
-
Description:
I had an issue where the state in my rolling window was incorrectly being
maintained from wi
[
https://issues.apache.org/jira/browse/FLINK-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Bress updated FLINK-5011:
-
Description:
I had an issue where the state in my rolling window was incorrectly being
maintained from wi
Dan Bress created FLINK-5011:
Summary: TraversableSerializer does not perform a deep copy of the
elements it is traversing
Key: FLINK-5011
URL: https://issues.apache.org/jira/browse/FLINK-5011
Project: Fl
[
https://issues.apache.org/jira/browse/FLINK-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633463#comment-15633463
]
ASF GitHub Bot commented on FLINK-4964:
---
Github user greghogan commented on a diff i
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2740#discussion_r86392126
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StringIndexer.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to t
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2740#discussion_r86391230
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StringIndexer.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to t
[
https://issues.apache.org/jira/browse/FLINK-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633464#comment-15633464
]
ASF GitHub Bot commented on FLINK-4964:
---
Github user greghogan commented on a diff i
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2740#discussion_r86391698
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StringIndexer.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to t
[
https://issues.apache.org/jira/browse/FLINK-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633465#comment-15633465
]
ASF GitHub Bot commented on FLINK-4964:
---
Github user greghogan commented on a diff i
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633418#comment-15633418
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633410#comment-15633410
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633409#comment-15633409
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633438#comment-15633438
]
ASF GitHub Bot commented on FLINK-4983:
---
Github user Makman2 commented on the issue:
Github user Makman2 commented on the issue:
https://github.com/apache/flink/pull/2737
yeah I think also an outline image is better :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633417#comment-15633417
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633412#comment-15633412
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633416#comment-15633416
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633411#comment-15633411
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633413#comment-15633413
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633415#comment-15633415
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633414#comment-15633414
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user aljoscha commented on a diff in
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86377130
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
---
@@ -65,11 +107,23 @@ public long getWind
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86376593
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/Evictor.java
---
@@ -18,15 +18,17 @@
package org.apache.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86379042
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
@@ -273,32 +284,93 @@ pu
[
https://issues.apache.org/jira/browse/FLINK-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633419#comment-15633419
]
ASF GitHub Bot commented on FLINK-4174:
---
Github user aljoscha commented on a diff in
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86379858
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
@@ -273,32 +284,93 @@ pu
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86388455
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorTest.java
---
@@ -58,6 +61,458 @@
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86385660
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
---
@@ -35,23 +37,63 @@
private stat
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86379014
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
@@ -235,10 +244,10 @@ pu
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86377225
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
---
@@ -65,11 +107,23 @@ public long getWind
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86377093
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
---
@@ -65,11 +107,23 @@ public long getWind
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86376746
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/Evictor.java
---
@@ -41,13 +43,46 @@
public interface Ev
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86377048
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
---
@@ -65,11 +107,23 @@ public long getWind
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2737
Why not keep the color image for the favicons? The smaller size looks like
a black blob to my eyes. The current color icon is distinctive and will look
even better at 32x32. If we wanted to use B&W
[
https://issues.apache.org/jira/browse/FLINK-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633274#comment-15633274
]
ASF GitHub Bot commented on FLINK-4983:
---
Github user greghogan commented on the issu
Till Rohrmann created FLINK-5010:
Summary: Decouple the death watch parameters from the Akka ask
timeout
Key: FLINK-5010
URL: https://issues.apache.org/jira/browse/FLINK-5010
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633263#comment-15633263
]
ASF GitHub Bot commented on FLINK-4814:
---
GitHub user uce opened a pull request:
1 - 100 of 303 matches
Mail list logo
