[jira] [Updated] (FLINK-4707) Including flink-connector-filesystem as dependency fails build

2016-09-28 Thread Melmoth (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Melmoth updated FLINK-4707: --- Description: When using flink-connector-filesystem I'm now required to include the maven-bundle-plugin in my

[jira] [Updated] (FLINK-4707) Including flink-connector-filesystem as dependency fails build

2016-09-28 Thread Melmoth (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Melmoth updated FLINK-4707: --- Description: When using flink-connector-filesystem I'm now required to include the maven-bundle-plugin in my

[jira] [Created] (FLINK-4707) Including flink-connector-filesystem as dependency fails build

2016-09-28 Thread Melmoth (JIRA)
Melmoth created FLINK-4707: -- Summary: Including flink-connector-filesystem as dependency fails build Key: FLINK-4707 URL: https://issues.apache.org/jira/browse/FLINK-4707 Project: Flink Issue Type:

[jira] [Commented] (FLINK-4686) Add possibility to get column names

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531819#comment-15531819 ] ASF GitHub Bot commented on FLINK-4686: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2553: [FLINK-4686] [table] Add possibility to get column names

2016-09-28 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2553 Hi @twalthr , I addressed the comments. Thank you for your suggestion. I add some tests that getting schema from tables in existing ITCases. --- If your project is set up for it, you can reply to t

[jira] [Updated] (FLINK-4344) Implement new JobManager

2016-09-28 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-4344: -- Assignee: (was: Kurt Young) > Implement new JobManager > > >

[GitHub] flink pull request #2565: [FLINK-4406] [cluster management] Implement job ma...

2016-09-28 Thread KurtYoung
GitHub user KurtYoung opened a pull request: https://github.com/apache/flink/pull/2565 [FLINK-4406] [cluster management] Implement job master registration at resource manager You can merge this pull request into a Git repository by running: $ git pull https://github.com/Kurt

[jira] [Commented] (FLINK-4406) Implement job master registration at resource manager

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531705#comment-15531705 ] ASF GitHub Bot commented on FLINK-4406: --- GitHub user KurtYoung opened a pull request

[jira] [Created] (FLINK-4706) Is there a way to load user classes first?

2016-09-28 Thread JIRA
刘喆 created FLINK-4706: - Summary: Is there a way to load user classes first? Key: FLINK-4706 URL: https://issues.apache.org/jira/browse/FLINK-4706 Project: Flink Issue Type: New Feature Componen

[jira] [Commented] (FLINK-4606) Integrate the new ResourceManager with the existing FlinkResourceManager

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531437#comment-15531437 ] ASF GitHub Bot commented on FLINK-4606: --- Github user beyond1920 closed the pull requ

[GitHub] flink pull request #2540: [FLINK-4606] [cluster management] Integrate the ne...

2016-09-28 Thread beyond1920
Github user beyond1920 closed the pull request at: https://github.com/apache/flink/pull/2540 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4669) scala api createLocalEnvironment() function add default Configuration parameter

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531067#comment-15531067 ] ASF GitHub Bot commented on FLINK-4669: --- Github user shijinkui commented on a diff i

[GitHub] flink pull request #2541: [FLINK-4669] scala api createLocalEnvironment() fu...

2016-09-28 Thread shijinkui
Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/2541#discussion_r81031381 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala --- @@ -124,7 +125,7 @@ class StreamEx

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531007#comment-15531007 ] ASF GitHub Bot commented on FLINK-2254: --- GitHub user mushketyk opened a pull request

[GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class

2016-09-28 Thread mushketyk
GitHub user mushketyk opened a pull request: https://github.com/apache/flink/pull/2564 [FLINK-2254] Add BipartiateGraph class This PR implements BipartiteGraph class with support classes and lays foundation for future work on bipartite graphs support. I didn't add documentation bec

[jira] [Commented] (FLINK-4650) Frequent task manager disconnects from JobManager

2016-09-28 Thread Nagarjun Guraja (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530607#comment-15530607 ] Nagarjun Guraja commented on FLINK-4650: Hey [~uce]... We talked about this briefl

[jira] [Commented] (FLINK-4629) Kafka v 0.10 Support

2016-09-28 Thread Mariano Gonzalez (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530561#comment-15530561 ] Mariano Gonzalez commented on FLINK-4629: - [~tzulitai] You are right, sorry I didn

[GitHub] flink pull request #2541: [FLINK-4669] scala api createLocalEnvironment() fu...

2016-09-28 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2541#discussion_r80984450 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala --- @@ -124,7 +125,7 @@ class Stream

[jira] [Commented] (FLINK-4701) Unprotected access to cancelables in StreamTask

2016-09-28 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530460#comment-15530460 ] Stephan Ewen commented on FLINK-4701: - Every actual modification to "cancelables" is l

[jira] [Created] (FLINK-4705) Instrument FixedLengthRecordSorter

2016-09-28 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-4705: - Summary: Instrument FixedLengthRecordSorter Key: FLINK-4705 URL: https://issues.apache.org/jira/browse/FLINK-4705 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-4669) scala api createLocalEnvironment() function add default Configuration parameter

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530446#comment-15530446 ] ASF GitHub Bot commented on FLINK-4669: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-09-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530310#comment-15530310 ] Chesnay Schepler commented on FLINK-4563: - no, the exact opposite. {code} Charact

[jira] [Commented] (FLINK-4669) scala api createLocalEnvironment() function add default Configuration parameter

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530229#comment-15530229 ] ASF GitHub Bot commented on FLINK-4669: --- Github user shijinkui commented on a diff i

[GitHub] flink pull request #2541: [FLINK-4669] scala api createLocalEnvironment() fu...

2016-09-28 Thread shijinkui
Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/2541#discussion_r80966754 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala --- @@ -124,7 +125,7 @@ class StreamEx

[jira] [Commented] (FLINK-3409) Integrate STOP with Savepoints

2016-09-28 Thread Nagarjun Guraja (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530225#comment-15530225 ] Nagarjun Guraja commented on FLINK-3409: First version could be: Flink stops auto

[GitHub] flink pull request #2541: [FLINK-4669] scala api createLocalEnvironment() fu...

2016-09-28 Thread shijinkui
Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/2541#discussion_r80963928 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala --- @@ -124,7 +125,7 @@ class StreamEx

[jira] [Commented] (FLINK-4669) scala api createLocalEnvironment() function add default Configuration parameter

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530198#comment-15530198 ] ASF GitHub Bot commented on FLINK-4669: --- Github user shijinkui commented on a diff i

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-09-28 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530178#comment-15530178 ] Aljoscha Krettek commented on FLINK-3674: - Turns out that adding a generic interfa

[jira] [Updated] (FLINK-4650) Frequent task manager disconnects from JobManager

2016-09-28 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi updated FLINK-4650: --- Component/s: Network Distributed Coordination > Frequent task manager disconnects fro

[jira] [Commented] (FLINK-4650) Frequent task manager disconnects from JobManager

2016-09-28 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530147#comment-15530147 ] Ufuk Celebi commented on FLINK-4650: Hey Nagarjun! +1 to Stephan's questions and addit

[GitHub] flink issue #2435: [FLINK-4478] [flip-6] Add HeartbeatManager

2016-09-28 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2435 Could you rebase this again? I think we should merge this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[jira] [Commented] (FLINK-4478) Implement heartbeat logic

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530121#comment-15530121 ] ASF GitHub Bot commented on FLINK-4478: --- Github user mxm commented on the issue:

[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530097#comment-15530097 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on the issu

[GitHub] flink issue #2460: [FLINK-4562] table examples make an divided module in fli...

2016-09-28 Thread shijinkui
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2460 @wuchong you are right. Different package of scala/java can avoid same class conflict --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530093#comment-15530093 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on a diff i

[GitHub] flink pull request #2460: [FLINK-4562] table examples make an divided module...

2016-09-28 Thread shijinkui
Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r80955533 --- Diff: flink-examples/flink-examples-table/pom.xml --- @@ -0,0 +1,24 @@ + +http://maven.apache.org/POM/4.0.0"; +xmlns:xsi="http://

[jira] [Reopened] (FLINK-4703) RpcCompletenessTest: Add support for type arguments and subclasses

2016-09-28 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reopened FLINK-4703: --- > RpcCompletenessTest: Add support for type arguments and subclasses > ---

[jira] [Closed] (FLINK-4703) RpcCompletenessTest: Add support for type arguments and subclasses

2016-09-28 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-4703. - Resolution: Fixed > RpcCompletenessTest: Add support for type arguments and subclasses > -

[jira] [Updated] (FLINK-4703) RpcCompletenessTest: Add support for type arguments and subclasses

2016-09-28 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-4703: -- Fix Version/s: (was: 1.2.0) > RpcCompletenessTest: Add support for type arguments an

[jira] [Updated] (FLINK-4703) RpcCompletenessTest: Add support for type arguments and subclasses

2016-09-28 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-4703: -- Affects Version/s: (was: 1.2.0) > RpcCompletenessTest: Add support for type argument

[GitHub] flink pull request #2460: [FLINK-4562] table examples make an divided module...

2016-09-28 Thread shijinkui
Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r80955413 --- Diff: flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/StreamSQLExample.scala --- @@ -15,7 +15,7 @@ * See the L

[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530092#comment-15530092 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on a diff i

[jira] [Closed] (FLINK-4703) RpcCompletenessTest: Add support for type arguments and subclasses

2016-09-28 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-4703. - Resolution: Fixed Fixed with 87767ab4daf06300aac0e5d969e6e44808657187 > RpcCompletenessTe

[jira] [Commented] (FLINK-3656) Rework Table API tests

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530087#comment-15530087 ] ASF GitHub Bot commented on FLINK-3656: --- GitHub user twalthr opened a pull request:

[GitHub] flink pull request #2563: [FLINK-3656] [table] Reduce number of ITCases

2016-09-28 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2563 [FLINK-3656] [table] Reduce number of ITCases This is the first step of reducing the number of ITCases of the Table API. This PR modifies the TableProgramsTestBase to test only the default configur

[jira] [Commented] (FLINK-4677) Jars with no job executions produces NullPointerException in ClusterClient

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530081#comment-15530081 ] ASF GitHub Bot commented on FLINK-4677: --- Github user mxm commented on the issue:

[GitHub] flink issue #2548: [FLINK-4677] fail if user jar contains no executions

2016-09-28 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2548 That's a good point @greghogan. We don't have a standard way to print a usage message. A disadvantage of the approach in this PR is that we will display an error message which might actually mask any usa

[jira] [Commented] (FLINK-4703) RpcCompletenessTest: Add support for type arguments and subclasses

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530067#comment-15530067 ] ASF GitHub Bot commented on FLINK-4703: --- Github user mxm closed the pull request at:

[jira] [Commented] (FLINK-4703) RpcCompletenessTest: Add support for type arguments and subclasses

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530068#comment-15530068 ] ASF GitHub Bot commented on FLINK-4703: --- Github user mxm commented on the issue:

[GitHub] flink issue #2561: [FLINK-4703] RpcCompletenessTest: Add support for type ar...

2016-09-28 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2561 Merged to `flip-6`. Let me know if you have any comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] flink pull request #2561: [FLINK-4703] RpcCompletenessTest: Add support for ...

2016-09-28 Thread mxm
Github user mxm closed the pull request at: https://github.com/apache/flink/pull/2561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[jira] [Commented] (FLINK-3257) Add Exactly-Once Processing Guarantees in Iterative DataStream Jobs

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529691#comment-15529691 ] ASF GitHub Bot commented on FLINK-3257: --- Github user senorcarbone commented on the i

[jira] [Commented] (FLINK-4606) Integrate the new ResourceManager with the existing FlinkResourceManager

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530021#comment-15530021 ] ASF GitHub Bot commented on FLINK-4606: --- Github user mxm commented on the issue:

[GitHub] flink issue #2540: [FLINK-4606] [cluster management] Integrate the new Resou...

2016-09-28 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2540 This has been merged. Thank you. Could you close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-4573) Potential resource leak due to unclosed RandomAccessFile in TaskManagerLogHandler

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530006#comment-15530006 ] ASF GitHub Bot commented on FLINK-4573: --- Github user lw-lin commented on a diff in t

[GitHub] flink pull request #2556: [FLINK-4573] Fix potential resource leak due to un...

2016-09-28 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/flink/pull/2556#discussion_r80947439 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java --- @@ -210,7 +210,17 @@ public void onSucce

[jira] [Commented] (FLINK-4686) Add possibility to get column names

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529861#comment-15529861 ] ASF GitHub Bot commented on FLINK-4686: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4686) Add possibility to get column names

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529859#comment-15529859 ] ASF GitHub Bot commented on FLINK-4686: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4686) Add possibility to get column names

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529857#comment-15529857 ] ASF GitHub Bot commented on FLINK-4686: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-09-28 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529899#comment-15529899 ] Anton Mushin commented on FLINK-4563: - Do you propose to caching last CharacterFilter

[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529773#comment-15529773 ] ASF GitHub Bot commented on FLINK-4068: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4686) Add possibility to get column names

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529854#comment-15529854 ] ASF GitHub Bot commented on FLINK-4686: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4686) Add possibility to get column names

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529860#comment-15529860 ] ASF GitHub Bot commented on FLINK-4686: --- Github user twalthr commented on a diff in

[GitHub] flink issue #2546: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...

2016-09-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2546 Hi @aljoscha, the problem with the AlignedWindowOperator tests is that they were using the DefaultTimeServiceProvider and by not shutting down the service, the previous timers would fire and throw a NP

[jira] [Commented] (FLINK-4686) Add possibility to get column names

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529853#comment-15529853 ] ASF GitHub Bot commented on FLINK-4686: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4686) Add possibility to get column names

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529858#comment-15529858 ] ASF GitHub Bot commented on FLINK-4686: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4686) Add possibility to get column names

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529855#comment-15529855 ] ASF GitHub Bot commented on FLINK-4686: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4686) Add possibility to get column names

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529856#comment-15529856 ] ASF GitHub Bot commented on FLINK-4686: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2553: [FLINK-4686] [table] Add possibility to get column...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2553#discussion_r80930670 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/Schema.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Soft

[GitHub] flink pull request #2553: [FLINK-4686] [table] Add possibility to get column...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2553#discussion_r80931954 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -66,6 +66,17 @@ class Table( def getRelNode: RelNod

[GitHub] flink pull request #2553: [FLINK-4686] [table] Add possibility to get column...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2553#discussion_r80932356 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/SchemaTest.java --- @@ -0,0 +1,84 @@ +/* + * Licensed to the Apac

[GitHub] flink pull request #2553: [FLINK-4686] [table] Add possibility to get column...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2553#discussion_r80930567 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/Schema.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Soft

[GitHub] flink pull request #2553: [FLINK-4686] [table] Add possibility to get column...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2553#discussion_r80931476 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/Schema.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Soft

[GitHub] flink pull request #2553: [FLINK-4686] [table] Add possibility to get column...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2553#discussion_r80930699 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/Schema.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Soft

[GitHub] flink pull request #2553: [FLINK-4686] [table] Add possibility to get column...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2553#discussion_r80929290 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/Schema.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Soft

[GitHub] flink pull request #2553: [FLINK-4686] [table] Add possibility to get column...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2553#discussion_r80931239 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/Schema.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Soft

[GitHub] flink pull request #2553: [FLINK-4686] [table] Add possibility to get column...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2553#discussion_r80931530 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/Schema.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Soft

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-09-28 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529746#comment-15529746 ] Anton Mushin commented on FLINK-4563: - I am understand. I planning to fix this issue

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-09-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529812#comment-15529812 ] Chesnay Schepler commented on FLINK-4563: - I wouldn't store it for different filte

[jira] [Commented] (FLINK-4564) [metrics] Delimiter should be configured per reporter

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529783#comment-15529783 ] ASF GitHub Bot commented on FLINK-4564: --- Github user ex00 commented on a diff in the

[jira] [Commented] (FLINK-4329) Fix Streaming File Source Timestamps/Watermarks Handling

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529786#comment-15529786 ] ASF GitHub Bot commented on FLINK-4329: --- Github user kl0u commented on the issue:

[GitHub] flink pull request #2560: [FLINK-4068] [table] Move constant computations ou...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2560#discussion_r80927113 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/BatchTableEnvironment.scala --- @@ -228,19 +229,13 @@ abstract class BatchTab

[GitHub] flink pull request #2517: [FLINK-4564] [metrics] Delimiter should be configu...

2016-09-28 Thread ex00
Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/2517#discussion_r80927679 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java --- @@ -216,17 +244,20 @@ public ScopeFormats getScopeFormats() {

[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529775#comment-15529775 ] ASF GitHub Bot commented on FLINK-4068: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2560: [FLINK-4068] [table] Move constant computations ou...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2560#discussion_r80925547 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/BatchTableEnvironmentTest.scala --- @@ -0,0 +1,46 @@ +/* + * Licensed

[GitHub] flink pull request #2560: [FLINK-4068] [table] Move constant computations ou...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2560#discussion_r80919671 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/BatchTableEnvironment.scala --- @@ -228,19 +229,13 @@ abstract class BatchTab

[jira] [Commented] (FLINK-4329) Fix Streaming File Source Timestamps/Watermarks Handling

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529764#comment-15529764 ] ASF GitHub Bot commented on FLINK-4329: --- Github user aljoscha commented on the issue

[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529774#comment-15529774 ] ASF GitHub Bot commented on FLINK-4068: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529776#comment-15529776 ] ASF GitHub Bot commented on FLINK-4068: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2560: [FLINK-4068] [table] Move constant computations ou...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2560#discussion_r80921875 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkRelBuilder.scala --- @@ -38,7 +38,12 @@ class FlinkRelBuilder(

[GitHub] flink issue #2546: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...

2016-09-28 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2546 Just a quick comment (I didn't review all code): Why does this touch the AlignedWindowOperator tests? I would like to keep this commit as small as possible because we're dealing with sensitive stuff

[GitHub] flink issue #1668: [FLINK-3257] Add Exactly-Once Processing Guarantees for I...

2016-09-28 Thread senorcarbone
Github user senorcarbone commented on the issue: https://github.com/apache/flink/pull/1668 Hey! Good to be back :) . Let's fix this properly, as @StephanEwen recommended it now that there is some time. We are writing together with @FouadMA a FLIP to address major loop fixes. Namel

[jira] [Commented] (FLINK-4702) Kafka consumer must commit offsets asynchronously

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529655#comment-15529655 ] ASF GitHub Bot commented on FLINK-4702: --- Github user tzulitai commented on the issue

[GitHub] flink issue #2559: [FLINK-4702] [kafka connector] Commit offets to Kafka asy...

2016-09-28 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2559 Seems like currently only the 0.8 Kafka connector have tests related to offset committing (in `Kafka08ITCase`). My two cents for testing this for now is that a IT test for correct offset co

[jira] [Commented] (FLINK-4329) Fix Streaming File Source Timestamps/Watermarks Handling

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529640#comment-15529640 ] ASF GitHub Bot commented on FLINK-4329: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2546: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...

2016-09-28 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2546 I added some more comments. I could not find in that test anywhere the notion of checking that elements are not late, but properly interleaved with the watermarks. Is there a test that c

[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529637#comment-15529637 ] ASF GitHub Bot commented on FLINK-4562: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples

2016-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529636#comment-15529636 ] ASF GitHub Bot commented on FLINK-4562: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2460: [FLINK-4562] table examples make an divided module...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r80916077 --- Diff: flink-examples/flink-examples-table/pom.xml --- @@ -0,0 +1,24 @@ + +http://maven.apache.org/POM/4.0.0"; +xmlns:xsi="http://ww

[GitHub] flink pull request #2460: [FLINK-4562] table examples make an divided module...

2016-09-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r80910964 --- Diff: flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/StreamSQLExample.scala --- @@ -15,7 +15,7 @@ * See the Lic

  1   2   3   >