[
https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529786#comment-15529786
]
ASF GitHub Bot commented on FLINK-4329:
---------------------------------------
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2546
Hi @aljoscha, the problem with the AlignedWindowOperator tests is that
they were using the DefaultTimeServiceProvider and by not shutting down the
service, the previous timers would fire and throw a NPE because the reference
to the operator they had would have been invalidated.
For the restriction to TestTimeServiceProvider, this was done because now
the DefaultTimeServiceProvider needs the checkpointLock, so either in the same
constructor we add this as an argument, or we have to restrict the options to
only the TestProvider.
Finally for the StreamConfig I agree that it is only needed for one test so
we can just expose it.
> Fix Streaming File Source Timestamps/Watermarks Handling
> --------------------------------------------------------
>
> Key: FLINK-4329
> URL: https://issues.apache.org/jira/browse/FLINK-4329
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
> Affects Versions: 1.1.0
> Reporter: Aljoscha Krettek
> Assignee: Kostas Kloudas
> Fix For: 1.2.0, 1.1.3
>
>
> The {{ContinuousFileReaderOperator}} does not correctly deal with watermarks,
> i.e. they are just passed through. This means that when the
> {{ContinuousFileMonitoringFunction}} closes and emits a {{Long.MAX_VALUE}}
> that watermark can "overtake" the records that are to be emitted in the
> {{ContinuousFileReaderOperator}}. Together with the new "allowed lateness"
> setting in window operator this can lead to elements being dropped as late.
> Also, {{ContinuousFileReaderOperator}} does not correctly assign ingestion
> timestamps since it is not technically a source but looks like one to the
> user.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
