[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290321#comment-15290321 ] ASF GitHub Bot commented on FLINK-1745: --- Github user chiwanpark commented on a diff

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63815357 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Commented] (FLINK-1719) Add naive Bayes classification algorithm to machine learning library

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290211#comment-15290211 ] ASF GitHub Bot commented on FLINK-1719: --- Github user danielblazevski commented on th

[GitHub] flink pull request: [FLINK-1719] [ml] Add Multinomial Naive Bayes ...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1156#issuecomment-220201194 Should the input be DataSets of Strings? The documentation, syntax are heavy on the side of dealing exclusively with text classification. Could just be me sinc

[jira] [Closed] (FLINK-3750) Make JDBCInputFormat a parallel source

2016-05-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3750. Resolution: Implemented Fix Version/s: 1.1.0 Implemented for 1.1.0 with 09b428bd65819b946cf82

[jira] [Resolved] (FLINK-3914) BlobServer.createTemporaryFilename() has concurrency safety problem

2016-05-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske resolved FLINK-3914. -- Resolution: Fixed Fix Version/s: 1.0.4 1.1.0 Fixed for 1.0.4 with 6f13

[jira] [Closed] (FLINK-3926) Incorrect implementation of getFieldIndex in TupleTypeInfo

2016-05-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3926. Resolution: Fixed Fix Version/s: 1.0.4 1.1.0 Fixed in 1.0.4 with db5ff636b

[jira] [Commented] (FLINK-3926) Incorrect implementation of getFieldIndex in TupleTypeInfo

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289967#comment-15289967 ] ASF GitHub Bot commented on FLINK-3926: --- Github user asfgit closed the pull request

[GitHub] flink pull request: Flink 3750 fixed

2016-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1941 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3914) BlobServer.createTemporaryFilename() has concurrency safety problem

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289968#comment-15289968 ] ASF GitHub Bot commented on FLINK-3914: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-3914] [runtime] fixed race when attempt...

2016-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2000 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-3926][TypeSystem]Incorrect implementati...

2016-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2004 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3699) Allow per-job Kerberos authentication

2016-05-18 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289880#comment-15289880 ] Eron Wright commented on FLINK-3699: - It is perceived as quite difficult to protect o

[jira] [Created] (FLINK-3932) Implement State Backend Security

2016-05-18 Thread Eron Wright (JIRA)
Eron Wright created FLINK-3932: --- Summary: Implement State Backend Security Key: FLINK-3932 URL: https://issues.apache.org/jira/browse/FLINK-3932 Project: Flink Issue Type: New Feature

[jira] [Updated] (FLINK-3931) Implement Transport Encryption (SSL/TLS)

2016-05-18 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eron Wright updated FLINK-3931: Labels: security (was: ) > Implement Transport Encryption (SSL/TLS) > -

[jira] [Created] (FLINK-3931) Implement Transport Encryption (SSL/TLS)

2016-05-18 Thread Eron Wright (JIRA)
Eron Wright created FLINK-3931: --- Summary: Implement Transport Encryption (SSL/TLS) Key: FLINK-3931 URL: https://issues.apache.org/jira/browse/FLINK-3931 Project: Flink Issue Type: New Feature

[jira] [Updated] (FLINK-3930) Implement Service-Level Authorization

2016-05-18 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eron Wright updated FLINK-3930: Labels: security (was: ) > Implement Service-Level Authorization >

[jira] [Updated] (FLINK-3929) Support for Kerberos Authentication with Keytab Credential

2016-05-18 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eron Wright updated FLINK-3929: Labels: kerberos security (was: kerberos) > Support for Kerberos Authentication with Keytab Credent

[jira] [Created] (FLINK-3930) Implement Service-Level Authorization

2016-05-18 Thread Eron Wright (JIRA)
Eron Wright created FLINK-3930: --- Summary: Implement Service-Level Authorization Key: FLINK-3930 URL: https://issues.apache.org/jira/browse/FLINK-3930 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-3914) BlobServer.createTemporaryFilename() has concurrency safety problem

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289766#comment-15289766 ] ASF GitHub Bot commented on FLINK-3914: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-3914] [runtime] fixed race when attempt...

2016-05-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2000#issuecomment-220150853 This was PR No. 2000 :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[jira] [Commented] (FLINK-2044) Implementation of Gelly HITS Algorithm

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289736#comment-15289736 ] ASF GitHub Bot commented on FLINK-2044: --- Github user greghogan commented on the pull

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-18 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-220147037 I also like @vasia's idea since we might get to add the analytic `DyadicCensus` (basically counting how many edges are `u <-> v` and `u -> v`). The relative performanc

[jira] [Commented] (FLINK-2044) Implementation of Gelly HITS Algorithm

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289713#comment-15289713 ] ASF GitHub Bot commented on FLINK-2044: --- Github user greghogan commented on the pull

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-18 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-220143133 @vasia that is a very good idea. I've been doing this for `TriangleListing` for directed clustering coefficient and it should probably be a separate `GraphAlgorithm`.

[jira] [Commented] (FLINK-3926) Incorrect implementation of getFieldIndex in TupleTypeInfo

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289644#comment-15289644 ] ASF GitHub Bot commented on FLINK-3926: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-3914) BlobServer.createTemporaryFilename() has concurrency safety problem

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289647#comment-15289647 ] ASF GitHub Bot commented on FLINK-3914: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: Flink 3750 fixed

2016-05-18 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1941#issuecomment-220133396 Merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[jira] [Commented] (FLINK-2044) Implementation of Gelly HITS Algorithm

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289658#comment-15289658 ] ASF GitHub Bot commented on FLINK-2044: --- Github user vasia commented on the pull req

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-18 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-220134968 Thanks for the update @gallenvara and @greghogan for the review. I have left a few comments in places where I couldn't figure out the code logic. There is one

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-18 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r63765714 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -160,7 +240,7 @@ public void sendMessages(Vertex>

[GitHub] flink pull request: [FLINK-3925] GraphAlgorithm to filter by maxim...

2016-05-18 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2005 [FLINK-3925] GraphAlgorithm to filter by maximum degree You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 3925_graphalgorithm_t

[GitHub] flink pull request: [FLINK-3928] [gelly] Potential overflow due to...

2016-05-18 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2006 [FLINK-3928] [gelly] Potential overflow due to 32-bit int arithmetic You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 39

[GitHub] flink pull request: [FLINK-3926][TypeSystem]Incorrect implementati...

2016-05-18 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2004#issuecomment-220133027 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] flink pull request: [FLINK-3914] [runtime] fixed race when attempt...

2016-05-18 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2000#issuecomment-220133139 Merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-18 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r63765397 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -46,40 +46,89 @@ * represented a page that i

[jira] [Commented] (FLINK-2044) Implementation of Gelly HITS Algorithm

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289639#comment-15289639 ] ASF GitHub Bot commented on FLINK-2044: --- Github user vasia commented on a diff in th

[jira] [Commented] (FLINK-2044) Implementation of Gelly HITS Algorithm

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289637#comment-15289637 ] ASF GitHub Bot commented on FLINK-2044: --- Github user vasia commented on a diff in th

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-18 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1980#issuecomment-220122997 I figured. I forgot to mention that I was looking to reference the JaccardIndex self-join in the discussion of FLINK-3910 but I can link into the PR this time. --- I

[GitHub] flink pull request: [FLINK-3854] Support Avro key-value rolling si...

2016-05-18 Thread IgorBerman
Github user IgorBerman commented on the pull request: https://github.com/apache/flink/pull/1953#issuecomment-220131404 @aljoscha , ok, I'll try to refactor tests to be unit at weekend --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-18 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r63765556 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -122,22 +179,45 @@ public void updateVertex(Vertex

[jira] [Commented] (FLINK-3854) Support Avro key-value rolling sink writer

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289638#comment-15289638 ] ASF GitHub Bot commented on FLINK-3854: --- Github user IgorBerman commented on the pul

[jira] [Commented] (FLINK-2044) Implementation of Gelly HITS Algorithm

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289640#comment-15289640 ] ASF GitHub Bot commented on FLINK-2044: --- Github user vasia commented on a diff in th

[jira] [Updated] (FLINK-3928) Potential overflow due to 32-bit int arithmetic

2016-05-18 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-3928: -- Fix Version/s: 1.1.0 > Potential overflow due to 32-bit int arithmetic > ---

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-18 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r63765321 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -46,40 +46,89 @@ * represented a page that i

[jira] [Commented] (FLINK-2044) Implementation of Gelly HITS Algorithm

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289633#comment-15289633 ] ASF GitHub Bot commented on FLINK-2044: --- Github user vasia commented on a diff in th

[jira] [Updated] (FLINK-3925) GraphAlgorithm to filter by maximum degree

2016-05-18 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-3925: -- Fix Version/s: 1.1.0 > GraphAlgorithm to filter by maximum degree >

[jira] [Commented] (FLINK-3928) Potential overflow due to 32-bit int arithmetic

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289631#comment-15289631 ] ASF GitHub Bot commented on FLINK-3928: --- GitHub user greghogan opened a pull request

[jira] [Commented] (FLINK-3925) GraphAlgorithm to filter by maximum degree

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289626#comment-15289626 ] ASF GitHub Bot commented on FLINK-3925: --- GitHub user greghogan opened a pull request

[jira] [Created] (FLINK-3929) Support for Kerberos Authentication with Keytab Credential

2016-05-18 Thread Eron Wright (JIRA)
Eron Wright created FLINK-3929: --- Summary: Support for Kerberos Authentication with Keytab Credential Key: FLINK-3929 URL: https://issues.apache.org/jira/browse/FLINK-3929 Project: Flink Issue

[jira] [Commented] (FLINK-3780) Jaccard Similarity

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289581#comment-15289581 ] ASF GitHub Bot commented on FLINK-3780: --- Github user greghogan commented on the pull

[jira] [Assigned] (FLINK-3670) Kerberos: Improving long-running streaming jobs

2016-05-18 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eron Wright reassigned FLINK-3670: --- Assignee: Eron Wright > Kerberos: Improving long-running streaming jobs > --

[jira] [Commented] (FLINK-3670) Kerberos: Improving long-running streaming jobs

2016-05-18 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289619#comment-15289619 ] Eron Wright commented on FLINK-3670: - After some design discussion, the keytab approa

[jira] [Commented] (FLINK-3780) Jaccard Similarity

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289542#comment-15289542 ] ASF GitHub Bot commented on FLINK-3780: --- Github user vasia commented on the pull req

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-18 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1980#issuecomment-220118204 Great, that's my plan :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-3928) Potential overflow due to 32-bit int arithmetic

2016-05-18 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289531#comment-15289531 ] Greg Hogan commented on FLINK-3928: --- Nice find! How did you find this? The {{RMatGraph}}

[jira] [Commented] (FLINK-3780) Jaccard Similarity

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289527#comment-15289527 ] ASF GitHub Bot commented on FLINK-3780: --- Github user greghogan commented on the pull

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-18 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1980#issuecomment-220116075 Hi @vasia that would be great if you have time after 2044. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] flink pull request: Support for bz2 compression in flink-core

2016-05-18 Thread mtanski
Github user mtanski commented on the pull request: https://github.com/apache/flink/pull/2002#issuecomment-220115838 My big question is: should I implement the other compressors from apache commons-io (snappy, xz). And if so should flink apache commons-io for gzip deflate as well? --

[GitHub] flink pull request: Support for bz2 compression in flink-core

2016-05-18 Thread mtanski
Github user mtanski commented on a diff in the pull request: https://github.com/apache/flink/pull/2002#discussion_r63755827 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/compression/Bzip2InputStreamFactory.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to t

[GitHub] flink pull request: [script] Simple fix of typo from JobManager to...

2016-05-18 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/2001#issuecomment-220113385 The failed test should not be caused by this simple change. Will merge unless anyone has comment by end of day. --- If your project is set up for it, you can reply

[jira] [Commented] (FLINK-2147) Approximate calculation of frequencies in data streams

2016-05-18 Thread Stavros Kontopoulos (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289498#comment-15289498 ] Stavros Kontopoulos commented on FLINK-2147: How do you want to move on? colla

[jira] [Commented] (FLINK-1502) Expose metrics to graphite, ganglia and JMX.

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289493#comment-15289493 ] ASF GitHub Bot commented on FLINK-1502: --- Github user zentol commented on the pull re

[GitHub] flink pull request: [FLINK-1502] [WIP] Basic Metric System

2016-05-18 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1947#issuecomment-220112639 renaming the module is a good idea --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[jira] [Assigned] (FLINK-3928) Potential overflow due to 32-bit int arithmetic

2016-05-18 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan reassigned FLINK-3928: - Assignee: Greg Hogan > Potential overflow due to 32-bit int arithmetic >

[GitHub] flink pull request: [FLINK-3854] Support Avro key-value rolling si...

2016-05-18 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1953#issuecomment-220105461 We recently became more aware of build time increases due to our usage of a lot of ITCases. I think we should have the tests as unit tests instead of ITCases since they

[jira] [Commented] (FLINK-3854) Support Avro key-value rolling sink writer

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289422#comment-15289422 ] ASF GitHub Bot commented on FLINK-3854: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-18 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1980#issuecomment-220103434 Hey @greghogan, it's usually a good idea to have at least one person look at the code :) Is this blocking some other feature? If not, I could take a look at this PR

[jira] [Commented] (FLINK-3780) Jaccard Similarity

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289408#comment-15289408 ] ASF GitHub Bot commented on FLINK-3780: --- Github user vasia commented on the pull req

[jira] [Commented] (FLINK-1502) Expose metrics to graphite, ganglia and JMX.

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289384#comment-15289384 ] ASF GitHub Bot commented on FLINK-1502: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1502] [WIP] Basic Metric System

2016-05-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1947#issuecomment-220099057 How about renaming the maven module from `flink-metrics` to `flink-metric-reporters`? The metrics systems itself is part of `flink-core` after all... --- If your p

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289374#comment-15289374 ] ASF GitHub Bot commented on FLINK-3909: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220098334 Could you reproduce the problem on your laptop? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] flink pull request: Support for bz2 compression in flink-core

2016-05-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2002#issuecomment-220097588 Looks good to me, with one minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] flink pull request: Support for bz2 compression in flink-core

2016-05-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2002#discussion_r63744808 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/compression/Bzip2InputStreamFactory.java --- @@ -0,0 +1,50 @@ +/* + * Licensed

[GitHub] flink pull request: Flink 3750 fixed

2016-05-18 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1941#issuecomment-220094095 Thanks for the update. Looks good. Will merge it later :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[jira] [Commented] (FLINK-1502) Expose metrics to graphite, ganglia and JMX.

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289339#comment-15289339 ] ASF GitHub Bot commented on FLINK-1502: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1502] [WIP] Basic Metric System

2016-05-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1947#issuecomment-220093974 Thanks, Chesnay. Checking out the new changes now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-3914) BlobServer.createTemporaryFilename() has concurrency safety problem

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289309#comment-15289309 ] ASF GitHub Bot commented on FLINK-3914: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-3914] [runtime] fixed race when attempt...

2016-05-18 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2000#issuecomment-220090860 Fix looks good to me. Thanks @markreddy! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-3780) Jaccard Similarity

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289294#comment-15289294 ] ASF GitHub Bot commented on FLINK-3780: --- Github user greghogan commented on the pull

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-18 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1980#issuecomment-220088196 Tests are passing ... will merge ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[jira] [Commented] (FLINK-1502) Expose metrics to graphite, ganglia and JMX.

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289290#comment-15289290 ] ASF GitHub Bot commented on FLINK-1502: --- Github user zentol commented on the pull re

[GitHub] flink pull request: [FLINK-1502] [WIP] Basic Metric System

2016-05-18 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1947#issuecomment-220087815 I've had an offline chat with @StephanEwen and as a result updated the PR. List of changes: * dropped Meters, Histograms and Timers * we weren't convinced

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-18 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220087832 Couldn't find the problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289291#comment-15289291 ] ASF GitHub Bot commented on FLINK-3909: --- Github user tillrohrmann commented on the p

[jira] [Commented] (FLINK-3926) Incorrect implementation of getFieldIndex in TupleTypeInfo

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289282#comment-15289282 ] ASF GitHub Bot commented on FLINK-3926: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-3926) Incorrect implementation of getFieldIndex in TupleTypeInfo

2016-05-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289280#comment-15289280 ] Fabian Hueske commented on FLINK-3926: -- Ah, now I see what you mean. :-) Good fix, th

[GitHub] flink pull request: [FLINK-3926][TypeSystem]Incorrect implementati...

2016-05-18 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/2004#issuecomment-220086765 +1 to merge. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[jira] [Closed] (FLINK-3772) Graph algorithms for vertex and edge degree

2016-05-18 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-3772. - > Graph algorithms for vertex and edge degree > --- > >

[jira] [Commented] (FLINK-3926) Incorrect implementation of getFieldIndex in TupleTypeInfo

2016-05-18 Thread Yijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289260#comment-15289260 ] Yijie Shen commented on FLINK-3926: --- I've opened https://github.com/apache/flink/pull/20

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-220083900 The PR looks good to me. The only think which could be good to get rid of is the requirement that you have to select a Euclidean distance for the quadtree. Maybe th

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289259#comment-15289259 ] ASF GitHub Bot commented on FLINK-1745: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-3909] update Maven Failsafe version

2016-05-18 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/2003#issuecomment-220081808 Running the tests from within IntelliJ works fine without a problem. I guess it has something todo how failsafe `2.19` handles dependencies. --- If your project is

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289243#comment-15289243 ] ASF GitHub Bot commented on FLINK-3909: --- Github user tillrohrmann commented on the p

[jira] [Updated] (FLINK-3728) Throw meaningful exceptions for unsupported SQL features

2016-05-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-3728: - Description: We must explicitly exclude unsupported SQL features such as Grouping Sets from being

[jira] [Commented] (FLINK-3926) Incorrect implementation of getFieldIndex in TupleTypeInfo

2016-05-18 Thread Yijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289230#comment-15289230 ] Yijie Shen commented on FLINK-3926: --- We have the test case: {code} public void testAsWit

[jira] [Updated] (FLINK-3728) Throw meaningful exceptions for unsupported SQL features

2016-05-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-3728: - Summary: Throw meaningful exceptions for unsupported SQL features (was: Find a way to exclude uns

[jira] [Commented] (FLINK-3916) Allow generic types passing the Table API

2016-05-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289220#comment-15289220 ] Fabian Hueske commented on FLINK-3916: -- Duplicate of FLINK-3615? > Allow generic typ

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

2016-05-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289218#comment-15289218 ] ASF GitHub Bot commented on FLINK-1745: --- Github user tillrohrmann commented on a dif

  1   2   3   >