[ https://issues.apache.org/jira/browse/FLINK-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290211#comment-15290211 ]
ASF GitHub Bot commented on FLINK-1719: --------------------------------------- Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1156#issuecomment-220201194 Should the input be DataSets of Strings? The documentation, syntax are heavy on the side of dealing exclusively with text classification. Could just be me since don't come from an NLP background, and this made is less clear to read the logic of the code, e.g. I'm more used to applying numeric values for Bayes. See, e.g. examples of using Bayes in scikit-learn: http://scikit-learn.org/stable/modules/generated/sklearn.naive_bayes.GaussianNB.html. I presume the goal of this issue would be to apply to contexts outside of text classification and allow for users to apply the Bayes to numeric data like the scikit-learn example. Correct me if I'm wrong @tillrohrmann @chiwanpark > Add naive Bayes classification algorithm to machine learning library > -------------------------------------------------------------------- > > Key: FLINK-1719 > URL: https://issues.apache.org/jira/browse/FLINK-1719 > Project: Flink > Issue Type: New Feature > Components: Machine Learning Library > Reporter: Till Rohrmann > Assignee: Jonathan Hasenburg > Labels: ML > > Add naive Bayes algorithm to Flink's machine learning library as a basic > classification algorithm. Maybe we can incorporate some of the improvements > developed by [Karl-Michael > Schneider|http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.59.2085&rep=rep1&type=pdf], > [Sang-Bum Kim et > al.|http://ieeexplore.ieee.org/xpl/articleDetails.jsp?arnumber=1704799] or > [Jason Rennie et > al.|http://people.csail.mit.edu/jrennie/papers/icml03-nb.pdf] into the > implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)