[GitHub] flink pull request: [FLINK-2115] [Table API] support no aggregatio...

2015-12-01 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1377#issuecomment-161190371 Hi, @aljoscha , i guess you may forget this PR :smile: , could you help to move this forward? it should be ready yet. --- If your project is set up for it, you can

[jira] [Commented] (FLINK-2115) TableAPI throws ExpressionException for "Dangling GroupBy operation"

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035340#comment-15035340 ] ASF GitHub Bot commented on FLINK-2115: --- Github user ChengXiangLi commented on the p

[jira] [Commented] (FLINK-3098) Cast from Date to Long throw compile error.

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035332#comment-15035332 ] ASF GitHub Bot commented on FLINK-3098: --- GitHub user ChengXiangLi opened a pull requ

[GitHub] flink pull request: [FLINK-3098] [Table API] Cast Date to Long thr...

2015-12-01 Thread ChengXiangLi
GitHub user ChengXiangLi opened a pull request: https://github.com/apache/flink/pull/1431 [FLINK-3098] [Table API] Cast Date to Long throw compile error. While cast Date to Long, the generated code has compile error. You can merge this pull request into a Git repository by running:

[jira] [Created] (FLINK-3098) Cast from Date to Long throw compile error.

2015-12-01 Thread Chengxiang Li (JIRA)
Chengxiang Li created FLINK-3098: Summary: Cast from Date to Long throw compile error. Key: FLINK-3098 URL: https://issues.apache.org/jira/browse/FLINK-3098 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035150#comment-15035150 ] ASF GitHub Bot commented on FLINK-1745: --- Github user danielblazevski commented on th

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-01 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-161160377 Excellent, thanks @tillrohrmann and @chiwanpark, I will get back to this in the next few days. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (FLINK-3087) Table API do not support multi count in aggregation.

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035101#comment-15035101 ] ASF GitHub Bot commented on FLINK-3087: --- Github user ChengXiangLi commented on the p

[GitHub] flink pull request: [FLINK-3087] [Table-API] support multi count i...

2015-12-01 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1414#issuecomment-161153580 Let's reuse the count aggregation now, as it's better for performance now. I would revisit this after NULL value handling is enabled. --- If your project is set up

[GitHub] flink pull request: JobManager Data Structure doc fix

2015-12-01 Thread jaoki
GitHub user jaoki opened a pull request: https://github.com/apache/flink/pull/1430 JobManager Data Structure doc fix It seems AbstractJobVertex class no longer exists but the doc's link still points to it. You can merge this pull request into a Git repository by running: $ git

[jira] [Commented] (FLINK-3097) Add support for custom functions in Table API

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034838#comment-15034838 ] ASF GitHub Bot commented on FLINK-3097: --- GitHub user twalthr opened a pull request:

[GitHub] flink pull request: [FLINK-3097] [table] Add support for custom fu...

2015-12-01 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/1429 [FLINK-3097] [table] Add support for custom functions in Table API As described in FLINK-3097, this PR implements the possibility of adding custom row functions for the Table API. In the te

[jira] [Created] (FLINK-3097) Add support for custom functions in Table API

2015-12-01 Thread Timo Walther (JIRA)
Timo Walther created FLINK-3097: --- Summary: Add support for custom functions in Table API Key: FLINK-3097 URL: https://issues.apache.org/jira/browse/FLINK-3097 Project: Flink Issue Type: New Fea

[jira] [Commented] (FLINK-2949) Add method 'writeSequencefile' to DataSet

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034391#comment-15034391 ] ASF GitHub Bot commented on FLINK-2949: --- Github user smarthi commented on the pull r

[GitHub] flink pull request: FLINK-2949 [WIP]: Add method 'writeSequencefil...

2015-12-01 Thread smarthi
Github user smarthi commented on the pull request: https://github.com/apache/flink/pull/1311#issuecomment-161066615 @rmetzger This fell off my radar briefly as other things took priority. Let me know what you think about adding this to DataSet API, this follows from a similar change t

[jira] [Commented] (FLINK-3093) Introduce annotations for interface stability

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034388#comment-15034388 ] ASF GitHub Bot commented on FLINK-3093: --- Github user zentol commented on a diff in t

[GitHub] flink pull request: [FLINK-3093] Introduce annotations for interfa...

2015-12-01 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1427#discussion_r46323631 --- Diff: flink-core/src/main/java/org/apache/flink/types/Pair.java --- @@ -33,6 +34,7 @@ * @param Type of the pair's first element. * @param Type

[jira] [Closed] (FLINK-3038) Add maven plugin to ensure our modules define all used dependencies

2015-12-01 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger closed FLINK-3038. - Resolution: Won't Fix > Add maven plugin to ensure our modules define all used dependencies >

[jira] [Commented] (FLINK-3038) Add maven plugin to ensure our modules define all used dependencies

2015-12-01 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034351#comment-15034351 ] Robert Metzger commented on FLINK-3038: --- I'm closing this issue because its not feas

[jira] [Comment Edited] (FLINK-2732) Add access to the TaskManagers' log file and out file in the web dashboard.

2015-12-01 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034349#comment-15034349 ] Robert Metzger edited comment on FLINK-2732 at 12/1/15 6:51 PM:

[jira] [Commented] (FLINK-2732) Add access to the TaskManagers' log file and out file in the web dashboard.

2015-12-01 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034349#comment-15034349 ] Robert Metzger commented on FLINK-2732: --- Hi [~mliesenberg], thank you for the summa

[jira] [Commented] (FLINK-2949) Add method 'writeSequencefile' to DataSet

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034326#comment-15034326 ] ASF GitHub Bot commented on FLINK-2949: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: FLINK-2949 [WIP]: Add method 'writeSequencefil...

2015-12-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1311#issuecomment-161058586 Thank you for the contribution. To me it seems that the pull request so far consists only of unrelated changes. Did you make any progress on resolving the issue?

[jira] [Assigned] (FLINK-3093) Introduce annotations for interface stability

2015-12-01 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-3093: - Assignee: Robert Metzger > Introduce annotations for interface stability > --

[jira] [Commented] (FLINK-3093) Introduce annotations for interface stability

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034309#comment-15034309 ] ASF GitHub Bot commented on FLINK-3093: --- GitHub user rmetzger opened a pull request:

[jira] [Commented] (FLINK-3093) Introduce annotations for interface stability

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034308#comment-15034308 ] ASF GitHub Bot commented on FLINK-3093: --- GitHub user rmetzger opened a pull request:

[GitHub] flink pull request: [FLINK-3093] Introduce annotations for interfa...

2015-12-01 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1428 [FLINK-3093] Introduce annotations for interface stability in remaining modules Please see https://github.com/apache/flink/pull/1426 This pull request depends on https://github.com/apache/

[jira] [Commented] (FLINK-3093) Introduce annotations for interface stability

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034306#comment-15034306 ] ASF GitHub Bot commented on FLINK-3093: --- Github user rmetzger closed the pull reques

[jira] [Commented] (FLINK-3093) Introduce annotations for interface stability

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034305#comment-15034305 ] ASF GitHub Bot commented on FLINK-3093: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3093] Introduce annotations for interfa...

2015-12-01 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1427 [FLINK-3093] Introduce annotations for interface stability in flink-core Please see https://github.com/apache/flink/pull/1426 You can merge this pull request into a Git repository by running:

[GitHub] flink pull request: [FLINK-3093] Introduce annotations for interfa...

2015-12-01 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/1426 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] flink pull request: [FLINK-3093] Introduce annotations for interfa...

2015-12-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1426#issuecomment-161056518 Okay, I'll reopen two new PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Created] (FLINK-3096) ChaosMonkeyITCase fails in checkCleanRecoveryState with Unclean checkpoints

2015-12-01 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-3096: - Summary: ChaosMonkeyITCase fails in checkCleanRecoveryState with Unclean checkpoints Key: FLINK-3096 URL: https://issues.apache.org/jira/browse/FLINK-3096 Project:

[jira] [Created] (FLINK-3095) Test ZooKeeperLeaderElectionTest.testZooKeeperReelectionWithReplacement unstable

2015-12-01 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-3095: - Summary: Test ZooKeeperLeaderElectionTest.testZooKeeperReelectionWithReplacement unstable Key: FLINK-3095 URL: https://issues.apache.org/jira/browse/FLINK-3095 Proj

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034189#comment-15034189 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-161045939 Actually all changes after running `gulp` in `flink-runtime-web/web-dashboard` are committed. There should be no need. I had similar problems as the WebUI caches stuff in `

[jira] [Commented] (FLINK-3093) Introduce annotations for interface stability

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034179#comment-15034179 ] ASF GitHub Bot commented on FLINK-3093: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-3093] Introduce annotations for interfa...

2015-12-01 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1426#issuecomment-161045370 Hi @rmetzger, thanks for taking the initiative for this issue! I tried to review the PR, but the diff set it too large for the Github viewer. I know, I could checkout

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-161044122 Do I have to build the web resources as well? Because I don't see the stop button. Thanks for your contribution @mjsax. The PR is in a good shape. I

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034173#comment-15034173 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on the p

[jira] [Commented] (FLINK-3073) Activate streaming mode by default

2015-12-01 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034151#comment-15034151 ] Robert Metzger commented on FLINK-3073: --- I would remove all the code for specific st

[jira] [Commented] (FLINK-3080) Cannot union a data stream with a product of itself

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034139#comment-15034139 ] ASF GitHub Bot commented on FLINK-3080: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-3080] Relax restrictions of DataStream....

2015-12-01 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1425#issuecomment-161041477 Also changed the doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-3080) Cannot union a data stream with a product of itself

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034137#comment-15034137 ] ASF GitHub Bot commented on FLINK-3080: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-3080] Relax restrictions of DataStream....

2015-12-01 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1425#issuecomment-161041124 Yes, you get each element twice, so it behaves like bag-union. @mxm I added a test case. --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46308707 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -732,6 +758,18 @@ else if (current == JobStatus.RESTART

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034120#comment-15034120 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034090#comment-15034090 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46307098 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -227,4 +235,121 @@ public void testRequestPartitionState()

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034069#comment-15034069 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46305433 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -732,6 +758,18 @@ else if (current == JobStatus.

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033994#comment-15033994 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46300626 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -227,4 +235,121 @@ public void testRequestPartitionState()

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46300384 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java --- @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Softwa

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033991#comment-15033991 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46300103 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -227,4 +235,121 @@ public void testRequestPartitionS

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033988#comment-15033988 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033987#comment-15033987 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46299763 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java --- @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46294804 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to t

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46295358 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertexTest.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the A

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033923#comment-15033923 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033917#comment-15033917 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033889#comment-15033889 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-3080] Relax restrictions of DataStream....

2015-12-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1425#issuecomment-160999814 Looks good. Is there a test case for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46293301 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java --- @@ -227,6 +229,10 @@ public ExecutionState getAggregat

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033856#comment-15033856 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-3080] Relax restrictions of DataStream....

2015-12-01 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1425#issuecomment-161003995 Hi @aljoscha, thanks for fixing this! It seems that, with this change, when you union a stream with itself you get each element twice. If this is intentional, could yo

[jira] [Commented] (FLINK-3080) Cannot union a data stream with a product of itself

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033886#comment-15033886 ] ASF GitHub Bot commented on FLINK-3080: --- Github user vasia commented on the pull req

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46292645 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -112,19 +114,24 @@ /** The log object use

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033884#comment-15033884 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46290688 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -420,6 +420,23 @@ class JobManager( )

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46291411 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java --- @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Softwa

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033864#comment-15033864 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-3080) Cannot union a data stream with a product of itself

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033857#comment-15033857 ] ASF GitHub Bot commented on FLINK-3080: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46290465 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerTest.java --- @@ -227,4 +235,121 @@ public void testRequestPartitionState()

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033853#comment-15033853 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033852#comment-15033852 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46290433 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java --- @@ -227,6 +229,10 @@ public ExecutionState getA

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46290038 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -112,19 +114,24 @@ /** The log obj

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033847#comment-15033847 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033764#comment-15033764 ] ASF GitHub Bot commented on FLINK-2837: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033812#comment-15033812 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46287242 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSignalsTest.java --- @@ -0,0 +1,221 @@ +/* + * Licens

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033807#comment-15033807 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033810#comment-15033810 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46287079 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexStopTest.java --- @@ -0,0 +1,138 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46287141 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -569,6 +571,69 @@ public int compare(JobStatusMessage o1, JobStatusMessage

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033799#comment-15033799 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46286695 --- Diff: docs/apis/cli.md --- @@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs. -s,--scheduledShow only schedule

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46286476 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertexTest.java --- @@ -0,0 +1,41 @@ +/* + * Licensed t

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033797#comment-15033797 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[jira] [Updated] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-12-01 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-2624: -- Fix Version/s: 1.0.0 > RabbitMQ source / sink should participate in checkpointing >

[jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033793#comment-15033793 ] ASF GitHub Bot commented on FLINK-2624: --- Github user mxm commented on the pull reque

[jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033788#comment-15033788 ] ASF GitHub Bot commented on FLINK-2624: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2624]: RabbitMQSource now extends Messa...

2015-12-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1243#issuecomment-160988124 Thank for your contribution @HilmiYildirim. I've merged your commit and put some changes on top of it in 9215b72422d3e638fe950b61fa01f2e4e04981a0. --- If your project is se

[GitHub] flink pull request: [FLINK-2624]: RabbitMQSource now extends Messa...

2015-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1243 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-12-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46286009 --- Diff: flink-runtime-web/web-dashboard/package.json --- @@ -7,27 +7,27 @@ "devDependencies": { "browserify": "^9.0.3", "coffeeify": "^

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-12-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033787#comment-15033787 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2600) Failing ElasticsearchSinkITCase.testNodeClient test case

2015-12-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033783#comment-15033783 ] Stephan Ewen commented on FLINK-2600: - I think we should start making this a manual te

  1   2   >