Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r46308707
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
 ---
    @@ -732,6 +758,18 @@ else if (current == JobStatus.RESTARTING) {
                }
        }
     
    +   public void stop() {
    +           if(jobType == JobType.STREAMING) {
    +                   for(ExecutionVertex ev : 
this.getAllExecutionVertices()) {
    +                           if(ev.getNumberOfInputs() == 0) { // send 
signal to sources only
    +                                   ev.stop();
    +                           }
    +                   }
    +           } else {
    +                   throw new RuntimeException("STOP is only supported by 
streaming jobs.");
    --- End diff --
    
    This is not a problem: in `JobManager.scala` a potential `Throwable` is 
caught when `ExecutionGraph.stop()` is called and a prober `StoppingFailure` 
message is sent back as response. I tested this in local mode. The job manager 
did not go down. Or is there any other place in the code in which this could 
become a problem? As alternative, we could introduce a regular exception (ie, 
`StoppingException`) and add a `throws` clause to `stop()`. What do you think 
about this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to