Re: [PR] fix: Fix memory leak from user script handler [cordova-ios]

2024-08-15 Thread via GitHub
dpogue merged PR #1456: URL: https://github.com/apache/cordova-ios/pull/1456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.

Re: [I] CDVViewController leaks CDVWebViewWeakScriptMessageHandler when destroyed [cordova-ios]

2024-08-15 Thread via GitHub
dpogue closed issue #920: CDVViewController leaks CDVWebViewWeakScriptMessageHandler when destroyed URL: https://github.com/apache/cordova-ios/issues/920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] CDVViewController leaks CDVWebViewWeakScriptMessageHandler when destroyed [cordova-ios]

2024-08-15 Thread via GitHub
dpogue closed issue #920: CDVViewController leaks CDVWebViewWeakScriptMessageHandler when destroyed URL: https://github.com/apache/cordova-ios/issues/920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] refactor!: Add CDVSettingsDictionary class [cordova-ios]

2024-08-15 Thread via GitHub
dpogue opened a new pull request, #1458: URL: https://github.com/apache/cordova-ios/pull/1458 ### To Do - [ ] Write unit tests ### Platforms affected iOS ### Motivation and Context This will replace the extension category on NSDictionary, which has always f

Re: [I] Fail to launch google map app even if comgooglemaps is included in LSApplicationQueriesSchemes [cordova-ios]

2024-08-15 Thread via GitHub
dpogue commented on issue #1450: URL: https://github.com/apache/cordova-ios/issues/1450#issuecomment-2291031882 The behaviour for launching other apps from URLs is complicated and inconsistent. I suspect this might be due to trying to open it via JavaScript with `window.location.href`.

[PR] chore: Clean up ancient plist-to-config.xml cruft [cordova-ios]

2024-08-15 Thread via GitHub
dpogue opened a new pull request, #1459: URL: https://github.com/apache/cordova-ios/pull/1459 ### Platforms affected iOS ### Motivation and Context Closes #1414. This was for migrating from PhoneGap 1.x to Cordova, and is definitely not compatible with any mod

Re: [I] drop xcode 11-12-13 support [cordova-ios]

2024-08-15 Thread via GitHub
dpogue closed issue #1367: drop xcode 11-12-13 support URL: https://github.com/apache/cordova-ios/issues/1367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] chore!: Bump minimum Xcode version to 15 [cordova-ios]

2024-08-15 Thread via GitHub

Re: [PR] refactor!: Add CDVSettingsDictionary class [cordova-ios]

2024-08-15 Thread via GitHub
codecov-commenter commented on PR #1458: URL: https://github.com/apache/cordova-ios/pull/1458#issuecomment-2291044707 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1458?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+c

Re: [PR] chore: Clean up ancient plist-to-config.xml cruft [cordova-ios]

2024-08-15 Thread via GitHub
codecov-commenter commented on PR #1459: URL: https://github.com/apache/cordova-ios/pull/1459#issuecomment-2291049822 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1459?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+c

Re: [I] Invalid URL Error while adding iOS platform [cordova-ios]

2024-08-15 Thread via GitHub
dpogue closed issue #1348: Invalid URL Error while adding iOS platform URL: https://github.com/apache/cordova-ios/issues/1348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] ci: update workflow dependencies & node support [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
erisu opened a new pull request, #61: URL: https://github.com/apache/cordova-plugin-test-framework/pull/61 ### Platforms affected n/a ### Motivation and Context Update CI workflow ### Description Update dependencies Update node support

[PR] chore: update package-lock & eslint-config [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
erisu opened a new pull request, #62: URL: https://github.com/apache/cordova-plugin-test-framework/pull/62 ### Platforms affected n/a ### Motivation, Context & Description Update Eslint-Config & package-lock lockfileVersion v3 ### Testing

[I] All sorts of error messages. What does it all mean? [cordova-ios]

2024-08-15 Thread via GitHub
geoidesic opened a new issue, #1460: URL: https://github.com/apache/cordova-ios/issues/1460 I don't understand any of this output: ``` Installing "@havesource/cordova-plugin-push" for ios [!] The Sportch [Debug] target overrides the LD_RUNPATH_SEARCH_PATHS build setting defi

Re: [I] cordova platform add iOS - generates all sorts of (error?) messages. What does it all mean? [cordova-ios]

2024-08-15 Thread via GitHub
breautek closed issue #1460: cordova platform add iOS - generates all sorts of (error?) messages. What does it all mean? URL: https://github.com/apache/cordova-ios/issues/1460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] cordova platform add iOS - generates all sorts of (error?) messages. What does it all mean? [cordova-ios]

2024-08-15 Thread via GitHub
breautek commented on issue #1460: URL: https://github.com/apache/cordova-ios/issues/1460#issuecomment-2291296697 The `LD_RUNPATH_SEARCH_PATHS` are warnings not errors. But it means that the app is overriding the build setting that CocoaPods is using, and as a result if you have any pods in

[I] Signing for "MyProject" requires a development team. Select a development team in the Signing & Capabilities editor. [cordova-ios]

2024-08-15 Thread via GitHub
geoidesic opened a new issue, #1461: URL: https://github.com/apache/cordova-ios/issues/1461 # Bug Report ## Problem Unless I edit this manually via Xcode, I can't deploy the iOS app ### What is expected to happen? The cordova process shouldn't require manual editing of a p

Re: [I] Signing for "MyProject" requires a development team. Select a development team in the Signing & Capabilities editor. [cordova-ios]

2024-08-15 Thread via GitHub
breautek commented on issue #1461: URL: https://github.com/apache/cordova-ios/issues/1461#issuecomment-2291355598 Have you seen https://cordova.apache.org/docs/en/12.x/guide/platforms/ios/index.html#signing-an-app? You should be able to have a gitignored [build.json](https://cordova.

Re: [I] Signing for "MyProject" requires a development team. Select a development team in the Signing & Capabilities editor. [cordova-ios]

2024-08-15 Thread via GitHub
geoidesic closed issue #1461: Signing for "MyProject" requires a development team. Select a development team in the Signing & Capabilities editor. URL: https://github.com/apache/cordova-ios/issues/1461 -- This is an automated message from the Apache Git Service. To respond to the message, pl

[I] iOS universal icon support [cordova-ios]

2024-08-15 Thread via GitHub
geoidesic opened a new issue, #1462: URL: https://github.com/apache/cordova-ios/issues/1462 # Feature Request iOS universal icon support https://cordova.apache.org/docs/en/12.x/config_ref/images.html#ios ## Motivation Behind Feature iOS supports using a single universal ic

Re: [I] iOS universal icon support [cordova-ios]

2024-08-15 Thread via GitHub
breautek commented on issue #1462: URL: https://github.com/apache/cordova-ios/issues/1462#issuecomment-2291621192 It was proposed last year via https://github.com/apache/cordova-ios/pull/1309 but at the time the community voted to continue support for iOS 11, which meant we couldn't support

Re: [I] iOS universal icon support [cordova-ios]

2024-08-15 Thread via GitHub
geoidesic commented on issue #1462: URL: https://github.com/apache/cordova-ios/issues/1462#issuecomment-2291646370 I mean, I believe you but also honestly that doesn't make sense. Firstly, I believe Apple's new minimum build target is 12. So there's that. Secondly, I don't see why

Re: [I] iOS universal icon support [cordova-ios]

2024-08-15 Thread via GitHub
breautek commented on issue #1462: URL: https://github.com/apache/cordova-ios/issues/1462#issuecomment-2291671158 > Firstly, I believe Apple's new minimum build target is 12. So there's that. Not very accurate. iOS 11 is out of support of XCode, but it doesn't prevent projects from sp

Re: [I] iOS universal icon support [cordova-ios]

2024-08-15 Thread via GitHub
geoidesic commented on issue #1462: URL: https://github.com/apache/cordova-ios/issues/1462#issuecomment-2291690737 Ok that makes sense. I'll have go if you can help me with two things: 1. How do I connect my globally installed `cordova` to a local copy of `cordova-ios`? Or is that

Re: [I] iOS universal icon support [cordova-ios]

2024-08-15 Thread via GitHub
breautek commented on issue #1462: URL: https://github.com/apache/cordova-ios/issues/1462#issuecomment-2291713523 > How do I connect my globally installed cordova to a local copy of cordova-ios? Or is that the wrong approach? They are two separate packages that are decoupled. If you f

Re: [I] iOS universal icon support [cordova-ios]

2024-08-15 Thread via GitHub
geoidesic closed issue #1462: iOS universal icon support URL: https://github.com/apache/cordova-ios/issues/1462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] iOS universal icon support [cordova-ios]

2024-08-15 Thread via GitHub
geoidesic commented on issue #1462: URL: https://github.com/apache/cordova-ios/issues/1462#issuecomment-2291719858 Oh wow. Ok that all went over my head. What I meant was, when I run this command: `cordova do-some-sh1T ios` then that's not `cordova-ios` that's running that command, in

Re: [I] iOS universal icon support [cordova-ios]

2024-08-15 Thread via GitHub
geoidesic commented on issue #1462: URL: https://github.com/apache/cordova-ios/issues/1462#issuecomment-2291724726 > Consider joining the community [slack](https://join.slack.com/t/cordova/shared_invite/zt-z70vy6tx-7VNulesO0Qz0Od9QV4tc1Q) for more dev assistance. Amazing. It's taken

Re: [I] iOS universal icon support [cordova-ios]

2024-08-15 Thread via GitHub
dpogue commented on issue #1462: URL: https://github.com/apache/cordova-ios/issues/1462#issuecomment-2291996943 We definitely want to support the single 1024×1024 icon for the next major version (Cordova iOS 8), along with the new iOS 18 feature of dark mode and tinted icon variants, so I'm

Re: [PR] chore: Clean up ancient plist-to-config.xml cruft [cordova-ios]

2024-08-15 Thread via GitHub
dpogue merged PR #1459: URL: https://github.com/apache/cordova-ios/pull/1459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.

Re: [I] [Next Major] Delete bin/cordova_plist_to_config_xml script [cordova-ios]

2024-08-15 Thread via GitHub
dpogue closed issue #1414: [Next Major] Delete bin/cordova_plist_to_config_xml script URL: https://github.com/apache/cordova-ios/issues/1414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] refactor!: Move CDVAllowList out of public API [cordova-ios]

2024-08-15 Thread via GitHub
dpogue opened a new pull request, #1463: URL: https://github.com/apache/cordova-ios/pull/1463 ### Platforms affected iOS ### Motivation and Context This isn't really accessible outside of implementation details of the internal CDVIntentAndNavigationFilter plugin, so

Re: [PR] refactor(template)!: Update app template to Swift & storyboards [cordova-ios]

2024-08-15 Thread via GitHub
dpogue commented on PR #1457: URL: https://github.com/apache/cordova-ios/pull/1457#issuecomment-2292366642 Current feedback is that some plugins are (unsafely!) trying to add category extensions to the template's `AppDelegate` class. This was never really a safe thing to do, since people ca

Re: [PR] refactor!: Move CDVAllowList out of public API [cordova-ios]

2024-08-15 Thread via GitHub
codecov-commenter commented on PR #1463: URL: https://github.com/apache/cordova-ios/pull/1463#issuecomment-2292367408 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1463?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+c

Re: [I] iOS universal icon support [cordova-ios]

2024-08-15 Thread via GitHub
jcesarmobile commented on issue #1462: URL: https://github.com/apache/cordova-ios/issues/1462#issuecomment-2292413394 > > Consider joining the community [slack](https://join.slack.com/t/cordova/shared_invite/zt-z70vy6tx-7VNulesO0Qz0Od9QV4tc1Q) for more dev assistance. > > Amazing. It

Re: [PR] ci: update workflow dependencies & node support [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
erisu merged PR #61: URL: https://github.com/apache/cordova-plugin-test-framework/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

Re: [PR] Bump word-wrap from 1.2.3 to 1.2.4 [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
erisu commented on PR #60: URL: https://github.com/apache/cordova-plugin-test-framework/pull/60#issuecomment-2292570939 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Bump minimist from 1.2.5 to 1.2.6 [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
erisu commented on PR #57: URL: https://github.com/apache/cordova-plugin-test-framework/pull/57#issuecomment-2292571268 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Bump word-wrap from 1.2.3 to 1.2.4 [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
dependabot[bot] commented on PR #60: URL: https://github.com/apache/cordova-plugin-test-framework/pull/60#issuecomment-2292571357 Looks like word-wrap is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Bump word-wrap from 1.2.3 to 1.2.4 [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
dependabot[bot] closed pull request #60: Bump word-wrap from 1.2.3 to 1.2.4 URL: https://github.com/apache/cordova-plugin-test-framework/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Bump json5 from 1.0.1 to 1.0.2 [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
dependabot[bot] closed pull request #59: Bump json5 from 1.0.1 to 1.0.2 URL: https://github.com/apache/cordova-plugin-test-framework/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Bump minimist from 1.2.5 to 1.2.6 [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
dependabot[bot] closed pull request #57: Bump minimist from 1.2.5 to 1.2.6 URL: https://github.com/apache/cordova-plugin-test-framework/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Bump minimist from 1.2.5 to 1.2.6 [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
dependabot[bot] commented on PR #57: URL: https://github.com/apache/cordova-plugin-test-framework/pull/57#issuecomment-2292571505 Looks like minimist is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] chore: update package-lock & eslint-config [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
erisu merged PR #62: URL: https://github.com/apache/cordova-plugin-test-framework/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

Re: [PR] Bump json5 from 1.0.1 to 1.0.2 [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
erisu commented on PR #59: URL: https://github.com/apache/cordova-plugin-test-framework/pull/59#issuecomment-2292571237 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Bump json5 from 1.0.1 to 1.0.2 [cordova-plugin-test-framework]

2024-08-15 Thread via GitHub
dependabot[bot] commented on PR #59: URL: https://github.com/apache/cordova-plugin-test-framework/pull/59#issuecomment-2292571439 Looks like json5 is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Capture from Camera and library not working on IOS [cordova-plugin-camera]

2024-08-15 Thread via GitHub
gary-britland commented on issue #872: URL: https://github.com/apache/cordova-plugin-camera/issues/872#issuecomment-2292706617 Having the same issue here. Not sure what I am missing. This is the only thread that mentions the same problem. -- This is an automated message from the Apache G