dpogue opened a new pull request, #1458: URL: https://github.com/apache/cordova-ios/pull/1458
### To Do - [ ] Write unit tests ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> This will replace the extension category on NSDictionary, which has always felt a little bit hacky and has caused issues in weird circumstances due to requiring special build flags to work properly. ### Description <!-- Describe your changes in detail --> Add a new `CDVSettingsDictionary` class that is used for accessing preferences. Yes, subclassing `NSDictionary` is generally considered a bad idea because the internal implementation details are weird and cause problems. However, in this case we're essentially wrapping a real `NSMutableDictionary` and proxying everything to it, so this _should_ work the way we'd expect it to. ### Testing <!-- Please describe in detail how you tested your changes. --> TODO ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
