Re: [PR] remove potential error when setting exit code [cordova-cli]

2024-07-30 Thread via GitHub
Molkars commented on PR #640: URL: https://github.com/apache/cordova-cli/pull/640#issuecomment-2259486964 Yeah, but change my not made its way into distributed releases yet Original message From: Riquelme1075 ***@***.***> Date: 7/30/24 9:27 PM (GMT-05:00)

Re: [PR] remove potential error when setting exit code [cordova-cli]

2024-07-30 Thread via GitHub
Riquelme1075 commented on PR #640: URL: https://github.com/apache/cordova-cli/pull/640#issuecomment-2259459505 Good evening, did you manage to resolve it? I’ve tried everything and still couldn’t fix it. This error appeared out of nowhere. For example, at 8 PM I ran cordova platform add and

Re: [PR] remove potential error when setting exit code [cordova-cli]

2024-06-15 Thread via GitHub
breautek merged PR #640: URL: https://github.com/apache/cordova-cli/pull/640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.

Re: [PR] remove potential error when setting exit code [cordova-cli]

2024-05-25 Thread via GitHub
breautek commented on PR #640: URL: https://github.com/apache/cordova-cli/pull/640#issuecomment-2131363732 All test passes. If there are no objections in the next couple of days or so I'll do a merge so that this change is included on our next release. -- This is an automated message from

Re: [PR] remove potential error when setting exit code [cordova-cli]

2024-05-25 Thread via GitHub
codecov-commenter commented on PR #640: URL: https://github.com/apache/cordova-cli/pull/640#issuecomment-2131362931 ## [Codecov](https://app.codecov.io/gh/apache/cordova-cli/pull/640?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

Re: [PR] remove potential error when setting exit code [cordova-cli]

2024-05-22 Thread via GitHub
breautek commented on code in PR #640: URL: https://github.com/apache/cordova-cli/pull/640#discussion_r1609854176 ## bin/cordova: ## @@ -29,7 +29,11 @@ cli(process.argv).catch(err => { const errorOutput = typeof err === 'string' ? err : util.inspect(err); throw

Re: [PR] remove potential error when setting exit code [cordova-cli]

2024-05-19 Thread via GitHub
Molkars commented on PR #640: URL: https://github.com/apache/cordova-cli/pull/640#issuecomment-2119638201 sorry to ignore the PR format, but... very simple change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] remove potential error when setting exit code [cordova-cli]

2024-05-19 Thread via GitHub
Molkars opened a new pull request, #640: URL: https://github.com/apache/cordova-cli/pull/640 this PR implements a more reliable way of setting the CLI's exit code in error cases. Previously, I encountered this error when running the cli: ```console $ cordova build TypeError [